mirror of
https://github.com/kremalicious/metamask-extension.git
synced 2024-11-23 02:10:12 +01:00
b4ecc4c3f5
* Added translation for eth sign toggle * Disabled the ability to call eth_sign by default. Added ability within advanced settings to renable support for eth_sign * Add test case for eth_sign being enabled and disabled * Modified copy * Moved rpc method preference to its own object within store * Complete work on moving rpc method preference into its own object within store * Fix with prettier * Fix lint * Fix a unit test * Fix test * Renamed function and object keys to be more intuitive * Fix e2e test * Enabled eth_sign through preferences fixture * Fix lint * Fix e2e test Wait for the notification popup to close, leaving 2 window handles the extension and the test dapp * Fix e2e test * Fix unit test Enable eth_sign method * Lint fix --------- Co-authored-by: PeterYinusa <peter.yinusa@consensys.net> Co-authored-by: Dan J Miller <danjm.com@gmail.com>
107 lines
3.7 KiB
JavaScript
107 lines
3.7 KiB
JavaScript
const { strict: assert } = require('assert');
|
|
const { convertToHexValue, withFixtures } = require('../helpers');
|
|
const FixtureBuilder = require('../fixture-builder');
|
|
|
|
const ganacheOptions = {
|
|
accounts: [
|
|
{
|
|
secretKey:
|
|
'0x7C9529A67102755B7E6102D6D950AC5D5863C98713805CEC576B945B15B71EAC',
|
|
balance: convertToHexValue(25000000000000000000),
|
|
},
|
|
],
|
|
};
|
|
|
|
describe('Eth sign', function () {
|
|
it('will detect if eth_sign is disabled', async function () {
|
|
await withFixtures(
|
|
{
|
|
dapp: true,
|
|
fixtures: new FixtureBuilder()
|
|
.withPermissionControllerConnectedToTestDapp()
|
|
.build(),
|
|
ganacheOptions,
|
|
title: this.test.title,
|
|
},
|
|
async ({ driver }) => {
|
|
await driver.navigate();
|
|
await driver.fill('#password', 'correct horse battery staple');
|
|
await driver.press('#password', driver.Key.ENTER);
|
|
|
|
await driver.openNewPage('http://127.0.0.1:8080/');
|
|
await driver.clickElement('#ethSign');
|
|
|
|
const ethSignButton = await driver.findElement('#ethSign');
|
|
const exceptionString =
|
|
'ERROR: ETH_SIGN HAS BEEN DISABLED. YOU MUST ENABLE IT IN THE ADVANCED SETTINGS';
|
|
|
|
assert.equal(await ethSignButton.getText(), exceptionString);
|
|
},
|
|
);
|
|
});
|
|
|
|
it('can initiate and confirm a eth sign', async function () {
|
|
const expectedPersonalMessage =
|
|
'0x879a053d4800c6354e76c7985a865d2922c82fb5b3f4577b2fe08b998954f2e0';
|
|
const expectedEthSignResult =
|
|
'"0x816ab6c5d5356548cc4e004ef35a37fdfab916742a2bbeda756cd064c3d3789a6557d41d49549be1de249e1937a8d048996dfcc70d0552111605dc7cc471e8531b"';
|
|
await withFixtures(
|
|
{
|
|
dapp: true,
|
|
fixtures: new FixtureBuilder()
|
|
.withPreferencesController({
|
|
disabledRpcMethodPreferences: {
|
|
eth_sign: true,
|
|
},
|
|
})
|
|
.withPermissionControllerConnectedToTestDapp()
|
|
.build(),
|
|
ganacheOptions,
|
|
title: this.test.title,
|
|
},
|
|
async ({ driver }) => {
|
|
await driver.navigate();
|
|
await driver.fill('#password', 'correct horse battery staple');
|
|
await driver.press('#password', driver.Key.ENTER);
|
|
|
|
await driver.openNewPage('http://127.0.0.1:8080/');
|
|
await driver.clickElement('#ethSign');
|
|
|
|
// Wait for Signature request popup
|
|
await driver.waitUntilXWindowHandles(3);
|
|
let windowHandles = await driver.getAllWindowHandles();
|
|
await driver.switchToWindowWithTitle(
|
|
'MetaMask Notification',
|
|
windowHandles,
|
|
);
|
|
|
|
const title = await driver.findElement(
|
|
'.request-signature__content__title',
|
|
);
|
|
const origin = await driver.findElement('.request-signature__origin');
|
|
assert.equal(await title.getText(), 'Signature request');
|
|
assert.equal(await origin.getText(), 'http://127.0.0.1:8080');
|
|
|
|
const personalMessageRow = await driver.findElement(
|
|
'.request-signature__row-value',
|
|
);
|
|
const personalMessage = await personalMessageRow.getText();
|
|
assert.equal(personalMessage, expectedPersonalMessage);
|
|
|
|
await driver.clickElement('[data-testid="page-container-footer-next"]');
|
|
await driver.clickElement(
|
|
'.signature-request-warning__footer__sign-button',
|
|
);
|
|
// Switch to the Dapp
|
|
await driver.waitUntilXWindowHandles(2);
|
|
windowHandles = await driver.getAllWindowHandles();
|
|
await driver.switchToWindowWithTitle('E2E Test Dapp', windowHandles);
|
|
|
|
// Verify
|
|
const result = await driver.findElement('#ethSignResult');
|
|
assert.equal(await result.getText(), expectedEthSignResult);
|
|
},
|
|
);
|
|
});
|
|
});
|