mirror of
https://github.com/kremalicious/metamask-extension.git
synced 2024-12-01 21:57:06 +01:00
8527d051b0
utils.formatBalance was returning rounded ether, was not useful for displaying account balances. Now returns four decimal points, and is easily configurable for more, with passing tests. Spoiler alert: Don't you dare divide bignumber wei. Bignumber does not have decimals. Keep it as wei, format it as ether.
115 lines
3.1 KiB
JavaScript
115 lines
3.1 KiB
JavaScript
var assert = require('assert')
|
|
var sinon = require('sinon')
|
|
const ethUtil = require('ethereumjs-util')
|
|
|
|
var path = require('path')
|
|
var util = require(path.join(__dirname, '..', '..', 'app', 'util.js'))
|
|
|
|
describe('util', function() {
|
|
var ethInWei = '1'
|
|
for (var i = 0; i < 18; i++ ) { ethInWei += '0' }
|
|
|
|
beforeEach(function() {
|
|
this.sinon = sinon.sandbox.create()
|
|
})
|
|
|
|
afterEach(function() {
|
|
this.sinon.restore()
|
|
})
|
|
|
|
describe('numericBalance', function() {
|
|
|
|
it('should return a BN 0 if given nothing', function() {
|
|
var result = util.numericBalance()
|
|
assert.equal(result.toString(10), 0)
|
|
})
|
|
|
|
it('should work with hex prefix', function() {
|
|
var result = util.numericBalance('0x012')
|
|
assert.equal(result.toString(10), '18')
|
|
})
|
|
|
|
it('should work with no hex prefix', function() {
|
|
var result = util.numericBalance('012')
|
|
assert.equal(result.toString(10), '18')
|
|
})
|
|
|
|
})
|
|
|
|
describe('#ethToWei', function() {
|
|
|
|
it('should take an eth BN, returns wei BN', function() {
|
|
var input = new ethUtil.BN(1, 10)
|
|
var result = util.ethToWei(input)
|
|
assert.equal(result, ethInWei, '18 zeroes')
|
|
})
|
|
|
|
})
|
|
|
|
describe('#weiToEth', function() {
|
|
|
|
it('should take a wei BN and return an eth BN', function() {
|
|
var result = util.weiToEth(new ethUtil.BN(ethInWei))
|
|
assert.equal(result, '1', 'equals 1 eth')
|
|
})
|
|
|
|
})
|
|
|
|
describe('#formatBalance', function() {
|
|
|
|
it('when given nothing', function() {
|
|
var result = util.formatBalance()
|
|
assert.equal(result, 'None', 'should return "None"')
|
|
})
|
|
|
|
it('should return eth as string followed by ETH', function() {
|
|
var input = new ethUtil.BN(ethInWei, 10).toJSON()
|
|
var result = util.formatBalance(input)
|
|
assert.equal(result, '1.0000 ETH')
|
|
})
|
|
|
|
it('should return eth as string followed by ETH', function() {
|
|
var input = new ethUtil.BN(ethInWei, 10).div(new ethUtil.BN('2', 10)).toJSON()
|
|
var result = util.formatBalance(input)
|
|
assert.equal(result, '.5000 ETH')
|
|
})
|
|
|
|
it('should display four decimal points', function() {
|
|
var input = "0x128dfa6a90b28000"
|
|
var result = util.formatBalance(input)
|
|
assert.equal(result, '1.3370 ETH')
|
|
})
|
|
|
|
})
|
|
|
|
describe('#normalizeToWei', function() {
|
|
it('should convert an eth to the appropriate equivalent values', function() {
|
|
var valueTable = {
|
|
wei: '1000000000000000000',
|
|
kwei: '1000000000000000',
|
|
mwei: '1000000000000',
|
|
gwei: '1000000000',
|
|
szabo: '1000000',
|
|
finney:'1000',
|
|
ether: '1',
|
|
kether:'0.001',
|
|
mether:'0.000001',
|
|
// AUDIT: We're getting BN numbers on these ones.
|
|
// I think they're big enough to ignore for now.
|
|
// gether:'0.000000001',
|
|
// tether:'0.000000000001',
|
|
}
|
|
var oneEthBn = new ethUtil.BN(ethInWei, 10)
|
|
|
|
for(var currency in valueTable) {
|
|
|
|
var value = new ethUtil.BN(valueTable[currency], 10)
|
|
var output = util.normalizeToWei(value, currency)
|
|
assert.equal(output.toString(10), valueTable.wei, `value of ${output.toString(10)} ${currency} should convert to ${oneEthBn}`)
|
|
|
|
}
|
|
})
|
|
})
|
|
|
|
})
|