mirror of
https://github.com/kremalicious/metamask-extension.git
synced 2024-11-30 08:09:15 +01:00
1e494f3004
We would like to insert TypeScript into the ESLint configuration, and because of the way that the current config is organized, that is not easy to do. Most files are assumed to be files that are suited for running in a browser context. This isn't correct, as we should expect most files to work in a Node context instead. This is because all browser-based files will be run through a transpiler that is able to make use of Node-specific variables anyway. There are a couple of important ways we can categories files which our ESLint config should be capable of handling well: * Is the file a script or a module? In other words, does the file run procedurally or is the file intended to be brought into an existing file? * If the file is a module, does it use the CommonJS syntax (`require()`) or does it use the ES syntax (`import`/`export`)? When we introduce TypeScript, this set of questions will become: * Is the file a script or a module? * If the file is a module, is it a JavaScript module or a TypeScript module? * If the file is a JavaScript module, does it use the CommonJS syntax (`require()`) or does it use the ES syntax (`import`/`export`)? To represent these divisions, this commit removes global rules — so now all of the rules are kept in `overrides` for explicitness — and sets up rules for CommonJS- and ES-module-compatible files that intentionally do not overlap with each other. This way TypeScript (which has its own set of rules independent from JavaScript and therefore shouldn't overlap with the other rules either) can be easily added later. Finally, this commit splits up the ESLint config into separate files and adds documentation to each section. This way sets of rules which are connected to a particular plugin (`jsdoc`, `@babel`, etc.) can be easily understood instead of being obscured.
232 lines
8.1 KiB
JavaScript
232 lines
8.1 KiB
JavaScript
const { strict: assert } = require('assert');
|
|
const {
|
|
convertToHexValue,
|
|
withFixtures,
|
|
regularDelayMs,
|
|
} = require('../helpers');
|
|
|
|
describe('Sign Typed Data V4 Signature Request', function () {
|
|
it('can initiate and confirm a Signature Request', async function () {
|
|
const ganacheOptions = {
|
|
accounts: [
|
|
{
|
|
secretKey:
|
|
'0x7C9529A67102755B7E6102D6D950AC5D5863C98713805CEC576B945B15B71EAC',
|
|
balance: convertToHexValue(25000000000000000000),
|
|
},
|
|
],
|
|
};
|
|
const publicAddress = '0x5cfe73b6021e818b776b421b1c4db2474086a7e1';
|
|
await withFixtures(
|
|
{
|
|
dapp: true,
|
|
fixtures: 'connected-state',
|
|
ganacheOptions,
|
|
title: this.test.title,
|
|
},
|
|
async ({ driver }) => {
|
|
await driver.navigate();
|
|
await driver.fill('#password', 'correct horse battery staple');
|
|
await driver.press('#password', driver.Key.ENTER);
|
|
|
|
await driver.openNewPage('http://127.0.0.1:8080/');
|
|
|
|
// creates a sign typed data signature request
|
|
await driver.clickElement('#signTypedDataV4');
|
|
|
|
await driver.waitUntilXWindowHandles(3);
|
|
let windowHandles = await driver.getAllWindowHandles();
|
|
await driver.switchToWindowWithTitle(
|
|
'MetaMask Notification',
|
|
windowHandles,
|
|
);
|
|
|
|
const title = await driver.findElement(
|
|
'.signature-request-content__title',
|
|
);
|
|
const name = await driver.findElement(
|
|
'.signature-request-content__info--bolded',
|
|
);
|
|
const content = await driver.findElements(
|
|
'.signature-request-content__info',
|
|
);
|
|
const origin = content[0];
|
|
const address = content[1];
|
|
const message = await driver.findElement(
|
|
'.signature-request-message--node-value',
|
|
);
|
|
assert.equal(await title.getText(), 'Signature Request');
|
|
assert.equal(await name.getText(), 'Ether Mail');
|
|
assert.equal(await origin.getText(), 'http://127.0.0.1:8080');
|
|
assert.equal(
|
|
await address.getText(),
|
|
`${publicAddress.slice(0, 8)}...${publicAddress.slice(
|
|
publicAddress.length - 8,
|
|
)}`,
|
|
);
|
|
assert.equal(await message.getText(), 'Hello, Bob!');
|
|
// Approve signing typed data
|
|
await driver.clickElement(
|
|
'[data-testid="signature-request-scroll-button"]',
|
|
);
|
|
await driver.delay(regularDelayMs);
|
|
await driver.clickElement({ text: 'Sign', tag: 'button' });
|
|
await driver.waitUntilXWindowHandles(2);
|
|
windowHandles = await driver.getAllWindowHandles();
|
|
|
|
// switch to the Dapp and verify the signed addressed
|
|
await driver.switchToWindowWithTitle('E2E Test Dapp', windowHandles);
|
|
await driver.clickElement('#signTypedDataV4Verify');
|
|
const recoveredAddress = await driver.findElement(
|
|
'#signTypedDataV4VerifyResult',
|
|
);
|
|
assert.equal(await recoveredAddress.getText(), publicAddress);
|
|
},
|
|
);
|
|
});
|
|
});
|
|
|
|
/* eslint-disable-next-line mocha/max-top-level-suites */
|
|
describe('Sign Typed Data V3 Signature Request', function () {
|
|
it('can initiate and confirm a Signature Request', async function () {
|
|
const ganacheOptions = {
|
|
accounts: [
|
|
{
|
|
secretKey:
|
|
'0x7C9529A67102755B7E6102D6D950AC5D5863C98713805CEC576B945B15B71EAC',
|
|
balance: convertToHexValue(25000000000000000000),
|
|
},
|
|
],
|
|
};
|
|
const publicAddress = '0x5cfe73b6021e818b776b421b1c4db2474086a7e1';
|
|
await withFixtures(
|
|
{
|
|
dapp: true,
|
|
fixtures: 'connected-state',
|
|
ganacheOptions,
|
|
title: this.test.title,
|
|
},
|
|
async ({ driver }) => {
|
|
await driver.navigate();
|
|
await driver.fill('#password', 'correct horse battery staple');
|
|
await driver.press('#password', driver.Key.ENTER);
|
|
|
|
await driver.openNewPage('http://127.0.0.1:8080/');
|
|
|
|
// creates a sign typed data signature request
|
|
await driver.clickElement('#signTypedDataV3');
|
|
|
|
await driver.waitUntilXWindowHandles(3);
|
|
let windowHandles = await driver.getAllWindowHandles();
|
|
await driver.switchToWindowWithTitle(
|
|
'MetaMask Notification',
|
|
windowHandles,
|
|
);
|
|
|
|
const title = await driver.findElement(
|
|
'.signature-request-content__title',
|
|
);
|
|
const name = await driver.findElement(
|
|
'.signature-request-content__info--bolded',
|
|
);
|
|
const content = await driver.findElements(
|
|
'.signature-request-content__info',
|
|
);
|
|
const origin = content[0];
|
|
const address = content[1];
|
|
const messages = await driver.findElements(
|
|
'.signature-request-message--node-value',
|
|
);
|
|
assert.equal(await title.getText(), 'Signature Request');
|
|
assert.equal(await name.getText(), 'Ether Mail');
|
|
assert.equal(await origin.getText(), 'http://127.0.0.1:8080');
|
|
assert.equal(
|
|
await address.getText(),
|
|
`${publicAddress.slice(0, 8)}...${publicAddress.slice(
|
|
publicAddress.length - 8,
|
|
)}`,
|
|
);
|
|
assert.equal(await messages[4].getText(), 'Hello, Bob!');
|
|
|
|
// Approve signing typed data
|
|
await driver.clickElement({ text: 'Sign', tag: 'button' });
|
|
await driver.waitUntilXWindowHandles(2);
|
|
windowHandles = await driver.getAllWindowHandles();
|
|
|
|
// switch to the Dapp and verify the signed addressed
|
|
await driver.switchToWindowWithTitle('E2E Test Dapp', windowHandles);
|
|
await driver.clickElement('#signTypedDataV3Verify');
|
|
const recoveredAddress = await driver.findElement(
|
|
'#signTypedDataV3VerifyResult',
|
|
);
|
|
assert.equal(await recoveredAddress.getText(), publicAddress);
|
|
},
|
|
);
|
|
});
|
|
});
|
|
|
|
describe('Sign Typed Data Signature Request', function () {
|
|
it('can initiate and confirm a Signature Request', async function () {
|
|
const ganacheOptions = {
|
|
accounts: [
|
|
{
|
|
secretKey:
|
|
'0x7C9529A67102755B7E6102D6D950AC5D5863C98713805CEC576B945B15B71EAC',
|
|
balance: convertToHexValue(25000000000000000000),
|
|
},
|
|
],
|
|
};
|
|
const publicAddress = '0x5cfe73b6021e818b776b421b1c4db2474086a7e1';
|
|
await withFixtures(
|
|
{
|
|
dapp: true,
|
|
fixtures: 'connected-state',
|
|
ganacheOptions,
|
|
title: this.test.title,
|
|
},
|
|
async ({ driver }) => {
|
|
await driver.navigate();
|
|
await driver.fill('#password', 'correct horse battery staple');
|
|
await driver.press('#password', driver.Key.ENTER);
|
|
|
|
await driver.openNewPage('http://127.0.0.1:8080/');
|
|
|
|
// creates a sign typed data signature request
|
|
await driver.clickElement('#signTypedData');
|
|
|
|
await driver.waitUntilXWindowHandles(3);
|
|
let windowHandles = await driver.getAllWindowHandles();
|
|
await driver.switchToWindowWithTitle(
|
|
'MetaMask Notification',
|
|
windowHandles,
|
|
);
|
|
|
|
const title = await driver.findElement(
|
|
'.request-signature__header__text',
|
|
);
|
|
const origin = await driver.findElement('.request-signature__origin');
|
|
const message = await driver.findElements(
|
|
'.request-signature__row-value',
|
|
);
|
|
assert.equal(await title.getText(), 'Signature Request');
|
|
assert.equal(await origin.getText(), 'http://127.0.0.1:8080');
|
|
assert.equal(await message[0].getText(), 'Hi, Alice!');
|
|
assert.equal(await message[1].getText(), '1337');
|
|
|
|
// Approve signing typed data
|
|
await driver.clickElement({ text: 'Sign', tag: 'button' });
|
|
await driver.waitUntilXWindowHandles(2);
|
|
windowHandles = await driver.getAllWindowHandles();
|
|
|
|
// switch to the Dapp and verify the signed addressed
|
|
await driver.switchToWindowWithTitle('E2E Test Dapp', windowHandles);
|
|
await driver.clickElement('#signTypedDataVerify');
|
|
const recoveredAddress = await driver.findElement(
|
|
'#signTypedDataVerifyResult',
|
|
);
|
|
assert.equal(await recoveredAddress.getText(), publicAddress);
|
|
},
|
|
);
|
|
});
|
|
});
|