1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-10-22 19:26:13 +02:00
metamask-extension/ui/app/pages
Mark Stacey 2b3acfc92b
Skip ENS reverse resolution when address is blank (#8184)
The address is blank momentarily when navigating to the confirmation
screen when sending a token. The address is updated in a subsequent
render.

The ENS reverse resolution is now only attempted if the address is
given. It has also been updated to attempt resolution when the address
is finally set, which fixes the reverse resolution for token sends.

I had hoped to get rid of this interim render-without-address, but that
turned out to be a bit more challenging. The problem is that the UI
submits transactions through the provider just as a dapp would, and the
provider doesn't say when the transaction is submitted. The promise
returned doesn't resolve until after confirmation. We would have to
start calling the background methods directly and bypass the provider
to get the feedback we need, and that sounded potentially dangerous.
Definitely a challenge for another day.
2020-03-12 10:50:37 -03:00
..
add-token Enable arrow-parens ESLint rule 2020-02-15 17:04:21 -03:30
confirm-add-suggested-token Remove faux <header> elements (#8131) 2020-02-27 18:00:20 -04:00
confirm-add-token Remove faux <header> elements (#8131) 2020-02-27 18:00:20 -04:00
confirm-approve LoginPerSite: Support multiple accounts without automatic switching (#8079) 2020-03-06 13:34:56 -08:00
confirm-decrypt-message LoginPerSite: Support multiple accounts without automatic switching (#8079) 2020-03-06 13:34:56 -08:00
confirm-deploy-contract Enable arrow-parens ESLint rule 2020-02-15 17:04:21 -03:30
confirm-encryption-public-key LoginPerSite: Support multiple accounts without automatic switching (#8079) 2020-03-06 13:34:56 -08:00
confirm-send-ether LoginPerSite: Support multiple accounts without automatic switching (#8079) 2020-03-06 13:34:56 -08:00
confirm-send-token LoginPerSite: Support multiple accounts without automatic switching (#8079) 2020-03-06 13:34:56 -08:00
confirm-token-transaction-base LoginPerSite: Support multiple accounts without automatic switching (#8079) 2020-03-06 13:34:56 -08:00
confirm-transaction LoginPerSite: Support multiple accounts without automatic switching (#8079) 2020-03-06 13:34:56 -08:00
confirm-transaction-base Skip ENS reverse resolution when address is blank (#8184) 2020-03-12 10:50:37 -03:00
confirm-transaction-switch Implementation encrypt/decrypt feature (#7831) 2020-02-19 14:24:16 -04:00
connected-sites Connect distinct accounts per site (#7004) 2019-12-03 09:35:56 -08:00
create-account Remove recompose (#8097) 2020-02-24 19:28:26 -03:30
error Add top-level error page (#7889) 2020-01-24 17:11:02 -04:00
first-time-flow Translation helper: substitute react components and component wrapping substrings (#8129) 2020-03-11 12:30:05 -02:30
home Consolidate Home UI (#8141) 2020-02-28 17:46:01 -04:00
keychains Remove faux <header> elements (#8131) 2020-02-27 18:00:20 -04:00
lock Remove recompose (#8097) 2020-02-24 19:28:26 -03:30
mobile-sync Enable arrow-parens ESLint rule 2020-02-15 17:04:21 -03:30
permissions-connect Change permissions connect screen to use browser routing (#8072) 2020-02-27 11:20:05 -04:00
routes LoginPerSite: Support multiple accounts without automatic switching (#8079) 2020-03-06 13:34:56 -08:00
send Handle and set gas estimation when max mode is clicked (#8176) 2020-03-11 13:13:48 -07:00
settings Use consistent variable name for classnames import (#8143) 2020-03-01 06:14:16 -04:00
unlock-page Remove recompose (#8097) 2020-02-24 19:28:26 -03:30
index.js Add top-level error page (#7889) 2020-01-24 17:11:02 -04:00
index.scss Extract style for Home component into separate module (#8139) 2020-02-28 16:27:22 -04:00