1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
metamask-extension/development
Mark Stacey 165666b315
Remove unnecessary tx meta properties (#8489)
* Remove `estimatedGas` property from `txMeta`

The `estimatedGas` property was a cache of the gas value estimated for
a transaction when the default gas limit was set. This property wasn't
used anywhere. It may have been useful for debugging purposes, but the
same gas estimate is already stored on the `history` property so it
should be present in state logs regardless.

* Remove `gasLimitSpecified` txMeta property

The `gasLimitSpecified` property of `txMeta` wasn't used for anything.
It might have been useful for debugging purposes, but whether or not
the gas limit was specified can also be determined from looking at the
transaction history, so it's not a huge loss.

* Remove `gasPriceSpecified` txMeta property

The `gasPriceSpecified` property of `txMeta` wasn't used for anything.
It might have been useful for debugging purposes, but whether or not
the gas price was specified can also be determined from looking at the
transaction history, so it's not a huge loss.

* Remove `simpleSend` txMeta property

The `simpleSend` property of `txMeta` was used to ensure a buffer was
not added to the gas limit during gas estimation for simple send
transactions. It was made redundant by #8484, which accomplishes this
without the use of this property.
2020-05-01 08:44:05 -03:00
..
build Use @fortawesome/fontawesome-free npm package (#8256) 2020-03-30 20:05:51 -03:00
states Remove unnecessary tx meta properties (#8489) 2020-05-01 08:44:05 -03:00
announcer.js Build system refactor (#8140) 2020-03-09 08:55:02 +08:00
auto-changelog.sh Add shellcheck lint (#7392) 2019-11-19 10:46:10 -05:00
backGroundConnectionModifiers.js
generate-migration.sh Add tests around migration files (#7016) 2019-12-12 20:44:29 -03:30
genStates.js Migrate codebase to use ESM (#7730) 2020-01-09 00:04:58 -03:30
gource-viz.sh
index.html
metamaskbot-build-announce.js Fix page benchmark result display (#8438) 2020-04-28 09:50:21 -03:00
mock-3box.js Prevent accidental use of globals (#8340) 2020-04-15 14:23:27 -03:00
mock-dev.js Remove unused states (#8345) 2020-04-16 12:27:25 -03:00
README.md
require-react-devtools.js
run-ganache
selector.js Migrate codebase to use ESM (#7730) 2020-01-09 00:04:58 -03:30
sentry-publish.js Improve Sentry publish script (#7417) 2019-12-05 17:59:48 -04:00
sentry-upload-artifacts.sh Improve Sentry publish script (#7417) 2019-12-05 17:59:48 -04:00
shellcheck.sh Add lint:shellcheck:package (#7568) 2019-12-11 15:52:08 -05:00
show-deps-install-scripts.js Enable arrow-parens ESLint rule 2020-02-15 17:04:21 -03:30
source-map-explorer.sh ci - create source-map-explorer build-artifacts (#7141) 2019-09-11 23:35:30 +08:00
sourcemap-validator.js Enable arrow-parens ESLint rule 2020-02-15 17:04:21 -03:30
static-server.js Add support for one-click onboarding (#7017) 2019-11-22 13:03:51 -04:00
test.html
verify-locale-strings.js Enable arrow-parens ESLint rule 2020-02-15 17:04:21 -03:30

Development

Several files which are needed for developing on(!) MetaMask.

Usually each files contains information about its scope / usage.