1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
metamask-extension/development
Mark Stacey 165666b315
Remove unnecessary tx meta properties (#8489)
* Remove `estimatedGas` property from `txMeta`

The `estimatedGas` property was a cache of the gas value estimated for
a transaction when the default gas limit was set. This property wasn't
used anywhere. It may have been useful for debugging purposes, but the
same gas estimate is already stored on the `history` property so it
should be present in state logs regardless.

* Remove `gasLimitSpecified` txMeta property

The `gasLimitSpecified` property of `txMeta` wasn't used for anything.
It might have been useful for debugging purposes, but whether or not
the gas limit was specified can also be determined from looking at the
transaction history, so it's not a huge loss.

* Remove `gasPriceSpecified` txMeta property

The `gasPriceSpecified` property of `txMeta` wasn't used for anything.
It might have been useful for debugging purposes, but whether or not
the gas price was specified can also be determined from looking at the
transaction history, so it's not a huge loss.

* Remove `simpleSend` txMeta property

The `simpleSend` property of `txMeta` was used to ensure a buffer was
not added to the gas limit during gas estimation for simple send
transactions. It was made redundant by #8484, which accomplishes this
without the use of this property.
2020-05-01 08:44:05 -03:00
..
build
states Remove unnecessary tx meta properties (#8489) 2020-05-01 08:44:05 -03:00
announcer.js
auto-changelog.sh
backGroundConnectionModifiers.js
generate-migration.sh
genStates.js
gource-viz.sh
index.html
metamaskbot-build-announce.js
mock-3box.js
mock-dev.js
README.md
require-react-devtools.js
run-ganache
selector.js
sentry-publish.js
sentry-upload-artifacts.sh
shellcheck.sh
show-deps-install-scripts.js
source-map-explorer.sh
sourcemap-validator.js
static-server.js
test.html
verify-locale-strings.js

Development

Several files which are needed for developing on(!) MetaMask.

Usually each files contains information about its scope / usage.