mirror of
https://github.com/kremalicious/metamask-extension.git
synced 2024-11-22 18:00:18 +01:00
96929d99c0
What - modify `ui/app/helpers/utils/transactions.util.js` and `ui/lib/account-link.js` to strip trailing slashes if they are present. - added relevant tests not just for the new scenario, but also the general scenarios for these functions, as there previously was no test coverage for these two functions. Why - Current behaviour, when user enters a block explorer URL when configuring a custom RPC, and that block explorer URL contains a trailing `/`. - e.g. `https://block.explorer/` - this results in a double-slash (`//`) in the transaction and account URLs generated by MetaMask. - e.g. `https://block.explorer/tx/0xabcd...`, `https://block.explorer/account/0xabcd...` - This needs to be handled using a router redirect on the server of the block explorer, and this changes would avoid that requirement. |
||
|---|---|---|
| .. | ||
| account-link.js | ||
| etherscan-prefix-for-network.js | ||
| icon-factory.js | ||
| is-mobile-view.js | ||
| local-storage-helpers.js | ||
| shallow-with-context.js | ||
| test-timeout.js | ||
| tx-helper.js | ||
| webcam-utils.js | ||