1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-11-23 10:30:04 +01:00
metamask-extension/app/scripts
Mark Stacey 703a063ad1
Fix metrics error when options are not used (#9985)
Attempts to send metrics would fail when no `options` were used. This
was because when the options parameter was not set, it was often sent
over our RPC connection as `undefined`, which gets serialized to `null`
when the message is converted to JSON. This `null` parameter didn't
trigger the default parameter set in the metametrics controller, as
default parameters are only used for `undefined`.

Instead the `options` parameter is now treated as fully optional, with
no default value set. The optional chaining operator is used to ensure
it won't blow up if it's not set. A fallback of `{}` was used for the
one destructure case as well.
2020-12-03 15:35:11 -03:30
..
account-import-strategies Create custom addHexPrefix function (#9306) 2020-11-06 13:18:00 -08:00
controllers Fix metrics error when options are not used (#9985) 2020-12-03 15:35:11 -03:30
lib add new MetaMetricsController (#9857) 2020-12-02 15:41:30 -06:00
migrations add new MetaMetricsController (#9857) 2020-12-02 15:41:30 -06:00
platforms expand transaction constants coverage (#9790) 2020-11-07 01:38:12 -06:00
background.js Add SES lockdown to extension webapp (#9729) 2020-11-24 11:26:43 +08:00
chromereload.js
contentscript.js Make JSDoc formatting more consistent (#9796) 2020-11-10 14:00:41 -03:30
first-time-state.js [RFC] add prettier to eslint (#8595) 2020-11-02 17:41:28 -06:00
initSentry.js Add SES lockdown to extension webapp (#9729) 2020-11-24 11:26:43 +08:00
inpage.js Warn instead of throw on duplicate web3 and do not inject (#9832) 2020-11-09 10:40:40 -08:00
metamask-controller.js add new MetaMetricsController (#9857) 2020-12-02 15:41:30 -06:00
phishing-detect.js [RFC] add prettier to eslint (#8595) 2020-11-02 17:41:28 -06:00
runLockdown.js Add SES lockdown to extension webapp (#9729) 2020-11-24 11:26:43 +08:00
ui.js Add SES lockdown to extension webapp (#9729) 2020-11-24 11:26:43 +08:00