1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-11-26 12:29:06 +01:00
metamask-extension/app
Dan J Miller 7bc2370be5 Use tokenList to get token details, when available, in getTokenStanda… (#17891)
* Use tokenList to get token details, when available, in getTokenStandardAndDetails

Previously, every call to getTokenStandardAndDetails would fetch data via the provider.
This would result in at least 3 network requests whenever that method is called for an
ERC20 token, contributing to unneccesary loading and lagging in multiple places.
This commit takes advantage of stored data we already have available to avoid the unnecessary
loading.

* Lint fix

* Fix build-quote test

* bump coverage targets

* Pass provider to token-util, for use in ethers Contract module

* Check all possible sources of ERC20 token data before async call to assetsContractController

* Add and update tests

* Update app/scripts/metamask-controller.js

Co-authored-by: Alex Donesky <adonesky@gmail.com>

* Update app/scripts/metamask-controller.js

Co-authored-by: Alex Donesky <adonesky@gmail.com>

* Remove unnecessary this.ethQuery changes

* Use metamask-eth-abis instead of human-standard-token-abi in token-util.ts

* Add explanatory comments to getTokenStandardAndDetails

* lint fix

* Cleanup

* fix test

* Update app/scripts/metamask-controller.js

Co-authored-by: Alex Donesky <adonesky@gmail.com>

* update error message

---------

Co-authored-by: Alex Donesky <adonesky@gmail.com>
2023-03-09 09:59:14 +00:00
..
_locales UX: Icons: Stop using fa-address-book (#17761) 2023-03-02 12:40:20 +00:00
build-types Add desktop build type (#17592) 2023-02-08 09:24:01 +00:00
fonts UI-14395: typography v2 (#15408) 2022-08-18 10:51:53 -07:00
images add double arrow icons (#17654) 2023-02-08 13:10:07 +05:30
manifest Restore support for Chromium v78 (#17251) 2023-01-23 12:36:48 -03:30
scripts Use tokenList to get token details, when available, in getTokenStanda… (#17891) 2023-03-09 09:59:14 +00:00
vendor/trezor
background.html Integrating snow into metamask (#15580) 2022-11-24 02:36:19 +02:00
home.html Integrating snow into metamask (#15580) 2022-11-24 02:36:19 +02:00
loading.html
notification.html Integrating snow into metamask (#15580) 2022-11-24 02:36:19 +02:00
popup.html Integrating snow into metamask (#15580) 2022-11-24 02:36:19 +02:00
trezor-usb-permissions.html chore: Adjust trailing whitespace (#15636) 2022-08-24 14:11:49 -05:00