m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-12 20:57:12 +01:00
Code
6ad76745fe
metamask-extension/app/scripts/controllers/permissions
History
Mark Stacey 917290e764 Revert "Moved subscribe and filter into network controller (#16693)" (#18129) 
* Revert "Moved subscribe and filter into network controller (#16693)"

This reverts commit 6f6984fa58. That
commit was an RPC middleware refactor intended to move the subscribe
and filter middleware into the network controller, to simplify the
process of sharing this middleware between clients.

This refactor resulted in `eth_subscribe` notifications being sent on
the wrong connections, causing the UI to break in some cases (the UI
`provider` connection does not support notifications). This happened
because the `setupProviderEngine` function runs per-connection,
whereas the engine setup inside the network controller is global. The
global network client cannot support notifications because it has no
way to route them; they'll need to stay in the per-connection provider
engine.

Closes #17467

* Add e2e test

An e2e test has been added that confirms subscriptions are only
broadcast to the site that registered them. This test fails on
`develop`.
2023-03-30 15:18:50 +01:00
..
flask Pass excludedPermissions to SnapController (#17321) 2023-02-15 11:09:47 +01:00
background-api.js Making addPermittedAccount and removePermittedAccount methods idempotent (#15709) 2022-09-07 01:17:48 +05:30
background-api.test.js Making addPermittedAccount and removePermittedAccount methods idempotent (#15709) 2022-09-07 01:17:48 +05:30
caveat-mutators.js Migrate to new controller packages (#16547) 2022-11-24 16:29:07 -03:30
caveat-mutators.test.js Migrate to new controller packages (#16547) 2022-11-24 16:29:07 -03:30
enums.js Permission System 2.0 (#12243) 2021-12-06 19:16:49 -08:00
index.js Add Snaps via Flask (#13462) 2022-02-14 16:02:51 -08:00
permission-log.js remove exclusions for mismatched object jsdoc type casing (#15351) 2022-07-27 08:28:05 -05:00
permission-log.test.js remove exclusions for mismatched object jsdoc type casing (#15351) 2022-07-27 08:28:05 -05:00
selectors.js Permission System 2.0 (#12243) 2021-12-06 19:16:49 -08:00
selectors.test.js Permission System 2.0 (#12243) 2021-12-06 19:16:49 -08:00
specifications.js Revert "Moved subscribe and filter into network controller (#16693)" (#18129) 2023-03-30 15:18:50 +01:00
specifications.test.js [FLASK] BREAKING - snaps-monorepo@0.30.0 (#17718) 2023-03-08 13:29:23 -05:00