1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-10-24 12:23:39 +02:00
metamask-extension/ui/app/pages/swaps/select-quote-popover
Mark Stacey bb3a0423d4
Ensure custom slippage is a number (#9915)
This fixes a PropType error when using non-custom slippage, and it
fixes a type inconsistency when custom slippage is used.

Previously, `slippage` was being converted explicitly to a `Number` as
it was passed into `BuildQuote`, but not as it was passed into
`AwaitingSwap`. Also the PropType was set as `string`, despite the fact
that it's a number in most cases, and is used for math.

The PropType has been changed to `number`, and the selective casting to
`Number` has been removed. Instead, the `maxSlippage` value is cast to
a `Number` as it's being selected, so that the type is always
consistent.
2020-11-19 11:56:55 -03:30
..
quote-details Provide alternative text for images where appropriate 2020-11-11 09:38:15 -06:00
sort-list [RFC] add prettier to eslint (#8595) 2020-11-02 17:41:28 -06:00
index.js
index.scss
mock-quote-data.js Fix PropType warning about quoteDataRows[0].rawNetworkFees (#9842) 2020-11-10 14:17:55 -03:30
select-quote-popover-constants.js Ensure custom slippage is a number (#9915) 2020-11-19 11:56:55 -03:30
select-quote-popover.js [RFC] add prettier to eslint (#8595) 2020-11-02 17:41:28 -06:00
select-quote-popover.stories.js