1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
metamask-extension/ui/app/ducks
Mark Stacey 5ee1291662
Prevent accidental use of globals (#8340)
Previously all browser globals were allowed to be used anywhere by
ESLint because we had set the `env` property to `browser` in the ESLint
config. This has made it easy to accidentally use browser globals
(e.g. #8338), so it has been removed. Instead we now have a short list
of allowed globals.

All browser globals are now accessed as properties on `window`.

Unfortunately this change resulted in a few different confusing unit
test errors, as some of our unit tests setup assumed that a particular
global would be used via `window` or `global`. In particular,
`window.fetch` didn't work correctly because it wasn't patched by the
AbortController polyfill (only `global.fetch` was being patched).
The `jsdom-global` package we were using complicated matters by setting
all of the JSDOM `window` properties directly on `global`, overwriting
the `AbortController` for example.

The `helpers.js` test setup module has been simplified somewhat by
removing `jsdom-global` and constructing the JSDOM instance manually.
The JSDOM window is set on `window`, and a few properties are set on
`global` as well as needed by various dependencies. `node-fetch` and
the AbortController polyfill/patch now work as expected as well,
though `fetch` is only available on `window` now.
2020-04-15 14:23:27 -03:00
..
app Move action constants to separate module (#8308) 2020-04-08 21:35:37 -03:00
confirm-transaction Enable arrow-parens ESLint rule 2020-02-15 17:04:21 -03:30
gas Prevent accidental use of globals (#8340) 2020-04-15 14:23:27 -03:00
locale Move action constants to separate module (#8308) 2020-04-08 21:35:37 -03:00
metamask Move action constants to separate module (#8308) 2020-04-08 21:35:37 -03:00
send Update ESLint rules for test suite (#8023) 2020-02-11 13:21:13 -03:30
index.js Use combineReducers for rootReducer (#7964) 2020-02-06 13:08:14 -03:30