mirror of
https://github.com/kremalicious/metamask-extension.git
synced 2024-11-23 02:10:12 +01:00
5ee1291662
Previously all browser globals were allowed to be used anywhere by ESLint because we had set the `env` property to `browser` in the ESLint config. This has made it easy to accidentally use browser globals (e.g. #8338), so it has been removed. Instead we now have a short list of allowed globals. All browser globals are now accessed as properties on `window`. Unfortunately this change resulted in a few different confusing unit test errors, as some of our unit tests setup assumed that a particular global would be used via `window` or `global`. In particular, `window.fetch` didn't work correctly because it wasn't patched by the AbortController polyfill (only `global.fetch` was being patched). The `jsdom-global` package we were using complicated matters by setting all of the JSDOM `window` properties directly on `global`, overwriting the `AbortController` for example. The `helpers.js` test setup module has been simplified somewhat by removing `jsdom-global` and constructing the JSDOM instance manually. The JSDOM window is set on `window`, and a few properties are set on `global` as well as needed by various dependencies. `node-fetch` and the AbortController polyfill/patch now work as expected as well, though `fetch` is only available on `window` now. |
||
|---|---|---|
| .. | ||
| contract-test | ||
| fixtures | ||
| mock-3box | ||
| send-eth-with-private-key-test | ||
| tests | ||
| webdriver | ||
| .eslintrc.js | ||
| address-book.spec.js | ||
| benchmark.js | ||
| ethereum-on.spec.js | ||
| fixture-server.js | ||
| from-import-ui.spec.js | ||
| ganache.js | ||
| helpers.js | ||
| incremental-security.spec.js | ||
| metamask-responsive-ui.spec.js | ||
| metamask-ui.spec.js | ||
| permissions.spec.js | ||
| run-all.sh | ||
| run-web3.sh | ||
| send-edit.spec.js | ||
| signature-request.spec.js | ||
| threebox.spec.js | ||
| web3.spec.js | ||