mirror of
https://github.com/kremalicious/metamask-extension.git
synced 2024-12-23 09:52:26 +01:00
5ee1291662
Previously all browser globals were allowed to be used anywhere by ESLint because we had set the `env` property to `browser` in the ESLint config. This has made it easy to accidentally use browser globals (e.g. #8338), so it has been removed. Instead we now have a short list of allowed globals. All browser globals are now accessed as properties on `window`. Unfortunately this change resulted in a few different confusing unit test errors, as some of our unit tests setup assumed that a particular global would be used via `window` or `global`. In particular, `window.fetch` didn't work correctly because it wasn't patched by the AbortController polyfill (only `global.fetch` was being patched). The `jsdom-global` package we were using complicated matters by setting all of the JSDOM `window` properties directly on `global`, overwriting the `AbortController` for example. The `helpers.js` test setup module has been simplified somewhat by removing `jsdom-global` and constructing the JSDOM instance manually. The JSDOM window is set on `window`, and a few properties are set on `global` as well as needed by various dependencies. `node-fetch` and the AbortController polyfill/patch now work as expected as well, though `fetch` is only available on `window` now. |
||
|---|---|---|
| .. | ||
| ens-ipfs | ||
| migrator | ||
| account-tracker.js | ||
| auto-reload.js | ||
| backend-metametrics.js | ||
| buy-eth-url.js | ||
| cleanErrorStack.js | ||
| ComposableObservableStore.js | ||
| createDnodeRemoteGetter.js | ||
| createLoggerMiddleware.js | ||
| createOnboardingMiddleware.js | ||
| createOriginMiddleware.js | ||
| createStreamSink.js | ||
| createTabIdMiddleware.js | ||
| decrypt-message-manager.js | ||
| encryption-public-key-manager.js | ||
| enums.js | ||
| extractEthjsErrorMessage.js | ||
| fetch-with-timeout.js | ||
| freezeGlobals.js | ||
| get-first-preferred-lang-code.js | ||
| getObjStructure.js | ||
| local-store.js | ||
| message-manager.js | ||
| network-store.js | ||
| nodeify.js | ||
| notification-manager.js | ||
| pending-balance-calculator.js | ||
| personal-message-manager.js | ||
| random-id.js | ||
| reportFailedTxToSentry.js | ||
| seed-phrase-verifier.js | ||
| select-chain-id.js | ||
| setupFetchDebugging.js | ||
| setupSentry.js | ||
| stream-utils.js | ||
| typed-message-manager.js | ||
| util.js | ||