mirror of
https://github.com/kremalicious/metamask-extension.git
synced 2024-11-28 23:06:37 +01:00
49a525b9f8
* Add `react/no-unused-prop-types` rule All detected unused prop types have been removed. I have attempted to ensure these props are no longer passed in either. * Update handling of props to avoid false positive lint errors These cases were detected by `react/no-unused-prop-types` as being unused props, even though they were used. These minor adjustments prevent them from being flagged as errors. * Update unit tests Many of these tests were just checking that specific props were passed from containers or to a child component. These were deleted, as I can't imagine how they'd be useful. * Disable `react/no-unused-prop-types` in `componentWillReceiveProps The rule `react/no-unused-prop-types` doesn't seem to be detecting props used within `UNSAFE_componentWillReceiveProps`. The two cases have been disabled temporarily until we can replace these unsafe lifecycle functions.
94 lines
2.7 KiB
JavaScript
94 lines
2.7 KiB
JavaScript
import assert from 'assert'
|
|
import proxyquire from 'proxyquire'
|
|
import sinon from 'sinon'
|
|
|
|
let mapDispatchToProps
|
|
|
|
const actionSpies = {
|
|
setMaxModeTo: sinon.spy(),
|
|
updateSendAmount: sinon.spy(),
|
|
}
|
|
const duckActionSpies = {
|
|
updateSendErrors: sinon.spy(),
|
|
}
|
|
|
|
proxyquire('../send-amount-row.container.js', {
|
|
'react-redux': {
|
|
connect: (_, md) => {
|
|
mapDispatchToProps = md
|
|
return () => ({})
|
|
},
|
|
},
|
|
'./send-amount-row.selectors': { sendAmountIsInError: (s) => `mockInError:${s}` },
|
|
'../../send.utils': {
|
|
getAmountErrorObject: (mockDataObject) => ({ ...mockDataObject, mockChange: true }),
|
|
getGasFeeErrorObject: (mockDataObject) => ({ ...mockDataObject, mockGasFeeErrorChange: true }),
|
|
},
|
|
'../../../../store/actions': actionSpies,
|
|
'../../../../ducks/send/send.duck': duckActionSpies,
|
|
})
|
|
|
|
describe('send-amount-row container', () => {
|
|
|
|
describe('mapDispatchToProps()', () => {
|
|
let dispatchSpy
|
|
let mapDispatchToPropsObject
|
|
|
|
beforeEach(() => {
|
|
dispatchSpy = sinon.spy()
|
|
mapDispatchToPropsObject = mapDispatchToProps(dispatchSpy)
|
|
duckActionSpies.updateSendErrors.resetHistory()
|
|
})
|
|
|
|
describe('setMaxModeTo()', () => {
|
|
it('should dispatch an action', () => {
|
|
mapDispatchToPropsObject.setMaxModeTo('mockBool')
|
|
assert(dispatchSpy.calledOnce)
|
|
assert(actionSpies.setMaxModeTo.calledOnce)
|
|
assert.equal(
|
|
actionSpies.setMaxModeTo.getCall(0).args[0],
|
|
'mockBool'
|
|
)
|
|
})
|
|
})
|
|
|
|
describe('updateSendAmount()', () => {
|
|
it('should dispatch an action', () => {
|
|
mapDispatchToPropsObject.updateSendAmount('mockAmount')
|
|
assert(dispatchSpy.calledOnce)
|
|
assert(actionSpies.updateSendAmount.calledOnce)
|
|
assert.equal(
|
|
actionSpies.updateSendAmount.getCall(0).args[0],
|
|
'mockAmount'
|
|
)
|
|
})
|
|
})
|
|
|
|
describe('updateGasFeeError()', () => {
|
|
it('should dispatch an action', () => {
|
|
mapDispatchToPropsObject.updateGasFeeError({ some: 'data' })
|
|
assert(dispatchSpy.calledOnce)
|
|
assert(duckActionSpies.updateSendErrors.calledOnce)
|
|
assert.deepEqual(
|
|
duckActionSpies.updateSendErrors.getCall(0).args[0],
|
|
{ some: 'data', mockGasFeeErrorChange: true }
|
|
)
|
|
})
|
|
})
|
|
|
|
describe('updateSendAmountError()', () => {
|
|
it('should dispatch an action', () => {
|
|
mapDispatchToPropsObject.updateSendAmountError({ some: 'data' })
|
|
assert(dispatchSpy.calledOnce)
|
|
assert(duckActionSpies.updateSendErrors.calledOnce)
|
|
assert.deepEqual(
|
|
duckActionSpies.updateSendErrors.getCall(0).args[0],
|
|
{ some: 'data', mockChange: true }
|
|
)
|
|
})
|
|
})
|
|
|
|
})
|
|
|
|
})
|