mirror of
https://github.com/kremalicious/metamask-extension.git
synced 2024-11-25 20:02:58 +01:00
adb50d1357
* Add a delay after connecting This addresses an intermittent test failure where the MetaMask Notification window cannot be found. It appears to be caused by the Send button being clicked too soon after connecting to a dapp, before the background has had a chance to process the approval. The premature send is ignored and the window never appears. This delay (2 seconds) should be sufficient time for the connection to be processed. A later 5-second delay was also reduced to 2 seconds. * Select onboarding buttons by button text The onboarding buttons were being selected using the classname, which was common to all onboarding buttons. This resulting in buttons being selected just before a page transition, leading to an error about the element reference being stale when a click was attempted. The CSS class selectors have been replaced by text selectors, which are more specific and shouldn't be at risk of resolving early. They're also easier to read. * Remove retypeSeedPhrase function This function was used to re-type the seed phrase in the event that a failure occurred when confirming the seed phrase. I'm not sure what failure this was meant to address exactly, but this contingency hasn't been needed for some time. We can tell that it hasn't been used because it wasn't updated for the incremental account security changes, so it couldn't have worked since then (it would have clicked the wrong button). |
||
---|---|---|
.. | ||
contract-test | ||
mock-3box | ||
send-eth-with-private-key-test | ||
address-book.spec.js | ||
ethereum-on.spec.js | ||
fetch-mocks.json | ||
from-import-ui.spec.js | ||
func.js | ||
helpers.js | ||
incremental-security.spec.js | ||
metamask-responsive-ui.spec.js | ||
metamask-ui.spec.js | ||
run-all.sh | ||
run-web3.sh | ||
send-edit.spec.js | ||
threebox.spec.js | ||
web3.spec.js |