mirror of
https://github.com/kremalicious/metamask-extension.git
synced 2024-12-23 09:52:26 +01:00
cdfa2e66fd
On-chain failed transactions have a transaction status of `confirmed`, and should not be retried. Our retry function doesn't handle on-chain failures yet, so it would inevitably fail due to the transaction having the same nonce as a confirmed on-chain transaction. When determining whether to show the retry button in the UI, we had mistakenly been using a `status` variable that determined whether we should show "Failed" on that transaction in the activity log. That display status includes both network and on-chain failures, unlike the `txMeta.status` property. The `showRetry` logic has been updated to ensure it's only shown when `txMeta.status` is `failed`, meaning on-chain failures will no longer show the retry button. Additionally, the display-specific `status` variable has been renamed to `displayedStatusKey`, to indicate that it is a string that corresponds to a localized message, and that it's the status meant for display purposes. |
||
|---|---|---|
| .. | ||
| tests | ||
| useCancelTransaction.js | ||
| useCopyToClipboard.js | ||
| useCurrencyDisplay.js | ||
| useCurrentAsset.js | ||
| useEqualityCheck.js | ||
| useEthFiatAmount.js | ||
| useI18nContext.js | ||
| useMethodData.js | ||
| useMetricEvent.js | ||
| usePrevious.js | ||
| useRetryTransaction.js | ||
| useShouldShowSpeedUp.js | ||
| useSwappedTokenValue.js | ||
| useTimeout.js | ||
| useTokenData.js | ||
| useTokenDisplayValue.js | ||
| useTokenFiatAmount.js | ||
| useTokensToSearch.js | ||
| useTokenTracker.js | ||
| useTransactionDisplayData.js | ||
| useTransactionTimeRemaining.js | ||
| useUserPreferencedCurrency.js | ||