1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-11-24 11:01:41 +01:00
metamask-extension/ui/app/pages/swaps
Mark Stacey bb3a0423d4
Ensure custom slippage is a number (#9915)
This fixes a PropType error when using non-custom slippage, and it
fixes a type inconsistency when custom slippage is used.

Previously, `slippage` was being converted explicitly to a `Number` as
it was passed into `BuildQuote`, but not as it was passed into
`AwaitingSwap`. Also the PropType was set as `string`, despite the fact
that it's a number in most cases, and is used for math.

The PropType has been changed to `number`, and the selective casting to
`Number` has been removed. Instead, the `maxSlippage` value is cast to
a `Number` as it's being selected, so that the type is always
consistent.
2020-11-19 11:56:55 -03:30
..
actionable-message [RFC] add prettier to eslint (#8595) 2020-11-02 17:41:28 -06:00
awaiting-swap Fix gas_fees properties collected for swaps analytics events (#9727) 2020-11-10 14:09:45 -03:30
build-quote Add token verification message to swaps build quote screen (#9891) 2020-11-17 17:26:02 -03:30
countdown-timer [RFC] add prettier to eslint (#8595) 2020-11-02 17:41:28 -06:00
dropdown-input-pair [RFC] add prettier to eslint (#8595) 2020-11-02 17:41:28 -06:00
dropdown-search-list Use optional chaining for functions 2020-11-05 10:28:24 -06:00
exchange-rate-display Revert view quote design updates (#9904) 2020-11-18 22:10:24 -03:30
fee-card Revert view quote design updates (#9904) 2020-11-18 22:10:24 -03:30
intro-popup Provide alternative text for images where appropriate 2020-11-11 09:38:15 -06:00
loading-swaps-quotes Provide alternative text for images where appropriate 2020-11-11 09:38:15 -06:00
main-quote-summary Revert view quote design updates (#9904) 2020-11-18 22:10:24 -03:30
searchable-item-list Merge pull request #9853 from darkwing/image-updates 2020-11-13 13:44:55 -06:00
select-quote-popover Ensure custom slippage is a number (#9915) 2020-11-19 11:56:55 -03:30
slippage-buttons Ensure custom slippage is a number (#9915) 2020-11-19 11:56:55 -03:30
swaps-footer Revert view quote design updates (#9904) 2020-11-18 22:10:24 -03:30
swaps-gas-customization-modal Fix setGasPrice dispatch function params 2020-11-12 14:57:29 -08:00
view-quote Revert view quote design updates (#9904) 2020-11-18 22:10:24 -03:30
index.js Ensure custom slippage is a number (#9915) 2020-11-19 11:56:55 -03:30
index.scss Add MetaMask Swaps (#9482) 2020-10-06 15:58:38 -02:30
swaps-util-test-constants.js [RFC] add prettier to eslint (#8595) 2020-11-02 17:41:28 -06:00
swaps.util.js Revert view quote design updates (#9904) 2020-11-18 22:10:24 -03:30
swaps.util.test.js [RFC] add prettier to eslint (#8595) 2020-11-02 17:41:28 -06:00