m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-10-25 04:40:18 +02:00
Code
3f8fa161ca
metamask-extension/ui/app/ducks/confirm-transaction/confirm-transaction.duck.test.js
Mark Stacey 165666b315
Remove unnecessary tx meta properties (#8489) 
* Remove `estimatedGas` property from `txMeta`

The `estimatedGas` property was a cache of the gas value estimated for
a transaction when the default gas limit was set. This property wasn't
used anywhere. It may have been useful for debugging purposes, but the
same gas estimate is already stored on the `history` property so it
should be present in state logs regardless.

* Remove `gasLimitSpecified` txMeta property

The `gasLimitSpecified` property of `txMeta` wasn't used for anything.
It might have been useful for debugging purposes, but whether or not
the gas limit was specified can also be determined from looking at the
transaction history, so it's not a huge loss.

* Remove `gasPriceSpecified` txMeta property

The `gasPriceSpecified` property of `txMeta` wasn't used for anything.
It might have been useful for debugging purposes, but whether or not
the gas price was specified can also be determined from looking at the
transaction history, so it's not a huge loss.

* Remove `simpleSend` txMeta property

The `simpleSend` property of `txMeta` was used to ensure a buffer was
not added to the gas limit during gas estimation for simple send
transactions. It was made redundant by #8484, which accomplishes this
without the use of this property.
2020-05-01 08:44:05 -03:00

655 lines
18 KiB
JavaScript
Raw Blame History

import assert from 'assert'
import configureMockStore from 'redux-mock-store'
import thunk from 'redux-thunk'
import sinon from 'sinon'
import ConfirmTransactionReducer, * as actions from './confirm-transaction.duck.js'
const initialState = {
txData: {},
tokenData: {},
methodData: {},
tokenProps: {
tokenDecimals: '',
tokenSymbol: '',
},
fiatTransactionAmount: '',
fiatTransactionFee: '',
fiatTransactionTotal: '',
ethTransactionAmount: '',
ethTransactionFee: '',
ethTransactionTotal: '',
hexTransactionAmount: '',
hexTransactionFee: '',
hexTransactionTotal: '',
nonce: '',
toSmartContract: false,
fetchingData: false,
}
const UPDATE_TX_DATA = 'metamask/confirm-transaction/UPDATE_TX_DATA'
const CLEAR_TX_DATA = 'metamask/confirm-transaction/CLEAR_TX_DATA'
const UPDATE_TOKEN_DATA = 'metamask/confirm-transaction/UPDATE_TOKEN_DATA'
const CLEAR_TOKEN_DATA = 'metamask/confirm-transaction/CLEAR_TOKEN_DATA'
const UPDATE_METHOD_DATA = 'metamask/confirm-transaction/UPDATE_METHOD_DATA'
const CLEAR_METHOD_DATA = 'metamask/confirm-transaction/CLEAR_METHOD_DATA'
const UPDATE_TRANSACTION_AMOUNTS = 'metamask/confirm-transaction/UPDATE_TRANSACTION_AMOUNTS'
const UPDATE_TRANSACTION_FEES = 'metamask/confirm-transaction/UPDATE_TRANSACTION_FEES'
const UPDATE_TRANSACTION_TOTALS = 'metamask/confirm-transaction/UPDATE_TRANSACTION_TOTALS'
const UPDATE_TOKEN_PROPS = 'metamask/confirm-transaction/UPDATE_TOKEN_PROPS'
const UPDATE_NONCE = 'metamask/confirm-transaction/UPDATE_NONCE'
const UPDATE_TO_SMART_CONTRACT = 'metamask/confirm-transaction/UPDATE_TO_SMART_CONTRACT'
const FETCH_DATA_START = 'metamask/confirm-transaction/FETCH_DATA_START'
const FETCH_DATA_END = 'metamask/confirm-transaction/FETCH_DATA_END'
const CLEAR_CONFIRM_TRANSACTION = 'metamask/confirm-transaction/CLEAR_CONFIRM_TRANSACTION'
describe('Confirm Transaction Duck', function () {
describe('State changes', function () {
const mockState = {
txData: {
id: 1,
},
tokenData: {
name: 'abcToken',
},
methodData: {
name: 'approve',
},
tokenProps: {
tokenDecimals: '3',
tokenSymbol: 'ABC',
},
fiatTransactionAmount: '469.26',
fiatTransactionFee: '0.01',
fiatTransactionTotal: '1.000021',
ethTransactionAmount: '1',
ethTransactionFee: '0.000021',
ethTransactionTotal: '469.27',
hexTransactionAmount: '',
hexTransactionFee: '0x1319718a5000',
hexTransactionTotal: '',
nonce: '0x0',
toSmartContract: false,
fetchingData: false,
}
it('should initialize state', function () {
assert.deepEqual(ConfirmTransactionReducer(undefined, {}), initialState)
})
it('should return state unchanged if it does not match a dispatched actions type', function () {
assert.deepEqual(
ConfirmTransactionReducer(mockState, {
type: 'someOtherAction',
value: 'someValue',
}),
{ ...mockState },
)
})
it('should set txData when receiving a UPDATE_TX_DATA action', function () {
assert.deepEqual(
ConfirmTransactionReducer(mockState, {
type: UPDATE_TX_DATA,
payload: {
id: 2,
},
}),
{
...mockState,
txData: {
...mockState.txData,
id: 2,
},
}
)
})
it('should clear txData when receiving a CLEAR_TX_DATA action', function () {
assert.deepEqual(
ConfirmTransactionReducer(mockState, {
type: CLEAR_TX_DATA,
}),
{
...mockState,
txData: {},
}
)
})
it('should set tokenData when receiving a UPDATE_TOKEN_DATA action', function () {
assert.deepEqual(
ConfirmTransactionReducer(mockState, {
type: UPDATE_TOKEN_DATA,
payload: {
name: 'defToken',
},
}),
{
...mockState,
tokenData: {
...mockState.tokenData,
name: 'defToken',
},
}
)
})
it('should clear tokenData when receiving a CLEAR_TOKEN_DATA action', function () {
assert.deepEqual(
ConfirmTransactionReducer(mockState, {
type: CLEAR_TOKEN_DATA,
}),
{
...mockState,
tokenData: {},
}
)
})
it('should set methodData when receiving a UPDATE_METHOD_DATA action', function () {
assert.deepEqual(
ConfirmTransactionReducer(mockState, {
type: UPDATE_METHOD_DATA,
payload: {
name: 'transferFrom',
},
}),
{
...mockState,
methodData: {
...mockState.methodData,
name: 'transferFrom',
},
}
)
})
it('should clear methodData when receiving a CLEAR_METHOD_DATA action', function () {
assert.deepEqual(
ConfirmTransactionReducer(mockState, {
type: CLEAR_METHOD_DATA,
}),
{
...mockState,
methodData: {},
}
)
})
it('should update transaction amounts when receiving an UPDATE_TRANSACTION_AMOUNTS action', function () {
assert.deepEqual(
ConfirmTransactionReducer(mockState, {
type: UPDATE_TRANSACTION_AMOUNTS,
payload: {
fiatTransactionAmount: '123.45',
ethTransactionAmount: '.5',
hexTransactionAmount: '0x1',
},
}),
{
...mockState,
fiatTransactionAmount: '123.45',
ethTransactionAmount: '.5',
hexTransactionAmount: '0x1',
}
)
})
it('should update transaction fees when receiving an UPDATE_TRANSACTION_FEES action', function () {
assert.deepEqual(
ConfirmTransactionReducer(mockState, {
type: UPDATE_TRANSACTION_FEES,
payload: {
fiatTransactionFee: '123.45',
ethTransactionFee: '.5',
hexTransactionFee: '0x1',
},
}),
{
...mockState,
fiatTransactionFee: '123.45',
ethTransactionFee: '.5',
hexTransactionFee: '0x1',
}
)
})
it('should update transaction totals when receiving an UPDATE_TRANSACTION_TOTALS action', function () {
assert.deepEqual(
ConfirmTransactionReducer(mockState, {
type: UPDATE_TRANSACTION_TOTALS,
payload: {
fiatTransactionTotal: '123.45',
ethTransactionTotal: '.5',
hexTransactionTotal: '0x1',
},
}),
{
...mockState,
fiatTransactionTotal: '123.45',
ethTransactionTotal: '.5',
hexTransactionTotal: '0x1',
}
)
})
it('should update tokenProps when receiving an UPDATE_TOKEN_PROPS action', function () {
assert.deepEqual(
ConfirmTransactionReducer(mockState, {
type: UPDATE_TOKEN_PROPS,
payload: {
tokenSymbol: 'DEF',
tokenDecimals: '1',
},
}),
{
...mockState,
tokenProps: {
tokenSymbol: 'DEF',
tokenDecimals: '1',
},
}
)
})
it('should update nonce when receiving an UPDATE_NONCE action', function () {
assert.deepEqual(
ConfirmTransactionReducer(mockState, {
type: UPDATE_NONCE,
payload: '0x1',
}),
{
...mockState,
nonce: '0x1',
}
)
})
it('should update nonce when receiving an UPDATE_TO_SMART_CONTRACT action', function () {
assert.deepEqual(
ConfirmTransactionReducer(mockState, {
type: UPDATE_TO_SMART_CONTRACT,
payload: true,
}),
{
...mockState,
toSmartContract: true,
}
)
})
it('should set fetchingData to true when receiving a FETCH_DATA_START action', function () {
assert.deepEqual(
ConfirmTransactionReducer(mockState, {
type: FETCH_DATA_START,
}),
{
...mockState,
fetchingData: true,
}
)
})
it('should set fetchingData to false when receiving a FETCH_DATA_END action', function () {
assert.deepEqual(
ConfirmTransactionReducer({ fetchingData: true }, { type: FETCH_DATA_END }),
{ fetchingData: false },
)
})
it('should clear confirmTransaction when receiving a FETCH_DATA_END action', function () {
assert.deepEqual(ConfirmTransactionReducer(mockState, { type: CLEAR_CONFIRM_TRANSACTION }), initialState)
})
})
describe('Single actions', function () {
it('should create an action to update txData', function () {
const txData = { test: 123 }
const expectedAction = {
type: UPDATE_TX_DATA,
payload: txData,
}
assert.deepEqual(
actions.updateTxData(txData),
expectedAction
)
})
it('should create an action to clear txData', function () {
const expectedAction = {
type: CLEAR_TX_DATA,
}
assert.deepEqual(
actions.clearTxData(),
expectedAction
)
})
it('should create an action to update tokenData', function () {
const tokenData = { test: 123 }
const expectedAction = {
type: UPDATE_TOKEN_DATA,
payload: tokenData,
}
assert.deepEqual(
actions.updateTokenData(tokenData),
expectedAction
)
})
it('should create an action to clear tokenData', function () {
const expectedAction = {
type: CLEAR_TOKEN_DATA,
}
assert.deepEqual(
actions.clearTokenData(),
expectedAction
)
})
it('should create an action to update methodData', function () {
const methodData = { test: 123 }
const expectedAction = {
type: UPDATE_METHOD_DATA,
payload: methodData,
}
assert.deepEqual(
actions.updateMethodData(methodData),
expectedAction
)
})
it('should create an action to clear methodData', function () {
const expectedAction = {
type: CLEAR_METHOD_DATA,
}
assert.deepEqual(
actions.clearMethodData(),
expectedAction
)
})
it('should create an action to update transaction amounts', function () {
const transactionAmounts = { test: 123 }
const expectedAction = {
type: UPDATE_TRANSACTION_AMOUNTS,
payload: transactionAmounts,
}
assert.deepEqual(
actions.updateTransactionAmounts(transactionAmounts),
expectedAction
)
})
it('should create an action to update transaction fees', function () {
const transactionFees = { test: 123 }
const expectedAction = {
type: UPDATE_TRANSACTION_FEES,
payload: transactionFees,
}
assert.deepEqual(
actions.updateTransactionFees(transactionFees),
expectedAction
)
})
it('should create an action to update transaction totals', function () {
const transactionTotals = { test: 123 }
const expectedAction = {
type: UPDATE_TRANSACTION_TOTALS,
payload: transactionTotals,
}
assert.deepEqual(
actions.updateTransactionTotals(transactionTotals),
expectedAction
)
})
it('should create an action to update tokenProps', function () {
const tokenProps = {
tokenDecimals: '1',
tokenSymbol: 'abc',
}
const expectedAction = {
type: UPDATE_TOKEN_PROPS,
payload: tokenProps,
}
assert.deepEqual(
actions.updateTokenProps(tokenProps),
expectedAction
)
})
it('should create an action to update nonce', function () {
const nonce = '0x1'
const expectedAction = {
type: UPDATE_NONCE,
payload: nonce,
}
assert.deepEqual(
actions.updateNonce(nonce),
expectedAction
)
})
it('should create an action to set fetchingData to true', function () {
const expectedAction = {
type: FETCH_DATA_START,
}
assert.deepEqual(
actions.setFetchingData(true),
expectedAction
)
})
it('should create an action to set fetchingData to false', function () {
const expectedAction = {
type: FETCH_DATA_END,
}
assert.deepEqual(
actions.setFetchingData(false),
expectedAction
)
})
it('should create an action to clear confirmTransaction', function () {
const expectedAction = {
type: CLEAR_CONFIRM_TRANSACTION,
}
assert.deepEqual(
actions.clearConfirmTransaction(),
expectedAction
)
})
})
describe('Thunk actions', function () {
beforeEach(function () {
global.eth = {
getCode: sinon.stub().callsFake(
(address) => Promise.resolve(address && address.match(/isContract/) ? 'not-0x' : '0x')
),
}
})
afterEach(function () {
global.eth.getCode.resetHistory()
})
it('updates txData and gas on an existing transaction in confirmTransaction', function () {
const mockState = {
metamask: {
conversionRate: 468.58,
currentCurrency: 'usd',
},
confirmTransaction: {
ethTransactionAmount: '1',
ethTransactionFee: '0.000021',
ethTransactionTotal: '1.000021',
fetchingData: false,
fiatTransactionAmount: '469.26',
fiatTransactionFee: '0.01',
fiatTransactionTotal: '469.27',
hexGasTotal: '0x1319718a5000',
methodData: {},
nonce: '',
tokenData: {},
tokenProps: {
tokenDecimals: '',
tokenSymbol: '',
},
txData: {
history: [],
id: 2603411941761054,
loadingDefaults: false,
metamaskNetworkId: '3',
origin: 'faucet.metamask.io',
status: 'unapproved',
time: 1530838113716,
},
},
}
const middlewares = [thunk]
const mockStore = configureMockStore(middlewares)
const store = mockStore(mockState)
const expectedActions = [
'metamask/confirm-transaction/UPDATE_TX_DATA',
'metamask/confirm-transaction/UPDATE_TRANSACTION_AMOUNTS',
'metamask/confirm-transaction/UPDATE_TRANSACTION_FEES',
'metamask/confirm-transaction/UPDATE_TRANSACTION_TOTALS',
]
store.dispatch(actions.updateGasAndCalculate({ gasLimit: '0x2', gasPrice: '0x25' }))
const storeActions = store.getActions()
assert.equal(storeActions.length, expectedActions.length)
storeActions.forEach((action, index) => assert.equal(action.type, expectedActions[index]))
})
it('updates txData and updates gas values in confirmTransaction', function () {
const txData = {
history: [],
id: 2603411941761054,
loadingDefaults: false,
metamaskNetworkId: '3',
origin: 'faucet.metamask.io',
status: 'unapproved',
time: 1530838113716,
txParams: {
from: '0xc5ae6383e126f901dcb06131d97a88745bfa88d6',
gas: '0x33450',
gasPrice: '0x2540be400',
to: '0x81b7e08f65bdf5648606c89998a9cc8164397647',
value: '0xde0b6b3a7640000',
},
}
const mockState = {
metamask: {
conversionRate: 468.58,
currentCurrency: 'usd',
},
confirmTransaction: {
ethTransactionAmount: '1',
ethTransactionFee: '0.000021',
ethTransactionTotal: '1.000021',
fetchingData: false,
fiatTransactionAmount: '469.26',
fiatTransactionFee: '0.01',
fiatTransactionTotal: '469.27',
hexGasTotal: '0x1319718a5000',
methodData: {},
nonce: '',
tokenData: {},
tokenProps: {
tokenDecimals: '',
tokenSymbol: '',
},
txData: {
...txData,
txParams: {
...txData.txParams,
},
},
},
}
const middlewares = [thunk]
const mockStore = configureMockStore(middlewares)
const store = mockStore(mockState)
const expectedActions = [
'metamask/confirm-transaction/UPDATE_TX_DATA',
'metamask/confirm-transaction/UPDATE_TRANSACTION_AMOUNTS',
'metamask/confirm-transaction/UPDATE_TRANSACTION_FEES',
'metamask/confirm-transaction/UPDATE_TRANSACTION_TOTALS',
]
store.dispatch(actions.updateTxDataAndCalculate(txData))
const storeActions = store.getActions()
assert.equal(storeActions.length, expectedActions.length)
storeActions.forEach((action, index) => assert.equal(action.type, expectedActions[index]))
})
it('updates confirmTransaction transaction', function () {
const mockState = {
metamask: {
conversionRate: 468.58,
currentCurrency: 'usd',
network: '3',
unapprovedTxs: {
2603411941761054: {
history: [],
id: 2603411941761054,
loadingDefaults: false,
metamaskNetworkId: '3',
origin: 'faucet.metamask.io',
status: 'unapproved',
time: 1530838113716,
txParams: {
from: '0xc5ae6383e126f901dcb06131d97a88745bfa88d6',
gas: '0x33450',
gasPrice: '0x2540be400',
to: '0x81b7e08f65bdf5648606c89998a9cc8164397647',
value: '0xde0b6b3a7640000',
},
},
},
},
confirmTransaction: {},
}
const middlewares = [thunk]
const mockStore = configureMockStore(middlewares)
const store = mockStore(mockState)
const expectedActions = [
'metamask/confirm-transaction/UPDATE_TX_DATA',
'metamask/confirm-transaction/UPDATE_TRANSACTION_AMOUNTS',
'metamask/confirm-transaction/UPDATE_TRANSACTION_FEES',
'metamask/confirm-transaction/UPDATE_TRANSACTION_TOTALS',
]
store.dispatch(actions.setTransactionToConfirm(2603411941761054))
const storeActions = store.getActions()
assert.equal(storeActions.length, expectedActions.length)
storeActions.forEach((action, index) => assert.equal(action.type, expectedActions[index]))
})
})
})
View Git Blame Copy Permalink