1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
metamask-extension/test
Mark Stacey 3ab00b48df
Return Promise from setSelectedAddress thunk (#8426)
`setSelectedAddress` returned a thunk that didn't return a Promise,
despite doing async work. It now returns a Promise.

This action creator was only called in two places, and neither benefit
from using the Promise now returned. They were both event handlers. In
both cases there was an existing Promise chain, but the only thing
after this set was a `catch` block that displayed any error
encountered. I decided not to return the result of `setSelectedAddress`
to this chain, because all it would do is set the warning a second
time in the event of failure.
2020-04-27 18:56:17 -03:00
..
data Remove unused ShapeShift components (#8402) 2020-04-24 12:33:24 -03:00
e2e Remove unused currentAccountTab state (#8404) 2020-04-24 00:23:28 -03:00
integration Prevent accidental use of globals (#8340) 2020-04-15 14:23:27 -03:00
lib Export individual fns from tx-state-history-helpers (#8370) 2020-04-20 13:00:51 -02:30
stub Migrate codebase to use ESM (#7730) 2020-01-09 00:04:58 -03:30
unit Return Promise from setSelectedAddress thunk (#8426) 2020-04-27 18:56:17 -03:00
unit-global Update ESLint rules for test suite (#8023) 2020-02-11 13:21:13 -03:30
web3 Enable arrow-parens ESLint rule 2020-02-15 17:04:21 -03:30
base.conf.js eslint --fix . 2018-07-02 18:49:33 -04:00
env.js Remove cross-env (#7950) 2020-01-30 14:11:26 -03:30
flat.conf.js eslint --fix . 2018-07-02 18:49:33 -04:00
helper.js Prevent accidental use of globals (#8340) 2020-04-15 14:23:27 -03:00
setup.js Remove obs-store babel register handling (#8413) 2020-04-27 07:54:42 -07:00