mirror of
https://github.com/kremalicious/metamask-extension.git
synced 2024-12-23 09:52:26 +01:00
9e2e353a24
We inject `web3` globally on most websites. This has been breaking websites that attempted to serialize the `window` object, because any attempt to access certain `web3` properties (such as `web3.eth.mining`) would throw an error. This is because `web3` defined a getter for these properties that would call `.send([method])`, which doesn't work for most methods. An example of a site that this breaks is `Storybook`, when the `@storybook/addon-actions` addon is being used. When using storybook with this addon and with the MetaMask extension installed, actions would not be properly dispatched because an error would be thrown in the attempt to serialize the event (which includes a reference to the `window`). The `web3` global we inject is now defined as non-enumerable, so it will be skipped automatically in any attempt to serialize the `window` object. |
||
|---|---|---|
| .. | ||
| account-import-strategies | ||
| controllers | ||
| lib | ||
| migrations | ||
| platforms | ||
| background.js | ||
| chromereload.js | ||
| contentscript.js | ||
| first-time-state.js | ||
| inpage.js | ||
| metamask-controller.js | ||
| phishing-detect.js | ||
| ui.js | ||