1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
metamask-extension/test/unit/app
Mark Stacey 656dc4cf18
Cleanup detect-tokens controller and tests (#8329)
The tests for the detect-tokens controller were nearly all broken. They
have been fixed, and a few improvements were made to controller itself
to help with this.

* The core `detectNewTokens` method has been updated to be async, so
that the caller can know when the operation had completed.
* The part of the function that used `Web3` to check the token balances
has been split into a separate function, so that that part could be
stubbed out in tests. Eventually we should test this using `ganache`
instead, but this was an easier first step.
* The internal `tokenAddresses` array is now initialized on
construction, rather than upon the first Preferences controller update.
The `detectNewTokens` function would have previously failed if it ran
prior to this initialization, so it was failing if called before any
preferences state changes.

Additionally, the `detectTokenBalance` function was removed, as it was
no longer used.

The tests have been updated to ensure they're actually testing the
behavior they purport to be testing. I've simulated a test failure with
each one to check that it'd fail when it should. The preferences
controller instance was updated to set addresses correctly as well.
2020-04-13 17:14:42 -03:00
..
controllers Cleanup detect-tokens controller and tests (#8329) 2020-04-13 17:14:42 -03:00
account-import-strategies.spec.js Update ESLint rules for test suite (#8023) 2020-02-11 13:21:13 -03:30
buy-eth-url.spec.js Update Wyre ETH purchase url (#8051) 2020-02-14 14:07:24 -08:00
cleanErrorStack.spec.js Update ESLint rules for test suite (#8023) 2020-02-11 13:21:13 -03:30
ComposableObservableStore.js Update ESLint rules for test suite (#8023) 2020-02-11 13:21:13 -03:30
fetch-with-timeout.test.js Enable arrow-parens ESLint rule 2020-02-15 17:04:21 -03:30
message-manager-test.js Migrate codebase to use ESM (#7730) 2020-01-09 00:04:58 -03:30
nodeify-test.js Update mocha version (#8028) 2020-02-12 14:47:36 -03:30
pending-balance-test.js Update ESLint rules for test suite (#8023) 2020-02-11 13:21:13 -03:30
personal-message-manager-test.js Migrate codebase to use ESM (#7730) 2020-01-09 00:04:58 -03:30
seed-phrase-verifier-test.js Replace clone dependency with cloneDeep from lodash (#7926) 2020-01-29 13:14:33 -04:00
typed-message-manager.spec.js Update ESLint rules for test suite (#8023) 2020-02-11 13:21:13 -03:30
util-test.js Update ESLint rules for test suite (#8023) 2020-02-11 13:21:13 -03:30