mirror of
https://github.com/kremalicious/metamask-extension.git
synced 2024-11-25 11:28:51 +01:00
fd819451e1
Co-authored-by: Dan J Miller <danjm.com@gmail.com> Co-authored-by: Pedro Figueiredo <pedro.figueiredo@consensys.net> Co-authored-by: brad-decker <bhdecker84@gmail.com>
358 lines
11 KiB
JavaScript
358 lines
11 KiB
JavaScript
import { ethErrors } from 'eth-rpc-errors';
|
|
import { Interface } from '@ethersproject/abi';
|
|
import abi from 'human-standard-token-abi';
|
|
import { addHexPrefix } from '../../../lib/util';
|
|
import {
|
|
TransactionEnvelopeType,
|
|
TransactionStatus,
|
|
} from '../../../../../shared/constants/transaction';
|
|
import { isEIP1559Transaction } from '../../../../../shared/modules/transaction.utils';
|
|
import { isValidHexAddress } from '../../../../../shared/modules/hexstring-utils';
|
|
|
|
const normalizers = {
|
|
from: addHexPrefix,
|
|
to: (to, lowerCase) =>
|
|
lowerCase ? addHexPrefix(to).toLowerCase() : addHexPrefix(to),
|
|
nonce: addHexPrefix,
|
|
value: addHexPrefix,
|
|
data: addHexPrefix,
|
|
gas: addHexPrefix,
|
|
gasPrice: addHexPrefix,
|
|
maxFeePerGas: addHexPrefix,
|
|
maxPriorityFeePerGas: addHexPrefix,
|
|
type: addHexPrefix,
|
|
estimateSuggested: (estimate) => estimate,
|
|
estimateUsed: (estimate) => estimate,
|
|
};
|
|
|
|
export function normalizeAndValidateTxParams(txParams, lowerCase = true) {
|
|
const normalizedTxParams = normalizeTxParams(txParams, lowerCase);
|
|
validateTxParams(normalizedTxParams);
|
|
return normalizedTxParams;
|
|
}
|
|
|
|
/**
|
|
* Normalizes the given txParams
|
|
*
|
|
* @param {object} txParams - The transaction params
|
|
* @param {boolean} [lowerCase] - Whether to lowercase the 'to' address.
|
|
* Default: true
|
|
* @returns {object} the normalized tx params
|
|
*/
|
|
export function normalizeTxParams(txParams, lowerCase = true) {
|
|
// apply only keys in the normalizers
|
|
const normalizedTxParams = {};
|
|
for (const key in normalizers) {
|
|
if (txParams[key]) {
|
|
normalizedTxParams[key] = normalizers[key](txParams[key], lowerCase);
|
|
}
|
|
}
|
|
return normalizedTxParams;
|
|
}
|
|
|
|
/**
|
|
* Given two fields, ensure that the second field is not included in txParams,
|
|
* and if it is throw an invalidParams error.
|
|
*
|
|
* @param {object} txParams - the transaction parameters object
|
|
* @param {string} fieldBeingValidated - the current field being validated
|
|
* @param {string} mutuallyExclusiveField - the field to ensure is not provided
|
|
* @throws {ethErrors.rpc.invalidParams} Throws if mutuallyExclusiveField is
|
|
* present in txParams.
|
|
*/
|
|
function ensureMutuallyExclusiveFieldsNotProvided(
|
|
txParams,
|
|
fieldBeingValidated,
|
|
mutuallyExclusiveField,
|
|
) {
|
|
if (typeof txParams[mutuallyExclusiveField] !== 'undefined') {
|
|
throw ethErrors.rpc.invalidParams(
|
|
`Invalid transaction params: specified ${fieldBeingValidated} but also included ${mutuallyExclusiveField}, these cannot be mixed`,
|
|
);
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Ensures that the provided value for field is a string, throws an
|
|
* invalidParams error if field is not a string.
|
|
*
|
|
* @param {object} txParams - the transaction parameters object
|
|
* @param {string} field - the current field being validated
|
|
* @throws {ethErrors.rpc.invalidParams} Throws if field is not a string
|
|
*/
|
|
function ensureFieldIsString(txParams, field) {
|
|
if (typeof txParams[field] !== 'string') {
|
|
throw ethErrors.rpc.invalidParams(
|
|
`Invalid transaction params: ${field} is not a string. got: (${txParams[field]})`,
|
|
);
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Ensures that the provided txParams has the proper 'type' specified for the
|
|
* given field, if it is provided. If types do not match throws an
|
|
* invalidParams error.
|
|
*
|
|
* @param {object} txParams - the transaction parameters object
|
|
* @param {'gasPrice' | 'maxFeePerGas' | 'maxPriorityFeePerGas'} field - the
|
|
* current field being validated
|
|
* @throws {ethErrors.rpc.invalidParams} Throws if type does not match the
|
|
* expectations for provided field.
|
|
*/
|
|
function ensureProperTransactionEnvelopeTypeProvided(txParams, field) {
|
|
switch (field) {
|
|
case 'maxFeePerGas':
|
|
case 'maxPriorityFeePerGas':
|
|
if (
|
|
txParams.type &&
|
|
txParams.type !== TransactionEnvelopeType.feeMarket
|
|
) {
|
|
throw ethErrors.rpc.invalidParams(
|
|
`Invalid transaction envelope type: specified type "${txParams.type}" but including maxFeePerGas and maxPriorityFeePerGas requires type: "${TransactionEnvelopeType.feeMarket}"`,
|
|
);
|
|
}
|
|
break;
|
|
case 'gasPrice':
|
|
default:
|
|
if (
|
|
txParams.type &&
|
|
txParams.type === TransactionEnvelopeType.feeMarket
|
|
) {
|
|
throw ethErrors.rpc.invalidParams(
|
|
`Invalid transaction envelope type: specified type "${txParams.type}" but included a gasPrice instead of maxFeePerGas and maxPriorityFeePerGas`,
|
|
);
|
|
}
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Validates the given tx parameters
|
|
*
|
|
* @param {object} txParams - the tx params
|
|
* @param {boolean} eip1559Compatibility - whether or not the current network supports EIP-1559 transactions
|
|
* @throws {Error} if the tx params contains invalid fields
|
|
*/
|
|
export function validateTxParams(txParams, eip1559Compatibility = true) {
|
|
if (!txParams || typeof txParams !== 'object' || Array.isArray(txParams)) {
|
|
throw ethErrors.rpc.invalidParams(
|
|
'Invalid transaction params: must be an object.',
|
|
);
|
|
}
|
|
if (!txParams.to && !txParams.data) {
|
|
throw ethErrors.rpc.invalidParams(
|
|
'Invalid transaction params: must specify "data" for contract deployments, or "to" (and optionally "data") for all other types of transactions.',
|
|
);
|
|
}
|
|
if (isEIP1559Transaction({ txParams }) && !eip1559Compatibility) {
|
|
throw ethErrors.rpc.invalidParams(
|
|
'Invalid transaction params: params specify an EIP-1559 transaction but the current network does not support EIP-1559',
|
|
);
|
|
}
|
|
|
|
Object.entries(txParams).forEach(([key, value]) => {
|
|
// validate types
|
|
switch (key) {
|
|
case 'from':
|
|
validateFrom(txParams);
|
|
break;
|
|
case 'to':
|
|
validateRecipient(txParams);
|
|
break;
|
|
case 'gasPrice':
|
|
ensureProperTransactionEnvelopeTypeProvided(txParams, 'gasPrice');
|
|
ensureMutuallyExclusiveFieldsNotProvided(
|
|
txParams,
|
|
'gasPrice',
|
|
'maxFeePerGas',
|
|
);
|
|
ensureMutuallyExclusiveFieldsNotProvided(
|
|
txParams,
|
|
'gasPrice',
|
|
'maxPriorityFeePerGas',
|
|
);
|
|
ensureFieldIsString(txParams, 'gasPrice');
|
|
break;
|
|
case 'maxFeePerGas':
|
|
ensureProperTransactionEnvelopeTypeProvided(txParams, 'maxFeePerGas');
|
|
ensureMutuallyExclusiveFieldsNotProvided(
|
|
txParams,
|
|
'maxFeePerGas',
|
|
'gasPrice',
|
|
);
|
|
ensureFieldIsString(txParams, 'maxFeePerGas');
|
|
break;
|
|
case 'maxPriorityFeePerGas':
|
|
ensureProperTransactionEnvelopeTypeProvided(
|
|
txParams,
|
|
'maxPriorityFeePerGas',
|
|
);
|
|
ensureMutuallyExclusiveFieldsNotProvided(
|
|
txParams,
|
|
'maxPriorityFeePerGas',
|
|
'gasPrice',
|
|
);
|
|
ensureFieldIsString(txParams, 'maxPriorityFeePerGas');
|
|
break;
|
|
case 'value':
|
|
ensureFieldIsString(txParams, 'value');
|
|
if (value.toString().includes('-')) {
|
|
throw ethErrors.rpc.invalidParams(
|
|
`Invalid transaction value "${value}": not a positive number.`,
|
|
);
|
|
}
|
|
|
|
if (value.toString().includes('.')) {
|
|
throw ethErrors.rpc.invalidParams(
|
|
`Invalid transaction value of "${value}": number must be in wei.`,
|
|
);
|
|
}
|
|
|
|
if (!value.match(/^0x[a-fA-F0-9]+$/u)) {
|
|
throw ethErrors.rpc.invalidParams(
|
|
`Invalid transaction value of "${value}": not a valid hex string.`,
|
|
);
|
|
}
|
|
break;
|
|
case 'chainId':
|
|
if (typeof value !== 'number' && typeof value !== 'string') {
|
|
throw ethErrors.rpc.invalidParams(
|
|
`Invalid transaction params: ${key} is not a Number or hex string. got: (${value})`,
|
|
);
|
|
}
|
|
break;
|
|
case 'data':
|
|
validateInputData(value);
|
|
ensureFieldIsString(txParams, 'data');
|
|
break;
|
|
default:
|
|
ensureFieldIsString(txParams, key);
|
|
}
|
|
});
|
|
}
|
|
|
|
/**
|
|
*
|
|
* @param {*} value
|
|
*/
|
|
export function validateInputData(value) {
|
|
if (value !== null) {
|
|
// Validate the input data
|
|
const hstInterface = new Interface(abi);
|
|
try {
|
|
hstInterface.parseTransaction({ data: value });
|
|
} catch (e) {
|
|
// Throw an invalidParams error if BUFFER_OVERRUN
|
|
/* eslint require-unicode-regexp: off */
|
|
if (e.message.match(/BUFFER_OVERRUN/)) {
|
|
throw ethErrors.rpc.invalidParams(
|
|
`Invalid transaction params: data out-of-bounds, BUFFER_OVERRUN.`,
|
|
);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Validates the {@code from} field in the given tx params
|
|
*
|
|
* @param {object} txParams
|
|
* @throws {Error} if the from address isn't valid
|
|
*/
|
|
export function validateFrom(txParams) {
|
|
if (!(typeof txParams.from === 'string')) {
|
|
throw ethErrors.rpc.invalidParams(
|
|
`Invalid "from" address "${txParams.from}": not a string.`,
|
|
);
|
|
}
|
|
if (!isValidHexAddress(txParams.from, { allowNonPrefixed: false })) {
|
|
throw ethErrors.rpc.invalidParams('Invalid "from" address.');
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Validates the {@code to} field in the given tx params
|
|
*
|
|
* @param {object} txParams - the tx params
|
|
* @returns {object} the tx params
|
|
* @throws {Error} if the recipient is invalid OR there isn't tx data
|
|
*/
|
|
export function validateRecipient(txParams) {
|
|
if (txParams.to === '0x' || txParams.to === null) {
|
|
if (txParams.data) {
|
|
delete txParams.to;
|
|
} else {
|
|
throw ethErrors.rpc.invalidParams('Invalid "to" address.');
|
|
}
|
|
} else if (
|
|
txParams.to !== undefined &&
|
|
!isValidHexAddress(txParams.to, { allowNonPrefixed: false })
|
|
) {
|
|
throw ethErrors.rpc.invalidParams('Invalid "to" address.');
|
|
}
|
|
return txParams;
|
|
}
|
|
|
|
export const validateConfirmedExternalTransaction = ({
|
|
txMeta,
|
|
pendingTransactions,
|
|
confirmedTransactions,
|
|
} = {}) => {
|
|
if (!txMeta || !txMeta.txParams) {
|
|
throw ethErrors.rpc.invalidParams(
|
|
'"txMeta" or "txMeta.txParams" is missing',
|
|
);
|
|
}
|
|
if (txMeta.status !== TransactionStatus.confirmed) {
|
|
throw ethErrors.rpc.invalidParams(
|
|
'External transaction status should be "confirmed"',
|
|
);
|
|
}
|
|
const externalTxNonce = txMeta.txParams.nonce;
|
|
if (pendingTransactions && pendingTransactions.length > 0) {
|
|
const foundPendingTxByNonce = pendingTransactions.find(
|
|
(el) => el.txParams?.nonce === externalTxNonce,
|
|
);
|
|
if (foundPendingTxByNonce) {
|
|
throw ethErrors.rpc.invalidParams(
|
|
'External transaction nonce should not be in pending txs',
|
|
);
|
|
}
|
|
}
|
|
if (confirmedTransactions && confirmedTransactions.length > 0) {
|
|
const foundConfirmedTxByNonce = confirmedTransactions.find(
|
|
(el) => el.txParams?.nonce === externalTxNonce,
|
|
);
|
|
if (foundConfirmedTxByNonce) {
|
|
throw ethErrors.rpc.invalidParams(
|
|
'External transaction nonce should not be in confirmed txs',
|
|
);
|
|
}
|
|
}
|
|
};
|
|
|
|
/**
|
|
* Returns a list of final states
|
|
*
|
|
* @returns {string[]} the states that can be considered final states
|
|
*/
|
|
export function getFinalStates() {
|
|
return [
|
|
TransactionStatus.rejected, // the user has responded no!
|
|
TransactionStatus.confirmed, // the tx has been included in a block.
|
|
TransactionStatus.failed, // the tx failed for some reason, included on tx data.
|
|
TransactionStatus.dropped, // the tx nonce was already used
|
|
];
|
|
}
|
|
|
|
/**
|
|
* Normalizes tx receipt gas used to be a hexadecimal string.
|
|
* It seems that sometimes the numerical values being returned from
|
|
* this.query.getTransactionReceipt are BN instances and not strings.
|
|
*
|
|
* @param {string or BN instance} gasUsed
|
|
* @returns normalized gas used as hexadecimal string
|
|
*/
|
|
export function normalizeTxReceiptGasUsed(gasUsed) {
|
|
return typeof gasUsed === 'string' ? gasUsed : gasUsed.toString(16);
|
|
}
|