1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-10-22 19:26:13 +02:00
metamask-extension/ui/app
Thomas Huang 4354e9eb93
Call getMethodDataAsync when knownMethodData[fourBytePrefix] object is empty (#8836)
Fixes #8835

In cases where the registry failed to load, and the sig is set to `{}` on this line: e85b162651/ui/app/helpers/utils/transactions.util.js (L78) this proceeds to set the method prefix to `{}` in knownMethodData.

Additionally check if the method prefix object is empty to proceed call getMethodDataAsync again.

I could only reproduce by intentionally failing the method registry lookup and found this solution. I could not find an instance where the registry consistently failed to lookup even on slow/throttled/high latency networks.
2020-06-22 21:30:45 -07:00
..
components fix overflowing contract names and origins (#8823) 2020-06-17 11:38:15 -05:00
contexts Implement asset page (#8696) 2020-06-01 14:54:32 -03:00
css Fix connect hardware styling (#8680) 2020-05-28 11:47:48 -07:00
ducks Consolidate connected account alerts (#8802) 2020-06-15 12:08:53 -07:00
helpers Consolidate connected account alerts (#8802) 2020-06-15 12:08:53 -07:00
hooks fix overflowing contract names and origins (#8823) 2020-06-17 11:38:15 -05:00
pages Update connected status popover content (#8834) 2020-06-21 14:00:06 -07:00
selectors delete targetDomainMetadata selector 2020-06-16 11:34:08 -07:00
store Call getMethodDataAsync when knownMethodData[fourBytePrefix] object is empty (#8836) 2020-06-22 21:30:45 -07:00