mirror of
https://github.com/kremalicious/metamask-extension.git
synced 2024-12-23 09:52:26 +01:00
5560b7c3e5
* Update build system lockdown parameter * Add @reduxjs/toolkit patch * Fix Mozilla lint syntax error * Standardize a thing * Remove redundant check for globalThis
92 lines
3.4 KiB
JavaScript
92 lines
3.4 KiB
JavaScript
// Make all "object" and "function" own properties of globalThis
|
|
// non-configurable and non-writable, when possible.
|
|
// We call a property that is non-configurable and non-writable,
|
|
// "non-modifiable".
|
|
try {
|
|
/**
|
|
* `lockdown` only hardens the properties enumerated by the
|
|
* universalPropertyNames constant specified in 'ses/src/whitelist'. This
|
|
* function makes all function and object properties on the start compartment
|
|
* global non-configurable and non-writable, unless they are already
|
|
* non-configurable.
|
|
*
|
|
* It is critical that this function runs at the right time during
|
|
* initialization, which should always be immediately after `lockdown` has been
|
|
* called. At the time of writing, the modifications this function makes to the
|
|
* runtime environment appear to be non-breaking, but that could change with
|
|
* the addition of dependencies, or the order of our scripts in our HTML files.
|
|
* Exercise caution.
|
|
*
|
|
* See inline comments for implementation details.
|
|
*
|
|
* We write this function in IIFE format to avoid polluting global scope.
|
|
*/
|
|
(function protectIntrinsics() {
|
|
const namedIntrinsics = Reflect.ownKeys(new Compartment().globalThis);
|
|
|
|
// These named intrinsics are not automatically hardened by `lockdown`
|
|
const shouldHardenManually = new Set(['eval', 'Function']);
|
|
|
|
const globalProperties = new Set([
|
|
// universalPropertyNames is a constant added by lockdown to global scope
|
|
// at the time of writing, it is initialized in 'ses/src/whitelist'.
|
|
// These properties tend to be non-enumerable.
|
|
...namedIntrinsics,
|
|
|
|
// TODO: Also include the named platform globals
|
|
// This grabs every enumerable property on globalThis.
|
|
// ...Object.keys(globalThis),
|
|
]);
|
|
|
|
globalProperties.forEach((propertyName) => {
|
|
const descriptor = Reflect.getOwnPropertyDescriptor(
|
|
globalThis,
|
|
propertyName,
|
|
);
|
|
|
|
if (descriptor) {
|
|
if (descriptor.configurable) {
|
|
// If the property on globalThis is configurable, make it
|
|
// non-configurable. If it has no accessor properties, also make it
|
|
// non-writable.
|
|
if (hasAccessor(descriptor)) {
|
|
Object.defineProperty(globalThis, propertyName, {
|
|
configurable: false,
|
|
});
|
|
} else {
|
|
Object.defineProperty(globalThis, propertyName, {
|
|
configurable: false,
|
|
writable: false,
|
|
});
|
|
}
|
|
}
|
|
|
|
if (shouldHardenManually.has(propertyName)) {
|
|
harden(globalThis[propertyName]);
|
|
}
|
|
}
|
|
});
|
|
|
|
/**
|
|
* Checks whether the given propertyName descriptor has any accessors, i.e. the
|
|
* properties `get` or `set`.
|
|
*
|
|
* We want to make globals non-writable, and we can't set the `writable`
|
|
* property and accessor properties at the same time.
|
|
*
|
|
* @param {Object} descriptor - The propertyName descriptor to check.
|
|
* @returns {boolean} Whether the propertyName descriptor has any accessors.
|
|
*/
|
|
function hasAccessor(descriptor) {
|
|
return 'set' in descriptor || 'get' in descriptor;
|
|
}
|
|
})();
|
|
} catch (error) {
|
|
console.error('Protecting intrinsics failed:', error);
|
|
if (globalThis.sentry && globalThis.sentry.captureException) {
|
|
globalThis.sentry.captureException(
|
|
new Error(`Protecting intrinsics failed: ${error.message}`),
|
|
);
|
|
}
|
|
}
|