mirror of
https://github.com/kremalicious/metamask-extension.git
synced 2024-11-29 15:50:28 +01:00
31d5c1cf22
* Version v10.18.4 * Fix default currency symbol for `wallet_addEthereumChain` + improve warnings for data that doesn't match our validation expectations (#15201) * set more appropriate default for ticker symbol when wallet_addEthereumChain is called * throw error to dapp when site suggests network with same chainId but different ticker symbol from already added network, instead of showing error and disabled notification to user * Fix Provider Tracking Metrics (#15082) * fix filetype audit (#15334) * Remove decentralized 4byte function signature registry since it contains incorrect signatures and we can't algorithmically check for best option when 4byte.directory is down (#15300) * remove decentralized 4byte function signature registry since it is griefed and we can't algorithmically check for best option when 4byte is down * add migration * remove nock of on chain registry call in getMethodDataAsync test * remove audit exclusion (#15346) * Updates `eth-lattice-keyring` to v0.10.0 (#15261) This is mainly associated with an update in GridPlus SDK and enables better strategies for fetching calldata decoder data. `eth-lattice-keyring` changes: GridPlus/eth-lattice-keyring@v0.7.3...v0.10.0 `gridplus-sdk` changes (which includes a codebase rewrite): GridPlus/gridplus-sdk@v1.2.3...v2.2.2 * Fix 'block link explorer on custom networks' (#13870) * Created a logic for the 'Add a block explorer URL' Removed unused message Message logic rollback Modified history push operation WIP: Pushing before rebasing Applied requested changes Removed unintenionally added code * Lint fix * Metrics fixed * Stop injecting provider on docs.google.com (#15459) * Fix setting of gasPrice when on non-eip 1559 networks (#15628) * Fix setting of gasPrice when on non-eip 1559 networks * Fix unit tests * Fix logic * Update ui/ducks/send/send.test.js Co-authored-by: Mark Stacey <markjstacey@gmail.com> Co-authored-by: Mark Stacey <markjstacey@gmail.com> * [GridPlus] Bumps `eth-lattice-keyring` to v0.11.0 (#15490) * [GridPlus] Bumps `gridplus-sdk` to v2.2.4 (#15561) * remove exclusions for mismatched object jsdoc type casing (#15351) * Improve `tokenId` parsing and clean up `useAssetDetails` hook (#15304) * Fix state creation in setupSentryGetStateGlobal (#15635) * filter breadcrumbs for improved clarity while debugging sentry errors (#15639) * Update v10.18.4 changelog (#15645) * Auto generated changelog * Update 10.18.4 changelog * Run lavamoat:auto * Call metrics event for wallet type selection at the right time (#15591) * Fix Sentry in LavaMoat contexts (#15672) Our Sentry setup relies upon application state, but it wasn't able to access it in LavaMoat builds because it's running in a separate Compartment. A patch has been introduced to the LavaMoat runtime to allow the root Compartment to mutate the `rootGlobals` object, which is accessible from outside the compartment as well. This lets us expose application state to our Sentry integration. * Fix Sentry deduplication of events that were never sent (#15677) The Sentry `Dedupe` integration has been filtering out our events, even when they were never sent due to our `beforeSend` handler. It was wrongly identifying them as duplicates because it has no knowledge of `beforeSend` or whether they were actually sent or not. To resolve this, the filtering we were doing in `beforeSend` has been moved to a Sentry integration. This integration is installed ahead of the `Dedupe` integration, so `Dedupe` should never find out about any events that we filter out, and thus will never consider them as sent when they were not. * Replace `lavamoat-runtime.js` patch (#15682) A patch made in #15672 was found to be unnecessary. Instead of setting a `rootGlobals` object upon construction of the root compartment, we are now creating a `sentryHooks` object in the initial top-level compartment. I hadn't realized at the time that the root compartment would inherit all properties of the initial compartment `globalThis`. This accomplishes the same goals as #15672 except without needing a patch. * Update v10.18.4 changelog * Fix lint issues * Update yarn.lock * Update `depcheck` to latest version (#15690) `depcheck` has been updated to the latest version. This version pins `@babel/parser` to v7.16.4 because of unresolved bugs in v7.16.5 that result in `depcheck` failing to parse TypeScript files correctly. We had a Yarn resolution in place to ensure `@babel/parser@7.16.4` was being used already. That resolution is no longer needed so it has been removed. This should resove the issue the dev team has been seeing lately where `yarn` and `yarn-deduplicate` disagree about the state the lockfile should be in. * Update yarn.lock * Update LavaMoat policy * deduplicate * Update LavaMoat build policy Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com> Co-authored-by: Alex Donesky <adonesky@gmail.com> Co-authored-by: Brad Decker <bhdecker84@gmail.com> Co-authored-by: Alex Miller <asmiller1989@gmail.com> Co-authored-by: Filip Sekulic <filip.sekulic@consensys.net> Co-authored-by: Erik Marks <25517051+rekmarks@users.noreply.github.com> Co-authored-by: Dan J Miller <danjm.com@gmail.com> Co-authored-by: Mark Stacey <markjstacey@gmail.com> Co-authored-by: seaona <54408225+seaona@users.noreply.github.com> Co-authored-by: seaona <mariona@gmx.es> Co-authored-by: PeterYinusa <peter.yinusa@consensys.net>
269 lines
9.5 KiB
JavaScript
269 lines
9.5 KiB
JavaScript
import { isHexString } from 'ethereumjs-util';
|
|
import { ethers } from 'ethers';
|
|
import { abiERC721, abiERC20, abiERC1155 } from '@metamask/metamask-eth-abis';
|
|
import log from 'loglevel';
|
|
import { TOKEN_STANDARDS } from '../../ui/helpers/constants/common';
|
|
import { ASSET_TYPES, TRANSACTION_TYPES } from '../constants/transaction';
|
|
import { readAddressAsContract } from './contract-utils';
|
|
import { isEqualCaseInsensitive } from './string-utils';
|
|
|
|
/**
|
|
* @typedef { 'transfer' | 'approve' | 'setapprovalforall' | 'transferfrom' | 'contractInteraction'| 'simpleSend' } InferrableTransactionTypes
|
|
*/
|
|
|
|
/**
|
|
* @typedef {object} InferTransactionTypeResult
|
|
* @property {InferrableTransactionTypes} type - The type of transaction
|
|
* @property {string} getCodeResponse - The contract code, in hex format if
|
|
* it exists. '0x0' or '0x' are also indicators of non-existent contract
|
|
* code
|
|
*/
|
|
|
|
/**
|
|
* @typedef EthersContractCall
|
|
* @type object
|
|
* @property {any[]} args - The args/params to the function call.
|
|
* An array-like object with numerical and string indices.
|
|
* @property {string} name - The name of the function.
|
|
* @property {string} signature - The function signature.
|
|
* @property {string} sighash - The function signature hash.
|
|
* @property {EthersBigNumber} value - The ETH value associated with the call.
|
|
* @property {FunctionFragment} functionFragment - The Ethers function fragment
|
|
* representation of the function.
|
|
*/
|
|
|
|
const erc20Interface = new ethers.utils.Interface(abiERC20);
|
|
const erc721Interface = new ethers.utils.Interface(abiERC721);
|
|
const erc1155Interface = new ethers.utils.Interface(abiERC1155);
|
|
|
|
export function transactionMatchesNetwork(transaction, chainId, networkId) {
|
|
if (typeof transaction.chainId !== 'undefined') {
|
|
return transaction.chainId === chainId;
|
|
}
|
|
return transaction.metamaskNetworkId === networkId;
|
|
}
|
|
|
|
/**
|
|
* Determines if the maxFeePerGas and maxPriorityFeePerGas fields are supplied
|
|
* and valid inputs. This will return false for non hex string inputs.
|
|
*
|
|
* @param {import("../constants/transaction").TransactionMeta} transaction -
|
|
* the transaction to check
|
|
* @returns {boolean} true if transaction uses valid EIP1559 fields
|
|
*/
|
|
export function isEIP1559Transaction(transaction) {
|
|
return (
|
|
isHexString(transaction?.txParams?.maxFeePerGas) &&
|
|
isHexString(transaction?.txParams?.maxPriorityFeePerGas)
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Determine if the maxFeePerGas and maxPriorityFeePerGas fields are not
|
|
* supplied and that the gasPrice field is valid if it is provided. This will
|
|
* return false if gasPrice is a non hex string.
|
|
*
|
|
* @param {import("../constants/transaction").TransactionMeta} transaction -
|
|
* the transaction to check
|
|
* @returns {boolean} true if transaction uses valid Legacy fields OR lacks
|
|
* EIP1559 fields
|
|
*/
|
|
export function isLegacyTransaction(transaction) {
|
|
return (
|
|
typeof transaction.txParams.maxFeePerGas === 'undefined' &&
|
|
typeof transaction.txParams.maxPriorityFeePerGas === 'undefined' &&
|
|
(typeof transaction.txParams.gasPrice === 'undefined' ||
|
|
isHexString(transaction.txParams.gasPrice))
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Determine if a transactions gas fees in txParams match those in its dappSuggestedGasFees property
|
|
*
|
|
* @param {import("../constants/transaction").TransactionMeta} transaction -
|
|
* the transaction to check
|
|
* @returns {boolean} true if both the txParams and dappSuggestedGasFees are objects with truthy gas fee properties,
|
|
* and those properties are strictly equal
|
|
*/
|
|
export function txParamsAreDappSuggested(transaction) {
|
|
const { gasPrice, maxPriorityFeePerGas, maxFeePerGas } =
|
|
transaction?.txParams || {};
|
|
return (
|
|
(gasPrice && gasPrice === transaction?.dappSuggestedGasFees?.gasPrice) ||
|
|
(maxPriorityFeePerGas &&
|
|
maxFeePerGas &&
|
|
transaction?.dappSuggestedGasFees?.maxPriorityFeePerGas ===
|
|
maxPriorityFeePerGas &&
|
|
transaction?.dappSuggestedGasFees?.maxFeePerGas === maxFeePerGas)
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Attempts to decode transaction data using ABIs for three different token standards: ERC20, ERC721, ERC1155.
|
|
* The data will decode correctly if the transaction is an interaction with a contract that matches one of these
|
|
* contract standards
|
|
*
|
|
* @param data - encoded transaction data
|
|
* @returns {EthersContractCall | undefined}
|
|
*/
|
|
export function parseStandardTokenTransactionData(data) {
|
|
try {
|
|
return erc20Interface.parseTransaction({ data });
|
|
} catch {
|
|
// ignore and next try to parse with erc721 ABI
|
|
}
|
|
|
|
try {
|
|
return erc721Interface.parseTransaction({ data });
|
|
} catch {
|
|
// ignore and next try to parse with erc1155 ABI
|
|
}
|
|
|
|
try {
|
|
return erc1155Interface.parseTransaction({ data });
|
|
} catch {
|
|
// ignore and return undefined
|
|
}
|
|
|
|
return undefined;
|
|
}
|
|
|
|
/**
|
|
* Determines the type of the transaction by analyzing the txParams.
|
|
* This method will return one of the types defined in shared/constants/transactions
|
|
* It will never return TRANSACTION_TYPE_CANCEL or TRANSACTION_TYPE_RETRY as these
|
|
* represent specific events that we control from the extension and are added manually
|
|
* at transaction creation.
|
|
*
|
|
* @param {object} txParams - Parameters for the transaction
|
|
* @param {EthQuery} query - EthQuery instance
|
|
* @returns {InferTransactionTypeResult}
|
|
*/
|
|
export async function determineTransactionType(txParams, query) {
|
|
const { data, to } = txParams;
|
|
let name;
|
|
try {
|
|
({ name } = data && parseStandardTokenTransactionData(data));
|
|
} catch (error) {
|
|
log.debug('Failed to parse transaction data.', error, data);
|
|
}
|
|
|
|
let result;
|
|
let contractCode;
|
|
|
|
if (data && !to) {
|
|
result = TRANSACTION_TYPES.DEPLOY_CONTRACT;
|
|
} else {
|
|
const {
|
|
contractCode: resultCode,
|
|
isContractAddress,
|
|
} = await readAddressAsContract(query, to);
|
|
|
|
contractCode = resultCode;
|
|
|
|
if (isContractAddress) {
|
|
const tokenMethodName = [
|
|
TRANSACTION_TYPES.TOKEN_METHOD_APPROVE,
|
|
TRANSACTION_TYPES.TOKEN_METHOD_SET_APPROVAL_FOR_ALL,
|
|
TRANSACTION_TYPES.TOKEN_METHOD_TRANSFER,
|
|
TRANSACTION_TYPES.TOKEN_METHOD_TRANSFER_FROM,
|
|
TRANSACTION_TYPES.TOKEN_METHOD_SAFE_TRANSFER_FROM,
|
|
].find((methodName) => isEqualCaseInsensitive(methodName, name));
|
|
|
|
result =
|
|
data && tokenMethodName
|
|
? tokenMethodName
|
|
: TRANSACTION_TYPES.CONTRACT_INTERACTION;
|
|
} else {
|
|
result = TRANSACTION_TYPES.SIMPLE_SEND;
|
|
}
|
|
}
|
|
|
|
return { type: result, getCodeResponse: contractCode };
|
|
}
|
|
|
|
const INFERRABLE_TRANSACTION_TYPES = [
|
|
TRANSACTION_TYPES.TOKEN_METHOD_APPROVE,
|
|
TRANSACTION_TYPES.TOKEN_METHOD_SET_APPROVAL_FOR_ALL,
|
|
TRANSACTION_TYPES.TOKEN_METHOD_TRANSFER,
|
|
TRANSACTION_TYPES.TOKEN_METHOD_TRANSFER_FROM,
|
|
TRANSACTION_TYPES.CONTRACT_INTERACTION,
|
|
TRANSACTION_TYPES.SIMPLE_SEND,
|
|
];
|
|
|
|
/**
|
|
* Given a transaction meta object, determine the asset type that the
|
|
* transaction is dealing with, as well as the standard for the token if it
|
|
* is a token transaction.
|
|
*
|
|
* @param {import('../constants/transaction').TransactionMeta} txMeta -
|
|
* transaction meta object
|
|
* @param {EthQuery} query - EthQuery instance
|
|
* @param {Function} getTokenStandardAndDetails - function to get token
|
|
* standards and details.
|
|
* @returns {{ assetType: string, tokenStandard: string}}
|
|
*/
|
|
export async function determineTransactionAssetType(
|
|
txMeta,
|
|
query,
|
|
getTokenStandardAndDetails,
|
|
) {
|
|
// If the transaction type is already one of the inferrable types, then we do
|
|
// not need to re-establish the type.
|
|
let inferrableType = txMeta.type;
|
|
if (INFERRABLE_TRANSACTION_TYPES.includes(txMeta.type) === false) {
|
|
// Because we will deal with all types of transactions (including swaps)
|
|
// we want to get an inferrable type of transaction that isn't special cased
|
|
// that way we can narrow the number of logic gates required.
|
|
const result = await determineTransactionType(txMeta.txParams, query);
|
|
inferrableType = result.type;
|
|
}
|
|
|
|
// If the inferred type of the transaction is one of those that are part of
|
|
// the token contract standards, we can use the getTokenStandardAndDetails
|
|
// method to get the asset type.
|
|
const isTokenMethod = [
|
|
TRANSACTION_TYPES.TOKEN_METHOD_APPROVE,
|
|
TRANSACTION_TYPES.TOKEN_METHOD_SET_APPROVAL_FOR_ALL,
|
|
TRANSACTION_TYPES.TOKEN_METHOD_TRANSFER,
|
|
TRANSACTION_TYPES.TOKEN_METHOD_TRANSFER_FROM,
|
|
].find((methodName) => methodName === inferrableType);
|
|
|
|
if (
|
|
isTokenMethod ||
|
|
// We can also check any contract interaction type to see if the to address
|
|
// is a token contract. If it isn't, then the method will throw and we can
|
|
// fall through to the other checks.
|
|
inferrableType === TRANSACTION_TYPES.CONTRACT_INTERACTION
|
|
) {
|
|
try {
|
|
// We don't need a balance check, so the second parameter to
|
|
// getTokenStandardAndDetails is omitted.
|
|
const details = await getTokenStandardAndDetails(txMeta.txParams.to);
|
|
if (details.standard) {
|
|
return {
|
|
assetType:
|
|
details.standard === TOKEN_STANDARDS.ERC20
|
|
? ASSET_TYPES.TOKEN
|
|
: ASSET_TYPES.COLLECTIBLE,
|
|
tokenStandard: details.standard,
|
|
};
|
|
}
|
|
} catch {
|
|
// noop, We expect errors here but we don't need to report them or do
|
|
// anything in response.
|
|
}
|
|
}
|
|
|
|
// If the transaction is interacting with a contract but isn't a token method
|
|
// we use the 'UNKNOWN' value to show that it isn't a transaction sending any
|
|
// particular asset.
|
|
if (inferrableType === TRANSACTION_TYPES.CONTRACT_INTERACTION) {
|
|
return {
|
|
assetType: ASSET_TYPES.UNKNOWN,
|
|
tokenStandard: TOKEN_STANDARDS.NONE,
|
|
};
|
|
}
|
|
return { assetType: ASSET_TYPES.NATIVE, tokenStandard: TOKEN_STANDARDS.NONE };
|
|
}
|