mirror of
https://github.com/kremalicious/metamask-extension.git
synced 2024-12-12 04:37:13 +01:00
31d5c1cf22
* Version v10.18.4 * Fix default currency symbol for `wallet_addEthereumChain` + improve warnings for data that doesn't match our validation expectations (#15201) * set more appropriate default for ticker symbol when wallet_addEthereumChain is called * throw error to dapp when site suggests network with same chainId but different ticker symbol from already added network, instead of showing error and disabled notification to user * Fix Provider Tracking Metrics (#15082) * fix filetype audit (#15334) * Remove decentralized 4byte function signature registry since it contains incorrect signatures and we can't algorithmically check for best option when 4byte.directory is down (#15300) * remove decentralized 4byte function signature registry since it is griefed and we can't algorithmically check for best option when 4byte is down * add migration * remove nock of on chain registry call in getMethodDataAsync test * remove audit exclusion (#15346) * Updates `eth-lattice-keyring` to v0.10.0 (#15261) This is mainly associated with an update in GridPlus SDK and enables better strategies for fetching calldata decoder data. `eth-lattice-keyring` changes: GridPlus/eth-lattice-keyring@v0.7.3...v0.10.0 `gridplus-sdk` changes (which includes a codebase rewrite): GridPlus/gridplus-sdk@v1.2.3...v2.2.2 * Fix 'block link explorer on custom networks' (#13870) * Created a logic for the 'Add a block explorer URL' Removed unused message Message logic rollback Modified history push operation WIP: Pushing before rebasing Applied requested changes Removed unintenionally added code * Lint fix * Metrics fixed * Stop injecting provider on docs.google.com (#15459) * Fix setting of gasPrice when on non-eip 1559 networks (#15628) * Fix setting of gasPrice when on non-eip 1559 networks * Fix unit tests * Fix logic * Update ui/ducks/send/send.test.js Co-authored-by: Mark Stacey <markjstacey@gmail.com> Co-authored-by: Mark Stacey <markjstacey@gmail.com> * [GridPlus] Bumps `eth-lattice-keyring` to v0.11.0 (#15490) * [GridPlus] Bumps `gridplus-sdk` to v2.2.4 (#15561) * remove exclusions for mismatched object jsdoc type casing (#15351) * Improve `tokenId` parsing and clean up `useAssetDetails` hook (#15304) * Fix state creation in setupSentryGetStateGlobal (#15635) * filter breadcrumbs for improved clarity while debugging sentry errors (#15639) * Update v10.18.4 changelog (#15645) * Auto generated changelog * Update 10.18.4 changelog * Run lavamoat:auto * Call metrics event for wallet type selection at the right time (#15591) * Fix Sentry in LavaMoat contexts (#15672) Our Sentry setup relies upon application state, but it wasn't able to access it in LavaMoat builds because it's running in a separate Compartment. A patch has been introduced to the LavaMoat runtime to allow the root Compartment to mutate the `rootGlobals` object, which is accessible from outside the compartment as well. This lets us expose application state to our Sentry integration. * Fix Sentry deduplication of events that were never sent (#15677) The Sentry `Dedupe` integration has been filtering out our events, even when they were never sent due to our `beforeSend` handler. It was wrongly identifying them as duplicates because it has no knowledge of `beforeSend` or whether they were actually sent or not. To resolve this, the filtering we were doing in `beforeSend` has been moved to a Sentry integration. This integration is installed ahead of the `Dedupe` integration, so `Dedupe` should never find out about any events that we filter out, and thus will never consider them as sent when they were not. * Replace `lavamoat-runtime.js` patch (#15682) A patch made in #15672 was found to be unnecessary. Instead of setting a `rootGlobals` object upon construction of the root compartment, we are now creating a `sentryHooks` object in the initial top-level compartment. I hadn't realized at the time that the root compartment would inherit all properties of the initial compartment `globalThis`. This accomplishes the same goals as #15672 except without needing a patch. * Update v10.18.4 changelog * Fix lint issues * Update yarn.lock * Update `depcheck` to latest version (#15690) `depcheck` has been updated to the latest version. This version pins `@babel/parser` to v7.16.4 because of unresolved bugs in v7.16.5 that result in `depcheck` failing to parse TypeScript files correctly. We had a Yarn resolution in place to ensure `@babel/parser@7.16.4` was being used already. That resolution is no longer needed so it has been removed. This should resove the issue the dev team has been seeing lately where `yarn` and `yarn-deduplicate` disagree about the state the lockfile should be in. * Update yarn.lock * Update LavaMoat policy * deduplicate * Update LavaMoat build policy Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com> Co-authored-by: Alex Donesky <adonesky@gmail.com> Co-authored-by: Brad Decker <bhdecker84@gmail.com> Co-authored-by: Alex Miller <asmiller1989@gmail.com> Co-authored-by: Filip Sekulic <filip.sekulic@consensys.net> Co-authored-by: Erik Marks <25517051+rekmarks@users.noreply.github.com> Co-authored-by: Dan J Miller <danjm.com@gmail.com> Co-authored-by: Mark Stacey <markjstacey@gmail.com> Co-authored-by: seaona <54408225+seaona@users.noreply.github.com> Co-authored-by: seaona <mariona@gmx.es> Co-authored-by: PeterYinusa <peter.yinusa@consensys.net>
285 lines
8.7 KiB
JavaScript
285 lines
8.7 KiB
JavaScript
import EventEmitter from 'safe-event-emitter';
|
|
import log from 'loglevel';
|
|
import EthQuery from 'ethjs-query';
|
|
import { TRANSACTION_STATUSES } from '../../../../shared/constants/transaction';
|
|
import { ERROR_SUBMITTING } from './tx-state-manager';
|
|
|
|
/**
|
|
* Event emitter utility class for tracking the transactions as they
|
|
* go from a pending state to a confirmed (mined in a block) state.
|
|
*
|
|
* As well as continues broadcast while in the pending state.
|
|
*/
|
|
export default class PendingTransactionTracker extends EventEmitter {
|
|
/**
|
|
* We wait this many blocks before emitting a 'tx:dropped' event
|
|
*
|
|
* This is because we could be talking to a node that is out of sync.
|
|
*
|
|
* @type {number}
|
|
*/
|
|
DROPPED_BUFFER_COUNT = 3;
|
|
|
|
/**
|
|
* A map of transaction hashes to the number of blocks we've seen
|
|
* since first considering it dropped
|
|
*
|
|
* @type {Map<string, number>}
|
|
*/
|
|
droppedBlocksBufferByHash = new Map();
|
|
|
|
/**
|
|
* @param {object} config - Configuration.
|
|
* @param {Function} config.approveTransaction - Approves a transaction.
|
|
* @param {Function} config.confirmTransaction - Set a transaction as confirmed.
|
|
* @param {Function} config.getCompletedTransactions - Returns completed transactions.
|
|
* @param {Function} config.getPendingTransactions - Returns an array of pending transactions,
|
|
* @param {object} config.nonceTracker - see nonce tracker
|
|
* @param {object} config.provider - A network provider.
|
|
* @param {object} config.query - An EthQuery instance.
|
|
* @param {Function} config.publishTransaction - Publishes a raw transaction,
|
|
*/
|
|
constructor(config) {
|
|
super();
|
|
this.query = config.query || new EthQuery(config.provider);
|
|
this.nonceTracker = config.nonceTracker;
|
|
this.getPendingTransactions = config.getPendingTransactions;
|
|
this.getCompletedTransactions = config.getCompletedTransactions;
|
|
this.publishTransaction = config.publishTransaction;
|
|
this.approveTransaction = config.approveTransaction;
|
|
this.confirmTransaction = config.confirmTransaction;
|
|
}
|
|
|
|
/**
|
|
* checks the network for signed txs and releases the nonce global lock if it is
|
|
*/
|
|
async updatePendingTxs() {
|
|
// in order to keep the nonceTracker accurate we block it while updating pending transactions
|
|
const nonceGlobalLock = await this.nonceTracker.getGlobalLock();
|
|
try {
|
|
const pendingTxs = this.getPendingTransactions();
|
|
await Promise.all(
|
|
pendingTxs.map((txMeta) => this._checkPendingTx(txMeta)),
|
|
);
|
|
} catch (err) {
|
|
log.error(
|
|
'PendingTransactionTracker - Error updating pending transactions',
|
|
);
|
|
log.error(err);
|
|
}
|
|
nonceGlobalLock.releaseLock();
|
|
}
|
|
|
|
/**
|
|
* Resubmits each pending transaction
|
|
*
|
|
* @param {string} blockNumber - the latest block number in hex
|
|
* @fires tx:warning
|
|
* @returns {Promise<void>}
|
|
*/
|
|
async resubmitPendingTxs(blockNumber) {
|
|
const pending = this.getPendingTransactions();
|
|
if (!pending.length) {
|
|
return;
|
|
}
|
|
for (const txMeta of pending) {
|
|
try {
|
|
await this._resubmitTx(txMeta, blockNumber);
|
|
} catch (err) {
|
|
const errorMessage =
|
|
err.value?.message?.toLowerCase() || err.message.toLowerCase();
|
|
const isKnownTx =
|
|
// geth
|
|
errorMessage.includes('replacement transaction underpriced') ||
|
|
errorMessage.includes('known transaction') ||
|
|
// parity
|
|
errorMessage.includes('gas price too low to replace') ||
|
|
errorMessage.includes(
|
|
'transaction with the same hash was already imported',
|
|
) ||
|
|
// other
|
|
errorMessage.includes('gateway timeout') ||
|
|
errorMessage.includes('nonce too low');
|
|
// ignore resubmit warnings, return early
|
|
if (isKnownTx) {
|
|
return;
|
|
}
|
|
// encountered real error - transition to error state
|
|
txMeta.warning = {
|
|
error: errorMessage,
|
|
message: ERROR_SUBMITTING,
|
|
};
|
|
this.emit('tx:warning', txMeta, err);
|
|
}
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Attempts to resubmit the given transaction with exponential backoff
|
|
*
|
|
* Will only attempt to retry the given tx every {@code 2**(txMeta.retryCount)} blocks.
|
|
*
|
|
* @param {object} txMeta - the transaction metadata
|
|
* @param {string} latestBlockNumber - the latest block number in hex
|
|
* @returns {Promise<string|undefined>} the tx hash if retried
|
|
* @fires tx:block-update
|
|
* @fires tx:retry
|
|
* @private
|
|
*/
|
|
async _resubmitTx(txMeta, latestBlockNumber) {
|
|
if (!txMeta.firstRetryBlockNumber) {
|
|
this.emit('tx:block-update', txMeta, latestBlockNumber);
|
|
}
|
|
|
|
const firstRetryBlockNumber =
|
|
txMeta.firstRetryBlockNumber || latestBlockNumber;
|
|
const txBlockDistance =
|
|
Number.parseInt(latestBlockNumber, 16) -
|
|
Number.parseInt(firstRetryBlockNumber, 16);
|
|
|
|
const retryCount = txMeta.retryCount || 0;
|
|
|
|
// Exponential backoff to limit retries at publishing (capped at ~15 minutes between retries)
|
|
if (txBlockDistance < Math.min(50, Math.pow(2, retryCount))) {
|
|
return undefined;
|
|
}
|
|
|
|
// Only auto-submit already-signed txs:
|
|
if (!('rawTx' in txMeta)) {
|
|
return this.approveTransaction(txMeta.id);
|
|
}
|
|
|
|
const { rawTx } = txMeta;
|
|
const txHash = await this.publishTransaction(rawTx);
|
|
|
|
// Increment successful tries:
|
|
this.emit('tx:retry', txMeta);
|
|
return txHash;
|
|
}
|
|
|
|
/**
|
|
* Query the network to see if the given {@code txMeta} has been included in a block
|
|
*
|
|
* @param {object} txMeta - the transaction metadata
|
|
* @returns {Promise<void>}
|
|
* @fires tx:confirmed
|
|
* @fires tx:dropped
|
|
* @fires tx:failed
|
|
* @fires tx:warning
|
|
* @private
|
|
*/
|
|
|
|
async _checkPendingTx(txMeta) {
|
|
const txHash = txMeta.hash;
|
|
const txId = txMeta.id;
|
|
|
|
// Only check submitted txs
|
|
if (txMeta.status !== TRANSACTION_STATUSES.SUBMITTED) {
|
|
return;
|
|
}
|
|
|
|
// extra check in case there was an uncaught error during the
|
|
// signature and submission process
|
|
if (!txHash) {
|
|
const noTxHashErr = new Error(
|
|
'We had an error while submitting this transaction, please try again.',
|
|
);
|
|
noTxHashErr.name = 'NoTxHashError';
|
|
this.emit('tx:failed', txId, noTxHashErr);
|
|
|
|
return;
|
|
}
|
|
|
|
if (await this._checkIfNonceIsTaken(txMeta)) {
|
|
this.emit('tx:dropped', txId);
|
|
return;
|
|
}
|
|
|
|
try {
|
|
const transactionReceipt = await this.query.getTransactionReceipt(txHash);
|
|
if (transactionReceipt?.blockNumber) {
|
|
const {
|
|
baseFeePerGas,
|
|
timestamp: blockTimestamp,
|
|
} = await this.query.getBlockByHash(
|
|
transactionReceipt?.blockHash,
|
|
false,
|
|
);
|
|
|
|
this.emit(
|
|
'tx:confirmed',
|
|
txId,
|
|
transactionReceipt,
|
|
baseFeePerGas,
|
|
blockTimestamp,
|
|
);
|
|
return;
|
|
}
|
|
} catch (err) {
|
|
txMeta.warning = {
|
|
error: err.message,
|
|
message: 'There was a problem loading this transaction.',
|
|
};
|
|
this.emit('tx:warning', txMeta, err);
|
|
return;
|
|
}
|
|
|
|
if (await this._checkIfTxWasDropped(txMeta)) {
|
|
this.emit('tx:dropped', txId);
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Checks whether the nonce in the given {@code txMeta} is behind the network nonce
|
|
*
|
|
* @param {object} txMeta - the transaction metadata
|
|
* @returns {Promise<boolean>}
|
|
* @private
|
|
*/
|
|
async _checkIfTxWasDropped(txMeta) {
|
|
const {
|
|
hash: txHash,
|
|
txParams: { nonce, from },
|
|
} = txMeta;
|
|
const networkNextNonce = await this.query.getTransactionCount(from);
|
|
|
|
if (parseInt(nonce, 16) >= networkNextNonce.toNumber()) {
|
|
return false;
|
|
}
|
|
|
|
if (!this.droppedBlocksBufferByHash.has(txHash)) {
|
|
this.droppedBlocksBufferByHash.set(txHash, 0);
|
|
}
|
|
|
|
const currentBlockBuffer = this.droppedBlocksBufferByHash.get(txHash);
|
|
|
|
if (currentBlockBuffer < this.DROPPED_BUFFER_COUNT) {
|
|
this.droppedBlocksBufferByHash.set(txHash, currentBlockBuffer + 1);
|
|
return false;
|
|
}
|
|
|
|
this.droppedBlocksBufferByHash.delete(txHash);
|
|
return true;
|
|
}
|
|
|
|
/**
|
|
* Checks whether the nonce in the given {@code txMeta} is correct against the local set of transactions
|
|
*
|
|
* @param {object} txMeta - the transaction metadata
|
|
* @returns {Promise<boolean>}
|
|
* @private
|
|
*/
|
|
async _checkIfNonceIsTaken(txMeta) {
|
|
const address = txMeta.txParams.from;
|
|
const completed = this.getCompletedTransactions(address);
|
|
return completed.some(
|
|
// This is called while the transaction is in-flight, so it is possible that the
|
|
// list of completed transactions now includes the transaction we were looking at
|
|
// and if that is the case, don't consider the transaction to have taken its own nonce
|
|
(other) =>
|
|
!(other.id === txMeta.id) &&
|
|
other.txParams.nonce === txMeta.txParams.nonce,
|
|
);
|
|
}
|
|
}
|