mirror of
https://github.com/kremalicious/metamask-extension.git
synced 2024-11-26 20:39:08 +01:00
ed3cc404f2
The `network` store of the network controller crams two types of data into one place. It roughly tracks whether we have enough information to make requests to the network and whether the network is capable of receiving requests, but it also stores the ID of the network (as obtained via `net_version`). Generally we shouldn't be using the network ID for anything, as it has been completely replaced by chain ID, which all custom RPC endpoints have been required to support for over a year now. However, as the network ID is used in various places within the extension codebase, removing it entirely would be a non-trivial effort. So, minimally, this commit splits `network` into two stores: `networkId` and `networkStatus`. But it also expands the concept of network status. Previously, the network was in one of two states: "loading" and "not-loading". But now it can be in one of four states: - `available`: The network is able to receive and respond to requests. - `unavailable`: The network is not able to receive and respond to requests for unknown reasons. - `blocked`: The network is actively blocking requests based on the user's geolocation. (This is specific to Infura.) - `unknown`: We don't know whether the network can receive and respond to requests, either because we haven't checked or we tried to check and were unsuccessful. This commit also changes how the network status is determined — specifically, how many requests are used to determine that status, when they occur, and whether they are awaited. Previously, the network controller would make 2 to 3 requests during the course of running `lookupNetwork`. * First, if it was an Infura network, it would make a request for `eth_blockNumber` to determine whether Infura was blocking requests or not, then emit an appropriate event. This operation was not awaited. * Then, regardless of the network, it would fetch the network ID via `net_version`. This operation was awaited. * Finally, regardless of the network, it would fetch the latest block via `eth_getBlockByNumber`, then use the result to determine whether the network supported EIP-1559. This operation was awaited. Now: * One fewer request is made, specifically `eth_blockNumber`, as we don't need to make an extra request to determine whether Infura is blocking requests; we can reuse `eth_getBlockByNumber`; * All requests are awaited, which makes `lookupNetwork` run fully in-band instead of partially out-of-band; and * Both requests for `net_version` and `eth_getBlockByNumber` are performed in parallel to make `lookupNetwork` run slightly faster.
424 lines
14 KiB
JavaScript
424 lines
14 KiB
JavaScript
const { strict: assert } = require('assert');
|
|
const { SMART_CONTRACTS } = require('../seeder/smart-contracts');
|
|
const { convertToHexValue, withFixtures, tinyDelayMs } = require('../helpers');
|
|
const FixtureBuilder = require('../fixture-builder');
|
|
|
|
describe('Send ETH from inside MetaMask using default gas', function () {
|
|
const ganacheOptions = {
|
|
accounts: [
|
|
{
|
|
secretKey:
|
|
'0x7C9529A67102755B7E6102D6D950AC5D5863C98713805CEC576B945B15B71EAC',
|
|
balance: convertToHexValue(25000000000000000000),
|
|
},
|
|
],
|
|
};
|
|
it('finds the transaction in the transactions list', async function () {
|
|
await withFixtures(
|
|
{
|
|
fixtures: new FixtureBuilder().build(),
|
|
ganacheOptions,
|
|
title: this.test.title,
|
|
},
|
|
async ({ driver }) => {
|
|
await driver.navigate();
|
|
await driver.fill('#password', 'correct horse battery staple');
|
|
await driver.press('#password', driver.Key.ENTER);
|
|
|
|
await driver.clickElement('[data-testid="eth-overview-send"]');
|
|
|
|
await driver.fill(
|
|
'input[placeholder="Search, public address (0x), or ENS"]',
|
|
'0x2f318C334780961FB129D2a6c30D0763d9a5C970',
|
|
);
|
|
|
|
const inputAmount = await driver.findElement('.unit-input__input');
|
|
await inputAmount.fill('1000');
|
|
|
|
const errorAmount = await driver.findElement('.send-v2__error-amount');
|
|
assert.equal(
|
|
await errorAmount.getText(),
|
|
'Insufficient funds for gas',
|
|
'send screen should render an insufficient fund for gas error message',
|
|
);
|
|
|
|
await inputAmount.press(driver.Key.BACK_SPACE);
|
|
await inputAmount.press(driver.Key.BACK_SPACE);
|
|
await inputAmount.press(driver.Key.BACK_SPACE);
|
|
|
|
await driver.assertElementNotPresent('.send-v2__error-amount');
|
|
|
|
const amountMax = await driver.findClickableElement(
|
|
'.send-v2__amount-max',
|
|
);
|
|
await amountMax.click();
|
|
|
|
let inputValue = await inputAmount.getProperty('value');
|
|
|
|
assert(Number(inputValue) > 24);
|
|
|
|
await amountMax.click();
|
|
|
|
assert.equal(await inputAmount.isEnabled(), true);
|
|
|
|
await inputAmount.fill('1');
|
|
|
|
inputValue = await inputAmount.getProperty('value');
|
|
assert.equal(inputValue, '1');
|
|
|
|
// Continue to next screen
|
|
await driver.clickElement({ text: 'Next', tag: 'button' });
|
|
|
|
await driver.clickElement({ text: 'Confirm', tag: 'button' });
|
|
|
|
await driver.clickElement('[data-testid="home__activity-tab"]');
|
|
await driver.wait(async () => {
|
|
const confirmedTxes = await driver.findElements(
|
|
'.transaction-list__completed-transactions .transaction-list-item',
|
|
);
|
|
return confirmedTxes.length === 1;
|
|
}, 10000);
|
|
|
|
await driver.waitForSelector({
|
|
css: '.transaction-list-item__primary-currency',
|
|
text: '-1 ETH',
|
|
});
|
|
},
|
|
);
|
|
});
|
|
});
|
|
|
|
describe('Send ETH non-contract address with data that matches ERC20 transfer data signature', function () {
|
|
const ganacheOptions = {
|
|
accounts: [
|
|
{
|
|
secretKey:
|
|
'0x7C9529A67102755B7E6102D6D950AC5D5863C98713805CEC576B945B15B71EAC',
|
|
balance: convertToHexValue(25000000000000000000),
|
|
},
|
|
],
|
|
};
|
|
it('renders the correct recipient on the confirmation screen', async function () {
|
|
await withFixtures(
|
|
{
|
|
fixtures: new FixtureBuilder()
|
|
.withPreferencesController({
|
|
featureFlags: {
|
|
sendHexData: true,
|
|
},
|
|
})
|
|
.build(),
|
|
ganacheOptions,
|
|
title: this.test.title,
|
|
},
|
|
async ({ driver }) => {
|
|
await driver.navigate();
|
|
await driver.fill('#password', 'correct horse battery staple');
|
|
await driver.press('#password', driver.Key.ENTER);
|
|
|
|
await driver.clickElement('[data-testid="eth-overview-send"]');
|
|
|
|
await driver.fill(
|
|
'input[placeholder="Search, public address (0x), or ENS"]',
|
|
'0xc427D562164062a23a5cFf596A4a3208e72Acd28',
|
|
);
|
|
|
|
await driver.fill(
|
|
'textarea[placeholder="Optional',
|
|
'0xa9059cbb0000000000000000000000002f318C334780961FB129D2a6c30D0763d9a5C970000000000000000000000000000000000000000000000000000000000000000a',
|
|
);
|
|
|
|
await driver.clickElement({ text: 'Next', tag: 'button' });
|
|
|
|
await driver.clickElement({ text: '0xc42...cd28' });
|
|
|
|
const recipientAddress = await driver.findElements({
|
|
text: '0xc427D562164062a23a5cFf596A4a3208e72Acd28',
|
|
});
|
|
|
|
assert.equal(recipientAddress.length, 1);
|
|
},
|
|
);
|
|
});
|
|
});
|
|
|
|
/* eslint-disable-next-line mocha/max-top-level-suites */
|
|
describe('Send ETH from inside MetaMask using advanced gas modal', function () {
|
|
const ganacheOptions = {
|
|
accounts: [
|
|
{
|
|
secretKey:
|
|
'0x7C9529A67102755B7E6102D6D950AC5D5863C98713805CEC576B945B15B71EAC',
|
|
balance: convertToHexValue(25000000000000000000),
|
|
},
|
|
],
|
|
};
|
|
it('finds the transaction in the transactions list', async function () {
|
|
await withFixtures(
|
|
{
|
|
fixtures: new FixtureBuilder().build(),
|
|
ganacheOptions,
|
|
title: this.test.title,
|
|
},
|
|
async ({ driver }) => {
|
|
await driver.navigate();
|
|
await driver.fill('#password', 'correct horse battery staple');
|
|
await driver.press('#password', driver.Key.ENTER);
|
|
|
|
await driver.clickElement('[data-testid="eth-overview-send"]');
|
|
|
|
await driver.fill(
|
|
'input[placeholder="Search, public address (0x), or ENS"]',
|
|
'0x2f318C334780961FB129D2a6c30D0763d9a5C970',
|
|
);
|
|
|
|
const inputAmount = await driver.findElement('.unit-input__input');
|
|
await inputAmount.fill('1');
|
|
|
|
const inputValue = await inputAmount.getProperty('value');
|
|
assert.equal(inputValue, '1');
|
|
|
|
// Continue to next screen
|
|
await driver.clickElement({ text: 'Next', tag: 'button' });
|
|
|
|
const transactionAmounts = await driver.findElements(
|
|
'.currency-display-component__text',
|
|
);
|
|
const transactionAmount = transactionAmounts[0];
|
|
assert.equal(await transactionAmount.getText(), '1');
|
|
|
|
await driver.clickElement({ text: 'Confirm', tag: 'button' });
|
|
|
|
await driver.wait(async () => {
|
|
const confirmedTxes = await driver.findElements(
|
|
'.transaction-list__completed-transactions .transaction-list-item',
|
|
);
|
|
return confirmedTxes.length === 1;
|
|
}, 10000);
|
|
|
|
await driver.waitForSelector({
|
|
css: '.transaction-list-item__primary-currency',
|
|
text: '-1 ETH',
|
|
});
|
|
},
|
|
);
|
|
});
|
|
});
|
|
|
|
describe('Send ETH from dapp using advanced gas controls', function () {
|
|
const ganacheOptions = {
|
|
accounts: [
|
|
{
|
|
secretKey:
|
|
'0x7C9529A67102755B7E6102D6D950AC5D5863C98713805CEC576B945B15B71EAC',
|
|
balance: convertToHexValue(25000000000000000000),
|
|
},
|
|
],
|
|
};
|
|
|
|
it('should display the correct gas price on the legacy transaction', async function () {
|
|
await withFixtures(
|
|
{
|
|
dapp: true,
|
|
fixtures: new FixtureBuilder()
|
|
.withPermissionControllerConnectedToTestDapp()
|
|
.build(),
|
|
ganacheOptions,
|
|
title: this.test.title,
|
|
},
|
|
async ({ driver }) => {
|
|
await driver.navigate();
|
|
await driver.fill('#password', 'correct horse battery staple');
|
|
await driver.press('#password', driver.Key.ENTER);
|
|
|
|
// initiates a send from the dapp
|
|
await driver.openNewPage('http://127.0.0.1:8080/');
|
|
await driver.clickElement({ text: 'Send', tag: 'button' });
|
|
await driver.waitUntilXWindowHandles(3);
|
|
const windowHandles = await driver.getAllWindowHandles();
|
|
const extension = windowHandles[0];
|
|
await driver.switchToWindowWithTitle(
|
|
'MetaMask Notification',
|
|
windowHandles,
|
|
);
|
|
await driver.assertElementNotPresent({ text: 'Data', tag: 'li' });
|
|
await driver.clickElement({ text: 'Edit', tag: 'button' });
|
|
await driver.waitForSelector({
|
|
text: '0.00021 ETH',
|
|
});
|
|
await driver.clickElement({
|
|
text: 'Edit suggested gas fee',
|
|
tag: 'button',
|
|
});
|
|
await driver.waitForSelector({
|
|
text: '0.00021 ETH',
|
|
});
|
|
const inputs = await driver.findElements('input[type="number"]');
|
|
const gasPriceInput = inputs[1];
|
|
await gasPriceInput.fill('100');
|
|
await driver.waitForSelector({
|
|
text: '0.0021 ETH',
|
|
});
|
|
await driver.clickElement({ text: 'Save', tag: 'button' });
|
|
await driver.waitForSelector({
|
|
css: '.transaction-detail-item:nth-of-type(1) h6:nth-of-type(2)',
|
|
text: '0.0021 ETH',
|
|
});
|
|
await driver.clickElement({ text: 'Confirm', tag: 'button' });
|
|
await driver.waitUntilXWindowHandles(2);
|
|
await driver.switchToWindow(extension);
|
|
|
|
// finds the transaction in the transactions list
|
|
await driver.clickElement('[data-testid="home__activity-tab"]');
|
|
await driver.waitForSelector(
|
|
'.transaction-list__completed-transactions .transaction-list-item:nth-of-type(1)',
|
|
);
|
|
await driver.waitForSelector({
|
|
css: '.transaction-list-item__primary-currency',
|
|
text: '-0 ETH',
|
|
});
|
|
|
|
// the transaction has the expected gas price
|
|
const txValue = await driver.findClickableElement(
|
|
'.transaction-list-item__primary-currency',
|
|
);
|
|
await txValue.click();
|
|
const gasPrice = await driver.waitForSelector({
|
|
css: '[data-testid="transaction-breakdown__gas-price"]',
|
|
text: '100',
|
|
});
|
|
assert.equal(await gasPrice.getText(), '100');
|
|
},
|
|
);
|
|
});
|
|
|
|
it('should display correct gas values for EIP-1559 transaction', async function () {
|
|
await withFixtures(
|
|
{
|
|
dapp: true,
|
|
fixtures: new FixtureBuilder()
|
|
.withPermissionControllerConnectedToTestDapp()
|
|
.build(),
|
|
ganacheOptions: {
|
|
...ganacheOptions,
|
|
hardfork: 'london',
|
|
},
|
|
title: this.test.title,
|
|
},
|
|
async ({ driver }) => {
|
|
await driver.navigate();
|
|
await driver.fill('#password', 'correct horse battery staple');
|
|
await driver.press('#password', driver.Key.ENTER);
|
|
|
|
// initiates a transaction from the dapp
|
|
await driver.openNewPage('http://127.0.0.1:8080/');
|
|
await driver.clickElement({ text: 'Create Token', tag: 'button' });
|
|
await driver.waitUntilXWindowHandles(3);
|
|
const windowHandles = await driver.getAllWindowHandles();
|
|
const extension = windowHandles[0];
|
|
await driver.switchToWindowWithTitle(
|
|
'MetaMask Notification',
|
|
windowHandles,
|
|
);
|
|
await driver.assertElementNotPresent({ text: 'Data', tag: 'li' });
|
|
await driver.clickElement('[data-testid="edit-gas-fee-button"]');
|
|
await driver.clickElement('[data-testid="edit-gas-fee-item-custom"]');
|
|
|
|
const baseFeeInput = await driver.findElement(
|
|
'[data-testid="base-fee-input"]',
|
|
);
|
|
await baseFeeInput.fill('25');
|
|
const priorityFeeInput = await driver.findElement(
|
|
'[data-testid="priority-fee-input"]',
|
|
);
|
|
await priorityFeeInput.fill('1');
|
|
|
|
await driver.clickElement({ text: 'Save', tag: 'button' });
|
|
await driver.delay(tinyDelayMs);
|
|
await driver.clickElement({ text: 'Confirm', tag: 'button' });
|
|
await driver.waitUntilXWindowHandles(2);
|
|
await driver.switchToWindow(extension);
|
|
|
|
// finds the transaction in the transactions list
|
|
await driver.clickElement('[data-testid="home__activity-tab"]');
|
|
await driver.waitForSelector(
|
|
'.transaction-list__completed-transactions .transaction-list-item:nth-of-type(1)',
|
|
);
|
|
await driver.waitForSelector({
|
|
css: '.transaction-list-item__primary-currency',
|
|
text: '-0 ETH',
|
|
});
|
|
|
|
// the transaction has the expected gas value
|
|
const txValue = await driver.findClickableElement(
|
|
'.transaction-list-item__primary-currency',
|
|
);
|
|
await txValue.click();
|
|
const baseFeeValue = await driver.waitForSelector({
|
|
text: '0.000000025',
|
|
});
|
|
assert.equal(await baseFeeValue.getText(), '0.000000025');
|
|
},
|
|
);
|
|
});
|
|
});
|
|
|
|
describe('Send ETH from inside MetaMask to a Multisig Address', function () {
|
|
const smartContract = SMART_CONTRACTS.MULTISIG;
|
|
const ganacheOptions = {
|
|
accounts: [
|
|
{
|
|
secretKey:
|
|
'0x7C9529A67102755B7E6102D6D950AC5D5863C98713805CEC576B945B15B71EAC',
|
|
balance: convertToHexValue(25000000000000000000),
|
|
},
|
|
],
|
|
};
|
|
it('finds the transaction in the transactions list', async function () {
|
|
await withFixtures(
|
|
{
|
|
fixtures: new FixtureBuilder().build(),
|
|
ganacheOptions,
|
|
smartContract,
|
|
title: this.test.title,
|
|
},
|
|
async ({ driver, contractRegistry }) => {
|
|
const contractAddress = await contractRegistry.getContractAddress(
|
|
smartContract,
|
|
);
|
|
await driver.navigate();
|
|
await driver.fill('#password', 'correct horse battery staple');
|
|
await driver.press('#password', driver.Key.ENTER);
|
|
|
|
await driver.clickElement('[data-testid="eth-overview-send"]');
|
|
|
|
await driver.fill(
|
|
'input[placeholder="Search, public address (0x), or ENS"]',
|
|
contractAddress,
|
|
);
|
|
|
|
const inputAmount = await driver.findElement('.unit-input__input');
|
|
await inputAmount.fill('1');
|
|
|
|
// Continue to next screen
|
|
await driver.clickElement({ text: 'Next', tag: 'button' });
|
|
|
|
await driver.clickElement({ text: 'Confirm', tag: 'button' });
|
|
|
|
await driver.clickElement('[data-testid="home__activity-tab"]');
|
|
await driver.wait(async () => {
|
|
const confirmedTxes = await driver.findElements(
|
|
'.transaction-list__completed-transactions .transaction-list-item',
|
|
);
|
|
return confirmedTxes.length === 1;
|
|
}, 10000);
|
|
|
|
const failedTx = await driver.isElementPresent(
|
|
'.transaction-status-label--failed',
|
|
);
|
|
assert.equal(failedTx, false, 'Transaction failed');
|
|
},
|
|
);
|
|
});
|
|
});
|