mirror of
https://github.com/kremalicious/metamask-extension.git
synced 2024-11-28 05:12:18 +01:00
4ef908aeb2
This reverts commit f5265c24ab.
Apparently it wasn't unnecessary after all. The Lock page served a few
different purposes. First, it was used to safeguard the seed phrase, in
case the user was interrupted after setting a password. Otherwise
anyone could open MetaMask and see the seed phrase without verifying
the password. Second, the submit function for the initialization unlock
screen also returned the seed phrase, so that it could be set in React
state for the confirmation step. Third, the submit function was also
responsible for navigating back to the seed phrase reveal page.
Removing the lock page had the effect of causing an infinite render
loop if onboarding was interrupted in the "Create" flow after setting
a password but before seed phrase confirmation. That redirect loop has
now been fixed.
41 lines
1005 B
JavaScript
41 lines
1005 B
JavaScript
import assert from 'assert'
|
|
import React from 'react'
|
|
import sinon from 'sinon'
|
|
import { mountWithRouter } from '../../../../../test/lib/render-helpers'
|
|
import Lock from '..'
|
|
|
|
describe('Lock', function () {
|
|
it('replaces history with default route when isUnlocked false', function () {
|
|
const props = {
|
|
isUnlocked: false,
|
|
history: {
|
|
replace: sinon.spy(),
|
|
},
|
|
}
|
|
|
|
mountWithRouter(<Lock.WrappedComponent {...props} />)
|
|
|
|
assert.equal(props.history.replace.getCall(0).args[0], '/')
|
|
})
|
|
|
|
it('locks and pushes history with default route when isUnlocked true', function (done) {
|
|
const props = {
|
|
isUnlocked: true,
|
|
lockMetamask: sinon.stub(),
|
|
history: {
|
|
push: sinon.spy(),
|
|
},
|
|
}
|
|
|
|
props.lockMetamask.resolves()
|
|
|
|
mountWithRouter(<Lock.WrappedComponent {...props} />)
|
|
|
|
assert(props.lockMetamask.calledOnce)
|
|
setImmediate(() => {
|
|
assert.equal(props.history.push.getCall(0).args[0], '/')
|
|
done()
|
|
})
|
|
})
|
|
})
|