1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
metamask-extension/app/scripts/controllers
Mark Stacey 703a063ad1
Fix metrics error when options are not used (#9985)
Attempts to send metrics would fail when no `options` were used. This
was because when the options parameter was not set, it was often sent
over our RPC connection as `undefined`, which gets serialized to `null`
when the message is converted to JSON. This `null` parameter didn't
trigger the default parameter set in the metametrics controller, as
default parameters are only used for `undefined`.

Instead the `options` parameter is now treated as fully optional, with
no default value set. The optional chaining operator is used to ensure
it won't blow up if it's not set. A fallback of `{}` was used for the
one destructure case as well.
2020-12-03 15:35:11 -03:30
..
ens [RFC] add prettier to eslint (#8595) 2020-11-02 17:41:28 -06:00
network add new MetaMetricsController (#9857) 2020-12-02 15:41:30 -06:00
permissions json-rpc-engine@6.1.0 (#9922) 2020-12-02 11:41:24 -08:00
transactions Fix inflated gas estimates (#9984) 2020-12-03 13:55:42 -03:30
alert.js [RFC] add prettier to eslint (#8595) 2020-11-02 17:41:28 -06:00
app-state.js Make JSDoc formatting more consistent (#9796) 2020-11-10 14:00:41 -03:30
cached-balances.js Make JSDoc formatting more consistent (#9796) 2020-11-10 14:00:41 -03:30
detect-tokens.js @metamask/contract-metadata (#9968) 2020-12-01 14:55:01 -08:00
incoming-transactions.js expand transaction constants coverage (#9790) 2020-11-07 01:38:12 -06:00
metametrics.js Fix metrics error when options are not used (#9985) 2020-12-03 15:35:11 -03:30
onboarding.js Track whether seed phrase has been backed up (#9830) 2020-11-10 12:34:20 -03:30
preferences.js Remove use of ethgasstation; use metaswap /gasPrices api for gas price estimates (#9867) 2020-12-02 19:55:19 -03:30
swaps.js Alternative savings fix (#9675) 2020-11-09 13:39:38 -03:30
threebox.js json-rpc-engine@6.1.0 (#9922) 2020-12-02 11:41:24 -08:00
token-rates.js [RFC] add prettier to eslint (#8595) 2020-11-02 17:41:28 -06:00