1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
metamask-extension/test/unit/app/controllers
Mark Stacey 165666b315
Remove unnecessary tx meta properties (#8489)
* Remove `estimatedGas` property from `txMeta`

The `estimatedGas` property was a cache of the gas value estimated for
a transaction when the default gas limit was set. This property wasn't
used anywhere. It may have been useful for debugging purposes, but the
same gas estimate is already stored on the `history` property so it
should be present in state logs regardless.

* Remove `gasLimitSpecified` txMeta property

The `gasLimitSpecified` property of `txMeta` wasn't used for anything.
It might have been useful for debugging purposes, but whether or not
the gas limit was specified can also be determined from looking at the
transaction history, so it's not a huge loss.

* Remove `gasPriceSpecified` txMeta property

The `gasPriceSpecified` property of `txMeta` wasn't used for anything.
It might have been useful for debugging purposes, but whether or not
the gas price was specified can also be determined from looking at the
transaction history, so it's not a huge loss.

* Remove `simpleSend` txMeta property

The `simpleSend` property of `txMeta` was used to ensure a buffer was
not added to the gas limit during gas estimation for simple send
transactions. It was made redundant by #8484, which accomplishes this
without the use of this property.
2020-05-01 08:44:05 -03:00
..
network Remove unnecessary tx meta properties (#8489) 2020-05-01 08:44:05 -03:00
permissions test/unit/permissions - fix promise await timing (#8410) 2020-04-24 15:05:30 -07:00
transactions Ensure tx has value before it's added (#8486) 2020-04-30 21:50:44 -03:00
balance-controller.spec.js Update ESLint rules for test suite (#8023) 2020-02-11 13:21:13 -03:30
cached-balances-test.js Update ESLint rules for test suite (#8023) 2020-02-11 13:21:13 -03:30
detect-tokens-test.js Cleanup detect-tokens controller and tests (#8329) 2020-04-13 17:14:42 -03:00
ens-controller-test.js Update ESLint rules for test suite (#8023) 2020-02-11 13:21:13 -03:30
incoming-transactions-test.js Prevent accidental use of globals (#8340) 2020-04-15 14:23:27 -03:00
infura-controller-test.js Remove unused sinon sandboxes (#8063) 2020-02-17 21:31:09 -04:00
metamask-controller-test.js Fix order of accounts in eth_accounts response (#8342) 2020-04-16 15:20:01 -03:00
preferences-controller-test.js Update PreferencesController tests (#8328) 2020-04-13 17:03:35 -02:30
token-rates-controller.js Update ESLint rules for test suite (#8023) 2020-02-11 13:21:13 -03:30