1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
metamask-extension/app/scripts
Mark Stacey 1282ed774e
Remove ineffectual close popup function (#8316)
During the initialization of the full-screen or popup UI, we attempted
to close the notification popup (if it was open). This never worked (or
at least hasn't in a long time).

The method used to attempt closing the notification popup was
`closePopup` from the `notificationManager`, which keeps track
internally of the id of the notification popup window, and can close
the window by using this id.

However, this id is only set in the first place if the popup is opened
with this specific instance of the `notificationManager`. The popup is
never opened from the UI in practice; it's only opened from the
background (which has its own instance of `notificationManager`). The
popup id is never set for this `notificationManager` instance in the UI.

It's not entirely clear that we'd always want to close the notification
popup in this circumstance anyway. The user might want to open MetaMask
alongside the popup to check something else.
2020-04-10 12:27:58 -03:00
..
account-import-strategies Clean up "JSON File" import strategy test output (#7855) 2020-01-17 19:59:47 -03:30
controllers Connect flow via popup (#8269) 2020-04-07 16:08:15 -02:30
lib Fix Sentry error processing for errors missing a stack (#8179) 2020-03-12 10:51:05 -03:00
migrations Enable arrow-parens ESLint rule 2020-02-15 17:04:21 -03:30
platforms Use @metamask/etherscan-link@1.1.0 (#8294) 2020-04-06 13:38:44 -02:30
background.js Fix popup not opening (#8314) 2020-04-09 20:43:32 -03:00
chromereload.js Fix console.error references 2016-08-29 17:32:39 -07:00
contentscript.js Merge pull request #8056 from whymarrh/arrow-parens 2020-02-17 15:26:43 -07:00
first-time-state.js Migrate codebase to use ESM (#7730) 2020-01-09 00:04:58 -03:30
inpage.js update inpage-provider; minor fixes (#7997) 2020-02-06 07:57:54 -08:00
metamask-controller.js Connect flow via popup (#8269) 2020-04-07 16:08:15 -02:30
phishing-detect.js Replace METAMASK_UI_TYPE global with helper function (#8279) 2020-04-01 19:28:10 -03:00
README.md add READMEs to folders, re #3427 2018-03-14 15:33:22 +02:00
ui.js Remove ineffectual close popup function (#8316) 2020-04-10 12:27:58 -03:00

Main MetaMask Code

This folder contains the core-code.

Currently, it is organized mostly based on file category, like:

controllers, migrations, lib

Ongoing Task

Refactor code-structure, thus the subsystems are reflected on the filesystem.

Examples