mirror of
https://github.com/kremalicious/metamask-extension.git
synced 2024-10-22 19:26:13 +02:00
1175b4bfa7
This PR makes ~all named intrinsics in all of our JavaScript processes non-modifiable. A named intrinsic is any property specified by the ECMAScript specification that exists on `globalThis` when the JavaScript process starts. We say that a property is non-modifiable if it is non-configurable and non-writable. We make exceptions for properties that meet any of the following criteria: 1. Properties that are non-configurable by the time `lockdown-run.js` is executed are not modified, because they can't be. 2. Properties that have accessor properties (`get` or `set`) are made non-configurable, but their writability cannot be modified, and is therefore left unchanged. It's unclear how many of the named intrinsics this applies to, if any, but it's good defensive programming, regardless. |
||
|---|---|---|
| .. | ||
| account-import-strategies | ||
| constants | ||
| controllers | ||
| lib | ||
| migrations | ||
| platforms | ||
| background.js | ||
| contentscript.js | ||
| disable-console.js | ||
| first-time-state.js | ||
| inpage.js | ||
| lockdown-run.js | ||
| metamask-controller.js | ||
| metamask-controller.test.js | ||
| phishing-detect.js | ||
| sentry-install.js | ||
| ui.js | ||