mirror of
https://github.com/kremalicious/metamask-extension.git
synced 2024-12-23 09:52:26 +01:00
04ae92a2c0
We've been using the `eslint-plugin-json` plugin for some time, but we haven't been visiting `.json` files in the lint script. The lint script has now been updated to incude `.json` files, which means any invalid JSON will result in a lint error. Unfortunately this JSON plugin doesn't seem to apply the other eslint rules (such as `key-spacing`) to the JSON files. I wasn't able to find a way to get that to work. Instead I manually auto-formatted each of the locale `message.json` files, which fixed many whitespace inconsistencies. The `states.json` file was deleted completely, as it appears to be unused. It wasn't a valid JSON file anyway, it was JavaScript. It looks like a `states.js` file is automatically generated, but an old copy was accidentally saved as `states.json` and included in the repo. Many duplicate key errors were found and fixed in the `development/states/` JSON files. `package-lock.json` was added to `.eslintignore` because it was very slow to lint, and linting it doesn't provide much value. |
||
---|---|---|
.. | ||
notices | ||
states | ||
.jsdoc.json | ||
announcer.js | ||
auto-changelog.sh | ||
backGroundConnectionModifiers.js | ||
genStates.js | ||
index.html | ||
metamaskbot-build-announce.js | ||
mock-dev.js | ||
mockExtension.js | ||
README.md | ||
require-react-devtools.js | ||
rollback.sh | ||
run-ganache | ||
run-version-bump.js | ||
selector.js | ||
sentry-publish.js | ||
sourcemap-validator.js | ||
test.html | ||
ui-dev.js | ||
uiStore.js | ||
verify-locale-strings.js | ||
version-bump.js |
Development
Several files which are needed for developing on(!) MetaMask.
Usually each files contains information about its scope / usage.