m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-11-23 02:10:12 +01:00
Code
16,252 Commits 2 Branches 0 Tags 265 MiB
fde18dec0c
Commit Graph

6332 Commits

Author SHA1 Message Date
Jyoti Puri
db09719e45
Move confirm-transaction/conf-tx.js to confirm-signature-request (#17408) 2023-02-02 20:22:11 +05:30
Nidhi Kumari
493ab6cbd9
remove nft toaster on first autohide (#17536) 2023-02-02 16:42:52 +05:30
ryanml
7f9977b7d2
Convert ui/store/actionConstants.js -> Typescript (#17442) 2023-02-01 22:16:59 -07:00
Vladimir Saric
308151cd49
Display a warning and gas fee component for token allowance and NFT flow when transaction is expected to fail (#17437) 
Co-authored-by: Pedro Figueiredo <pedro.figueiredo@consensys.net>
Co-authored-by: Dan J Miller <danjm.com@gmail.com>
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
 2023-02-01 17:14:09 -06:00
Garrett Bear
b0ed6be77a
remove unused banner base proptype (#17531) 2023-02-01 13:44:57 -08:00
Brad Decker
0885c6cd1f
prefer locale slice for locale state (#17499) 2023-02-01 11:53:35 -06:00
David Walsh
03d8ee5eae
Onboarding V2: Remove old onboarding flow (#17081) 2023-02-01 09:28:09 -06:00
Jyoti Puri
8fd65a698e
Fix build (#17538) 2023-02-01 19:07:15 +05:30
Garrett Bear
db0492e042
fix button text props (#17478) 
* fix button text props

* fix textProps size from being overriden

* Update ui/components/component-library/button-link/button-link.js

Co-authored-by: George Marshall <george.marshall@consensys.net>

---------

Co-authored-by: George Marshall <george.marshall@consensys.net>
 2023-02-01 13:25:46 +05:30
Jyoti Puri
26222a9b27
Refactoring confirm-transaction-base component (#17484) 2023-02-01 11:24:41 +05:30
Jyoti Puri
80fb59f0a0
Refactor conf-tx.js (#17380) 2023-02-01 11:24:18 +05:30
ryanml
83a3ce1aa0
Fix RPC Url editing issue of existing network (#17451) 2023-01-31 18:22:47 -07:00
ryanml
5e863a297f
Adjust 'Confirm' button color on setApprovalForAll revocations (#17506) 2023-01-31 18:22:33 -07:00
Brad Decker
6e7f5c3e21
Move THEME_TYPE to new preferences.ts file (#17515) 2023-01-31 17:49:00 -06:00
David Walsh
7a29d896ad
Fix #17328 - Move NFT settings to Experimental (#17400) 
* Fix #17328 - Move NFT settings to Experimental

* Don't indent second NFT setting

* Fix jest test
 2023-01-31 12:50:53 -06:00
David Walsh
145cf1ec01
UX - Update all copy icons (#17445) 2023-01-31 11:00:26 -06:00
Vladimir Saric
8aa3263b82
Added navigation between multiple sign prompts and reject all sign prompts (#17093) 
* Fixed navigation through multiple unapproved transactions for ERC20 tokens

* Fixed tx details activity-log currency

* Fixed e2e test failure

* Added navigation between multiple sign prompts and reject all sign prompts

* Resolving conflicts

* Creating SignatureRequestNavigation component and extracting the UI rendering part into a single component

* Fixing e2e tests and updating snapshot

* Using single component for navigation which shows both messages and transactions requests

* Fixing test-unit-jest-main

* Added more unit tests

* Fixing test-storybook

* Fixing test-storybook

---------

Co-authored-by: Filip Sekulic <filip.sekulic@consensys.net>
 2023-01-31 16:29:23 +01:00
David Walsh
6439d03075
Fix #17439 - Prevent event error when user presses enter key during onboarding (#17497) 2023-01-31 08:47:55 -06:00
David Walsh
18a1beb3dd
Update overview icons for buy, send, and swap (#17492) 2023-01-31 08:47:43 -06:00
David Walsh
d057410762
New Icons: Replace instance of fa-qr-code icon (#17474) 
* New Icons: Replace instance of fa-qr-code icon

* Update ui/pages/send/send-content/add-recipient/domain-input.component.js

Co-authored-by: George Marshall <george.marshall@consensys.net>

---------

Co-authored-by: George Marshall <george.marshall@consensys.net>
 2023-01-31 08:47:23 -06:00
David Walsh
edb2c9ea00
Fix #17441 - Update all MenuItem instances to use new icons (#17468) 2023-01-31 08:47:00 -06:00
David Walsh
ff843c1b10
Fix #17393 - Fix NFT collection header image (#17394) 2023-01-31 08:46:40 -06:00
Danica Shen
2958d68af8
feat(mme-17214): migrate L33 files to typescript (#17372) 2023-01-31 12:01:10 +00:00
ryanml
8a7c897a1c
Update copy when revoking setApprovalForAll (#17500) 2023-01-31 04:27:41 -07:00
David Walsh
acafe7c4c5
Update home portfolio dapp icon to new icon (#17471) 
* Update home portfolio dapp icon to new icon

* Using ButtonLink component so onClick isn't used on a div

---------

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
 2023-01-30 12:33:08 -06:00
Mark Stacey
55d8ec0572
Document displayWarning as deprecated (#17465) 
The `displayWarning` action creator will show the error in various
different places in the UI. This is confusing for users, we should stop
doing this.

Instead we can consider each error case separately. If there is a
scenario where it's appropriate to tell a user about an error, we
should build that case into the relevant UI and use localized error
messages.
 2023-01-30 09:37:04 -03:30
Danica Shen
c23bd4925b
feature: convert level 32 files to typescript (#17390) 2023-01-27 18:28:03 +00:00
Dan J Miller
7a77c82514
Use network provider state, instead of CurrencyRateController state, to select 'nativeCurrency' (#17450) 
* Use network provider state, instead of CurrencyRateController state, select 'nativeCurrency'

* Fix unit tests

* Lint fix

* Only use the network provider ticket for the native currency when useCurrencyRateCheck is false

* Fix unit test

* Fix tests for real
 2023-01-27 13:47:47 -03:30
David Walsh
6ee2d07706
Fix #17362 - Ensure NFT icons are correct (#17440) 
* Fix #17362 - Ensure NFT icons are correct

* Update trash icon
 2023-01-27 08:32:03 -06:00
David Walsh
b21e0df4fa
Fix #17385 - Provide autohide callback for ActionMessage (#17392) 
* Fix #17385 - Provide autohide callback for ActionMessage

* Add autohide to the removeal message
 2023-01-27 08:31:43 -06:00
Garrett Bear
30520a3352
button link housekeeping (#16885) 
* button link housekeeping

Co-authored-by: George Marshall <george.marshall@consensys.net>
Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
 2023-01-26 10:32:11 -08:00
amerkadicE
ab329e5186
Refactor confirm page container component from class to functional component (#16907) 2023-01-26 11:07:17 -06:00
Mark Stacey
506ee16648
Document callback-style background calls as deprecated (#17376) 
We've been migrating from callback-based to async background calls for
a number of years now. The async calls are easier to read, and less
likely to be misused (especially when it comes to error handling).

The `callBackgroundMethod` method, used to make a callback-based
background call, has been marked as deprecated. Hopefully this will
discourage further use.
 2023-01-26 12:27:15 -03:30
Jyoti Puri
5a493fb38e
Improving getMemoizedMetadataContractName selector (#17432) 2023-01-26 21:09:13 +05:30
Olusegun Akintayo
16ea4a8046
Put hardware wallets behind an HARDWARE_WALLETS_MV3 flag (#17354) 
* Put hardware wallets behind an HARDWARE_WALLETS_MV3 flag
Disable Hardware connect buttons if the flag is set.

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

update to metamask/eth-keyring-controller

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

revert to eth-keyring-controller v8

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

LAvamost after rebase

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

lock file.

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

Added toaster for removed NFTs (#17297)

* added notification for remove nfts

* reverted names for tabs

* updated default key

* updated snapshot

* updated remove nft toast to danger

Setup network controller mocks per-test (#17250)

The network controller unit test network mocks are now setup for each
test. This makes modifying network behavior on a per-test basis easier,
and makes it more clear which test relies upon which mocks.

Security provider check (OpenSea) (#16584)

chore: copy update for metamask fee on swaps (#17133)

* linter fix

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

* setLedgerTransportPreference in the metamask-controller should not be called, or should return immediately, if canUseHardwareWallets() is false

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
Co-authored-by: Jyoti Puri <jyotipuri@gmail.com>
 2023-01-25 17:42:08 -03:30
Nidhi Kumari
1d1b751f62
Consolidated all component import paths (#17368) 2023-01-25 11:54:08 -08:00
Nidhi Kumari
709d0267f8
updated new links for the stories (#17369) 2023-01-25 11:51:25 -08:00
David Walsh
29d4799f46
Fix #17388 - Remove dismiss button from NFT notification (#17389) 2023-01-25 13:28:15 -06:00
Daniel
a4f968b423
Remove a notification for falling back from STX to regular swaps (#17374) 2023-01-25 20:01:10 +01:00
Garrett Bear
ed75dabe57
Feat/15086/add banner severities component (#17307) 
* add banner component

* update banner styles and tests

* fix padding and update snapshot

* banner stories id removal

* update readme

* Update ui/components/component-library/banner/banner.js

Co-authored-by: George Marshall <george.marshall@consensys.net>

* Update ui/components/component-library/banner/README.mdx

Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>

* Update ui/components/component-library/banner/README.mdx

Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>

* banner updates

Co-authored-by: George Marshall <george.marshall@consensys.net>
Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
 2023-01-25 10:39:49 -08:00
Garrett Bear
23133a2735
fix icon names (#17391) 2023-01-25 23:41:13 +05:30
Alex Donesky
3d87f65d9b
Fix broken NFT import and auto-detect flows (#17384) 
* Fix broken NFT import and auto-detect flows
 2023-01-25 10:33:06 -06:00
Brad Decker
073718d965
Convert ui/helpers/constants/common to typescript (#17348) 2023-01-25 09:47:02 -06:00
Niranjana Binoy
129a06cc12
Copy update on Transaction breakdown for ApproveToken (#17296) 2023-01-25 10:15:58 -05:00
ryanml
47f6d46bb3
Add alt text for NFT images (#17284) 2023-01-25 08:08:35 -06:00
Nidhi Kumari
8a6bf4d1c9
Nit fixes for story-test integration (#17344) 
* nit fix for story-test integration

* updated package.jsson
 2023-01-25 09:24:13 +05:30
Garrett Bear
0bf6aeb5f5
icon audit, remove xxs icon size (#17089) 
* icon audit, remove xxs icon size

* update icon file names and snapshots

* remove unused icon- code and fix icons with slash issue

* close icon fix

* remove icons id

* update snapshot

* font awesome icon list

* remove font awesome

* fix linting issue
 2023-01-24 09:39:46 -08:00
Danica Shen
f5426a84d9
feat(mme-17212): convert shared/constants/swaps.js -> Typescript (#17322) 2023-01-24 16:38:01 +00:00
Maarten Zuidhoorn
2900fe2c1a
Move subject type enum to @metamask/subject-metadata-controller (#16431) 
* Move subject type enum to @metamask/controllers

* Fix imports
 2023-01-24 16:03:01 +01:00
Brad Decker
3ff12d70e9
Replace usages of conversion util in rest of UI folder in favor of Numeric (#17334) 2023-01-24 08:44:49 -06:00
amerkadicE
dd09245ff6
Fix/use etherjs specific imports (#15461) 
* replace ethers with submodules

Co-authored-by: Alex <adonesky@gmail.com>
 2023-01-24 08:10:36 -06:00
David Walsh
cf10b2a1a0
Fix #17300, #16843 - Use proper source for image of IPFS NFTs (#17302) 2023-01-23 16:04:11 -06:00
Brad Decker
b4c5837760
Remove usages of Conversion util in components folder in favor of Numeric (#17333) 
Co-authored-by: Danica Shen <zhaodanica@gmail.com>
 2023-01-23 13:30:43 -06:00
Brad Decker
d2c3abea51
Refactor Errors E2E test to no longer rely upon a real error (#17332) 
Co-authored-by: Danica Shen <zhaodanica@gmail.com>
 2023-01-23 12:58:35 -06:00
Frederik Bolding
ef69e2ae48
[FLASK] Update onboarding text to fit new panel (#17345) 
* Update Flask onboarding text to fit new panel

* Fix lint
 2023-01-23 18:43:35 +01:00
Brad Decker
ead1446c98
Refactor usages of conversion util in the app folder and shared folder in favor of Numeric (#17331) 2023-01-23 11:41:01 -06:00
Nidhi Kumari
213240349d
Updated Icons in Title of NFTs (#17205) 
* icon update for nft

* updated icon for previously owned icon

* removed isPreviouslyOwned condition
 2023-01-23 22:38:35 +05:30
Vladimir Saric
f988dc1c5e
Enable the Token Allowance flow by default for all users (#16740) 2023-01-23 21:49:55 +05:30
Brad Decker
af83e120dc
Convert app//scripts/lib/util.js to typescript (#17330) 2023-01-23 10:18:22 -06:00
aleksandar-mihajlovic
16851c83ef
Added fix for overlaping text in mozzila in activity tab (#17235) 2023-01-23 09:48:14 -06:00
Jyoti Puri
3e523e2382
Use PageContainerFooter to render footer on all confirmation pages (#17316) 2023-01-23 20:52:12 +05:30
Filip Sekulic
27d34166fe
Security provider check (OpenSea) (#16584) 2023-01-23 20:02:01 +05:30
Nidhi Kumari
180eabea06
Added toaster for removed NFTs (#17297) 
* added notification for remove nfts

* reverted names for tabs

* updated default key

* updated snapshot

* updated remove nft toast to danger
 2023-01-23 17:23:44 +05:30
David Walsh
cb6ee2b3fe
Use async/await instead of Promise.resolve (#16221) 2023-01-20 14:20:18 -06:00
Nidhi Kumari
c5368c152b
Added storybook check to CI (#17092) 
* added storybook test runner

* added test runner in ci

* updated test for ci and fixed lint error

* updated lavamoat policy

* updated test command

* updated playwright

* changed command to storybook;ci

* updated command

* updated instance for test-storybook

* updated playwright

* added playwright step

* replaced concurrently with start-server-and-test

* updated the static storybook directory

* replaced first with last

* updated lock file

* replaced first with last

* updated test-storybook with maxworkers

* updated .depchechrc

* updated yml

* removed id from banner base

* replaced broken stories with .stories-to-do.js extesnsion

* updated token allowance story

* removed duplicacies from yarn

* fixed lavamoat

* removed filename comment

* updated links for docs

* fixed file extension for stories

* updated path for stories.json

* updated stories.json path

* yarn updated

* updated stories

* updated yarn

* updated wait on
 2023-01-21 00:57:46 +05:30
Brad Decker
92f6ea6f6b
Relocate conversion utils to shared/modules/conversion.utils.js (#17319) 2023-01-20 11:04:37 -06:00
David Walsh
24551b7e9c
Fix #17138 - Allow ActionMessage to be autohidden after a given number of milliseconds (#17269) 2023-01-20 09:33:36 -06:00
ryanml
a19a5d60d3
Convert shared/constants/hardware-wallets.js -> Typescript (#17310) 2023-01-20 09:14:40 -06:00
Ariella Vu
c744f2d0cf
TransactionDecoding: rm unwanted cursor: pointer (#17318) 2023-01-20 21:37:50 +07:00
Ariella Vu
149b5721ad
Fix transaction decoding data types string and bool (#17299) 
* TransactionDecoding: support string type
- fixes #16951
- fixes #16952 (string cut off)

* TransactionDecoding: support bool type
 2023-01-20 20:31:26 +07:00
Nidhi Kumari
90d2ca0727
updated initial state of new imported nfts to expanded (#17285) 2023-01-19 23:01:13 +05:30
Nidhi Kumari
0fdff8955c
added title for each nft in asset dropdown (#17286) 2023-01-19 23:00:35 +05:30
Danica Shen
8f915807e4
fix(mme-14830): fix consistent tab when switching languages (#17155) 2023-01-19 15:05:42 +00:00
Dan J Miller
c90d389b84
Clarify effect of autodetect tokens toggle (#17293) 
* Clarify effect of autodetect tokens toggle

* Fix test

Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
 2023-01-19 11:33:08 -03:30
Dan J Miller
9a8bb81358
Allow user to scroll network form in onboarding modal (#17291) 2023-01-19 10:44:47 -03:30
ryanml
63a3de6768
Various NFT UI fixes (#17153) 
* Various NFT UI fixes

* Addressing review feedback

* Using ButtonIcon component for copy icon

* Using button for collectible item
 2023-01-18 15:39:15 -07:00
Thomas Huang
d99854baac
Convert signature request component to tlr. (#17268) 2023-01-18 11:34:28 -08:00
Ariella Vu
2d6529bc5c
GasDisplay: hide duplicate testnet value (#17207) 
- when isTestnet && !showFiatInTestnets
 2023-01-18 22:43:40 +07:00
Brad Decker
5f6d2ba6b0
Convert Transaction constants to typescript (#17149) 2023-01-18 08:47:29 -06:00
ryanml
d8ce8612bd
Update copy and fix duplicate entries for Token Detection Settings search results (#17273) 2023-01-18 11:13:57 -03:30
David Walsh
37174d749c
Fix #17162 - Add NFT disclaimer to details page (#17266) 2023-01-18 08:37:16 -06:00
Niranjana Binoy
20cbe44d63
Moving transaction-alerts component from /ui/pages/confirm-transaction folder to ui/component/app folder (#17272) 2023-01-18 09:30:26 -05:00
Vladimir Saric
c82c967c46
Fixing error when user input some letter in token allowance flow (#17117) 
* Fixing error when user input some letter in token allowance flow

* Rename the regex variable name and added a brief comment above its definition

Co-authored-by: Pedro Figueiredo <pedro.figueiredo@consensys.net>
 2023-01-18 10:53:10 +01:00
ryanml
a276208891
Fixing broken stories (#17227) 2023-01-17 18:42:02 -07:00
aleksandar-mihajlovic
48dd819763
Fix for showing warning when no pending confirmations when network switching (#17179) 2023-01-17 15:37:35 -06:00
aleksandar-mihajlovic
082772fd08
Fix for contacts tab alignment bugs (#17171) 2023-01-17 15:36:33 -06:00
David Walsh
7d616fa513
NFTs: Add proper padding to import warning (#17202) 2023-01-17 14:26:16 -06:00
Thomas Huang
4c3c4eebac
Final conversion of tests from enzyme to @testing-library/react (#16862) 
* Add transaction activity log component

* Remove duplicate tx activity log snapshot.

* Convert Advanced Tab to tlr.

* Lint fix

* Change ENS to DNS in mock state data.

* Add test ids for speedup, cancel, rety buttons.

* Convert TransactionListItemDetails component to RTL.

* Convert PageContainerHeader component to RTL.

* Convert TokenInput component to RTL.

* Convert UnitInput component to RTL.

* Convert withModalProps to RTL.

* Convert i18n-helper to RTL.

* Convert ConfirmSeedPhrase component to TLR.

* Convert AddRecipient component to RTL.

* Set process.env metamask build type to 'main' for test

Co-authored-by: Brad Decker <bhdecker84@gmail.com>
Co-authored-by: Pedro Figueiredo <pedro.figueiredo@consensys.net>
 2023-01-17 07:51:35 -08:00
Niranjana Binoy
a0bb4a6c5a
Toggle option to enable/disable balance and Token rate checking for using third-party API (#16772) 2023-01-17 10:23:04 -05:00
David Walsh
554939cc66
Fix #17142 - Ensure toggle arrow is visible in dark mode (#17204) 2023-01-17 09:19:26 -06:00
Michal
49c8b279be
harden export account (#17241) 
harden export account
 2023-01-17 15:01:12 +00:00
ryanml
d5fea389e3
Fix MetaMetrics settings toggle styling (#17224) 2023-01-17 05:52:55 -07:00
ryanml
c77629f8aa
Removing erroneous blank lines in ui/components (#17225) 2023-01-17 05:52:04 -07:00
Vladimir Saric
3c38ff3899
Validating or restricting the number of digits on token allowance flow (#17234) 
* Validating or restricting the number of digits after the decimal point that the user can enter and styles for Max button and description with error message

* Use better solution for validation the number of digits on token allowance flow
 2023-01-16 14:11:46 -03:30
Michal
32a2411cf5
Remove textarea caret dep (#17105) 
remove dependency for mascot head movement
 2023-01-16 13:07:59 +00:00
Nidhi Kumari
1df72c6e4e
Added padding/margin inline support to the Box component (#17134) 
* added tests and css for more padding/margin support

* updated README

* fixed spacings

* fixed spacings
 2023-01-14 10:54:25 +05:30
Garrett Bear
1265731344
Feat/16637/button housekeeping (#16872) 
* button housekeeping

* add iconsearch

* fix description

* readme update

* update disabled classnames

* buttonlink disabled class

* add disabled proptypes

* add constant exports

* update disabled style classes

* update snapshot for box pill classname

* add buttonTextProps

* update primarybutton background color to use box props

* update button secondary and link to use box props

* update tests
 2023-01-13 13:58:09 -08:00
ryanml
214afe1992
Remove 'Verify contract details' link on Sig Req screen when 'verifyingContract' is absent (#17128) 
* Remove 'Verify contract details' link on Sig Req screen when 'verifyingContract' is not provided

* Adding tests
 2023-01-13 12:28:52 -07:00
David Walsh
7760f4d658
Remove ONBOARDING_V2 flag for release (#16865) 
* Remove ONBOARDING_V2 flag for release

* Remove new usage

* Update e2e tests

* Update incremental-security.spec.js

* Fix lint

Co-authored-by: PeterYinusa <peter.yinusa@consensys.net>
 2023-01-13 10:25:01 -06:00
David Walsh
72a1df247c
Onboarding v2: Implement requested metrics (#17090) 2023-01-13 10:11:27 -06:00
amerkadicE
00aee11c2a
Add contact unit tests (#17131) 2023-01-13 09:52:03 -06:00
David Walsh
105762b0ed
Fix 16842 - Update NFT error message so that it's caught properly and displayed (#17165) 
Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
 2023-01-13 09:33:01 -06:00
Filip Sekulic
e70b6dc29e
13/12 (#16948) 2023-01-13 20:11:07 +05:30
Victor Naumik
7df712b888
Display primaryType in signTyped instead of 'Message' string (#17077) 
* fix: Display primaryType in signTyped instead of 'Message' string

* fix: added #17077 to changelog

* fix: remove unused signatureRequest1 message to fix test-lint failure

* Update CHANGELOG.md

Co-authored-by: Dan J Miller <danjm.com@gmail.com>

* test: add assertion for the primaryType to signature-request component test

Co-authored-by: Brad Decker <bhdecker84@gmail.com>
Co-authored-by: Dan J Miller <danjm.com@gmail.com>
 2023-01-12 15:52:02 +01:00
David Walsh
d468739ff0
Ensure the NFT feature flag has changed in all places (#17152) 2023-01-11 23:04:02 -07:00
ryanml
5061eac2e7
Fix duplicate button issue on Ledger connectivity screen (#17130) 2023-01-11 11:34:05 -07:00
Garrett Bear
01c0d7823d
Feat/15085/banner base component (#16828) 
* add banner base component

banner base wip

remove base avatar

banner base

* add banner base

* Update ui/components/component-library/banner-base/banner-base.stories.js

Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>

* Update ui/components/component-library/banner-base/banner-base.js

Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>

* named export org fix

* Update ui/components/component-library/banner-base/README.mdx

Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>

* updated changes to banner base

* banner base updates

* fix description/children

* move banner base down

* Update ui/components/component-library/banner-base/README.mdx

Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>

* Update ui/components/component-library/banner-base/README.mdx

Co-authored-by: George Marshall <george.marshall@consensys.net>

* Update ui/components/component-library/banner-base/banner-base.js

Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>

* Update ui/components/component-library/banner-base/banner-base.js

Co-authored-by: George Marshall <george.marshall@consensys.net>

* Update ui/components/component-library/banner-base/banner-base.test.js

Co-authored-by: George Marshall <george.marshall@consensys.net>

* Update ui/components/component-library/banner-base/banner-base.js

Co-authored-by: George Marshall <george.marshall@consensys.net>

* fix linting

Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
Co-authored-by: George Marshall <george.marshall@consensys.net>
 2023-01-11 09:42:18 -08:00
Nidhi Kumari
6e900fb0e3
housekeeping for Avatar Favicon (#16931) 
* housekeeping for avatar favicon

* added test for custom className

* fixed lint errors

* updated avatar favicon in tag url

* updated import

* updated readme and fixed label

* updated tag url snapshot

* updated snapshot for favicon
 2023-01-11 21:41:06 +05:30
David Walsh
c12d469af2
Onboarding V2 - Fix CSS/React warnings from last screen (#17125) 2023-01-11 09:21:19 -06:00
Filip Sekulic
fc83a1b631
Fixed navigation through multiple unapproved transactions for ERC20 tokens (#16822) 2023-01-11 09:01:50 -06:00
Garrett Bear
e236792a90
add width docs to box component (#17007) 
* add width docs to box component
 2023-01-09 22:30:29 -08:00
Nidhi Kumari
56a3afaace
avatar account housekeeping (#16930) 
* avatar account housekeeping

* avatar number to the diametere

* fixed lint errors

* converting blockie to number

* updated README

* updated constants for avatar account
 2023-01-09 16:38:43 -08:00
David Walsh
7cd2b28cd5
Fix #16959 - Don't allow user to see welcome or password creation screen after a keyring has been created (#17024) 2023-01-09 14:55:48 -06:00
ryanml
64eae7d3f0
Fix spacing issue in Settings Search input (#17108) 
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
 2023-01-09 13:54:28 -07:00
George Marshall
b653b4f934
Fixing some incorrect CSS color vars (#17033) 
* Fixing some incorrect css vars

* Static hex value fix

Co-authored-by: Brad Decker <bhdecker84@gmail.com>
 2023-01-09 11:58:34 -08:00
Alaa Hadad
174d3dbcf0
soft disable onramp provider wyre (#17102) 2023-01-09 13:44:13 -03:30
ryanml
7ea827565c
Fix 'Back' navigation from Restore Vault page when accessed from popup window (#17095) 2023-01-09 04:19:53 -07:00
amerkadicE
5964ece8d3
Ensure that protect your funds popover is displayed above tooltip (#17084) 2023-01-08 16:45:14 -06:00
amerkadicE
6ace8955d3
Make username mandatory when adding to address book (#17044) 2023-01-06 10:36:32 -06:00
Nidhi Kumari
be227705d0
added padding/margin inline, inline-start and inline-end support to Box Component (#17085) 
* added padding/margin inline-start and inline-end support

* updated story for margin
 2023-01-06 12:10:28 +05:30
ryanml
e8809cffaf
Onboarding V2: Fix 'Securing my Wallet' when coming from backup reminder after account recovery (#17088) 2023-01-05 23:14:32 -07:00
Nidhi Kumari
a1c5224997
housekeeping for picker-network (#16982) 
* updated test in picker-network

* fixed import order in README

* fixed global import path

* fixed formatting
 2023-01-05 15:30:42 -08:00
Nidhi Kumari
c9ddee9155
updated colors for typography component (#17009) 
* updated colors for typography

* updated valid colors
 2023-01-05 13:04:48 -08:00
Adnan Sahovic
fbbc1df853
Display large and small numbers as decimals instead of scientific notation on token allowance confirmation screens (#16676) 
Co-authored-by: VSaric <vladimir.saric@consensys.net>
Co-authored-by: Vladimir Saric <92527393+VSaric@users.noreply.github.com>
 2023-01-05 08:58:16 -06:00
Filip Sekulic
e6038d542a
Update UI for transaction security check in settings (#16830) 2023-01-04 15:59:48 -06:00
Vladimir Saric
4d12c36cf8
Align custom spending cap Max button in approve screen for multiple languages (#16927) 
* Align custom spending cap Max button in approve screen for multiple languages

* Modify some css styles and adding Box props

* Using ButtonLink component instead of <button/>

Co-authored-by: Brad Decker <bhdecker84@gmail.com>
 2023-01-04 22:31:52 +05:30
Vladimir Saric
23653f4c08
Added unit tests and story for SignatureRequestData component (#16759) 2023-01-04 09:31:23 -06:00
Frederik Bolding
05d50eee73
Improve SignatureRequest performance (#17052) 
* Improve SignatureRequestData performance

* Memoize more selectors
 2022-12-22 16:37:51 -03:30
HowardBraham
b9d9112b97
Prevent account name collisions (#16752) 
* dealt with most of the problems in the Create Account dialog

* Fixed "newAccountNumberName" localizations

* In another language, don't allow accounts named, for instance, Cuenta 3

* Editing an account name later now follows the same rules

* Fixing lint errors

* Responding to the review by @adonesky1

* Worked with @montelaidev to alter the RegExp, in order to catch spaces before and after the account name

* Fixed line breaks for eslint
 2022-12-22 11:27:31 -06:00
Daniel
2832f8a97e
Update quote selection for Optimism (#16998) 2022-12-21 20:59:34 +01:00
Nidhi Kumari
f8881a01db
AvatarWithBadge Housekeeping (#16985) 
* updated classnames

* updated readme and tests for avatar with badge

* updated constants in root

* replacing BADGE_POSITIONS with AVATAR_WITH_BADGE_BADGE_POSITIONS
 2022-12-22 00:36:40 +05:30
Ariella Vu
25e9184d9a
i18n: fix missing locale for "en" error (#17014) 
on locale change
 2022-12-22 00:31:06 +07:00
Alex Donesky
1a842aabb6
Replace eth-optimism/contracts package with local snippet of gas price ABI and address (#16891) 2022-12-20 14:05:07 -06:00
amerkadicE
362497ed64
Track when token balance is changed to update value on approval screen (#16964) 
* Track when token balance is changed to update value on approval screen

* Code refactor

* Fix unit test

* Fix sign approval balance

* Refactor code
 2022-12-20 09:24:28 -03:30
Frederik Bolding
7e7a0f1f72
[FLASK] Use custom UI for transaction insights (#16912) 
* Allow custom UI for transaction insights

* Fix margin

* Small fixes to CSS and selectors

* Rename property

* Fix E2E locally

* Bump test-snaps

* Bump test-snaps
 2022-12-20 11:44:49 +01:00
Guillaume Roux
85f260c22d
[FLASK] Use custom UI for dialogs (#16973) 
* update dialog templates to use custom UI

* add TODO comments

* Fix showDialog hook and destructuring

* Regen LavaMoat policies

* Re-add legacy snap confirmation for now

* Fix circular dependency issue

* Revert change to token-util

* Fix lint

Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
 2022-12-20 11:44:22 +01:00
Olusegun Akintayo
13de51e748
Security and Privacy Settings Re-org (#16756) 2022-12-19 18:46:36 +01:00
Dan J Miller
22fc60a341
Show user the general contract interaction screen for token approvals, when the asset standard is undefined (#16765) 
Co-authored-by: Jyoti Puri <jyotipuri@gmail.com>
 2022-12-19 13:38:28 -03:30
legobeat
204f39ef12
ui: make settings search regex range explicit (#16903) 
* ui: make settings search regex range explicit

- Addresses CodeQL advisory #31
- Removes `][^ as valid characters

* ui: settings-search: ignore leading/trailing whitespace
 2022-12-17 05:28:13 +09:00
Dan J Miller
074c2934fe
remove warning on revoke approval for all nfts (#16953) 
Co-authored-by: EresDev <eresdev@hotmail.com>
 2022-12-16 22:37:18 +05:30
dragana8
d2f8083d64
Fix insufficient currency buy or receive error message (#16979) 2022-12-16 10:17:01 -06:00
Ariella Vu
462e5faab5
Fix token balance precision on confirm token approval page from soon-to-be-deprecated token allowance flow (#16934) 
* ConfirmToken: fix token balance onboarding v1
this UI/UX should be deprecated following PR#16740, maybe v10.25

* TokenApproval: use precision for token balance

* EditApproval: calc utilizing existing util
 2022-12-16 22:20:05 +07:00
George Marshall
09d29ef00d
Renaming broken stories to clean up console (#16905) 
* Renaming broken stories. Fixing deprecated default arg syntax for stories using defaultValue

* Fixing imports
 2022-12-15 14:46:30 -08:00
legobeat
1acb1b2e5d
Refactor password validation (#16902) 
* ui: add common constant PASSWORD_MIN_LENGTH=8

* ui: simplify password validation logic

* ui: getPasswordStrengthLabel using t from context

Co-authored-by: Alex Donesky <adonesky@gmail.com>
 2022-12-15 20:56:27 +00:00
Garrett Bear
4ba081a096
add text directions (#16901) 
* add text directions

* add text direction test

Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
 2022-12-15 10:49:47 -08:00
Nidhi Kumari
88af4b3c36
Avatar Token HouseKeeping (#16662) 
* Avatar Token HouseKeeping

* updated props

* fixed indentation and avatar size

* fixed lint issues

* updated sizes

* fixed alignment of avatar token halo stories

* updated story for src

* updated avatar token

* updated README

* updated Readme
 2022-12-15 22:59:24 +05:30
Nidhi Kumari
4fcbaae32f
housekeeping for avatar network (#16663) 
* added housekeeping for avatar network

* fixed alt

* updated story in Readme

* fixed indentation and added network src

* updated SIZES for avatar network

* updated snapshot

* updated docs and props

* updated name of avatar

* removed comments

* updated avatar network component

* updated readme

* updated story for badge

* added constants to the root
 2022-12-15 22:58:42 +05:30
Nidhi Kumari
df73d1887d
added goerli and sepolia inverse colors (#16928) 
* added goerli and sepolia inverse colors

* updated story

* removed duplication of args

* updated colors in root
 2022-12-15 22:58:30 +05:30
Dan J Miller
0792e4ebbc
Recipient name passed to confirm-page-container component should be u… (#16961) 
* Recipient name passed to confirm-page-container component should be used if pet name exists for the to address

* Ensure recipient edit/add popup is shown for non-owned accounts

* Ensure contract name is rendered if it exists for recipient address

* Ensure that shortened address is last fallback after account, addressbook, token and ens names
 2022-12-15 13:03:59 -03:30
David Walsh
43adc60956
Onboarding: Set SeedPhraseBackedUp when appropriate (#16875) 
* Onboarding: Set SeedPhraseBackedUp when appropriate

* Dispatch setSeedPhraseBackedUp

* Fix test

* Make call async

* Fix test

* Fix test

* enhance test

Co-authored-by: Alex <adonesky@gmail.com>
 2022-12-15 08:38:15 -06:00
Alex Donesky
9dd30a0ac6
add back error when password is too short (#16876) 2022-12-14 19:20:55 -06:00
Frederik Bolding
13e4d3054b
[FLASK] Fix race condition with transaction insights (#16956) 
* Fix race condition with transaction insights

* Rename variable
 2022-12-14 19:50:23 +01:00
Alex Donesky
5d285f7be5
fix cached detected token results (#16866) 2022-12-14 12:26:08 +05:30
Alex Donesky
c76453d6cb
fix issue where final onboarding pages are not show (#16943) 2022-12-14 12:19:52 +05:30
Jyoti Puri
929dfbfd21
Fix onboarding V2 Install complete page (#16941) 2022-12-13 15:44:08 -06:00
Jyoti Puri
dc5a9f967d
ButtonIcon: fix react component proptype (#16942) 2022-12-13 15:23:39 -06:00
Alex Donesky
6a23dcc68a
remove the ability to navigate back into the onboarding flow after completing onboarding (#16916) 
* fix issue when navigating back into the onboarding flow after completing onboarding

* disable navigating back into the onboarding flow

* lint

* fix test

* lint
 2022-12-13 12:08:28 -06:00
Daniel
a6da5fd4c3
Add Optimism's L1 fee for an approval tx into total L1 fee in Swaps (#16929) 2022-12-13 18:28:05 +01:00
Frederik Bolding
659063b335
[FLASK] Allow Snaps UI to use Markdown for text formatting (#16911) 
* Allow Snaps UI to use Markdown for text formatting

* Fix yarn audit and dedupe errors

* Update LavaMoat policies

* Fix lint

* Add paragraph wrapper component

* Fix lint
 2022-12-13 15:37:20 +01:00
Vladimir Saric
11f24deef6
Added reject transactions modal to be present in the footer of the approve screen (#16832) 
* Added reject transactions modal in the footer

* Use Button component for multiple unapproved tx
 2022-12-13 13:33:35 +01:00
Jyoti Puri
9a4739c813
User should be able to search setting to batch account balance request (#16887) 2022-12-12 20:35:21 +05:30
David Walsh
dcffa4c7bc
Fix #16804 - Onboarding - Prevent odd behavior with clicks and show/hide password (#16878) 2022-12-12 08:36:02 -06:00
Frederik Bolding
5cca4b9b44
[FLASK] Fix a crash that occurred after a snap confirmation had been approved (#16864) 
* Fix a crash that occurred after a snap confirmation had been approved

* Fix lint

* Move code below early return
 2022-12-12 12:32:31 +01:00
David Walsh
7a1f75d17f
Fix #16852 - Update support link for BETA (#16853) 2022-12-09 08:01:40 -06:00
Frederik Bolding
c75d2dce55
[FLASK] Implement Snaps UI Renderer (#16605) 
* Start implementation of Snaps UI Renderer

* Add snap name and fix some design issues

* Fix lint

* Add some types

* More fixes

* Actually install snaps-ui

* Use JS instead of TS

* Remove unused deps

* Remove dep

* Update LavaMoat policies

* Fix style lint

* Add story

* Small tweaks after rebase

* Remove spacer and add test

* Fix lint

* Remove console.log

* Add error message

* Remove edge-case that doesnt exist anymore

* Update yarn.lock

* Update policy
 2022-12-09 13:05:31 +01:00
Bowen Sanders
7e7be2769d
[FLASK] Create E2E test for tx-insights (#16785) 
* Created an E2E test for tx-insights.

Co-authored-by: Guillaume Roux <guillaumeroux123@gmail.com>
 2022-12-08 12:15:59 -08:00
Jyoti Puri
8125473dc5
Removing flag for EIP1559 V2 support (#16446) 2022-12-09 00:07:06 +05:30
Nidhi Kumari
52304d7910
housekeeping for tag url (#16723) 
* housekeeping for tag url

* updated docs for tag url

* updated docs for tag url

* updated tag url component

* updated stories

* updated label

* Some small updates

* Updating test to catch failed propType

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
 2022-12-08 23:57:00 +05:30
Garrett Bear
c9560b75f2
add avatar icon component (#16755) 
* add avatar icon component

* add avatar icon severities

* avatar icon docs

* update tests and remove stylesheet

* aria label

* remove aria label

* update test

* remove aria label

* iconName prop type string

* Update ui/components/component-library/avatar-icon/README.mdx

Co-authored-by: George Marshall <george.marshall@consensys.net>

* Update ui/components/component-library/avatar-icon/README.mdx

Co-authored-by: George Marshall <george.marshall@consensys.net>

* Update ui/components/component-library/avatar-icon/avatar-icon.js

Co-authored-by: George Marshall <george.marshall@consensys.net>

* Update ui/components/component-library/avatar-icon/avatar-icon.stories.js

Co-authored-by: George Marshall <george.marshall@consensys.net>

* marginSizeControlOptions

Co-authored-by: George Marshall <george.marshall@consensys.net>
 2022-12-08 10:25:19 -08:00
David Walsh
7d3b1d08da
NFTs: Update COLLECTIBLES_V1 to NFTS_V1 (#16851) 2022-12-08 11:37:47 -06:00
David Walsh
43c278d813
Privacy - Show default selected network after a custom network has been added during onboarding (#16789) 
* Privacy - Allow users to set a custom RPC from the onboarding process (#16767)

* Privacy - Allow adding custom IPFS from onboarding (#16782)

* Privacy - Show default selected network after a custom network has been added during onboarding

* WIP: Show dropdown list of networks

* Add network switcher to the onboarding advanced privacy screen

* Fix duplicate imports

* Provide default for networks

* Update ui/helpers/utils/ipfs.js

Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>

* Fix lint

* Remove unwanted changes

* Fix lint

Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
 2022-12-08 10:42:23 -06:00
Pedro Figueiredo
3a456a45fc
fix locales for advance config (#16849) 2022-12-08 14:20:59 +00:00
ryanml
a759d427f0
Remove new address alert (#14811) 
* Removing new address alert

* remove unused copy

* fix broken e2e test

* rework layout nesting

* satisfy lint

* change layout to fix firefox tests

* change selector specificity on e2e test

* revert test change after fix has been merged from develop

* fix linting

Co-authored-by: Brad Decker <bhdecker84@gmail.com>
Co-authored-by: Pedro Figueiredo <pedro.figueiredo@consensys.net>
 2022-12-08 14:20:24 +00:00
David Walsh
ead5076b86
Privacy - Update metametrics copy during onboarding (#16825) 2022-12-07 12:56:57 -06:00
Filip Sekulic
ddcaaf3e8d
Allow transactions with gas price or priority fee 0 (#16651) 2022-12-07 09:10:10 -06:00
amerkadicE
8885c54f13
NFT setApprovalForAll warning popover (#16195) 
* NFT setApprovalForAll  warning popover
 2022-12-06 14:24:07 -06:00
George Marshall
5592bc5fff
TextField house keeping 🧹 (#16668) 
* TextField house keeping updates

* ButtonIcon prop name update and uncontrolled fix

* Updating snapshot
 2022-12-06 11:52:03 -08:00
George Marshall
971f153e65
TextFieldBase house keeping 🧹 (#16667) 
* TextFieldBase house keeping updates

* Fixing story

* Updating custom input story

* Updating ButtonIcon props and lint issues

* Updating snapshots
 2022-12-06 11:51:48 -08:00
Thomas Huang
8fde322907
Continue converting tests from enzyme to @testing-library/react (#16753) 2022-12-06 10:49:08 -06:00
Sailer43
1e173afc95
Fixed NumericInput Storybook Components (#16734) (#16737) 
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
Fixed https://github.com/MetaMask/metamask-extension/issues/16703
Fixes https://github.com/MetaMask/metamask-extension/issues/16703
 2022-12-06 10:48:55 -06:00
Daniel
7f50febfcd
Ensure 0% slippage on Arbitrum for wrapping / unwrapping (#16778) 
* Contract addresses to lowercase

* Use case insensitive checks in the shouldEnableDirectWrapping fn

* Remove duplicated functions, move unit tests into the right location
 2022-12-06 10:44:09 -06:00
Filip Sekulic
c3f329cc80
Transaction security provider feature flag (#16776) 2022-12-06 11:43:53 -03:00
Dan J Miller
2434c435b4
Fix getFullTxData so that customTxParamsData is not lost (#16805) 
Co-authored-by: Pedro Figueiredo <ganseki.figueiredo@gmail.com>
 2022-12-05 16:04:06 -03:30
Vladimir Saric
9ede85c9ac
Updated secondary copy and removed the address component from SetApprovalForAll and NFT Approve screens (#16292) 2022-12-05 10:59:15 -06:00
Vladimir Saric
40cba69128
Removed Confirm and Cancel events as they are not triggered anymore (#16777) 2022-12-03 09:59:55 -06:00
Brad Decker
f7014a79fc
remove network name from analytics (#16781) 2022-12-03 09:57:48 -06:00
Alex Donesky
f162c58f5a
Allow adding networks with the same chainId as a preloaded/default network via wallet_AddEthereumChain API (#16733) 
* allow adding networks with the same chainId as an existing network via API

Co-authored-by: Kurush Dubash <kurush@alchemyapi.io>
 2022-12-02 21:14:27 -06:00
Alex Donesky
05ab94fd1c
Add security & privacy "What's New" message (#16783) 2022-12-02 17:59:41 -06:00
amerkadicE
702cab5fa7
Add user guidance on signature request screen (#16600) 2022-12-02 08:12:43 -06:00
George Marshall
3deb8734ac
TextFieldSearch house keeping updates (#16669) 2022-12-01 13:48:53 -08:00
Pedro Figueiredo
d096560d85
Give the user ability to opt out of get balance batch request for all loaded accounts (#16746) 2022-12-01 21:16:04 +00:00
Garrett Bear
6689f8b71d
Feat/16634/buttonicon housekeeping (#16666) 
* rename iconName prop

* pixel update

* updates to iconProps

* arialabel to stories
 2022-12-01 09:26:31 -08:00
Garrett Bear
1007930078
Feat/16187/text housekeeping (#16589) 
* text housekeeping

* update testing

* Text constant

* TEXT const to story

* format text sizes

* add associated constants to text component

* add all exports to global index.js

* update snapshot

* update text component variants

* Update ui/components/component-library/text/README.mdx

Co-authored-by: George Marshall <george.marshall@consensys.net>

* update rearrangements

* update text in tests

Co-authored-by: George Marshall <george.marshall@consensys.net>
 2022-12-01 09:26:19 -08:00
Erik Marks
a861cc6dae
[FLASK] Add snap alerts and prompts via snap_dialog RPC method (#16048) 
Co-authored-by: Guillaume Roux <guillaumeroux123@gmail.com>
Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
 2022-12-01 16:46:06 +01:00
Frederik Bolding
025ee2cb48
[FLASK] Expose transaction origin to transaction insight snaps (#16671) 
* Expose transaction origin to transaction insight snaps

* Support multiple icons for each label for a permission

* Add transaction insight origin permission

* Fix fencing

* Fix import and permission crash

* Use function properly for connected accounts
 2022-12-01 14:38:56 +01:00
amerkadicE
80e4a1fef4
Update signature request screens (#15776) 
Fix e2e test

Update siteicon for v4 signature type

Code refactor

Code refactor

Remove origin and address in signatrue request

Update e2e tests

Use getNetworkName function

Move header component inline jsx

Update snaps
 2022-11-30 19:11:36 +01:00
Brad Decker
b3895b6840
remove rpc urls from metrics (#16710) 2022-11-30 09:52:25 -06:00
amerkadicE
dd0844e200
Add signature request warning modal (#16225) 
* Add signature request warning modal

Fix e2e tests

Fix e2e tests

Remove warning message from eth sign request

Remove unused locales

Fix e2e test

Fix e2e test

* Run pipeline

* Fix locales:
?

* Add unit tests
 2022-11-30 16:34:50 +01:00
amerkadicE
08ddd4fb0c
Show account name when qr scan in send screen (#16204) 
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
 2022-11-30 09:24:28 -06:00
Bowen Sanders
0e1c385cd0
[FLASK] Create E2E test for snap management (#16628) 
* added management test

* added id and dismiss alert function

* changed xwindow handling

* fixed linting
 2022-11-30 14:12:09 +01:00