Erik Marks
413700afc7
Rationalize build system arguments ( #12047 )
...
This rationalizes how arguments are passed to and parsed by the build system. To accomplish this, everything that isn't an environment variable from `.metamaskrc` or our CI environment is now passed as an argument on the command line.
Of such arguments, the `entryTask` is still expected as a positional argument in the first position (i.e. `process.argv[2]`), but everything else must be passed as a named argument. We use `minimist` to parse the arguments, and set defaults to preserve existing behavior.
Arguments are parsed in a new function, `parseArgv`, in `development/build/index.js`. They are assigned to environment variables where convenient, and otherwise returned from `parseArgv` to be passed to other functions invoked in the same file.
This change is motivated by our previous inconsistent handling of arguments to the build system, which will grow increasingly problematic as the build system grows in complexity. (Which it will very shortly, as we introduce Flask builds.)
Miscellaneous changes:
- Adds a build system readme at `development/build/README.md`
- Removes the `beta` package script. Now, we can instead call: `yarn dist --build-type beta`
- Fixes the casing of some log messages and reorders some parameters in the build system
2021-09-09 12:44:57 -07:00
Erik Marks
76a2a9bb8b
@metamask/eslint config@5.0.0 ( #10358 )
...
* @metamask/eslint-config@5.0.0
* Update eslintrc and prettierrc
* yarn lint:fix
2021-02-04 10:15:23 -08:00
Brad Decker
2ebf8756a4
[RFC] add prettier to eslint ( #8595 )
2020-11-02 17:41:28 -06:00
Whymarrh Whitby
b6ccd22d6c
Update ESLint shared config to v3 ( #9274 )
...
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
2020-08-19 13:57:05 -02:30
Whymarrh Whitby
2ae4720443
Fix words ( #9038 )
2020-07-20 14:32:49 -02:30
Whymarrh Whitby
983e32274c
Fix array-callback-return issues
...
See [`array-callback-return`](https://eslint.org/docs/rules/array-callback-return ) for more information.
This change enables `array-callback-return` and fixes the issues raised by the
rule.
2020-07-17 16:03:33 -02:30
Whymarrh Whitby
4f0a205369
Use eslint@6.8.0 ( #8978 )
...
* Use eslint@6.8.0
* yarn lint:fix
2020-07-14 12:50:41 -02:30
kumavis
7686edadb0
Build system refactor ( #8140 )
...
* build - start static asset task cleanup
* build - simplify manifest tasks
* build - refactor + rename some tasks
* build - various cleanups
* manifest - fix ref from controller
* build - drop gulp for simple async tasks
* build - breakout gulpfile into multiple files
* build - rename some tasks
* build - use task fn refs instead of string names
* build - bundle all scripts first, except for contentscript
* build - improve task timeline
* deps - update lock
* build - improve task time printout
* build/scripts - remove intermediate named task
* build - use 'yarn build' for task entry points
* build - properly run tasks via runTask for timeline display
* development/announcer - fix manifest path + clean
* build - lint fix
* build - make all defined tasks possible entry points
* build/task - properly report errors during task
* ci - fix sesify/lavamoat-viz build command
* build/scripts - run each bundle in separate processes
* lint fix
* build - forward childProcess logs to console
* build/task - fix parallel/series stream end event
* build/scripts refactor contentscript+inpage into a single task
* build/static - use the fs for 150x speedup zomg
* lint fix
* build/static - fix css copy
* Update development/build/scripts.js
Co-Authored-By: Mark Stacey <markjstacey@gmail.com>
* Update development/build/scripts.js
Co-Authored-By: Mark Stacey <markjstacey@gmail.com>
* Update development/build/index.js
Co-Authored-By: Mark Stacey <markjstacey@gmail.com>
* deps - remove redundant mkdirp
* deps - remove unused pumpify
* deps - remove redundant merge-deep
* deps - prefer is-stream of isstream
* deps - remove clone for lodash.cloneDeep
* clean - remove commented code
* build/static - use fs.copy + fast-glob instead of linux cp for better platform support
* build/manifest - standardize task naming
* build/display - clean - remove unused code
* bugfix - fix fs.promises import
* build - create "clean" as named task for use as entrypoint
* build/static - fix for copying dirs
* Update development/build/task.js
Co-Authored-By: Mark Stacey <markjstacey@gmail.com>
* Update development/build/display.js
Co-Authored-By: Mark Stacey <markjstacey@gmail.com>
* Update development/build/display.js
Co-Authored-By: Mark Stacey <markjstacey@gmail.com>
* Update development/build/display.js
Co-Authored-By: Mark Stacey <markjstacey@gmail.com>
* build - use task refs, tasks only return promises not streams, etc
* lint fi bad merge + lint
* build - one last cleanup + refactor
* build - add comments introducing file
* build/manifest - fix bug + subtasks dont beed to be named
* Update package.json
Co-Authored-By: Mark Stacey <markjstacey@gmail.com>
* build/task - remove unused fn
* Update package.json
Co-Authored-By: Mark Stacey <markjstacey@gmail.com>
* Update development/build/styles.js
Co-Authored-By: Mark Stacey <markjstacey@gmail.com>
* Update development/build/styles.js
Co-Authored-By: Mark Stacey <markjstacey@gmail.com>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
2020-03-09 08:55:02 +08:00
