1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-11-23 02:10:12 +01:00
Commit Graph

59 Commits

Author SHA1 Message Date
Mark Stacey
dadda918b4
Update code owners of manifest and lockfile (#6953) 2019-08-02 17:44:00 -02:30
Mark Stacey
1fd3dc9ecf
Switch from npm to yarn (#6843)
As a solution to the constant lockfile churn issues we've had with
`npm`, the project now uses `yarn` to manage dependencies.

The `package-lock.json` file has been replaced with `yarn.lock`, which
was created using `yarn import`. It should approximate the contents of
`package-lock.json` fairly well, though there may be some changes due to
deduplication. The codeowners file has been updated to reference this
new lockfile.

All documentation and npm scripts have been updated to reference `yarn`
rather than `npm`. Note that running scripts using `npm run` still works
fine, but it seemed better to switch those to `yarn` as well to avoid
confusion.

The `npm-audit` Bash script has been replaced with `yarn-audit`. The
output of `yarn audit` is a bit different than `npm audit` in that it
returns a bitmask to describe which severity issues were found. This
made it simpler to check the results directly from the Bash script, so
the associated `npm-audit-check.js` script was no longer required. The
output should be exactly the same, and the information is still sourced
from the same place (the npm registry).

The new `yarn-audit` script does have an external dependency: `jq`.
However, `jq` is already assumed to be present by another CI script, and
is present on all CI images we use. `jq` was not added to `package.json`
as a dependency because there is no official package on the npm
registry, just wrapper scripts. We don't need it anywhere exept on CI
anyway.

The section in `CONTRIBUTING` about how to develop inside the
`node_modules` folder was removed, as the advice was a bit dated, and
wasn't specific to this project anyway.
2019-07-30 15:36:23 -03:00
Dan Finlay
91cda027c9 Add Mark Stacey (Kyokan) to UI CodeOwners (#6798) 2019-07-03 22:34:44 -02:30
Whymarrh Whitby
c70ef95338 Add codeowner for package*.json files 2019-06-21 05:50:06 -02:30
Whymarrh Whitby
b4e7e0ec0f
Update UI codeowners 2019-01-30 10:32:04 -03:30
bobby dresser
da0510809b encourage stackexchange in issue templates (#5737) 2018-11-13 13:54:03 -03:30
bobby dresser
438fd5bce0
remove duplicate template (#5016) 2018-08-09 10:48:10 -07:00
bobby dresser
6fb790e9a8
Create issue templates (#4972)
adds issue templates
2018-08-09 10:09:33 -07:00
Dan Finlay
c3c0193a64 Added codeowners file 2018-07-17 20:14:53 -07:00