Paul Bouchon
45a9f40aa6
bugfix: normalize contract addresss when fetching exchange rates ( #5863 )
2018-11-30 11:52:00 -05:00
Dan Finlay
c7233e2cc7
Fixed Vivek's bug ( #5860 )
...
* Fixed Vivek's bug
Fixes #5850
What was happening:
It seems that his MetaMask had crashed while some new transactions had
been loading defaults. He probably had a network connectivity issue to
Infura (which we are working with Infura to address).
As a result of this network cutout, his three unapproved transactions
were not marked failed, and were not marked as `loadingDefaults =
false`, as their gas prices had not yet been estimated.
Normally this behavior is supposed to clean itself up when the
transaction controller starts up, via the
`TransactionController._onBootCleanUp()` function, but in this case,
during unlock, that function was unable to do its job because when it
requested the transaction list, the current network was in the `loading`
state, making it proceed as if there were no pending transactions.
To fix this, I am doing two things:
- Setting transactions to loadingDefaults = false in more catch blocks.
- Calling `onBootCleanUp()` when the network store's status changes, so
that it will re-trigger when loading completes.
* Fixed reference
* Fixed infinite loop bug
Was refreshing the tx list on every tx state change instead of just
network changes, creating an infinite loop.
* Add notes to tx updates to clarify logs
2018-11-29 16:08:03 -08:00
Frankie
a803522a92
transactions/tx-gas-utils - add the acctual response for eth_getCode for NO_CONTRACT_ERROR's && add a debug object to simulationFailed ( #5840 )
2018-11-29 10:07:05 -08:00
Whymarrh Whitby
67d9f445bd
Merge pull request #5848 from MetaMask/Less-Certain-Language
...
Soften accusatory language on phishing warning
2018-11-28 15:44:36 -03:30
Dan Finlay
ac1b756bd0
Soften accusatory language on phishing warning
...
We don't always know for sure that sites marked as phishers are
defiitely scams, and so we should avoid language that makes concrete
accusations.
2018-11-28 08:35:03 -08:00
Whymarrh Whitby
a9d3c1a87d
Open full-screen UI on install
2018-11-27 09:52:51 -03:30
Whymarrh Whitby
3e85d580f9
Revert "Don't open MetaMask website after install"
2018-11-27 08:50:54 -03:30
Frankie
8198ec9ae1
Autofill gasPrice for retry attempts with either the recommended gasprice or a %10 bump ( #5786 )
...
* transactions - autofill gasPrice for retry attempts with either the recomened gasprice or a %10 bump
* lint
2018-11-26 09:29:14 -10:00
Frankie
97c1e6bcc1
transactions - ensure err is defined when setting tx failed ( #5801 )
2018-11-26 09:00:58 -10:00
Bruno Barbieri
3b1e73eff8
Merge pull request #5792 from MetaMask/signed-type-data-error-hw-wallet
...
Consider HW Wallets for signTypedMessage
2018-11-26 13:40:04 -05:00
Bruno Barbieri
f2066432ba
Use Array.includes
2018-11-26 13:27:49 -05:00
Whymarrh Whitby
08c98a6df7
Show Connect Requests count in extension badge
2018-11-26 12:09:22 -03:30
Whymarrh Whitby
826eb82ed8
Use initState to avoid type-checking providerRequests in state
2018-11-26 12:06:17 -03:30
Bruno Barbieri
ae8626eceb
Merge pull request #5797 from MetaMask/trezor-v6
...
Add Firefox and Brave support for Trezor
2018-11-21 14:45:55 -05:00
brunobar79
9b1df386de
fix merge conflicts
2018-11-20 17:44:28 -05:00
brunobar79
fb94c1bae7
remove extra semicolon
2018-11-20 12:57:58 -05:00
brunobar79
3abf9ec7db
consider hw wallets
2018-11-20 12:48:43 -05:00
Whymarrh Whitby
444c68ae53
Don't announce new UI to users switching back
2018-11-20 14:04:50 -03:30
Whymarrh Whitby
c482c9926c
Default to the new UI for first time users
2018-11-20 14:04:17 -03:30
Paul Bouchon
7fe37276a1
1102: Push publicConfigStore to next turn to avoid race conditiono ( #5777 )
2018-11-18 07:23:04 -05:00
Dan Finlay
fdea642e6d
Auto fail transactions that have been approved for over 12 hours ( #5765 )
...
* Auto fail transactions that have been approved for over 12 hours
Converts txs using a migration.
This migration uses a new helper function that generates tx-failing
migrations, and only requires a version, error message, and condition to
run on each transaction.
* Linted
* Only migrate approved txs to failed
* Cleanup
* Cleanup
* Small lint fixes
2018-11-16 21:27:01 -08:00
Whymarrh Whitby
1988e1e96b
ESLint fixes ( #5775 )
...
* eslint . --fix
* Upgrade all ESLint warnings to errors
2018-11-16 14:54:55 -10:00
Frankie
ce147bf6d8
Tx controller now uses safe event emitter ( #5769 )
...
* transactions - use safe-event-emitter over events
* tests - pass a platform object on init with a noop showTransactionNotification
* test - fix for tx-state-history-helper trying to reduce an empty array
* deps - safe-event-emitter
* lint
2018-11-16 10:34:08 -08:00
brunobar79
e44b750f0f
Merge branch 'develop' of github.com:MetaMask/metamask-extension into trezor-v5
2018-11-15 00:29:06 -05:00
Dan Finlay
22ba0b0c2d
Resubmit approved transactions on new block ( #5752 )
...
* Add beginning of test
* Resubmit approved transactions on new block
May fix #4343 and related issues, where an error could leave
transactions stranded in the approved state.
* Remove unused test
* Re-approve transactions when retrying approved
* Add retry approved test
* Include approved in pending tx count
* Fix getPendingTxs()
* Linted
* Only throw hash error in submitted state
* Only check submitted txs for block inclusion
* Fix test expectations
2018-11-14 11:34:07 -10:00
brunobar79
18f39ef69e
Merge branch 'develop' of github.com:MetaMask/metamask-extension into trezor-v5
2018-11-14 15:42:45 -05:00
Paul Bouchon
f6e042b7b1
1102: use meta title if it exists before title
2018-11-14 10:43:10 -08:00
brunobar79
484aa6801e
Merge branch 'develop' into trezor-v5
2018-11-13 17:21:15 -05:00
Paul Bouchon
0549782595
Update Balanc3 API ( #5744 )
...
* Update balanc3 API used in TokenRatesController
* Remove demo URL and use nativeCurrency when fetching token rates
2018-11-13 14:57:43 -05:00
PaddyMc
7ce2cf4572
Fixes #3425 : Better support for batch transactions ( #5437 )
2018-11-13 13:49:12 -03:30
Paul Bouchon
c317624854
EIP-1102: Update publicConfig store concurrently with approval
2018-11-09 18:21:59 -08:00
Noah I
8bed073f20
1102: Fix inpage listener syntax ( #5708 ) ( #5709 )
2018-11-09 07:14:32 -05:00
bitpshr
718393f89a
Cleanup
2018-11-07 08:47:25 -08:00
bitpshr
a224b71837
1102: use postMessage instead of injected scripts to bypass CSP
2018-11-07 08:47:25 -08:00
bitpshr
1ce3591c8e
wip
2018-11-07 08:47:25 -08:00
brunobar79
c651212025
fix merge conflicts
2018-11-06 20:21:19 -05:00
bitpshr
896ae0ab89
Fix lint errors
2018-11-06 14:30:50 -05:00
bitpshr
d7b1cacabc
Remove injected script tags after use
2018-11-06 14:26:02 -05:00
bitpshr
34d80f21e2
Clear cached approval after rejection
2018-11-06 14:13:27 -05:00
bitpshr
b3f428fd1f
Move experimental provider augmentation
2018-11-05 15:07:09 -08:00
bitpshr
879997af51
Add experimental RPC method support
2018-11-05 15:07:09 -08:00
Whymarrh Whitby
26ada8a828
Update Connect Request screen design ( #5644 )
...
* Parameterize NetworkDisplay background colour
* Update design for login request screen
* Pass siteTitle, siteImage through for calls to ethereum.enable()
* Bring the site images closer together
2018-11-05 15:07:09 -08:00
bitpshr
31cb111d2e
Do not modify isApproved when locked
2018-11-05 15:07:09 -08:00
bitpshr
9984f7edeb
Mark origins as unapproved if user explicitly locks MetaMask
2018-11-05 15:07:09 -08:00
Paul Bouchon
f557d33718
Enable caching
2018-11-05 15:07:09 -08:00
bitpshr
991e08e346
isApproved should return false
2018-11-05 15:07:09 -08:00
bitpshr
72730b3929
Remove internal listeners
2018-11-05 15:07:09 -08:00
bitpshr
cc27a09a1a
rebase
2018-11-05 15:07:09 -08:00
bitpshr
d4171ccea5
Disable approval caching
2018-11-05 15:07:09 -08:00
bitpshr
cc1bab6ebb
Differentiate locked and enabled
2018-11-05 15:07:09 -08:00
bitpshr
d7618bd5c6
Code bath
2018-11-05 15:07:09 -08:00
bitpshr
ba40fcbcb4
Handle logout gracefully
2018-11-05 15:07:09 -08:00
bitpshr
f02e18dd80
Fix lint issues
2018-11-05 15:07:09 -08:00
bitpshr
ace7cfa065
Only filter selectedAddress from publicConfig store
2018-11-05 15:07:09 -08:00
bitpshr
f35466a247
Fix race condition with publicConfigStore
2018-11-05 15:07:09 -08:00
bitpshr
32630b68df
Move convenience methods to _metamask namespace
2018-11-05 15:07:09 -08:00
bitpshr
504f4a50f1
Fix lint issues
2018-11-05 15:07:09 -08:00
bitpshr
84874a639d
Add isUnlocked provider hook
2018-11-05 15:07:09 -08:00
bitpshr
573139b935
Differentiate isEnabled and isApproved hook
2018-11-05 15:07:09 -08:00
bitpshr
3a2ade4e84
Update isEnabled check
2018-11-05 15:07:09 -08:00
bitpshr
226601a956
EIP-1102: add user privacy option
2018-11-05 15:07:09 -08:00
bitpshr
bfcb73ad53
EIP-1102: add isEnabled convenience method to provider
2018-11-05 15:07:09 -08:00
bitpshr
89b4aa5d62
EIP-1102: Add option to force-enable provider
2018-11-05 15:07:09 -08:00
bitpshr
c76c9ca2c8
EIP-1102: updated implementation
2018-11-05 15:07:09 -08:00
kumavis
86f09e6bb5
network - infura - hardcode net_version and eth_chainId ( #5670 )
...
* network - infura - hardcode net_version and eth_chainId
* network - infura - add rinkeby handling
* lint fix
2018-11-05 14:13:37 -05:00
Esteban Miño
4489a57f2f
Update watchAsset ERC20 validation ( #5653 )
...
* update ERC20 token valodation for watchAsset
* update ERC20 validation test descriptions
2018-11-05 15:36:34 -03:30
kumavis
14852669ac
Merge pull request #5659 from MetaMask/token-rates-bugfix
...
token-rates - protect against bad token data
2018-11-03 21:57:21 -04:00
Thomas Huang
ed4f612bdc
Revert "support eth_chainId"
2018-11-03 14:21:41 -07:00
kumavis
2c1bca1ab0
token-rates - protect against bad token data
2018-11-02 22:14:40 -04:00
kumavis
73eeeda215
Merge pull request #5560 from MetaMask/sentry-enhancements2
...
Sentry - various enhancements to help debugging (alternate)
2018-10-29 21:57:51 -04:00
kumavis
310229d22e
Merge pull request #5567 from MetaMask/HowardBraham-develop
...
Feature: Warn when attempting to send tx with data to non-contract
2018-10-29 21:47:07 -04:00
kumavis
7ae5a23b6c
Merge branch 'sentry-enhancements2' of github.com:MetaMask/metamask-extension into sentry-enhancements2
2018-10-29 20:28:02 -04:00
kumavis
ccbc233282
Merge branch 'develop' of github.com:MetaMask/metamask-extension into sentry-enhancements2
2018-10-29 20:25:05 -04:00
kumavis
1bb4a8428c
Merge pull request #5596 from MetaMask/validateSignTypedData
...
Validate signTypedData signer/address in eth-json-rpc-middleware
2018-10-29 20:11:04 -04:00
kumavis
ad009a4606
Merge branch 'develop' into sentry-enhancements2
2018-10-29 19:49:53 -04:00
kumavis
18e530221b
Merge pull request #5552 from EthersocialNetwork/eth_chainid
...
network - check eth_chainId and fallback to net_version
2018-10-29 19:43:25 -04:00
kumavis
986f8b4c21
preferences - fix typo
2018-10-29 18:56:29 -04:00
hackyminer
bc7f8d0a5b
Merge branch 'develop' into eth_chainid
2018-10-26 20:37:35 +09:00
HackyMiner
54a8ade266
Add support for RPC endpoints with custom chain IDs ( #5134 )
2018-10-26 10:26:43 +02:00
kumavis
9b42416fc0
Merge branch 'develop' of github.com:MetaMask/metamask-extension into HowardBraham-develop
2018-10-25 22:24:30 -04:00
Thomas
8c0e5e97e5
Add version to unapprovedMessage
2018-10-24 20:24:42 -07:00
Thomas
95b92a1ddc
Remove commented out/unused methods
2018-10-24 20:13:40 -07:00
Thomas
1d65687ce4
Validate signTypedData in eth-json-rpc-middleware
2018-10-24 20:03:55 -07:00
kumavis
6d09f60bbf
ens-ipfs - refactor for readability ( #5568 )
...
* ens-ipfs - refactor for readability
* ens-ipfs - use official ipfs gateway for better performance
* lint - remove unused code
* ens-ipfs - support path and search
* lint - gotta love that linter
* ens-ipfs - improve loading page formatting
* ens-ipfs - loading - redirect to 404 after 1 min timeout
* ens-ipfs - destructure for cleaner code
2018-10-21 05:48:15 -04:00
kumavis
b62d07f3a5
Update network.js
2018-10-21 04:32:07 -04:00
brunobar79
9c1b2108f6
fix merge conflicts
2018-10-21 01:59:53 -04:00
kumavis
b0c649a4e3
Merge pull request #5555 from MetaMask/support-wallet-watch-asset
...
Support for prefix wallet_watchAsset
2018-10-21 01:27:08 -04:00
kumavis
61c7bbb1c1
network - improve logging and type conversion
2018-10-21 01:20:08 -04:00
kumavis
31e5cad1e3
tx-gas-util - set error message when invalidating tx based on tx data but no contract code
2018-10-21 01:01:21 -04:00
kumavis
f0602ca354
Merge branch 'develop' of github.com:MetaMask/metamask-extension into sentry-enhancements2
2018-10-20 23:51:00 -04:00
kumavis
3b46478024
Merge branch 'develop' into develop
2018-10-20 23:48:10 -04:00
kumavis
73ec4e66cb
sentry - include app state in ui errors
2018-10-20 03:14:59 -04:00
kumavis
e3fda83ab2
sentry - replace raven-js with sentry/browser
2018-10-20 02:22:50 -04:00
Esteban Miño
7c4f98ffd6
specific add and remove methods for frequentRpcList ( #5554 )
2018-10-19 17:50:54 -02:30
Esteban MIno
75661673e5
add support for wallet_watchAsset
2018-10-19 13:57:11 -03:00
hackyminer
2f6530a494
support both eth_chainId and net_version
...
get the real chainId using eth_chainId and use net_version as a fallback
2018-10-20 01:08:46 +09:00
kumavis
31175dcb24
blacklist + currency - report error via log instead of throw
2018-10-19 07:18:16 -04:00
kumavis
a57d267dcb
lint fix
2018-10-19 07:08:04 -04:00
kumavis
b85ae55cd5
fetch debugger - only append source stack if no stack is present
2018-10-19 06:42:53 -04:00
kumavis
3e3d4b9dde
sentry - failed txs - namespace txMeta for better readability
2018-10-19 05:30:21 -04:00