Dan Finlay
c431783602
Remove redundant logging block
2016-12-01 10:21:56 -08:00
Dan Finlay
1880cda9b9
Fix vault encrypting & unlocking bug
...
This is only a bug in dev, but was committed yesterday.
Sometimes the `encrypt` method was being passed values other than the password as the encryption key, leading to un-unlockable vaults.
To find this, and avoid it for all time hereafter, I added several more steps to our oft-neglected integration test suite, which now fully initializes a vault, locks it, and unlocks it again, to make sure all of those steps definitely work always.
2016-11-30 19:36:24 -08:00
Dan Finlay
049e351c9d
Add integration tests for logging out and back in
2016-11-30 16:01:51 -08:00
Dan Finlay
fe533bbef2
Add more integration tests
...
Integration tests now:
- Scroll through terms
- Accept terms
- Confirm seed phrase
- Verify account detail screen
2016-11-30 15:18:26 -08:00
Dan Finlay
549bbfd05f
Made integration test create a first vault
2016-11-30 14:58:40 -08:00
Kevin Serrano
5af4157363
Merge pull request #899 from MetaMask/i893-DenodeifyKeyringController
...
Fix incorrect nodeification and add descriptive error to help find in future
2016-11-29 15:59:18 -08:00
Dan Finlay
95bcc21a06
Add useful nodeify error message
...
If a nodified method does not return a Promise, it will throw an error, like this:
```
Error in event handler for (unknown): Error: The function setSelectedAccount did not return a Promise, but was nodeified.
```
2016-11-29 15:54:10 -08:00
Dan Finlay
df0b89074b
Return promise correctly from setSelectedAddress
2016-11-29 15:50:26 -08:00
Kevin Serrano
f8fbeb88ff
Merge pull request #896 from MetaMask/i893-DenodeifyKeyringController
...
Denodeify most of KeyringController
2016-11-29 15:16:24 -08:00
Dan Finlay
5bf1018d75
Flattened addTx async methods
2016-11-29 14:56:58 -08:00
Dan Finlay
ff3f6cc36a
Bind ethQuery to estimateGas to allow it to be moved around.
2016-11-29 14:13:12 -08:00
Dan Finlay
85d5b12f8d
Fix tx adding code
...
Broken in this commit:
bc39cd7b89
2016-11-29 12:46:08 -08:00
Dan Finlay
4b6b1db4f0
Ordered keyringController methods the same in metamask-controller
2016-11-29 12:05:23 -08:00
Dan Finlay
b81f00849d
Annotated KeyringController
2016-11-29 11:40:49 -08:00
Dan Finlay
12906df601
Remove unused dep
2016-11-28 17:27:44 -08:00
Dan Finlay
9d401f9137
Fix nodeify usage
2016-11-28 17:27:28 -08:00
Dan Finlay
9e764b1935
Fix nodeify
2016-11-28 17:27:20 -08:00
Dan Finlay
80e76b45ee
Denodeify most of KeyringController
...
Mostly Fixes #893
A couple methods cache callbacks, and will require a larger refactor to fully denodeify.
Specifically, our methods involving web3 requests to sign a tx, sign a message, and approve or cancel either of those.
I think we should postpone those until the TxManager refactor, since it will likely handle this response caching itself.
2016-11-28 16:13:03 -08:00
Kevin Serrano
da5be09a94
Merge pull request #890 from MetaMask/MergeMasterIntoDev
...
Merge master into dev
2016-11-28 13:22:27 -08:00
Dan Finlay
46bb9558d5
Merge pull request #891 from MetaMask/Version-2.13.11
...
Version 2.13.11
2016-11-28 11:41:07 -08:00
Dan Finlay
44a2f2ad9d
Version 2.13.11
2016-11-23 16:59:48 -08:00
Dan Finlay
b899119582
Merge branch 'master' into dev
2016-11-23 16:54:27 -08:00
Kevin Serrano
b9b3ef8fed
Merge pull request #887 from MetaMask/i865-erabe
...
Modify forgot password flow to go back to init screen.
2016-11-23 15:48:13 -08:00
Kevin Serrano
8dd298238d
Cosmetic changes, rename links.
2016-11-23 15:42:17 -08:00
Kevin Serrano
feae6235cb
Merge pull request #888 from MetaMask/i844-AsyncKeyrings
...
Modify Keyring protocol to always return promises for public methods
2016-11-23 15:31:17 -08:00
Kevin Serrano
3a503d2ac2
Add link back to unlock.
2016-11-23 15:29:42 -08:00
Dan Finlay
9f67974133
Fix last async keyring test
2016-11-23 14:39:35 -08:00
Dan Finlay
d9dc2eac63
Fix more async usage of KeyringController
2016-11-23 14:35:29 -08:00
Kevin Serrano
5a02e58f62
Fix proper behavior for restoring accounts when password forgotten.
2016-11-23 13:49:54 -08:00
Kevin Serrano
5251fb373f
Modify forgot password flow to go back to init screen.
2016-11-23 13:05:02 -08:00
Dan Finlay
230a0ab876
Fix more keyring asyncifying tests
2016-11-23 11:58:34 -08:00
kumavis
323f3cb1a0
Merge pull request #884 from MetaMask/i883-sync-uninstallFilter
...
Add support for sync RPC uninstallFilter
2016-11-23 14:29:21 -05:00
kumavis
36c824889f
changelog - add sync rpc eth_uninstallFilter note
2016-11-23 11:00:48 -08:00
kumavis
c0a2eb146a
rpc - add sync uninstallFilter support
2016-11-23 10:48:20 -08:00
Dan Finlay
600f5c31db
Mostly got async keyringController tests passing
2016-11-23 00:23:41 -08:00
Dan Finlay
c77d355e98
Complete first pass at asyncrhonizing keyring controller
2016-11-22 23:36:11 -08:00
Dan Finlay
2efab79f5b
Asynced keyrings and started on controller
2016-11-22 23:16:36 -08:00
Kevin Serrano
ec8b0148f0
Merge pull request #879 from MetaMask/i843-MoveSaltIntoEncryptor
...
Fix new encryptor implementation
2016-11-22 17:55:22 -08:00
Dan Finlay
05c8658ff3
Fix new encryptor migration logic
2016-11-22 17:41:54 -08:00
Dan Finlay
1e46d858e9
Fix undefined provider menu item
2016-11-22 16:34:02 -08:00
Dan Finlay
822face7a3
Fix password reference
2016-11-22 16:29:46 -08:00
Dan Finlay
427a103083
Merge pull request #878 from MetaMask/i843-MoveSaltIntoEncryptor
...
Simplify Encryptor API Surface
2016-11-22 16:22:31 -08:00
Dan Finlay
6ebdebc0a5
Remove line of cruft
2016-11-22 16:18:18 -08:00
Dan Finlay
93bbe2c60d
Merge pull request #876 from MetaMask/Version-2.13.10
...
Version 2.13.10
2016-11-22 16:10:50 -08:00
Dan Finlay
358440384c
Fix vault migration unit test
2016-11-22 16:07:35 -08:00
Dan Finlay
607a474c3f
Improve vault migration unit test
2016-11-22 16:05:37 -08:00
Dan Finlay
4b7b0a86d8
Refine isInitialized derivation method
2016-11-22 15:57:48 -08:00
Dan Finlay
7562d49db7
Linted
2016-11-22 15:56:54 -08:00
Dan Finlay
de8da9ddf6
Simplify Encryptor API Surface
...
At least, the portion of it that we use.
Moved salting within the encryptor, so it does not need to be managed externally.
KeyringController now caches the password instead of a passwordDerivedKey, since it is ignorant of the salt.
Encryptor payload is now in a JSON format, so its portions are both base64 encoded *and* labeled appropriately. The format is `{ "data": "0x0", "iv": "0x0", "salt": "string" }`.
Fixes #843
Fixes #859
2016-11-22 15:54:51 -08:00
Dan Finlay
2966d46fa2
Merge branch 'dev' into i843-MoveSaltIntoEncryptor
2016-11-22 15:36:50 -08:00
