1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-12 20:57:12 +01:00
Commit Graph

14196 Commits

Author SHA1 Message Date
Benjamin Bourgeois
d12097ac1c
UpdateNickname story : convert knobs and actions to controls/args (#13189)
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
2022-01-17 16:00:40 -06:00
Matthew Epps
a8ec876031
Fix token ordering: prioritize top before owned (#13270) 2022-01-17 15:55:23 -06:00
6201
371da2eb83
Box story: convert knobs to controls (#13274)
Co-authored-by: caogu <sunlon1987@gmail.com>
2022-01-17 15:50:27 -06:00
VSaric
cb815a91ad
SendHeader, ContactListTab and AdvancedTab story: converted knobs and actions to controls / args (#13230)
* SendHeader, ContactListTab and AdvancedTab story: converted knobs and actions to controls / args

* Added the other function type props to action controls

* Requested review changes
2022-01-17 10:58:12 -08:00
Elliot Winkler
8beaae3361
Fix UI issues at top of confirm page container (#13314)
This commit fixes a few issues with ConfirmPageContainerSummary (which
holds the contract being used or action being performed and the money
being sent):

* Remove fixed height so that the secondary currency doesn't get cut off
  or spill over
* Add missing padding
* Fix font size of primary and secondary currencies
* Add top border when there is a "address not in your address book"
  alert at the top

Co-authored-by: Ariella <ariellavu@gmail.com>
2022-01-14 20:12:20 -07:00
Erik Marks
a5873eb7ff
Fix manually connecting sites (#13320) 2022-01-14 14:31:32 -08:00
Niranjana Binoy
b5973b46e0
V10.9.0: Mainnet should have a capital M in the import token warning message (#13310) 2022-01-14 10:09:28 -05:00
Niranjana Binoy
58ff673bcd
V10.9.0: Disconnect all accounts flow (#13309) 2022-01-13 18:05:35 -05:00
ricky
f58e2552c3
use PAT for GITHUB_TOKEN (#13307)
Use `secrets.METAMASKBOT_CROWDIN_TOKEN` for `GITHUB_TOKEN`

ref: https://docs.github.com/en/actions/security-guides/automatic-token-authentication#using-the-github_token-in-a-workflow

> When you use the repository's GITHUB_TOKEN to perform tasks on behalf of the GitHub Actions app, events triggered by the GITHUB_TOKEN will not create a new workflow run. This prevents you from accidentally creating recursive workflow runs. For example, if a workflow run pushes code using the repository's GITHUB_TOKEN, a new workflow will not run even when the repository contains a workflow configured to run when push events occur.
2022-01-13 17:45:07 -05:00
Alex Donesky
269aaa6fb5
fix send duck standard setting bug in updateSendAsset (#13289) 2022-01-13 15:21:20 -06:00
Benjamin Bourgeois
4cf5c942aa
Typography stories : convert knobs and actions to controls / args (#13220)
Convert Typography story in ui/components/ui/typography/typography.stories.js to use controls argType annotation

- Add README.MDX
- Story has argTypes that align with component api / props
- All instances of @storybook/addon-knobs have been removed in favour of control args
- All instances of @storybook/addon-actions have been removed in favour of action argType annotation
2022-01-13 12:40:45 -07:00
Brad Decker
dffad6e35d
use object.values to get array for iteration (#13300) 2022-01-13 12:10:47 -06:00
Alejandro Garcia Anglada
5d7094cafc
Improve first time flow css - select action (#12799)
* Improve first time flow css - select action

* Update ui/pages/first-time-flow/select-action/index.scss

Co-authored-by: George Marshall <georgewrmarshall@gmail.com>

* Update ui/pages/first-time-flow/select-action/index.scss

Co-authored-by: George Marshall <georgewrmarshall@gmail.com>

Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
2022-01-13 09:46:38 -08:00
Mark Stacey
48d9ca19cc
Remove unnecessary Yarn resolution (#13305)
This resolution was used to force a transitive dependency to be updated
to a specific version. But this target version was within the range
that was already requested, so a resolution is not needed. Yarn
resolutions are used for forcing a package to update to something
_outside_ of the requested range. For in-range updates, a Yarn lockfile
update is all we need, and it leaves us with less of a maintenance
burden (the resolution can clobber future updates).
2022-01-13 13:19:35 -03:30
dragana8
76bfc399b6
convert knobs and actions to controls / args (#13203)
* changed knobs

* review updates
2022-01-13 08:06:27 -03:30
Erik Marks
d4b6e95f89
Add resolution for follow-redirects (#13301)
Adds a resolution for `follow-redirects` to resolve https://github.com/advisories/GHSA-74fj-2j2h-c42q. The dependency graph is `analytics-node#axios#follow-redirects`, and neither parent package has published a fix for this vulnerability.
2022-01-12 21:37:40 -08:00
Brad Decker
b820ef131b
Implement event fragments (#12251) 2022-01-12 13:31:54 -06:00
Hassan Malik
ff27f24ef9
Flask devx fix (#13280)
* added fix for snaps devx issue

* reordered lines

* updated comment

* added test that ensures removeFencedCode detects a file with sourceMap inclusion

* fixed test

* Update development/build/transforms/remove-fenced-code.test.js

Co-authored-by: Erik Marks <25517051+rekmarks@users.noreply.github.com>
2022-01-12 12:37:29 -05:00
MG
05f9ceda77
#10168 - Fix to Can't open settings if browser zoom level > 100% (#13281)
* Added css fix

* Fixed left margin
2022-01-12 17:54:51 +01:00
Mark Stacey
c188600dc7 Add missing autogenerated changelog entries
The auto-generated changelog was too short because it was comparing
against the recent Flask release rather than the real previous release.
Future Flask releases will be created at the same time as normal
MetaMask releases, so we won't have this problem next time.
2022-01-11 18:15:28 -03:30
MetaMask Bot
54ad3857be Version v10.9.0 2022-01-11 19:26:26 +00:00
Jyoti Puri
88faef7e19
Adding user setting option for EIP-1559 V2 (#13242) 2022-01-12 00:47:56 +05:30
Mark Stacey
14704917c6
Update Bug Report issue template (#13267)
The "Bug Report" issue template now uses the new "issue form" GitHub
feature[1], which allows creating issues using a web form. This form
should be more effective in encouraging submitters to fill out the
required fields.

This form includes a new field for error messages or log output, and
for the build type the user was using (e.g. Flask).

[1]: https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository#creating-issue-forms
2022-01-11 15:02:17 -03:30
Mark Stacey
859ac46e32
Remove unused localized messages (#13272)
These messages were removed from the `en` locale in #13244, but they
were not deleted because that branch was not up-to-date when it was
merged, and the translations were recent additions (#13206)
2022-01-11 07:26:13 +05:30
Niranjana Binoy
cd0892a3af
EIP-1559 V2: Use default gas preferences of user for all transactions (#13238) 2022-01-10 14:34:54 -05:00
Erik Marks
4d7689b2df
Handle missing eth_accounts permission history in getLastConnectedInfo (#13257)
This PR ensures that the `getLastConnectedInfo` selector handles missing `eth_accounts` permission history. Historically, `eth_accounts` was the only permission in existence, and the only way that a permission subject ended up with a permission history in the first place. This will no longer the case as of #11837, and we were perhaps never right to bake in this assumption to begin with.
2022-01-10 09:07:26 -08:00
Mark Stacey
0aad0d55a4
Update the copy for the Flask welcome page (#13223) (#13244)
* Update the copy for the Flask welcome page (#13223)

* Update the copy for the Flask welcome page

The copy for the Flask Welcome page has been updated to better dissuade
users who are not the target audience, and to better explain the risks
of using Flask.

* Fix typo

* Suggested edits (#13225)

* Suggested edits

* fixup! Suggested edits

Co-authored-by: Erik Marks <25517051+rekmarks@users.noreply.github.com>

* Update app/_locales/en/messages.json

Co-authored-by: David Walsh <davidwalsh83@gmail.com>

Co-authored-by: Erik Marks <25517051+rekmarks@users.noreply.github.com>
Co-authored-by: David Walsh <davidwalsh83@gmail.com>
2022-01-10 13:31:51 -03:30
Mark Stacey
57e83ff82a
Fix a propType warning on the Flask welcome screen (#13224) (#13246)
The first page of the Flask onboarding was causing a propType warning
to appear in the console. It was caused by the array of React Fragments
used to construct the ASCII fox; they were missing the `key` prop.

These fragments are static content, so React doesn't really need to
worry about what to do in the event they are re-ordered. The array
index has been used as the key to silence the warning.
2022-01-10 13:31:37 -03:30
dependabot[bot]
ac5d06e4e3
Bump copy-props from 2.0.4 to 2.0.5 (#13245)
Bumps [copy-props](https://github.com/gulpjs/copy-props) from 2.0.4 to 2.0.5.
- [Release notes](https://github.com/gulpjs/copy-props/releases)
- [Changelog](https://github.com/gulpjs/copy-props/blob/master/CHANGELOG.md)
- [Commits](https://github.com/gulpjs/copy-props/compare/2.0.4...2.0.5)

---
updated-dependencies:
- dependency-name: copy-props
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-01-10 21:57:13 +05:30
Alex Donesky
4826c8c95e
Feat/collectibles send flow (#13048)
* Add collectibles send flow
2022-01-10 10:23:53 -06:00
Niranjana Binoy
0d1e79dda5
EIP-1559 V2: : Advanced Gas Fee Modal - Updating the trend arrows (#13196) 2022-01-10 08:08:26 -05:00
George Marshall
4af7f250a2
Updating storybook docs (#13055)
* Updating and moving docs to .storybook/ folder and updating Button to be the standard of docs we want to strive for

* Capitalizing API
2022-01-07 12:30:37 -08:00
github-actions[bot]
49343d08c1
New Crowdin translations by Github Action (#13206)
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
2022-01-07 14:55:07 -05:00
Elliot Winkler
7b963cabd7
Alert users when the network is busy (#12268)
When a lot of transactions are occurring on the network, such as during
an NFT drop, it drives gas fees up. When this happens, we want to not
only inform the user about this, but also dissuade them from using a
higher gas fee (as we have proved in testing that high gas fees can
cause bidding wars and exacerbate the situation).

The method for determining whether the network is "busy" is already
handled by GasFeeController, which exposes a `networkCongestion`
property within the gas fee estimate data. If this number exceeds 0.66 —
meaning that the current base fee is above the 66th percentile among the
base fees over the last several days — then we determine that the
network is "busy".
2022-01-07 12:18:02 -07:00
Elliot Winkler
0bada3abf1
Clear Sass deprecations (#13227)
Sass has changed the syntax for dividing two numbers. Previously you
would use `/`, but because this causes some ambiguity with color
functions (`rgb()`, `rgba()`, and the like), where `/` is regularly used
to separate color channel information from an alpha value, Sass has
deprecate the use of `/` for division. [1]

This commit converts all such usages to use `math.div()` instead. This
is a little bit difficult because there are a few places in
`@fortawesome/fontawesome-free` which use the old syntax. There is an
issue open here about it [2] but that has not been fixed yet. So we have
to patch this package to make the deprecation warnings go away.

[1]: https://sass-lang.com/documentation/breaking-changes/slash-div
[2]: https://github.com/FortAwesome/Font-Awesome/issues/18371
2022-01-07 12:17:21 -07:00
Mark Stacey
3732c5f71e
Add JSDoc ESLint rules (#12112)
ESLint rules have been added to enforce our JSDoc conventions. These
rules were introduced by updating `@metamask/eslint-config` to v9.

Some of the rules have been disabled because the effort to fix all lint
errors was too high. It might be easiest to enable these rules one
directory at a time, or one rule at a time.

Most of the changes in this PR were a result of running
`yarn lint:fix`. There were a handful of manual changes that seemed
obvious and simple to make. Anything beyond that and the rule was left
disabled.
2022-01-07 12:27:33 -03:30
Brad Decker
e333eb4628
[Hotfix] track anonymous events appropriately (#13237) 2022-01-06 21:29:06 -06:00
Elliot Winkler
af971cd5b6
Remove dupe Prettier config from ESLint config (#13234)
The ESLint config for the extension explicitly includes support for
Prettier. However, this is already being provided by our global ESLint
config (`@metamask/eslint-config`). Therefore there is no need to
include it here. In fact, this is causing weird issues where the `curly`
option is getting overridden somehow. After this change, these syntaxes
are invalid:

``` javascript
if (foo) return;
```

``` javascript
if (foo) return 'bar';
```
2022-01-06 15:56:51 -07:00
Jyoti Puri
0c531f8b01
EIP-1559 V2 UI fixes (#13222) 2022-01-07 04:10:31 +05:30
David Walsh
10dc686505
Dark Mode Part 1: Switch to Using CSS Variables (#13147) 2022-01-06 11:35:49 -06:00
Jyoti Puri
f5dcd12293
using 1559 V2 for cancel speed up flows (#13019) 2022-01-06 08:17:26 +05:30
Erik Marks
dbfdf3b0eb
Update Flask support links and home footer (#13226)
* Update support links for Flask

* Disable 'prefer-const' in code fence linting

* Add bespoke home footer for Flask and update logic

* fixup! Add bespoke home footer for Flask and update logic

* Fix code fence lint failure

* Fix support request link in account menu

* Fix unit test failure
2022-01-05 21:25:20 -03:30
Alex Donesky
df48c424a4
fix issue where transaction items without a TRANSACTION_CONFIRMED_EVENT have unhandled error when clicking into activity log (#13221) 2022-01-05 17:49:20 -06:00
Mark Stacey
94dc287bb1
Fix missing targetSubjectMetadata.name propType error (#13218)
There was a propType error shown on the snap install screen about the
`name` property of `targetSubjectMetadata` being missing despite it
being marked as required. This property should not have been required,
it does not always exist.
2022-01-05 19:02:44 -03:30
朱里
b9093e2a4d
Remove bottom space when hiding testnet (#12821) 2022-01-05 13:04:34 -06:00
dragana8
fc185e3139
mainnet tokens autopopulate add token form fields when on custom networks #12087 (#12800)
Co-authored-by: Alex Donesky <alex.donesky@consensys.net>
2022-01-05 12:19:28 -06:00
zorrosword
e694059b28
Adjust the padding of lock button (#13017) 2022-01-05 12:16:24 -06:00
Mark Stacey
22f931e6b2
Prevent automatic rejection of confirmations (#13194)
* Prevent automatic rejection of confirmations

Confirmations are now only automatically rejected if a user explicitly
closes the notification window. If we close the window programmatically
because there are no notifications left to show, nothing gets rejected.

This partially avoids a race condition where a confirmation gets
rejected automatically without the user having seen the confirmation
first. This could happen if the confirmation was processed just as the
notification window was being closed.

It's still possible for a confirmation that the user has never seen to
get rejected as a result of the user closing the window. But at least
now it's no longer possible for a confirmation to get rejected in this
manner after the user resolves the last confirmation in the queue.

* Fix bug that prevented automatic closure detection

All windows were being detected as explicit window closures,
essentially just as they were previously, because this variable was
cleared too soon.

* Re-open popup when necessary

After the window is automatically closed, a confirmation may have been
queued up while the window was closing. If so, the popup is now re-
opened.
2022-01-05 13:39:19 -03:30
Mark Stacey
139a67fca4
Include style lints in lint:fix script (#13217)
The `lint:fix` script now also calls `yarn stylelint --fix`. This step
was omitted previously, despite `stylelint` being part of the `lint`
npm script.
2022-01-05 13:38:51 -03:30
Mark Stacey
966bdffb12
Fix account-menu styles lint failure (#13215)
This error was introduced with #13100, which was merged without CI
checks because CircleCI was not running on that branch for some reason.
This error was fixed with `yarn lint:styles --fix`.
2022-01-05 12:23:19 -03:30