Olusegun Akintayo
e2c4e93ab0
When gas fees suggested by dapp is too high, show warning color and icon ( #19088 )
...
* When gas fees suggested by dapp is too high, show warning color and icon
Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>
tests
Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>
Fix tests
Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>
set a default for high gas fees
Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>
Fix test cases where transaction is undefined.
Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>
Fix locale error
Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>
Fix error where dappSuggestedGasFees is null
Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>
Fix icon for site suggested
Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>
Fix unit tests snapshot
Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>
* Fix QA Comments
Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>
* lint:fix
Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>
* Fix unit tests
Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>
* Fix PR comments
Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>
* Lint fix
Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>
* Fix PR comment. - call setEstimateUsed only once.
Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>
* use constants for Priority levels.
Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>
---------
Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>
2023-06-08 13:26:18 +03:00
Suraj Jadhav
e7adf7ac22
issue-18714: Replaced deprecated constants with enum in confirmation-warning-modal.js ( #19477 )
2023-06-07 16:19:32 -07:00
Frederik Bolding
789779f4d5
[FLASK] Rework Snaps headers and footers ( #19442 )
...
* Add new snap header and footer to snap install
* Add new snap header and footer to snap result and snap update
* Fix loading state
* Fix lint
* Add required scrolling
* Adjust avatar component
* Apply new headers and footers to snaps confirmations
* Rename previous SnapAuthorship component to SnapAuthorshipExpanded
* Fix lint
* Fix font weight
* Fix fencing
* Fix a test
* Fix lint after rebase
* Fix E2E
* Fix locale lint
* Fix another E2E
* Fix test ID
* Address PR comments
* Better scroll button centering
* Address design comments
* Fix unit test
* Fix E2Es
2023-06-07 15:18:49 +02:00
Dhruv
2b95d7b242
Creating story for asset-list ( #19450 )
...
* Creating story for asset-list component
* lint fix
* lint-fix
2023-06-06 11:31:18 -07:00
Niranjana Binoy
b5b3f67b4b
Using NetworkAccountBalanceHeader component on SIWE screen ( #19361 )
2023-06-06 09:53:28 -04:00
David Drazic
354788510e
[FLASK] Update UI (for audit) (UI facelift) ( #19388 )
...
* Update UI (for audit)
Revert yarn.lock change
Update e2e tests with new copy for a button
Make UI changes to custom Snap UI
Update UI on snap installation success page
Fix icon on installation success
Fix snap name font weight in installation page
Add UI changes for Snap installation failed page
Add new copy for snap installation screen
Update e2e tests OK button name
Update OK button names in e2e tests
Return previous functionality of update flow
Add error message handling for update screens
* Fix after rebase
* Fix messages.json update message
* Revert SCSS changes
* Refactor failed and success screen rendering
2023-06-06 12:15:20 +02:00
rohit kerkar
15bdb32bb6
replacing depricated constants ( #19448 )
...
Co-authored-by: George Marshall <george.marshall@consensys.net>
2023-06-06 14:21:27 +05:30
rohit kerkar
b40b4c6239
replacing depricated constants ( #19447 )
2023-06-06 14:20:45 +05:30
Frederik Bolding
3b9e2eb5e5
[FLASK] Update snap tweaks ( #19410 )
...
* Sort revoked permissions before existing permissions
* Simplify update screen logic and update copy
* Remove approve and update copy
* Reduce nesting
2023-06-05 14:31:11 +02:00
vthomas13
1726fb3fd0
Remove MULTICHAIN flag for NFT badges ( #19416 )
2023-06-04 12:28:48 -04:00
vthomas13
4f8c4820d2
Multichain NFT network badges ( #19029 )
...
* adding badges for nfts
* fixing default nft styling issue
* adding multichain flag, making borderRadius inline
* Apply suggestions from code review
Co-authored-by: George Marshall <george.marshall@consensys.net>
* fixing imports
* removing nullcheck for guaranteed fields
* moving badgewrapper UI into multichain component
* using Box for button, removing inline style, border-radius for NFT default image
* adding nft badges to NFT Details page
* nits, snap update
* fixing/refactoring nftdefaultimage display, adding clickable, removing handleimageclick, refactor NFTItem, required props
* editing nft-default-image story, test, and snap
* Updating to fix positioning, use Box props to reduce CSS and BEM naming conventions
* moving minor styling to Box props, adding comment
* display block typo
---------
Co-authored-by: George Marshall <george.marshall@consensys.net>
2023-06-02 11:01:51 -04:00
Jyoti Puri
f1de905be7
Fix details when transferring NFT not added to wallet ( #19045 )
2023-06-02 18:33:10 +05:30
Pedro Pablo Aste Kompen
37af04374a
feature(on-ramp): update supported networks ( #19268 )
...
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
2023-06-02 08:19:03 -04:00
David Walsh
b89630fdd2
Release MultiChain 0.5 ( #18903 )
...
* Show portfolio icon in ETH overview
* Show new copy button in QR code modal
* Show address copy button in wallet overview
* Update connected status component
* Remove legacy MenuBar
* Remove legacy ImportTokenLink
* Remove AssetListItem
* Remove DetectedTokensLink
* Remove legacy AppHeader
* Remove MULTICHAIN flag from builds.yml
* Remove legacy AccountMenu
* FIX: Token cell snapshot
* Add data-testid for Account Picker
* Remove multichain check in LoadingNetworkScreen
* Remove MULTICHAIN check for AccountDetailsModal
* Remove MULTICHAIN check for AssetList
* Update QR dimensions
* Remove MULTICHAIN declaration from metamaskrc.dist
* Implement PickerNetwork and NetworkListMenu in onboarding
* Remove legacy NetworkDropdown and Dropdown
* Remove documentation about legacy account menu
* FIX: Fixes route tests for missing data-testid=network-display
* Fix account-menu-icon data-testid
* Fix TokenCell test
* FIX Onboarding Flow tests
* Remove unused locales from AccountMenu removal
* E2E: Fix Import Secret Recovery Phrase: logs out of the vault
* E2E: Fix Show account details: should show the QR code for the account
* E2E: Fix add-account.spec.js
* E2E: Fix state-logs.spec.js
* E2E: Fix lock-account.spec.js
* E2E: Fix settings-general.spec.js
* E2E: Fix advanced-settings.spec.js
* E2E: Fix auto-lock.spec.js
* E2E: Fix backup-restore.spec.js
* E2E: Fix clear-activity.spec.js
* E2E: Fix settings-search.spec.js
* E2E: Fix encrypt-decrypt.spec.js
* E2E: Fix dapp-interactions.spec.js
* E2E: Fix test-snap-management.spec.js
* E2E: Fix add-custom-network.spec.js
* E2E: Fix from-import-ui.spec.js
* E2E: Fix provider-api.spec.js
* E2E: Fix chain-interactions.spec.js
* E2E: Fix custom-rpc-history.spec.js
* Remove network icon from overview components
* E2E: Fix user-actions-benchmark.js
* E2E: Fix benchmark.js
* E2E: Fix add-hide-token.spec.js
* E2E: Fix address-book.spec.js
* E2E: Fix custom-token-add-approve.spec.js
* E2E: Fix incremental-security.spec.js
* E2E: Fix metamask-responsive-ui.spec.js
* E2E: Onboarding.spec.js
* E2E: Fix permissions.spec.js
* E2E: Fix send-hex-address.spec.js
* E2E: Fix send-to-contract.spec.js
* Remove dead AccountOptionsMenu test
* E2E: Fix token-details.spec.js
* E2E: Fix switch-custom-network.spec.js
* E2E: Fix metamask-ui.spec.js
* Revert "UX Multichain: updated border top for activity list (#19176 )"
This reverts commit 15598f2a23
2023-06-01 16:14:38 -05:00
Ariella Vu
8d79e28560
Clean ConfirmTransaction page related code ( #19208 )
...
* fix typo: uncofirmedTransactions -> unconfirmedTransactions
* txHelper: reorganize lines and improve test
* ConfirmTx: rn unconfirmedTxs->unconfirmedTxsSorted
* ConfirmTx: rn unconfirmedMessages-> unconfirmedTxs
2023-06-01 16:10:26 +02:00
David Drazic
f788121c3b
[FLASK] Add Snaps privacy warning on snap install ( #18835 )
...
* Add Snaps privacy warning on snap install
Add snap install warning status to storage
Add storybook
Add test for snap-privacy-warning
Resolve button type issue
Fix popup display logic
Update fixture
Update popup information and read more handling
Replace deprecated button
Update unit test
* Update buttons and add cancel flow
* Refactoring (review 1)
* Add more unit tests
2023-05-31 14:43:39 +02:00
David Walsh
68e1958005
Fix #19139 - Allow user to switch network when loading networking fails ( #19175 )
2023-05-24 09:40:12 -02:30
Albert Olivé
057188d155
[MMI] Add code fences in signature-request ( #18770 )
...
* Started adding code fences in signature-request
* Finished code fencing
* Improving code
* Fixed storybook and code fences bundle
* Added missing dependency
* Fixed yarn.lock
* Fixing policies
* Updated package.json
* updating lavamoat
* lavamoat fix
* adds missing package
* runs yarn dedupe
* updates method name
* run lavamoat:auto again
* Added more code fences
* updates snapshot
* snapshot updates
* updates mmi packages to lighter versions
* updates mmi packages
* runs lavamoat auto
* updates yarn lock and runs lavamoat auto
* updates yarn lock
* updates targets file
* Removed console log and added tests
---------
Co-authored-by: António Regadas <apregadas@gmail.com>
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
Co-authored-by: Antonio Regadas <antonio.regadas@consensys.net>
2023-05-24 13:41:21 +02:00
Albert Olivé
00bad7b8a8
[MMI] Added code fencing in transaction list ( #18071 )
...
* Added code fencing in transaction list
* Fixed import
* Fixed tests
* Fixed indentation
* Fixed code fences
* Removed custody icon in favor of svg
* Fix prettier
* lint
* Fixed prettier issue
* adds check before set state with variable _mounted
* lint
* check for address in selectedIdentity
* review fix
* lint
* updates test
* lint
* clean up
* prettier
* adds missing locale
* Added tests and improved code
* Fixed code
---------
Co-authored-by: Antonio Regadas <antonio.regadas@consensys.net>
2023-05-24 13:40:58 +02:00
Garrett Bear
ba90e57663
Feat/18444/text align update app folder ( #19216 )
...
* Update TEXT_ALIGN const to TextAlign enum
* update TEXT_ALIGN to TextAlign in app folder
2023-05-23 12:29:14 -07:00
Nidhi Kumari
9db971768b
UX Multichain: updated ui for settings page ( #19167 )
...
* updated ui for settings page
* lint fix
* resolved errors
* fixed search bar css
* fixed css
* lint fix
* fixed tests
* fixed indentation
* updated settings aria label
2023-05-23 23:59:00 +05:30
Nidhi Kumari
15598f2a23
UX Multichain: updated border top for activity list ( #19176 )
...
* updated border top for activity list
* updated border css via prop
* fixed symbol
* fixed lint errors
* fix conditions
* updated snapshot
2023-05-23 22:54:17 +05:30
Hassan Malik
a9429c5c0d
[FLASK] Fix classnames for snaps components ( #19234 )
...
* renamed classnames according to BEM, removed unnecessary scss file
* remove plurality in classnames
2023-05-23 09:07:44 -04:00
Albert Olivé
dfb2c0e0e8
[MMI] Added code fencing in app menu bar ( #18069 )
...
* Added code fencing in app me nu bar
* Fixed lint issues
* Fixed yarn.lock
* Fixed issue
* Fixed tests
* Fixed yarn.lock
* Fixing policies
* Fixing lavamoat
* fixed yarn.lock
* Fixed storybook
* clean up and adds test
* lint
* typo
* adds test
---------
Co-authored-by: Antonio Regadas <antonio.regadas@consensys.net>
2023-05-23 14:51:39 +02:00
George Marshall
8437d0491f
Deprecated Icon and ButtonIcon clean up ( #19220 )
...
* Updating all deprecated instances of Icon and ButtonIcon
* Removing unused deprecated components and scripts
2023-05-19 10:33:02 -07:00
Ariella Vu
ab4ef4f744
[Bug]: Updating and Adding ConfirmPageContainer Tests ( #19149 )
...
* updating the tokenBalance fetch and Token standard type to enable the Total in setSetApproveForAllWarning
* updating the base-10 for the BN.toString() conversion
* updating review comments
* adding string conversion to tokenBalance
* ConfirmPageContainer: mv props to the top
* ConfirmPageContainer: deprecate sinon
* updating coverage-targets
* updating the conversion base
* ConfirmPageContainer: add test for warning modal
---------
Co-authored-by: Niranjana Binoy <43930900+NiranjanaBinoy@users.noreply.github.com>
2023-05-19 01:22:43 +03:00
Niranjana Binoy
56440a84db
Cleanup PR: Renaming getNetworkName and moving that to utils file ( #19160 )
2023-05-18 09:53:11 -04:00
Niranjana Binoy
3fe5d3fc4c
[Bug]: Enabling the display of token total in SetApprovalForAll ( #18863 )
2023-05-18 09:51:38 -04:00
legobeat
8675c7863e
devDeps: storybook@7 ( #19092 )
...
* devDeps: pin @babel/core and @babel/runtime in resulotions
Without this: misses patch, lavamoat error
* storybook 6 to 7 migration
* devDeps: add @storybook/addon-mdx-gfm
* fix lint deps
* devDeps: remove unused require-from-string
* devDeps/resolutions: @types/react@^16.9.53
* devDeps: add @storybook/cli
* storybook: new-frameworks migration
* iyarc: remove resolved dependency advisory
* deps: set globalthis@1.0.1 in resolutions
This is required since a file is copied over from a set path in the dist
package subdirectory as of d13aabde23#10014 ).
A future update should either vendor the shim, or update to
compatibility with a maintained upstream version.
* mdx2 migration fixes
* chore: bump ljharb packages
* devDeps: @storybook/*@^7.0.10->^7.0.11
* storybook: update preview.js to use v7 addon api
* ci/test/storybook: echo between storybook build&test
* ci/circleci: resources tweak
* info-tab: handle undefined global.platform
* update lavamoat build policy
* update lavamoat browserify policies
2023-05-18 11:07:42 +09:00
Albert Olivé
ebc887021e
[MMI] Added code fences for account menu ( #17965 )
...
* Added code fences for account menu
* updates test and messages json
* clean up
* icons
* icons color correct
* icon size fix
* icon size fix
* adds mmi entries and updates to the new IconName
* clean up
* lint
* clean up
* prettier
* prettier
* camel case
---------
Co-authored-by: Antonio Regadas <antonio.regadas@consensys.net>
Co-authored-by: António Regadas <apregadas@gmail.com>
2023-05-17 16:58:00 +02:00
Albert Olivé
804d352d58
[MMI] Add MMI modals with their styles to the app/modals ( #18621 )
...
* Added code fences
* Fixing code fences
* Fixed paths
* Fixing issues
* Fixed imports
* removes fences in scss file and un-needed prop
---------
Co-authored-by: Antonio Regadas <antonio.regadas@consensys.net>
Co-authored-by: António Regadas <apregadas@gmail.com>
2023-05-17 16:57:46 +02:00
Albert Olivé
a017a1bae0
[MMI] Added note to trader code fencing ( #18051 )
...
* Added note to trader code fencing
* Started adding code fences in signature-request
* Finished code fencing
* Improving code
* adds check and runs prettier
* Fixed storybook and code fences bundle
* Added missing dependency
* updates fences
* fewer lines
* undo previously merged PR
* ran lavamoat auto
* adds test
* prettier
---------
Co-authored-by: António Regadas <apregadas@gmail.com>
Co-authored-by: Antonio Regadas <antonio.regadas@consensys.net>
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
2023-05-16 16:44:08 +01:00
Dhruv
488f212d28
Part of #18714 and #17670:set-approval-for-all-warnings ( #19115 )
...
* Changes to set-approval-for-all-warnings
* Suggested changes
* Updating deprecated components, improving semantic html and fixing text css strong tag styles
---------
Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
Co-authored-by: Garrett Bear <gwhisten@gmail.com>
2023-05-15 15:40:00 -07:00
Mark Stacey
4bd74c5059
Fix lint error ( #19157 )
...
Fix a lint error recently introduced by a merge conflict.
2023-05-15 18:37:20 -02:30
Dhruv
5135b80de7
Part of #18714 and #17670 : Changes to nfts-detection-notice.js ( #19051 )
...
* Changes to nfts-detection-notice.js
* Adding story
---------
Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
2023-05-15 11:08:48 -07:00
Dhruv
c9f420234f
Changes to gas-items-details ( #19075 )
2023-05-15 10:56:20 -07:00
Harsh Shukla
8a8c8fad10
Part of ##18714 Replace deprecated design system typography consts with enums in: confirm-page-container.component.js ( #19065 )
2023-05-15 10:50:49 -07:00
Harsh Shukla
1c346674df
Part of #18714 Replace deprecated design system typography consts with enums in: 'srp-input' ( #19040 )
...
* Part of #18714 Replace deprecated design system typography consts with enums in: 'srp-input'
* Update ui/components/app/srp-input/srp-input.js
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
* Update srp-input.js
---------
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
2023-05-15 09:52:02 -07:00
Albert Olivé
f95320d03e
[MMI] Started adding styles imports with code fences ( #17943 )
...
* Started adding styles imports with code fences
* FIxed prettier issues
* removed fences since they dont do anything
* Update ui/components/ui/ui-components.scss
Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
---------
Co-authored-by: Antonio Regadas <antonio.regadas@consensys.net>
Co-authored-by: António Regadas <apregadas@gmail.com>
Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
2023-05-15 12:38:54 +01:00
Ariella Vu
aa9ee8af6c
Update useDraftTransactionGasValues ( #19105 )
...
* useDraftTransactionGasValues: update return value
* rn useDraftTransactionGasValues
-> useDraftTransactionWithTxParams
2023-05-12 13:27:25 -05:00
Dan J Miller
578f73b2ea
Ensure the GasDetailsItem component can handle a tx with a maxPriorityFee of 0 ( #19102 )
...
* Ensure the GasDetailsItem component can handle a tx with a maxPriorityFee of 0
* Clean up code
* Update ui/components/app/gas-details-item/gas-details-item.js
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
---------
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
2023-05-12 12:31:15 -02:30
Nidhi Kumari
46c2f1cc56
removed mmi fencing from copy icon in header ( #19087 )
...
* removed mmi fencing from copy icon
* updated snapshot
2023-05-10 15:41:03 +02:00
Vinicius Stevam
df3db6e559
Adopt ApprovalType from core ( #18567 )
2023-05-10 06:36:01 +01:00
Dhruv
490e0770c7
Changes to edit-gas-display.component.js ( #19037 )
...
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
2023-05-09 17:52:16 -07:00
Nidhi Kumari
6535e34943
Replaced all fa-icon-circle with INFO icon ( #17539 )
...
* replace all fa-icon-circle with INFO icon
* updated classnames
* updated classnames
* updated snapshots
* updated colors
* resolved errors
* fixed relative import
* fixed lint errors
* added story for alerts tab
* update snapshot
* updated info-circle
* updated enum for iconName
* removed classnames
* updated iconName in settings
* fixed lint errors and snapshots
2023-05-09 23:04:58 +05:30
Dominik Rudzki
4cb3284136
Fix popover scroll button WhatsNewPopup hiding ( #19017 )
...
Co-authored-by: David Walsh <davidwalsh83@gmail.com>
2023-05-09 11:32:29 -05:00
Harsh Shukla
4ad281c806
Part of #17670 & #18714 : Replace Typography with Text component: nft-details.js ( #18771 )
...
* Update nft-details.js
* Update nft-details.test.js.snap
* Update nft-details.js
* Update ui/components/app/nft-details/nft-details.js
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
* Update ui/components/app/nft-details/nft-details.js
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
* Update ui/components/app/nft-details/nft-details.js
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
* Update ui/components/app/nft-details/nft-details.js
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
* Update ui/components/app/nft-details/nft-details.js
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
* Update ui/components/app/nft-details/nft-details.js
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
* Update ui/components/app/nft-details/nft-details.js
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
* Update ui/components/app/nft-details/nft-details.js
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
* Update ui/components/app/nft-details/nft-details.js
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
* Update ui/components/app/nft-details/nft-details.js
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
* Update ui/components/app/nft-details/nft-details.js
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
* Update ui/components/app/nft-details/nft-details.js
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
* Update ui/components/app/nft-details/nft-details.js
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
* Update ui/components/app/nft-details/nft-details.js
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
* Update nft-details.test.js.snap
---------
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
Co-authored-by: George Marshall <george.marshall@consensys.net>
2023-05-08 19:52:33 +05:30
David Walsh
a5494fc637
UX: Multichain: Account Details Fixes ( #18999 )
...
* Fix account details editable label
* Fix font-weight of the password label
* Remove duplicate error
* Hide password warning on first screen after bad password, autofocus password field
* Fix jest failure
* Restore className
2023-05-08 09:03:34 -05:00
Harsh Shukla
dd04913e7e
Working on some lint issues in 2 files. ( #18633 )
...
* Addressed some lint issues.
* Worked on the mentioned lint issue.
* Worked on the CRLF lint issues.
---------
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
Co-authored-by: George Marshall <george.marshall@consensys.net>
2023-05-08 08:55:25 -05:00
Dhruv
50f2d06223
Changes to confirm-data and confirm-hexdata ( #19041 )
2023-05-08 08:36:40 -05:00
