Nidhi Kumari
cb6223b75f
removed portfolio icon from eth overview ( #18662 )
2023-04-19 22:22:53 +05:30
David Drazic
525d5ff54e
[FLASK] Revert changes made to stable permission display (UI design) ( #18470 )
...
* Revert changes made to stable permission display (UI design)
* Add test for new component
* Update paddings for install flow
* Fix missing icons on snap installation flow
* Update storybook path
* Add targetSubjectMetadata param
---------
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
2023-04-19 14:09:09 -02:30
Dan J Miller
53faf7966c
Merge remote-tracking branch 'origin/develop' into master-sync
2023-04-19 13:44:02 -02:30
Elliot Winkler
a876eaba23
removeNetworkConfiguration validates given ID ( #18650 )
...
In the `core` version of NetworkController, `removeNetworkConfiguration`
throws an error if the given network configuration ID doesn't match an
existing network configuration. This commits adds the same check for
consistency. It also makes some minor changes to the implementation and
tests for `removeNetworkConfiguration` for consistency as well.
2023-04-19 09:47:33 -06:00
vthomas13
b7518c0810
adding notification 18 title ( #18526 )
...
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
2023-04-19 13:07:33 -02:30
Nidhi Kumari
d362dbfacb
UX Multichain: updated ethereum logo icon ( #18528 )
...
* updated ethereum logo icon
* Updating eth logo (#18631 )
* Updating eth logo
* Removing border from eth logo identicon
* Removing old eth logo
* updated snapshot and lint errors
* updated eth logo from svg to png
---------
Co-authored-by: George Marshall <george.marshall@consensys.net>
2023-04-19 20:55:19 +05:30
PeterYinusa
aef27db737
update policies
2023-04-19 16:24:47 +01:00
Peter
02e8e9c679
Avoid resetting the mock server ( #18661 )
2023-04-19 15:36:23 +01:00
Dan J Miller
7bc13e90f8
Rename migration 83 to 84 and rename migration 84 to 83 ( #18655 )
...
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
2023-04-19 11:38:16 -02:30
Dan J Miller
bffbfe1fad
Fix merge conflict introduced by cherry-picking ad11352
without also having 3577d3545f
on the branch
2023-04-19 11:31:30 -02:30
Peter
1cc709af41
wait for gas estimate to update ( #18658 )
2023-04-19 13:36:24 +01:00
Jyoti Puri
e091e77674
Update gas limit on token allowance change ( #18524 )
...
* Update gas limit on token allowance change
* Fix unit test case
* lint: remove unused var txParams
* fix
* fix
* fix e2e
* fix e2e
* fix e2e
* fix e2e
* fix e2e
* fix build
* fix build
* fix build
* fix
* fix
* fix
* fix
* fix
---------
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
Co-authored-by: legobt <6wbvkn0j@anonaddy.me>
2023-04-19 07:50:37 -02:30
Brad Decker
ad11352199
use network did change instead of state update for assetsContractController ( #18629 )
2023-04-19 07:50:37 -02:30
Jyoti Puri
600909418c
Fix approve all warning modal ( #18613 )
...
* Fix approve all warning modal
* fix
* fix
* fix
2023-04-19 07:50:37 -02:30
Dan J Miller
3cc82898a6
Ledger trezor display ( #18637 )
...
* gst
* Only display ledger info on approval screen for ledger hardware wallets
2023-04-19 07:50:37 -02:30
Dan J Miller
a97383d62e
Pass correct params to fetchEstimatedL1Fee in the swaps controller ( #18634 )
2023-04-19 07:50:37 -02:30
Jyoti Puri
b69e662ba5
Fix error in console on rejecting signature request ( #18614 )
2023-04-19 07:50:37 -02:30
Danica Shen
f8f1abf53c
fix/18577: Add title back for approving ERC20 token ( #18617 )
...
* fix/18577: Add title back for approving ERC20 token
* Apply suggestions from code review
Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
---------
Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
2023-04-19 07:50:36 -02:30
Jyoti Puri
9fa099f5fc
Fix issue with requests with empty data being forwarded to opensea ( #18598 )
2023-04-19 07:50:36 -02:30
Ariella Vu
7e14686ec7
siwe: add ledger instructions ( #18589 )
2023-04-19 07:50:36 -02:30
Matthew Walsh
58ed6af3a4
Disable rate limiting for signature approval requests ( #18594 )
2023-04-19 07:50:32 -02:30
George Marshall
2575fe1da8
Fix hold to reveal button ( #18496 )
2023-04-19 07:46:56 -02:30
Jyoti Puri
ca7f61126c
Improvement on approval pages ( #18545 )
2023-04-19 07:46:56 -02:30
sumit shinde ( Roni )
52e91058a0
knob to control ( #18635 )
...
* knob to control
* Update confirm-add-suggested-token.stories.js
* fix eslint
* Update ui/pages/confirm-add-suggested-token/confirm-add-suggested-token.stories.js
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
* Update ui/pages/confirm-add-suggested-token/confirm-add-suggested-token.stories.js
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
* Update ui/pages/confirm-add-suggested-token/confirm-add-suggested-token.stories.js
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
* Update ui/pages/confirm-add-suggested-token/confirm-add-suggested-token.stories.js
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
* Update confirm-add-suggested-token.stories.js
* updaes
* Updating to use redux provider
* lint fix
---------
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
2023-04-19 14:33:29 +05:30
Jyoti Puri
5892acab81
Update gas limit on token allowance change ( #18524 )
...
* Update gas limit on token allowance change
* Fix unit test case
* lint: remove unused var txParams
* fix
* fix
* fix e2e
* fix e2e
* fix e2e
* fix e2e
* fix e2e
* fix build
* fix build
* fix build
* fix
* fix
* fix
* fix
* fix
---------
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
Co-authored-by: legobt <6wbvkn0j@anonaddy.me>
2023-04-18 20:53:45 -02:30
Dan J Miller
39f6042e65
Ledger trezor display ( #18637 )
...
* gst
* Only display ledger info on approval screen for ledger hardware wallets
2023-04-18 17:19:49 -02:30
Jyoti Puri
599bef9dc5
Adding documentation for confirmation code cleanup ( #17975 )
2023-04-18 22:31:45 +05:30
Garrett Bear
13f4295287
update Icon to TS version in UI Folder ( #18551 )
...
* update Icon to TS version and using proper Enums
* Update ui/components/ui/menu/menu.stories.js
Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
* Update ui/components/ui/nickname-popover/nickname-popover.component.js
Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
---------
Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
2023-04-18 09:48:34 -07:00
Brad Decker
7fa7c05586
use network did change instead of state update for assetsContractController ( #18629 )
2023-04-18 14:03:12 -02:30
Mark Stacey
1fe28ee15a
Make setActiveNetwork
async ( #18605 )
...
The network controller method `setActiveNetwork` is now async, and the
asynchronous `_setProviderConfig` step is now awaited. The function
will not resolve until the network has finished switching.
This change affects the `eth_switchEthereumChain` and
`eth_addEthereumChain` middleware, and it affects any network switching
performed in our UI.
Relates to https://github.com/MetaMask/metamask-extension/issues/18587
2023-04-18 13:25:05 -02:30
Jyoti Puri
c6aa4f38c5
Fix approve all warning modal ( #18613 )
...
* Fix approve all warning modal
* fix
* fix
* fix
2023-04-18 13:22:16 -02:30
Niranjana Binoy
9d3cdd1b79
Overriding gas estimate in the send page even if enough ETH is not available ( #18554 )
2023-04-18 11:10:32 -04:00
Dan J Miller
e6f73f5fe9
Pass correct params to fetchEstimatedL1Fee in the swaps controller ( #18634 )
2023-04-18 12:15:18 -02:30
Danica Shen
66767d981c
fix/18577: Add title back for approving ERC20 token ( #18617 )
...
* fix/18577: Add title back for approving ERC20 token
* Apply suggestions from code review
Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
---------
Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
2023-04-18 15:49:31 +02:00
Guillaume Roux
76d79d9cce
[FLASK] Redesign dropdown-tab
( #18546 )
2023-04-18 12:46:38 +02:00
Vinicius Stevam
ae0af1b283
Adopt security provider request from core ( #18520 )
2023-04-18 08:33:32 +01:00
Jyoti Puri
09d00e1e45
Refactor confirm-send-ether into functional component ( #18527 )
2023-04-18 05:59:06 +05:30
Jyoti Puri
00d2d43d45
Fix error in console on rejecting signature request ( #18614 )
2023-04-18 05:58:28 +05:30
Mark Stacey
e5835ac459
Make resetConnection
async ( #18601 )
...
The network controller method `resetConnection` is now async. This has
no functional impact.
Relates to https://github.com/MetaMask/metamask-extension/issues/18587
2023-04-17 15:45:22 -02:30
Mark Stacey
b87c1b8526
Make setProviderType
async ( #18604 )
...
The network controller method `setProviderType` is now async, and the
async operation `_setProviderConfig` called at the end of the method is
now awaited.
Because the only async operation was the last step, this should have no
impact upon the flow of execution. The only functional change is that
now any callers have the option of waiting until the network switch
operation has completed.
One such change was made, in the `switch-ethereum-chain` middleware. As
a result, an error thrown while the network is switching will now
be thrown in this middleware and returned to the dapp as an internal
error.
Relates to https://github.com/MetaMask/metamask-extension/issues/18587
2023-04-17 15:45:01 -02:30
Garrett Bear
81393e1b5d
update to enum DS Text component ( #18584 )
...
* update to enum DS Text component
* Update ui/components/component-library/text/README.mdx
Co-authored-by: Danica Shen <zhaodanica@gmail.com>
* Update ui/components/component-library/text/README.mdx
Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
* Update ui/components/component-library/text/README.mdx
Co-authored-by: Danica Shen <zhaodanica@gmail.com>
* Update ui/components/component-library/text/README.mdx
Co-authored-by: Danica Shen <zhaodanica@gmail.com>
* Update ui/components/component-library/text/README.mdx
---------
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
Co-authored-by: Danica Shen <zhaodanica@gmail.com>
Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
2023-04-17 10:17:28 -07:00
Mark Stacey
39dff02a04
Consolidate network stores ( #18595 )
...
* Consolidate network stores
The network controller used to have multiple different state stores,
which were composed together to form the main controller state store.
They have been consolidated into a single store. This required few
changes because most state access was already being done through the
composed store.
Fixes https://github.com/MetaMask/metamask-extension/issues/18303
* Add JSDoc comment
2023-04-17 13:24:13 -02:30
Mark Stacey
3588e6d28e
Make network controller internal fields private ( #18607 )
...
Internal network controller methods and fields are now private fields,
using the JavaScript `#` syntax rather than the `private` TypeScript
keyword or a leading underscore.
The one reference to a private field was in the preferences controller
unit tests. Fortunately it was being used to create a test fixture that
was unused. The unnecessary test fixtures have been removed from that
test suite.
Fixes https://github.com/MetaMask/metamask-extension/issues/18588
2023-04-17 12:45:33 -02:30
Albert Olivé
c3cb464229
[MMI] Added custody-labels and account-list components ( #18197 )
...
* Added custody-labels and account-list components
* Modified link
* Renamed custody labels and improved code
* Added snapshot
* Fixed snapshot
* Finished connect-custody account-list
* Fixing css prettier
* Fixed comments of the PR
* Fixed code
---------
Co-authored-by: António Regadas <apregadas@gmail.com>
2023-04-17 17:06:41 +02:00
Niranjana Binoy
fedd6d4970
New reusable gas-display component ( #17976 )
2023-04-17 10:34:26 -04:00
dswilson4
ca10a1cdb6
updated onClick of close button to call the same autohide fxn as the NFT import removal ( #18504 )
...
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
2023-04-17 16:13:00 +02:00
Frederik Bolding
47f4f4008b
[FLASK] Remove unused snaps code ( #18565 )
...
* Remove unused code after snap_confirm was removed
* Remove more unused code
* Fix lint
2023-04-17 12:55:08 +02:00
OGPoyraz
867d637f06
fix: add metrics event to sign controller ( #18318 )
...
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
2023-04-17 11:21:33 +02:00
António Regadas
b50b9be502
[MMI] moves mmi selectors to institutional folder ( #18542 )
...
* adds the initial selectors
* adds more selectors
* adds tests
* fix lint and prettier
2023-04-17 09:22:53 +01:00
Jyoti Puri
cc71fda686
Fix issue with requests with empty data being forwarded to opensea ( #18598 )
2023-04-17 09:54:25 +05:30