m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-10-22 19:26:13 +02:00
Code
9,087 Commits 2 Branches 0 Tags 265 MiB
dcf3676685
Commit Graph

9087 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Whymarrh Whitby
c4a3d4ea82 Remove unneeded array cloning in getSendToAccounts selector 
The use of `Object.entries` here to map the accounts into a new array effectively
produces a shallow clone of the array without guaranteeing the order of the original
array (as object iteration order is implementation-specific and variable). From MDN [1]:

> The **`Object.entries()`** method returns an array of a given object's own enumerable
> string-keyed property `[key, value]` pairs, in the same order as that provided by a
> `for...in` loop

And also:

> The ordering of the properties is the same as that given by looping over the
> property values of the object manually.

Both of which suggest that the iteration order is the same as `for...in`, which is to
say that it's not specified. [2] [3]

This changeset removes the cloning, keeping the shallow clone created the line before
which preserves the order of the items in the array.

  [1]:https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/entries
  [2]:https://stackoverflow.com/a/5525820/1267663
  [3]:https://stackoverflow.com/a/30919039/1267663
 2019-04-11 21:50:06 -02:30
Sneh Koul
2786932576 repeated getSelectedAddress() func send.selectors.js removed (#6056) 2019-04-11 15:20:03 -02:30
pldespaigne
0c5d9fc58d fix npm ci bug (version mismatch) 2019-04-11 13:30:33 +02:00
Etienne Dusseault
7ceb1c63cc Added Chrome limited site access solution doc (#6422) 2019-04-10 22:56:47 -02:30
Paul Bouchon
a973a7420a
feature: switch token pricing to CoinGecko API (#6424) 2019-04-10 18:37:15 -04:00
Thomas Huang
d7a2ea9a2b Add Localhost 8545 for network dropdown names 2019-04-10 16:34:13 -05:00
Thomas Huang
7e0006a7fd
Merge pull request #6428 from MetaMask/sharefile.com 
Don't inject web3 on sharefile.com
 2019-04-09 11:56:59 -05:00
Whymarrh Whitby
24761326de
Don't inject web3 on sharefile.com 2019-04-09 14:14:04 -02:30
Whymarrh Whitby
f3f6f8ca68
Merge pull request #6417 from MetaMask/metrics-updates 
Metrics updates
 2019-04-09 00:00:41 -02:30
Thomas Huang
9bd719d33a
Merge pull request #6420 from bbondy/patch-2 
Fix links to MetamaskInpageProvider in porting_to_new_environment.md
 2019-04-08 15:08:03 -05:00
Brian R. Bondy
7b13e9ae2e
Update porting_to_new_environment.md 
This MetamaskInpageProvider file was moved out into its own repo, this updates the link to point to that repo.
 2019-04-08 15:43:34 -04:00
Dan J Miller
79804ec79b Version 6.3.2 (#6418) 2019-04-08 11:22:23 -07:00
Dan Miller
c80b295ccc Only pass english function names to functionType metric 2019-04-08 13:31:11 -02:30
Dan Miller
5d948360c0 Distinguish between token and eth selected in home screen send button metrics event. 2019-04-08 11:06:13 -02:30
Dan Miller
5454266d7c Metrics tracking gas changed - slow, average, fast, custom - on edit screen.- 2019-04-08 11:06:05 -02:30
kumavis
ac39a9b378
Merge pull request #6362 from MetaMask/metamaskbot-comment-content 
Remove broken image walkthrough from metamaskbot comment
 2019-04-05 12:55:49 +08:00
Dan Miller
4963ed65c0 Track seed phrase validation errors with MetaMetrics 2019-04-05 01:32:18 -02:30
kumavis
d610dfa870
Merge pull request #6401 from MetaMask/provider-error-fix 
metamask-controller - use improved provider-as-middleware utility
 2019-04-05 11:13:51 +08:00
Jenny Pollack
98a2fb43fb
Merge pull request #6406 from MetaMask/remove-user-actions-controller 
remove user actions controller
 2019-04-04 17:30:39 -07:00
kumavis
12cca73000 doc - publishing - typo fix (#6399) 2019-04-04 16:19:37 -02:30
Esteban Miño
55cb4bf907
pin eth-contract-metadata to last commit hash (#6396) 2019-04-04 15:49:10 -03:00
pldespaigne
dc4c40414e issue#5742 2019-04-04 17:15:57 +02:00
kumavis
89693a2315 metamask-controller - use improved provider-as-middleware utility 2019-04-04 22:11:28 +08:00
pldespaigne
b26a59dbbe renaming registrar into registry 2019-04-04 14:07:24 +02:00
kumavis
cf4eac3f2c
Merge pull request #6397 from MetaMask/wyre-deposit-modal 
Change coinbase to wyre
 2019-04-04 10:16:26 +08:00
Thomas Huang
6a80ff2718 Change coinbase to wyre 2019-04-03 16:45:43 -05:00
Bruno Barbieri
fee0da1ca3
bump ledger and trezor keyring (#6395) 2019-04-03 16:05:52 -04:00
Dan J Miller
95a2480074 Fix display of gas chart on Ethereum networks (#6389) 2019-04-03 13:31:43 -02:30
Thomas Huang
a46ec83c9b Remove NoticeController (#6382) 2019-04-01 22:33:54 -02:30
Whymarrh Whitby
4055dc3475
Remove unused account-dropdowns components (#6363) 2019-04-01 14:25:33 -02:30
Whymarrh Whitby
259aa36941
Remove unused mascara directory (#6360) 2019-04-01 14:25:14 -02:30
Thomas Huang
87f393eb31
Merge pull request #6375 from MetaMask/Version-6.3.1 
Version 6.3.1
 2019-03-29 13:27:16 -05:00
Dan Miller
57bcf1449c Version 6.3.1 2019-03-29 15:23:55 -02:30
Dan Miller
05fd704fef Check token name constants against the lower case methodData name in conf tx switch container. 2019-03-29 15:23:55 -02:30
Dan Miller
8458873a20 Ensure correct confirm screen in case of smartcontract check fail 2019-03-29 15:23:55 -02:30
Chi Kei Chan
adcf03eacc About tab copy changes; Update route for Info & Help in account menu (#6356) 2019-03-29 13:54:03 -02:30
Dan J Miller
1d14646a4c Revert to providing inline defaults in getHexGasTotal and increaseLastGasPrice (#6361) 2019-03-29 12:47:58 -02:30
Whymarrh Whitby
0762aaa5da Remove broken image walkthrough from metamaskbot comment 2019-03-29 12:39:43 -02:30
Dan J Miller
19c2b298f1
Further e2e fixes in wake of #6364 and #6367 (#6374) 
* getMethodData() default to abi decoded method if registry lookup errors

* Update e2e tests to work with getMethodData() fallback changes

* Remove indeterminency in gas input key entering in send token e2e test.
 2019-03-29 12:18:08 -02:30
Whymarrh Whitby
125a95ba71
Merge pull request #6364 from MetaMask/prevent-infura-requests-e2e-tests 
Prevent infura requests in e2e tests
 2019-03-29 11:27:05 -02:30
Whymarrh Whitby
3113114d51 Split e2e run-all commands onto multiple lines 2019-03-29 11:15:01 -02:30
Dan Miller
5a1545b3e4 Run from-import e2e tests with additional account, to avoid conflict with accounts in earlier test runs 2019-03-29 11:13:39 -02:30
Dan Miller
d927a3c20a Use localhost instead of mainnent/infura for custom rpc tests in e2e tests. 2019-03-29 11:13:39 -02:30
Whymarrh Whitby
7fc84f3cc0 ci: Add build:test Gulp task for e2e build 2019-03-29 11:13:39 -02:30
Whymarrh Whitby
99f53f5827 e2e: Update Contract Interaction wording 2019-03-29 11:13:20 -02:30
Whymarrh Whitby
643ddcb7d7 e2e: Skip approving token test 2019-03-29 11:13:09 -02:30
kumavis
c3a605f27a
Merge pull request #6328 from MetaMask/clearNotices 
Clear notices
 2019-03-29 14:23:02 +08:00
kumavis
133ed80aee
Merge pull request #6372 from MetaMask/addAddressIfNew 
prevent add duplicates when address is not new
 2019-03-29 13:48:15 +08:00
kumavis
0961449ca0 send-footer.utils.js - addressIsNew - improve readability 2019-03-29 13:34:49 +08:00
kumavis
ed381f5b2a test - unit - ui - actions - setCompletedOnboarding - fix stub to call callback 2019-03-29 13:10:42 +08:00