1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-11-22 09:57:02 +01:00
Commit Graph

1126 Commits

Author SHA1 Message Date
OGPoyraz
d99aecc164
deep clone signature tx in order to avoid state mutation bug on development (#19179) 2023-06-01 11:48:07 +02:00
Mark Stacey
000c1f2ef4
Update @metamask/controller-utils to v4 (#19344)
The package `@metamask/controller-utils` has been updated to v4. This
version was part of the core monorepo v53 release. The remaining
packages released as part of v53 will be updated in later PRs.

This release included a variety of breaking changes, but most of them
did not affect the extension's usage of this library. The one that did
have an impact was the removal of the `Json` type, which was identical
to the `Json` type in `@metamask/utils`. We're now using the
`@metamask/utils` version of this type exclusively.

Relates to #19271

Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
2023-05-31 18:33:29 -02:30
David Drazic
f788121c3b
[FLASK] Add Snaps privacy warning on snap install (#18835)
* Add Snaps privacy warning on snap install

Add snap install warning status to storage

Add storybook

Add test for snap-privacy-warning

Resolve button type issue

Fix popup display logic

Update fixture

Update popup information and read more handling

Replace deprecated button

Update unit test

* Update buttons and add cancel flow

* Refactoring (review 1)

* Add more unit tests
2023-05-31 14:43:39 +02:00
legobeat
dfafdbb6bd
Revert "[MMI] Add confirm-transaction-base code fences (#18795)" (#19328)
This reverts commit 97a9834182.

Co-authored-by: António Regadas <apregadas@gmail.com>
2023-05-30 21:39:38 +09:00
Albert Olivé
97a9834182
[MMI] Add confirm-transaction-base code fences (#18795)
* Added code fences

* Continue working on this ticket

* Fixed policies

* Added compliance-row component

* Fixed tests and css

* Fixed invalid locale

* Fixing linting

* Add optional check

* Fixing issues

* Fixed storybook

* Added missing dependency

* ran lavamoat auto

* ran dedupe and lavamoat

* lint

* Removed compliance row

* Removed unneeded package

* Removed unneeded proptyes

* updates mmi packages

* updating lavamoat

* formatting main

* Fixed conflicts

* updates lock file

* Moved code fences to have them all in the same place

* Updated yarn.lock and lavamoat

* remove linebreak

* Improved logic in order to not have many code fences and improve readability

* Fixing proptypes issues with eslint

* runs lavamoat auto

* Testing fixes issue e2e tests

* Testing issues

* Reverting code fences container

* Fixing issue with binding

* Added code fences in proptypes

* Reverting code fences

---------

Co-authored-by: Antonio Regadas <antonio.regadas@consensys.net>
Co-authored-by: António Regadas <apregadas@gmail.com>
2023-05-29 16:50:56 +01:00
Daniel
e1b12279ab
Show the right "balance needed" value if we fallback from STX to regular Swaps (#19230)
* Show the right balance needed value if we fallback from STX to regular Swaps
* Fix usage of StxErrorTypes
2023-05-25 19:30:10 +02:00
Daniel
af018efcb6
Styling fix and content update for Swaps (#19284) 2023-05-25 18:48:11 +02:00
Albert Olivé
057188d155
[MMI] Add code fences in signature-request (#18770)
* Started adding code fences in signature-request

* Finished code fencing

* Improving code

* Fixed storybook and code fences bundle

* Added missing dependency

* Fixed yarn.lock

* Fixing policies

* Updated package.json

* updating lavamoat

* lavamoat fix

* adds missing package

* runs yarn dedupe

* updates method name

* run lavamoat:auto again

* Added more code fences

* updates snapshot

* snapshot updates

* updates mmi packages to lighter versions

* updates mmi packages

* runs lavamoat auto

* updates yarn lock and runs lavamoat auto

* updates yarn lock

* updates targets file

* Removed console log and added tests

---------

Co-authored-by: António Regadas <apregadas@gmail.com>
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
Co-authored-by: Antonio Regadas <antonio.regadas@consensys.net>
2023-05-24 13:41:21 +02:00
Monte Lai
832ce634fd
feat(accounts): import account without password (#19132)
import account without password

---------

Co-authored-by: Mike B <32695229+plasmacorral@users.noreply.github.com>
Co-authored-by: Gustavo Antunes <17601467+gantunesr@users.noreply.github.com>
Co-authored-by: Howard Braham <howrad@gmail.com>
2023-05-23 15:54:30 -07:00
Nidhi Kumari
9db971768b
UX Multichain: updated ui for settings page (#19167)
* updated ui for settings page

* lint fix

* resolved errors

* fixed search bar css

* fixed css

* lint fix

* fixed tests

* fixed indentation

* updated settings aria label
2023-05-23 23:59:00 +05:30
Hassan Malik
a9429c5c0d
[FLASK] Fix classnames for snaps components (#19234)
* renamed classnames according to BEM, removed unnecessary scss file

* remove plurality in classnames
2023-05-23 09:07:44 -04:00
Frederik Bolding
80437b9b4a
[FLASK] Fix an issue with submitting an empty Snaps UI prompt (#19227)
* Fix an issue with submitting an empty Snaps UI prompt

* Fix code fencing

* Revert accidental whitespace change
2023-05-23 11:46:45 +02:00
George Marshall
8437d0491f
Deprecated Icon and ButtonIcon clean up (#19220)
* Updating all deprecated instances of Icon and ButtonIcon

* Removing unused deprecated components and scripts
2023-05-19 10:33:02 -07:00
OGPoyraz
99bd28d1d9
fix: support alerts confirmation page without pending transactions (#18983) 2023-05-19 14:13:34 +02:00
Ariella Vu
813ad984ce
Fix contract interaction recipient and contract address (#18855) 2023-05-18 18:19:40 +01:00
Andrew Peters
67614593a8
Disable Previous Button on First Page (#17610)
* disable prev page button

* test added

* test fixes

* tests fixed

* test fix

---------

Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
Co-authored-by: Mike B <32695229+plasmacorral@users.noreply.github.com>
2023-05-18 09:24:04 -04:00
legobeat
8675c7863e
devDeps: storybook@7 (#19092)
* devDeps: pin @babel/core and @babel/runtime in resulotions
    Without this: misses patch, lavamoat error


* storybook 6 to 7 migration
* devDeps: add @storybook/addon-mdx-gfm
* fix lint deps
* devDeps: remove unused require-from-string
* devDeps/resolutions: @types/react@^16.9.53
* devDeps: add @storybook/cli
* storybook: new-frameworks migration
* iyarc: remove resolved dependency advisory
* deps: set globalthis@1.0.1 in resolutions
   This is required since a file is copied over from a set path in the dist
   package subdirectory as of d13aabde23 (#10014).
   A future update should either vendor the shim, or update to
   compatibility with a maintained upstream version.

* mdx2 migration fixes
* chore: bump ljharb packages
* devDeps: @storybook/*@^7.0.10->^7.0.11
* storybook: update preview.js to use v7 addon api
* ci/test/storybook: echo between storybook build&test
* ci/circleci: resources tweak
* info-tab: handle undefined global.platform
* update lavamoat build policy
* update lavamoat browserify policies
2023-05-18 11:07:42 +09:00
Nidhi Kumari
ac6fb3bb09
UX Multichain: updated assets to tokens in home page (#19144)
* updated assets to tokens in home page

* lint fix

* lint fix

* updated tests and spec files

* lint fix
2023-05-17 08:30:47 +05:30
Albert Olivé
a017a1bae0
[MMI] Added note to trader code fencing (#18051)
* Added note to trader code fencing

* Started adding code fences in signature-request

* Finished code fencing

* Improving code

* adds check and runs prettier

* Fixed storybook and code fences bundle

* Added missing dependency

* updates fences

* fewer lines

* undo previously merged PR

* ran lavamoat auto

* adds test

* prettier

---------

Co-authored-by: António Regadas <apregadas@gmail.com>
Co-authored-by: Antonio Regadas <antonio.regadas@consensys.net>
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
2023-05-16 16:44:08 +01:00
Albert Olivé
f95320d03e
[MMI] Started adding styles imports with code fences (#17943)
* Started adding styles imports with code fences

* FIxed prettier issues

* removed fences since they dont do anything

* Update ui/components/ui/ui-components.scss

Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>

---------

Co-authored-by: Antonio Regadas <antonio.regadas@consensys.net>
Co-authored-by: António Regadas <apregadas@gmail.com>
Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
2023-05-15 12:38:54 +01:00
OGPoyraz
d37d5bf0ee
feat: Refactor Transaction Confirmation selector (#18796) 2023-05-11 07:56:17 +02:00
Vinicius Stevam
df3db6e559
Adopt ApprovalType from core (#18567) 2023-05-10 06:36:01 +01:00
Harsh Shukla
e991439718
Part of #17670 & #18714: Replace Typography with Text component in token-details-page.js (#18741)
* Worked on issue #17670 & #18714 in file token-details-page.js in file

* Worked on issue #17670 & #18714 in file token-details-page.js in file

* Update token-details-page.js
2023-05-09 17:55:30 -07:00
Nidhi Kumari
6535e34943
Replaced all fa-icon-circle with INFO icon (#17539)
* replace all fa-icon-circle with INFO icon

* updated classnames

* updated classnames

* updated snapshots

* updated colors

* resolved errors

* fixed relative import

* fixed lint errors

* added story for alerts tab

* update snapshot

* updated info-circle

* updated enum for iconName

* removed classnames

* updated iconName in settings

* fixed lint errors and snapshots
2023-05-09 23:04:58 +05:30
Nidhi Kumari
cde449925b
UX Multichain: updated margin top for assets tab (#19071)
* updated margin top for assets tab

* remove changes from yml file

* remove changes from yml file
2023-05-09 11:32:56 -05:00
David Walsh
b981377304
UX: Multichain: Disable network and account picker when necessary (#18909) 2023-05-08 12:32:39 -05:00
António Regadas
7ebd561ff9
[MMI] adds mmi logic in home view (#18960)
* adds mmi logic to home container

* adds code fences to home component

* adds code fences to home component

* lint fix

* lint fix

* updates fences and runs prettier

* version bump

* clean up code fence
2023-05-08 15:09:00 +01:00
Nidhi Kumari
e8dd6a6ff1
UX Multichain: Added extra margin for native token (#18988)
* added extra margin for native token

* fixed lint errors

* added marginTop via css

* updated test

* added boxprops and margin bottom for tab component

* updated snapshot

* update asset list component
2023-05-08 19:17:45 +05:30
Monte Lai
0306422bbf
Add reveal to export private key (#18170)
Co-authored-by: George Marshall <george.marshall@consensys.net>
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
Co-authored-by: David Walsh <davidwalsh83@gmail.com>
Co-authored-by: Howard Braham <howrad@gmail.com>

* change js to tsx

* update to typescript

* add labels to circle animation

* add willHide prop to hold to reveal modal

* add test

* convert to design system

* fix lint

* fix type

* bump coverage

* rename

* remove comments

* remove ts comment and add fix exhuastive dep check

* update coverage

* add hide modal test

* use banneralert

* update label

* remove unused

* fix text

* update aria label messages

* change exportAccountAndGetPrivateKey to be async

* fix lint

* update coverage target

* update coverage

* update input component

* update coverage

* update coverage

* fix blank line

* use &&

* move plainKey to under !privateKeyInput

* update hold modal to display srp and private key message

* fix styling

* fix lint and test

* fix unused locales

* remove redundent check

* update storybook

* fix text alignment

* fix lint

* update snapshot

* fix test

* update coverage

* fix merge conflict

* refactor

* fix variant

* update snapshot

* fix test after merge

* fix test after merge conflict

* fix label text

* update to use label component
2023-05-06 17:04:20 -04:00
Harsh Shukla
944d39ed3a
Part of #17670: Replace Typography with Text component in smart-transaction-status.js (#18743)
* Update smart-transaction-status.js

* Update smart-transaction-status.js

* Update smart-transaction-status.js again.

* Update smart-transaction-status.js

* Update smart-transaction-status.js

* Update ui/pages/swaps/smart-transaction-status/smart-transaction-status.js

Co-authored-by: George Marshall <georgewrmarshall@gmail.com>

* Update smart-transaction-status.js

---------

Co-authored-by: Brad Decker <bhdecker84@gmail.com>
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
2023-05-05 12:15:39 +01:00
Harsh Shukla
9fae71505c
Part of #17670 Replace Typography with Text component for 4 files. (#18793)
* Worked on issue #17670 & #18714 for 4 other files.

* Updated snapshots.

* Update index.test.js.snap

* Update customize-nonce.test.js.snap

* Update signature-request.component.test.js.snap

---------

Co-authored-by: Brad Decker <bhdecker84@gmail.com>
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
2023-05-05 12:14:09 +01:00
Guillaume Roux
f0fd1772ee
[FLASK] Don't show the title on Install/Update when it's loading (#19012) 2023-05-05 10:00:14 +02:00
Jyoti Puri
9c63dfca89
Changes in blockaid texts (#19001) 2023-05-04 23:51:46 +05:30
Harsh Shukla
398b0cf452
Part of #17670 & #18714: Replace Typography with Text component: token-allowance.js (#18742)
* Update token-allowance.js

* Remove fontWeight prop in: ui/pages/token-allowance/token-allowance.js

Co-authored-by: George Marshall <georgewrmarshall@gmail.com>

* Update ui/pages/token-allowance/token-allowance.js

Co-authored-by: George Marshall <georgewrmarshall@gmail.com>

* Update token-allowance.js

* Update ui/pages/token-allowance/token-allowance.js

Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>

* Update ui/pages/token-allowance/token-allowance.js

Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>

---------

Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
2023-05-04 22:08:43 +05:30
António Regadas
229906d09a
clean up and adds a code fence (#19005) 2023-05-04 15:57:12 +01:00
Nidhi Kumari
cfc653ada6
eth_sign toggle Update in advanced settings (#18848)
* added eth sign first step

* added modal

* added validation for form

* updated width with block

* added state trigger for toggle

* updated Eth sign modal text changes

* added eth sign toggle tex

* removed unnecessary code

* fixed form validation text

* updated eth toggle text

* added test

* added analytics

* updated design changes

* lint fix

* updated error text

* updated changes
2023-05-04 16:44:07 +05:30
David Walsh
ab4843f06b
UX: Multichain: Implement Account Details Popover (#18811)
* UX: Multichain: Implement Account Details Popover

* Styling account details popover

* using ButtonSecondary with variant, removing Text

* adding account-details jest test

* Close popover when outside area clicked

* Move all export functionality into the popover

* Improve jest tests

* Implement new design for export key screens

* Hide warning when popover is closed

* Vertically align the copy button

* Move AccountDetailsDisplay to its own file

* Move authentication to its own file

* Move private key to its own component

* Fix misalignment of avatar on display screen

* Move private key to its own component

* Update ui/components/multichain/account-details/account-details-authenticate.js

Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>

* Update ui/components/multichain/account-details/account-details.test.js

Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>

* Prevent account name overflow, update text size

* Use FormTextField

* Add analytics

* Move location of accountDetailsAddress

* Ensure passsword input is used

---------

Co-authored-by: Victor Thomas <10986371+vthomas13@users.noreply.github.com>
Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
2023-05-03 12:09:13 -05:00
Monte Lai
a3cf0036ad
Feat/srp metrics (#18015)
* add srp metrics

* add event names

* fix text

* add test

* add event test to hold to reveal modal

* fix lint

* add event test to reveal seed

* update coverage target

* revert willHide

* add more tests

* fix lint

* update coverage

* git commit -m "fix comments"

* fix merge conflict

* fixed the merge conflicts with #18353

* fix text

* update deprecated import

* alphabetize metametrics enums

* update coverage

* update coverage

---------

Co-authored-by: Brad Decker <bhdecker84@gmail.com>
Co-authored-by: Howard Braham <howrad@gmail.com>
2023-05-03 11:26:45 -05:00
António Regadas
bf0a70dbba
adds custody page route to account routes (#18985) 2023-05-03 15:04:49 +01:00
Dominik Rudzki
b5a11857c4
[FLASK] Fix overflowing notification content (#18881)
* Fix overflowing notification content

* Wrap overflow

* Fix lint & remove unnecessary width

---------

Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
2023-05-03 11:27:01 +02:00
Frederik Bolding
c716592fd1
Clean up some code fencing around snaps (#18802)
* Clean up some code fencing around snaps

* Fix code fencing

* Fix more fencing issues
2023-05-03 10:53:58 +02:00
Mark Stacey
d1cea85f33
Rename provider to providerConfig (#18907)
* Rename `provider` to `providerConfig`

The network controller `provider` state has been renamed to
 `providerConfig`. This better reflects what this state is, and makes
this controller more closely aligned with the core network controller.

All references to the provider configuration have been updated to
prefer `providerConfig` over `provider`, to make the distinction clear
between a provider and provider config.

Closes #18902

* Add migration
2023-05-02 13:23:20 -02:30
Mark Stacey
88ae10418b
Expand usage of getProviderConfig selector (#18906)
The `getProviderConfig` selector is now used anywhere the `provider`
state was previously referenced directly. This was done to simplify
renaming this state from `provider` to `providerConfig` in a later PR.

Note that there are many opportunities left to use more-specific
selectors (e.g. `getChainId()` over `getProviderConfig().chainId`), but
that was intentionally omitted from this PR to reduce the size. I
started going down this path and it quickly exploded in scope.

Relates to #18902
2023-05-02 10:06:24 -02:30
Ariella Vu
a5d7cf3319
Transaction cleanup and fix TransactionDetailItem key not unique bug (#18899)
* TransactionDetailItem: allow empty detailText

* TxDetailItem: fix keys; ensure unique keys
2023-05-02 00:42:59 -03:00
Harsh Shukla
f5f2e2e35f
Part of #17670 , #18714 & #18651 for 3 files. (#18752)
* Adding strong tag support for Text component

* Update build-quote.js

* Update awaiting-signatures.js

* Used <strong> tag in a better way.

* Remove <strong> tag from file: awaiting-signatures.js

Co-authored-by: Danica Shen <zhaodanica@gmail.com>

* Update awaiting-signatures.js

* Update ui/components/component-library/text/text.scss

Co-authored-by: George Marshall <georgewrmarshall@gmail.com>

* Update ui/pages/swaps/build-quote/build-quote.js

Co-authored-by: George Marshall <georgewrmarshall@gmail.com>

* Removing unintended UI and strong css from Text component

---------

Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
Co-authored-by: Danica Shen <zhaodanica@gmail.com>
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
2023-05-01 17:48:58 -07:00
Harsh Shukla
32a7f0fe09
Update pin-extension.js (#18877) 2023-05-01 17:39:56 -07:00
Mark Stacey
f765b8c9b9
Refactor provider config selector (#18905)
The provider configuration selector has been renamed from `getProvider`
to `getProviderConfig`, and it has been moved from the selectors module
into the MetaMask slice. A JSDoc description has been added as well.

This refactor was done to make a future PR simpler, and to make this
selector better aligned with best practices.

This relates to #18902
2023-05-01 21:04:43 -02:30
Jyoti Puri
4bad30c94d
Show gas warning for legacy networks also (#18871) 2023-05-01 20:33:32 +05:30
Albert Olivé
8193a4999c
Added code fences (#18872) 2023-05-01 15:59:35 +02:00
Harsh Shukla
7b323b8a30
Part of #17670: Replace Typography with Text component for 11 files. (#18837)
* Part of #17670: Replace Typography with Text component for 10 files.

* Update radio-group.component.js

* Update create-password.test.js.snap

* Update custom-spending-cap.test.js.snap

* Update add-network-modal.test.js.snap

* Update recovery-phrase-reminder.js
2023-04-28 16:18:46 -07:00