1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
Commit Graph

6242 Commits

Author SHA1 Message Date
Danica Shen
d4bc0a453b fix(17542): fix fiat currency display in few txn actions (#18011)
* fix(17542): fix fiat currency display in few txn actions

* fix(17542): refactor e2e tests to change to fia via fixture builder
2023-03-09 09:56:14 +00:00
Danica Shen
353c9927b4 fix(17857): show correctly converted account balance in sign&encrypt windows (#17973)
Co-authored-by: Dan J Miller <danjm.com@gmail.com>
2023-03-06 11:24:14 +00:00
David Walsh
5933dd1fd7 UX: Icon: Restore missing back chevron in settings (#17916)
* UX: Icon: Restore missing back chevron in settings

* Update ui/pages/settings/settings.component.js

Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>

* Fixing size and alignment

---------

Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
Co-authored-by: Garrett Bear <gwhisten@gmail.com>
2023-03-06 11:20:02 +00:00
Frederik Bolding
27f322c7db Selector performance improvements (#17410)
* Stop checksumming addresses unnecesarily

* Fix lint
2023-03-02 17:56:00 +00:00
ryanml
d0bea6ccd5 Fix incorrect balance in signature request header (#17829)
* Fix incorrect balance in signature request header

* Fix unit tests

* Fix tests and increase unit test coverage

* actually fix unit tests

---------

Co-authored-by: Dan Miller <danjm.com@gmail.com>
2023-03-02 12:48:19 +00:00
David Walsh
a4f42775b0 UX: Icons: Remove usage of chevron fa- icons (#17668) 2023-03-02 12:41:53 +00:00
David Walsh
0ef1d97061 UX: Icons: Stop using fa-address-book (#17761)
* UX: Icons: Stop using fa-address-book

* Remove locale string

* Fix positioning
2023-03-02 12:40:20 +00:00
David Walsh
de26c9e4a1 UX: Replace all fa-bell instances with Notification icon (#17524)
* UX: Replace all fa-bell instances with Notification icon

* Fix flask comment fencing

* Fix import error
2023-03-02 12:39:41 +00:00
Jyoti Puri
5691a00e20 Fix state in confirm transaction (#17838) 2023-03-02 11:38:53 +00:00
Ariella Vu
1d733194ea Cleanup: clearTimeout on useEffect for gas estimation and prevent state update on unmounted ConfirmTransactionBase (#17804) 2023-03-02 11:38:42 +00:00
Jyoti Puri
49d84140d9 Confirm transaction test (#17780) 2023-03-02 11:38:34 +00:00
Ariella Vu
de5ea66d8d Clean ConfirmTranscationPage component (#17546)
* ConfirmTransaction: rm unused metricEvent context

* ConfirmTransaction: rm unused mapToProps props:
- unapprovedTxs
- id

* ConfirmTransaction: convert to FC

* ConfirmTransaction: use const ORIGIN_METAMASK

* ConfirmTransaction: rm mapStateToProps

* ConfirmTransaction: mv confirm-transaction ducks

* ConfirmTransaction: mv getContractMethodData duck

* ConfirmTransaction: rm container file

* ConfirmTransaction: use ORIGIN_METAMASK const

* clean: rn totalUnapprovedCount -> totalUnapproved

* clean: reorder ConfirmTransaction & alphabetize

* clean: rn validTransactionId> isValidTransactionId

* clean: rn unconfirmedTransactions > unconfirmedTxs

* ConfirmationTransaction: add tests

* ConfirmTransaction: mv const

* ConfirmTransaction: update jest mock after merge

* ConfirmTransaction: fix from merge fault

* tests: update snapshot after mock-state updates
2023-03-02 11:38:24 +00:00
Ariella Vu
97013d8028 Fix GetEncryptionKey TypeError Cannot destructure property 'msgParams' of 'txData' (#17808)
* fix ConfirmEncryptionPublicKey txData

* encrypt/decrypt: fix missing txData state

* rm console.log
2023-03-02 10:55:07 +00:00
Brad Decker
591fe1a0a6 avoid mutation of state in signTransaction action (#17772)
Co-authored-by: ryanml <ryanlanese@gmail.com>
2023-03-02 10:54:55 +00:00
ryanml
2a6bcff4e2 Do not display experiment settings tab when there are no settings to show (#17765) 2023-03-02 10:52:58 +00:00
ryanml
970a5d4a77 Fix currency symbol in insufficient balance warning (#17820) 2023-03-02 10:48:09 +00:00
Dan J Miller
48251a4189 Ensure simulation failure warning is shown on all networks and accounts (#17458)
* Ensure simulation failure warning is shown on all networks and accounts

* Add e2e test to cover failure warning behaviour on non-eip-1559 network

* Fix new e2e test
2023-03-02 10:44:36 +00:00
David Walsh
72ae54bfa3 UX: Icons: Use proper send icon on wallet and token overview pages (#17720) 2023-02-15 10:26:21 -07:00
George Marshall
a5b908ccf3
Deprecating Typography component (#17672)
* Deprecating Typography component

* Fixing lint issue
2023-02-09 12:17:25 -08:00
Sam Gbafa
7aad1c9650
remove siwe feature flag (#17690)
Co-authored-by: Ariella Vu <20778143+digiwand@users.noreply.github.com>
2023-02-10 02:05:16 +07:00
amerkadicE
0c2af508ef
Fix recent recipient order (#16346) 2023-02-09 23:15:52 +05:30
David Walsh
10be6fcfeb
UX: Update block explorer icon (#17562)
* UX: Update block explorer icon

* Removing unneeded CSS and some HTML bloat

* Removing unneeded className

* Removing unneeded CSS and reducing HTML bloat for ContractTokenValues

---------

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
2023-02-09 10:21:51 -06:00
EresDev
58cd3deed5
fix test of useTransactionDisplayData for different timezone (#17063)
Co-authored-by: ryanml <ryanlanese@gmail.com>
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
Fixes https://github.com/MetaMask/metamask-extension/issues/17062
2023-02-08 17:13:39 -06:00
Jyoti Puri
61a7850afc
Sanitising string on signature request pages (#17571) 2023-02-09 04:35:52 +05:30
Nidhi Kumari
3be1fc6d0c
converted collectibles files to nfts (#17658)
* converted collectibles files to nfts

* updated relative import for scss

* updated scss for pages
2023-02-08 20:04:56 +05:30
Maarten Zuidhoorn
ff85b040cb
Sort permissions based on weight (#17660) 2023-02-08 15:28:48 +01:00
Ariella Vu
b5c1de900d
Refactor ConfirmTransaction to Functional Component (#17473)
* ConfirmTransaction: rm unused metricEvent context

* ConfirmTransaction: rm unused mapToProps props:
- unapprovedTxs
- id

* ConfirmTransaction: convert to FC

* ConfirmTransaction: use const ORIGIN_METAMASK

* ConfirmTransaction: rm mapStateToProps

* ConfirmTransaction: mv confirm-transaction ducks

* ConfirmTransaction: mv getContractMethodData duck

* ConfirmTransaction: rm container file

* ConfirmTransaction: use ORIGIN_METAMASK const

* ConfirmationTransaction: add tests

* ConfirmTransaction: update jest mock after merge

* tests: update snapshot after mock-state updates
2023-02-08 18:00:25 +07:00
Matthew Walsh
92367dff79
Add desktop build type (#17592)
Implement build type inheritance.
Add CircleCI jobs for desktop build type.
2023-02-08 09:24:01 +00:00
George Marshall
b55f955243
Adding docs for layout and spacing for Icon component (#17612)
* Adding docs for layout and spacing for Icon component

* Adding close bracket
2023-02-07 10:07:50 -08:00
Thomas Huang
14efbf1eea
Collectible Unit Tests (#17632)
* Add ipfs gateway and collectible state to mock-state.json

* Add collectible-default-image test with snapshot and testids

* Add Collectible Details test, snapshot, and test-ids

* Add Collectible Options tests and test-ids

* Add Collectible Items test and test-ids.

* Add more tests to Add Collectible component

* Update Security Tab snapshot with ipfs gateway state value

* Add data-testid to Menu component for menu background

* Lint

* Bump coverage targets

* Remove commented import

---------

Co-authored-by: David Walsh <davidwalsh83@gmail.com>
2023-02-07 12:06:37 -06:00
Garrett Bear
fd53de6af5
Update BannerAlert component (#17586)
* update button alert component

* update test

* rename Banner to BannerAlert

* remove old banner snapshot

* fix banner alert border left
2023-02-07 09:32:35 -08:00
Monte Lai
31afc76f9b
fix: update ledger logo (#17616) 2023-02-07 05:10:21 +08:00
Maarten Zuidhoorn
1d5030af97
Add hardcoded list of human-readable snap derivation paths (#17627)
* Add hardcoded list of human-readable snap derivation paths

* Fix formatting

* Update policies
2023-02-06 21:49:56 +01:00
Harry
b4ecc4c3f5
Disable eth_sign by default, allow users to toggle it back on (#17308)
* Added translation for eth sign toggle

* Disabled the ability to call eth_sign by default. Added ability within advanced settings to renable support for eth_sign

* Add test case for eth_sign being enabled and disabled

* Modified copy

* Moved rpc method preference to its own object within store

* Complete work on moving rpc method preference into its own object within store

* Fix with prettier

* Fix lint

* Fix a unit test

* Fix test

* Renamed function and object keys to be more intuitive

* Fix e2e test

* Enabled eth_sign through preferences fixture

* Fix lint

* Fix e2e test

Wait for the notification popup to close, leaving 2 window handles the extension and the test dapp

* Fix e2e test

* Fix unit test

Enable eth_sign method

* Lint fix

---------

Co-authored-by: PeterYinusa <peter.yinusa@consensys.net>
Co-authored-by: Dan J Miller <danjm.com@gmail.com>
2023-02-06 13:17:50 -03:30
David Walsh
02d608d20c
UX: Fix token image not displaying in asset listing (#17575) 2023-02-06 08:31:19 -06:00
David Walsh
4b8aebbd5d
Prevent lint warning in ActionableMessage (#17598) 2023-02-06 08:30:02 -06:00
Maarten Zuidhoorn
8cda817f5c
Add hardcoded list of human-readable snap names (#17595)
* Add hardcoded list of human-readable snap names

* Make the text properly bold

* Small style fixes to approval screen

* Run yarn lint:fix

* Update snapshots
2023-02-06 11:05:57 +01:00
David Walsh
68ea3a7298
NFTs: Update event name for Detect NFT settings (#17597) 2023-02-03 19:19:07 -06:00
David Walsh
678ad6397b
Change COLORS reference to Color (#17599)
* Change COLORS reference to Color

* Fix lint
2023-02-03 17:47:45 -06:00
David Walsh
330cba61de
UX: Remove the IconCopy and IconCopied Components and their usages (#17530) 2023-02-03 16:06:14 -06:00
David Walsh
710b1a3fbf
UX: Update support icon (#17560) 2023-02-03 16:05:51 -06:00
Brad Decker
31897b542d
Convert actions.js to typescript (#17446) 2023-02-03 11:56:44 -06:00
Niranjana Binoy
769efc9fe3
Disable fiat conversion in Approve Screen when Show balance and token price checker is OFF (#17443) 2023-02-03 12:13:19 -05:00
Dan J Miller
0c24448037
Ensure the advanced gas modal displays a zero priority fee if that is how it is set in the transaction (#17559)
Co-authored-by: Pedro Figueiredo <pedro.figueiredo@consensys.net>
2023-02-03 12:30:49 -03:30
Danica Shen
6b076fa346
feature: convert ui/ducks/app/app.ts to typescript (#17454)
Co-authored-by: Pedro Figueiredo <pedro.figueiredo@consensys.net>
2023-02-03 08:59:07 -06:00
Dan J Miller
8fa45c5454
Fix speed up of 0 max priority fee transactions (#17547)
* Fix speed up of 0 max priority fee transactions

* Update ui/hooks/gasFeeInput/useTransactionFunction.test.js

Co-authored-by: Brad Decker <bhdecker84@gmail.com>

* Use bignumber for comparison to zero

---------

Co-authored-by: Brad Decker <bhdecker84@gmail.com>
Co-authored-by: Pedro Figueiredo <pedro.figueiredo@consensys.net>
2023-02-03 07:57:32 -03:30
Garrett Bear
0465263d3e
update banner base component (#17582)
* update banner base component

* add description to story controls
2023-02-03 13:42:53 +05:30
Nidhi Kumari
41d3dcc8a3
updated tag icon (#17540) 2023-02-02 17:13:49 -08:00
Brad Decker
02b2d7fa42
Dead and redundant code removal (#17512) 2023-02-02 16:00:05 -06:00
Brad Decker
3fc26521d4
initialize currentLocale in the locale slice upon app start (#17579) 2023-02-02 15:24:48 -06:00