Mark Stacey
ce66ddcf0d
Use prettier
for JSON linting ( #9396 )
...
Instead of using `eslint-plugin-json` for linting JSON files,
`prettier` is now used. `prettier` is capable of detecting and
correcting more problems than `eslint-plugin-json` can, such as
indentation.
All JSON files have been run through `prettier`. The changes are all
superficial.
2020-09-11 10:57:39 -03:00
Kevin Holder
95acee95b5
nodeify removeFromAddressBook ( #9395 )
...
Right now when editing an address in "Settings > Contact", the contact
is lost after saving. This is because the code awaits
`removeFromAddressBook()` before creating the new contact but
`removeFromAddressBook()` never resolves. This change fixes this bug.
2020-09-11 09:58:51 -02:30
Whymarrh Whitby
e2dedaacdb
Use Infura v3 API ( #9368 )
...
* Use eth-json-rpc-infura@5.0.0
* Use Infura v3 API
* Add example .metamaskrc file
2020-09-10 13:46:00 -02:30
matteopey
ee36073eb5
Update italian translation ( #9293 )
2020-09-10 09:53:38 -02:30
Erik Marks
f02ba2d561
Ensure the extension can be unlocked without network access ( #9295 )
...
move checkForLatestBlock to separate catch block
add test case
remove duplicate checkForLatestBlock call
2020-09-08 22:29:24 -07:00
Patryk Łucka
3d4f1f45bd
Add messages to Ledger connection process ( #9344 )
2020-09-02 13:58:14 -02:30
Erik Marks
867dd33c1e
Remove 'Contact us' exclamation mark ( #9307 )
2020-08-25 13:54:33 -07:00
Erik Marks
81a1d0a23d
Remove unused diagnostics property ( #9296 )
...
* Remove unused diagnostics property
2020-08-25 13:54:15 -07:00
Erik Marks
29550e3e65
Remove 'Contact us' exclamation mark
2020-08-25 09:42:45 -07:00
Erik Marks
3aaa41ef44
Replace abi-decoder with ethers ( #9290 )
...
* replace abi-decoder with ethers
* handle transaction parsing errors
* update token param getter function names
* add docstrings
2020-08-21 19:29:19 -07:00
Erik Marks
e08a55c8bc
Add messages for MetaMetrics opt-in ( #9283 )
...
* Add messages for MetaMetrics opt-in
2020-08-20 17:13:14 -07:00
Whymarrh Whitby
f656d3236e
Remove outdated comment from MetamaskController ( #9284 )
2020-08-20 21:03:52 -02:30
Mark Stacey
0c72d0bc3d
Merge remote-tracking branch 'origin/develop' into sync-master
...
* origin/develop: (137 commits)
Use @metamask/eslint-config@3.1.0 (#9275 )
Standardize scss import practices (#9183 )
Update ESLint shared config to v3 (#9274 )
Add lock icon to default networks (#9269 )
Adds toPrecisionWithoutTrailingZeros utility (#9270 )
Hide gas estimate on non-main network (#9189 )
Move the mascot component to its own directory (#9272 )
Use @metamask/controllers@2.0.5 (#9266 )
Fix padding, alignment of actionable-message; add left aligned story
Code cleanup and simplification for actionable-message component
Adds actionable message component and stories
Fix lint issues (#9265 )
Fix prefer-destructuring issues (#9263 )
colocate confirm-decrypt-message page styles (#9252 )
Tidy up Migrator tests (#9264 )
Adds pulse loader component (#9259 )
Fix import/order issues (#9239 )
Fix radix issues (#9247 )
New info tooltip component (#9180 )
Improve scss naming
...
2020-08-19 17:53:20 -03:00
Whymarrh Whitby
b6ccd22d6c
Update ESLint shared config to v3 ( #9274 )
...
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
2020-08-19 13:57:05 -02:30
Mark Stacey
de354751fd
Handle non-String web3 property access ( #9256 )
...
The web3 usage metrics added in #9144 assumed that all web3 properties
were strings. When a `Symbol` property is accessed, our `inpage.js`
script crashes because the `Symbol` cannot be serialized correctly.
A check has been added for non-string property access. The metric event
in these cases is set to the string "typeof ", followed by the type of
the key. (e.g. `typeof symbol` for a `Symbol` property).
Fixes #9234
2020-08-18 23:10:06 -03:00
MetaMask Bot
5c88d8d250
Version v8.0.9
2020-08-19 02:07:15 +00:00
Whymarrh Whitby
6ab12001e3
Fix prefer-destructuring issues ( #9263 )
...
See [`prefer-destructuring`](https://eslint.org/docs/rules/prefer-destructuring ) for more information.
This change enables `prefer-destructuring` and fixes the issues raised by the rule.
2020-08-18 17:36:58 -02:30
Whymarrh Whitby
c1e3c229bc
Fix import/order issues ( #9239 )
...
See [`import/order`](https://eslint.org/docs/rules/import/order ) for more information.
This change enables `import/order` and fixes the issues raised by the rule.
2020-08-18 16:48:25 -02:30
Whymarrh Whitby
b7259e5d6a
Fix radix issues ( #9247 )
...
See [`radix`](https://eslint.org/docs/rules/radix ) for more information.
This change enables `radix` and fixes the issues raised by the rule.
2020-08-18 16:38:22 -02:30
Whymarrh Whitby
4357cda7b8
Fix no-shadow issues ( #9246 )
...
See [`no-shadow`](https://eslint.org/docs/rules/no-shadow ) for more information.
This change enables `no-shadow` and fixes the issues raised by the rule.
2020-08-18 14:06:45 -02:30
Mark Stacey
27e1189c91
Handle non-String web3 property access ( #9256 )
...
The web3 usage metrics added in #9144 assumed that all web3 properties
were strings. When a `Symbol` property is accessed, our `inpage.js`
script crashes because the `Symbol` cannot be serialized correctly.
A check has been added for non-string property access. The metric event
in these cases is set to the string "typeof ", followed by the type of
the key. (e.g. `typeof symbol` for a `Symbol` property).
Fixes #9234
2020-08-18 12:01:43 -03:00
Whymarrh Whitby
e803807dd9
Fix no-param-reassign issues ( #9235 )
...
See [`no-param-reassign`](https://eslint.org/docs/rules/no-param-reassign ) for more information.
This change enables `no-param-reassign` and fixes the issues raised by the rule.
2020-08-15 09:28:11 -02:30
Mark Stacey
52fd72feac
Merge remote-tracking branch 'origin/develop' into sync-master
...
* origin/develop: (107 commits)
Clear Account Details in AppState (#9238 )
Permit all-caps addresses (#9227 )
Send web3 usage metrics once per origin/property (#9237 )
Fix import/no-extraneous-dependencies issues (#9232 )
Remove unused buyEth fn from bg (#9236 )
Fix max-statements-per-line issues (#9218 )
Consolidate ESLint config files (#9231 )
Delete page-container.component.test.js (#9229 )
Tidy up getAccountLink (#9223 )
Tidy ConnectHardwareForm#checkIfUnlocked (#9224 )
Fix require-unicode-regexp issues (#9212 )
Fix no-negated-condition issues (#9222 )
Fix no-empty-function issues (#9216 )
Fix import/extensions issues (#9217 )
Dedupe glob-parent versions (#9220 )
Fix no-template-curly-in-string issues (#9221 )
Fix no-process-exit issues (#9219 )
Fix prefer-rest-params issues (#9215 )
Fix no-prototype-builtins issues (#9213 )
Fix no-nested-ternary issues (#9214 )
...
2020-08-14 20:32:32 -03:00
MetaMask Bot
5db866bc88
Version v8.0.8
2020-08-14 19:39:41 -03:00
Mark Stacey
d49c44426f
Send web3 usage metrics once per origin/property ( #9237 )
...
The usage metrics for the injected web3 instance were being sent upon
each use, which exceeded the limits of our Matomo plan. These metrics
are now only being sent upon the first usage, for each origin and
property.
2020-08-14 19:15:40 -03:00
Mark Stacey
f77151003e
Send web3 usage metrics once per origin/property ( #9237 )
...
The usage metrics for the injected web3 instance were being sent upon
each use, which exceeded the limits of our Matomo plan. These metrics
are now only being sent upon the first usage, for each origin and
property.
2020-08-14 19:15:21 -03:00
Patryk Łucka
74decc3407
Fix Etherscan redirect on notification click ( #9211 )
2020-08-14 19:15:03 -03:00
Mark Stacey
4d499cc39e
Add version
dimension to background metrics ( #9167 )
...
The background metrics were missing the `version` custom dimension. It
has now been added to all background metric events.
2020-08-14 19:05:27 -03:00
Whymarrh Whitby
c2edc342fb
Remove unused buyEth fn from bg ( #9236 )
2020-08-14 15:51:48 -02:30
Whymarrh Whitby
e021acdc0a
Fix max-statements-per-line issues ( #9218 )
...
See [`max-statements-per-line`](https://eslint.org/docs/rules/max-statements-per-line ) for more information.
This change enables `max-statements-per-line` and fixes the issues raised by the rule.
2020-08-14 15:13:56 -02:30
Whymarrh Whitby
5d42a9b773
Fix require-unicode-regexp issues ( #9212 )
...
* Fix require-unicode-regexp issues
See [`require-unicode-regexp`](https://eslint.org/docs/rules/require-unicode-regexp ) for more information.
This change enables `require-unicode-regexp` and fixes the issues raised by the rule.
* Remove case-insensitive flag from regexps
2020-08-14 09:18:42 -02:30
Whymarrh Whitby
884775cf71
Fix no-negated-condition issues ( #9222 )
...
See [`no-negated-condition`](https://eslint.org/docs/rules/no-negated-condition ) for more information.
This change enables `no-negated-condition` and fixes the issues raised by the rule.
2020-08-14 09:17:43 -02:30
Whymarrh Whitby
c11888f287
Fix no-empty-function issues ( #9216 )
...
See [`no-empty-function`](https://eslint.org/docs/rules/no-empty-function ) for more information.
This change enables `no-empty-function` and fixes the issues raised by the rule.
2020-08-14 09:17:02 -02:30
Whymarrh Whitby
9b78d3ab07
Fix import/extensions issues ( #9217 )
...
See [`import/extensions`](https://eslint.org/docs/rules/import/extensions ) for more information.
This change enables `import/extensions` and fixes the issues raised by the rule.
2020-08-14 09:16:45 -02:30
Whymarrh Whitby
3bd22a2058
Fix no-template-curly-in-string issues ( #9221 )
...
See [`no-template-curly-in-string`](https://eslint.org/docs/rules/no-template-curly-in-string ) for more information.
This change enables `no-template-curly-in-string` and fixes the issues raised by the rule.
2020-08-13 19:01:55 -02:30
Whymarrh Whitby
82a0ee27f3
Fix prefer-rest-params issues ( #9215 )
...
See [`prefer-rest-params`](https://eslint.org/docs/rules/prefer-rest-params ) for more information.
This change enables `prefer-rest-params` and fixes the issues raised by the rule.
2020-08-13 18:05:18 -02:30
Whymarrh Whitby
146127c474
Fix no-prototype-builtins issues ( #9213 )
...
See [`no-prototype-builtins`](https://eslint.org/docs/rules/no-prototype-builtins ) for more information.
This change enables `no-prototype-builtins` and fixes the issues raised by the rule.
2020-08-13 18:04:51 -02:30
Patryk Łucka
5991043cd7
Fix Etherscan redirect on notification click ( #9211 )
2020-08-13 13:51:31 -02:30
Whymarrh Whitby
cd370be728
Fix no-invalid-this issues ( #9207 )
...
See [`no-invalid-this`](https://eslint.org/docs/rules/no-invalid-this ) for more information.
This change enables `no-invalid-this` and fixes the issues raised by the rule.
2020-08-12 21:19:33 -02:30
Whymarrh Whitby
c0f05ccae6
Fix implicit-arrow-linebreak issues ( #9201 )
...
See [`implicit-arrow-linebreak`](https://eslint.org/docs/rules/implicit-arrow-linebreak ) for more information.
This change enables `implicit-arrow-linebreak` and fixes the issues raised by the rule.
2020-08-12 21:19:10 -02:30
Whymarrh Whitby
76bd7f98b6
Fix prefer-spread issues ( #9203 )
...
See [`prefer-spread`](https://eslint.org/docs/rules/prefer-spread ) for more information.
This change enables `prefer-spread` and fixes the issues raised by the rule.
2020-08-12 20:42:07 -02:30
Whymarrh Whitby
310b15ba4a
Fix no-plusplus issues ( #9206 )
...
See [`no-plusplus`](https://eslint.org/docs/rules/no-plusplus ) for more information.
This change enables `no-plusplus` and fixes the issues raised by the rule.
2020-08-12 20:36:44 -02:30
Whymarrh Whitby
88f54e29fb
Fix no-empty issues ( #9202 )
...
See [`no-empty`](https://eslint.org/docs/rules/no-empty ) for more information.
This change enables `no-empty` and fixes the issues raised by the rule.
2020-08-12 18:20:29 -02:30
Whymarrh Whitby
9842b2f1ce
Fix no-useless-catch issues ( #9198 )
...
See [`no-useless-catch`](https://eslint.org/docs/rules/no-useless-catch ) for more information.
This change enables `no-useless-catch` and fixes the issues raised by the rule.
2020-08-12 16:37:15 -02:30
Whymarrh Whitby
a8863a3446
Fix consistent-return issues ( #9192 )
...
See [`consistent-return`](https://eslint.org/docs/rules/consistent-return ) for more information.
This change enables `consistent-return` and fixes the issues raised by the rule.
2020-08-12 16:36:57 -02:30
Whymarrh Whitby
885125ad03
Fix no-case-declarations issues ( #9191 )
...
See [`no-case-declarations`](https://eslint.org/docs/rules/no-case-declarations ) for more information.
This change enables `no-case-declarations` and fixes the issues raised by the rule.
2020-08-12 14:11:27 -02:30
Mark Stacey
3d9b545771
Merge remote-tracking branch 'origin/master' into sync-master
...
* origin/master: (44 commits)
Add category in eventOpts (#9164 )
Update changelog for v8.0.7 (#9161 )
Version v8.0.7
Remove web3 e2e tests (#9159 )
Add web3 usage metrics, prepare for web3 removal (#9144 )
Use `pathname` instead of URL for `currentPath` metrics parameter (#9158 )
Remove `url` parameter from `metricsEvent` (#9157 )
Change MetaMetrics category for background events (#9155 )
remove .network-name height
Use luxon@1.24.1 (#9154 )
Update 'react-devtools' to ^4.8.0 (#9140 )
Fix connection removal bug (#9137 )
Add source map validator to CI (#9135 )
Update source map validator target files (#9133 )
Improve sourcemap validator console report (#9131 )
Add `validate-source-maps` npm script (#9134 )
Non-zero exit code upon failure to validate source maps (#9132 )
Update `brfs` from v1.6.1 to v2.0.2 (#9115 )
Factor out `getEnvironment` function in build script (#9114 )
Update `browserify` from v16.2.3 to v16.5.1 (#9113 )
...
2020-08-10 15:12:07 -03:00
Mark Stacey
cb503d9403
Refactor assignment of "Background" metrics category ( #9168 )
...
The "Background" metrics category was being set in the
`backgroundMetaMetricsEvent` function. This function might not
necessarily include any event at all though, so setting it here seemed
inappropriate. It would also crash if `eventData.eventOpts` was not
set, which is not great since that property is optional.
The background category is now set in the `sendBackgroundMetaMetrics`
function in `metamask-controller`. This method is used solely for event
data, so it would make sense for this category to be always set.
There is no functional difference, since `backgroundMetaMetricsEvent`
is called solely by `sendBackgroundMetaMetrics`.
2020-08-10 12:38:56 -03:00
Mark Stacey
c557e25ba6
Add version
dimension to background metrics ( #9167 )
...
The background metrics were missing the `version` custom dimension. It
has now been added to all background metric events.
2020-08-10 12:10:30 -03:00
Thomas Huang
747f4bb5c3
Add category in eventOpts ( #9164 )
2020-08-09 00:43:20 -03:00