1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-02 06:07:06 +01:00
Commit Graph

5653 Commits

Author SHA1 Message Date
Dan J Miller
2955b97f97 Prevent confirm screen from showing method name from contract registry for txes created within MetaMask (#15472)
* Prevent confirm screen from showing method name from contract registry for txes created within MetaMask

* Ensure method name does not get sent in state when sending to a contract, with tx data, from metamask send screen
2022-08-04 17:42:41 -02:30
Brad Decker
71dd39724b Use fromAccount instead of selectedAcccount for account updates on edit (#15449) 2022-08-03 19:51:46 -02:30
Dan J Miller
a4f0944517 Ensure smart contract interactions are properly represented on the confirm screen (#15446)
* Ensure smart contract interactions are properly represented on the confirm screen

* Fix unit tests

* Code cleanup

* Cleanup

* Code cleanup

* Fix test
2022-08-03 19:51:44 -02:30
Brad Decker
1073b4adfb add safegaurd for missing account in action (#15450)
* add safegaurd for missing account in action

* add test to cover case
2022-08-03 19:43:24 -02:30
Dan J Miller
d5b95d6e44 Ensure that if max is selected in send flow, the correct value is set after network switch (#15444) 2022-08-03 19:43:24 -02:30
ryanml
b6d587223b Opening Network Forms in full screen from the popup view (#15442) 2022-08-03 19:43:24 -02:30
Alex Donesky
47ae0def78 add access protection to the getNativeCurrencyImage selector in case it is the source of a mysterious bug on firefox (#15425) 2022-08-03 19:43:24 -02:30
Brad Decker
109e46c95f remove unnecessary usage of renderableGasButton logic (#15422) 2022-08-03 19:41:53 -02:30
Brad Decker
4c4ce83b0b fix issues relating to race conditions where draftTx does not exist (#15420)
* fix issues relating to race conditions where draftTx does not exist

* add another fail safe for inflight initializations
2022-08-03 19:39:03 -02:30
Alex Donesky
29c7f2227a Enhance approval screen title logic (#15406) 2022-08-03 19:39:02 -02:30
Dan J Miller
8b4e046ac3 Fix optimism send flow (#15419) 2022-08-03 19:33:45 -02:30
Alex Donesky
d363bdbb21 Fix error that occurs when attempting to display transaction value for an approval transaction with no value argument in the transaction data (#15398) 2022-08-03 19:33:45 -02:30
Dan J Miller
99f753d73f Metrics adjustments (#15313)
* Don't send errors to sentry if users have not opted-in to participate in metametrics

* Don't capture opt-out metrics

* Move the metrics-opt in screen to immediately after the welcome screen

* Ensure that global.getSentryState is set in the background

* Fix e2e tests after rearranging onboardin flow

* Fix unit tests

* More e2e test fixes

* Remove unnecessary wrappers around capture exception
2022-07-22 18:19:36 -02:30
Alex Donesky
f0556cf097 fix blockExplorer link on setApprovalForAll confirmation screen (#15312) 2022-07-21 20:55:04 -02:30
Brad Decker
024a62f401 enable direct routing to the send page (#15259) 2022-07-21 14:13:22 -02:30
Dan J Miller
11374ec4d7 Ensure that editing a tx from a transfer to a simple send resets data and updates type (#15248)
* Ensure that editing a transaction from a transfer to a simple send properly resets data and updates type

* Handle case where there are no unapproved txes

* Improve comment in updateSendAsset

* Remove unnecessary code in send transaction edit function

* Fix

* Ensure hex data is properly reset when changing from a safe transfer from tx to native send
2022-07-20 17:42:35 -07:00
Frederik Bolding
930f5e8558 Fix stringified object on NFT approve screen (#15287) 2022-07-20 14:28:47 -07:00
Alex Donesky
11abdddaa2 show asset name instead of symbol for setApprovalForAll calls on NFT contracts where possible (#15296) 2022-07-20 21:13:28 +02:00
Alex Donesky
de0f836a27 small approve confirmation ui fixes (#15239) 2022-07-15 14:45:06 +02:00
Dan J Miller
c63714c4f2 Show users a warning when they are sending directly to a token contract (#13588)
* Fix warning dialog when sending tokens to a known token contract address

Fixing after rebase

Covering missed cases

Rebased and ran yarn setup

Rebased

Fix checkContractAddress condition

Lint fix

Applied requested changes

Fix unit tests

Applying requested changes

Applied requested changes

Refactor and update

Lint fix

Use V2 of ActionableMessage component

Adding Learn More Link

Updating warning copy

Addressing review feedback

Fix up copy changes

Simplify validation of pasted addresses

Improve detection of whether this is a token contract

Refactor to leave updateRecipient unchanged, and to prevent the double calling of update recipient

Update tests

fix

* Fix unit tests

* Fix e2e tests

* Ensure next button is disabled while recipient type is loading

* Add optional chaining and a fallback to getRecipientWarningAcknowledgement

* Fix lint

* Don't reset recipient warning on asset change, because we should show recipient warnings regardless of asset

* Update unit tests

* Update unit tests

Co-authored-by: Filip Sekulic <filip.sekulic@consensys.net>
2022-07-13 19:46:30 -02:30
Dan J Miller
5e12aae541 Improve confirm screen tests (#15163)
* Improve confirm screen tests

* Fix transaction controller unit test

* Fix unit test fixtures

* Fix e2e test
2022-07-12 14:53:36 -02:30
Alex Donesky
8d20c2834f Add setApprovalForAll confirmation view (#15010)
* enhance setApprovalForAll confirmation flow

* cleanup

* address feedback
2022-07-11 22:02:56 -02:30
Niranjana Binoy
bafc235928
Disable Seedphrase import button after switching seedphrase length (#15139) 2022-07-07 11:37:21 -04:00
Dan J Miller
e8ea973f0f
Add feature flag to prevent add popular networks from being available on prod (#15117) 2022-07-04 12:20:37 -02:30
PeterYinusa
79d0a2c8ba
Update wallet-overview.js (#15125) 2022-07-01 12:35:40 -02:30
Brad Decker
94967072f7
Remove global transaction state from send flow (#14777)
* remove global transaction state from send slice

* fixup new test
2022-07-01 08:58:35 -05:00
Dan J Miller
f4b25d7ea5
Ensure native asset icon does not display incorrectly when switching networks and balance is loading (#15116) 2022-07-01 10:38:42 -02:30
Filip Sekulic
43f7a44c25
Adding popular custom network integration (#14557)
* Initial push

* Refactored the code

* Additional code

* Removed the unused message

* Added a tooltip

* Fixed tests

* Lint fix

* Added style to a tooltip

* Fix e2e test failure

* Lint fix and code revert

* Fix e2e test

* Fixed paddings

* Fixed paddings

* CSS fix

* Minified svg files

* Applied requested changes

* Fixed theme issue

* Code revert

* Added back overridden code

* Icon problem fixed

* Lint fix

* Replaced H3 with H4

* Added unit test

* Added breadcrumbs

* Added const props for networks

* Lint fix

* Lint fix

* Added toggle button for showing the custom network list and resolved few issues

* Fixed routes

* Refactored a piece of code

* Enabled searching for the newly created option

* Fixed unit test

* Updated theme
2022-06-30 13:49:07 -02:30
Alex Donesky
3a31326199
Add fallback image/card for NFTs when image was not fetched correctly or does not exist (#15034)
* add fallback image/card for collectibles when image was not fetched correctly or does not exist

* UI and storybook updates (#15071)

* UI and storybook updates

* Adding break so token id is displayed

* subtle border fix

* Updating content

* Removing unused image

* Adding proptype descriptions

* Lint fix

Co-authored-by: George Marshall <george.marshall@consensys.net>
2022-06-30 08:46:38 -07:00
Dan J Miller
c3623ab729
Remove change from cb77f94 that breaks ens inputs in send flow (#15069) 2022-06-28 17:06:55 -02:30
Dan J Miller
cb77f94bc5
Ensure that addresses are properly hex-prefixed in the generate ERC token transfer functions (#15064)
* Ensure that addresses are properly hex-prefixed in the generate ERC token transfer functions

* Ensure hex-prefixed addresses in send input

* Update unit tests

Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
2022-06-28 14:21:09 -02:30
Alex Donesky
5290402181
Fix tokenIds larger than MAX_SAFE_INTEGER converted to scientific notation and failing to import (#15016)
* fix tokenIds larger than MAX_SAFE_INTEGER breaking

* add tests
2022-06-27 19:31:25 -05:00
Daniel
5fa88bebce
Show how much a cancellation of a smart transaction will cost (#15011) 2022-06-22 18:58:51 +02:00
David Walsh
6ffd0ce063
Fix 14802 - Prevent children error in page container (#14809) 2022-06-21 18:38:39 -05:00
George Marshall
051254dffd
Fixing tooltip theming by enforcing default theme (#14992)
* Fixing tooltip theming by enforcing background color

* Removing wide prop
2022-06-21 09:50:44 -07:00
daniba
085126d275
Move search icon and add to storybook (#14940)
* move search icon || update imports || add to story

* Optimized svg path, updated icon api and updating colors

* update other icons

* update snapshot

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
2022-06-21 10:18:35 -05:00
Zachary Belford
5a1bc94aa4
Changed accounts fuzzy search threshhold to match all (#14914)
* Changed accounts fuzzy search threshhold to match all

* Changed account search only when there is at least 2 terms

* Fixed linting issue

* Lint fix account menu component
2022-06-20 15:35:07 -07:00
Guillaume Roux
25739a5fc1
[FLASK] Fix notifications icon color (#14941) 2022-06-20 23:23:51 +02:00
Frederik Bolding
4048feeaac
Increase likelyhood of valid method signatures being returned by getMethodData (#14937)
* Increase likelyhood of valid method signatures being returned by getMethodData

* Update coverage

* Update coverage

* Update coverage

* add a migration to clear knownMethodData

* Small typo changes

Co-authored-by: Alex <adonesky@gmail.com>
2022-06-17 23:11:09 +02:00
ricky
3d74d06f93
Add missing subtitles for secret recovery phrase (#14943)
* add missing subtitles

* Update subtitles map

* update subtitle map in onboarding v2 flow

Co-authored-by: Alex <adonesky@gmail.com>
2022-06-17 14:55:04 -04:00
白宦成
adbd1c79be
fix EditGasDisplay (#13980)
Co-authored-by: David Walsh <davidwalsh83@gmail.com>
2022-06-17 13:04:59 -05:00
George Marshall
fdf3e9d2d7
Fix/14856 network settings page (#14857)
* Removing other features code

* Improving acccessibility of check icon

* Fixing add network button footer in popover view

* Fixing unit tests
2022-06-15 13:16:53 -07:00
Ariella Vu
73488766b6
SB:EditGasDisplay: fix error (#14946) 2022-06-15 14:55:04 -05:00
Daniel
ebf967562b
Remove experimental gas editing for Swaps (#14942) 2022-06-15 21:08:13 +02:00
Ariella Vu
1771ed4925
ErrorMessage: add @deprecated (#14945) 2022-06-15 13:45:54 -05:00
David Walsh
ea49b40d33
Make the accounts menu accessible (#14936) 2022-06-15 12:49:18 -05:00
Jordon
f5c6d0054f
Convert knobs and actions to controls/args for MainQuoteSummary (#14758)
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
2022-06-15 10:43:26 -05:00
Ariella Vu
ede801e143
MetaMetrics: fix onCancel trackEvent (#14935)
should mirror first-time-flow/metametrics-opt-in logic
2022-06-14 11:00:11 -05:00
Soralit
804db7f1dc
fix animated qr in dark mode (#14900) 2022-06-13 16:07:51 -05:00
VSaric
f9edbf50ce
Empty balance while switching network (#14354) 2022-06-13 14:39:48 -05:00