1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-11-27 04:46:10 +01:00
Commit Graph

17221 Commits

Author SHA1 Message Date
Nidhi Kumari
cfc653ada6
eth_sign toggle Update in advanced settings (#18848)
* added eth sign first step

* added modal

* added validation for form

* updated width with block

* added state trigger for toggle

* updated Eth sign modal text changes

* added eth sign toggle tex

* removed unnecessary code

* fixed form validation text

* updated eth toggle text

* added test

* added analytics

* updated design changes

* lint fix

* updated error text

* updated changes
2023-05-04 16:44:07 +05:30
Pedro Figueiredo
bfbe10ba28
e2e test for action metrics (#18347)
* e2e test for action metrics

* add tests to implementing sw restart delay tracking

* wip

* wip

* wip

* wip

* remove unneeded code

* remove scuttling changes contemplated in #18989
2023-05-04 10:38:09 +04:00
Suryansh Anand
c92d7380df
Migrates avatar base to TypeScript (#18494)
* Converted file extension from .js to .tsx

* Updated README docs to match the enums. Resolved type errors

* Updated AvatarBaseSizes enum values to string literals

* Added TEXT_TRANSFORM.UPPERCASE as default value of textTransform in base file

* lint fix

* Solved liniting errors in avatar-base

* Made enum more consistent, added desc for AvatarBaseProps

* Updated snapshots of AvatarBase and exported AvatarBaseProps in index.ts

* Made textTransform property accept right values in avatar-base.tsx

* Adding temporary changed extensions

* Reverted files back to tsx and resolved conflicts

* Solved linting errors

* AvatarBaseProps now extends TextProps

* Changing extension to resolve conflict

* Reverted extensions back to tsx after resolving conflicts

* Added forwardRef in AvatarBase

* Updated import name of AvatarBaseSize in README.mdx. Removed empty children attribute from AvatarBase storybook file

---------

Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
2023-05-03 17:30:07 -07:00
legobeat
924df55e89
devDeps: pretty-error@2.1.1->2.1.2 (#18868)
CVE-2021-3803 / GHSA-rp65-9cf3-cjxr
2023-05-04 08:11:20 +09:00
Dominik Rudzki
9a583635c2
Fix popover hiding (#18843)
* Fix popover hiding

* Fix popover hiding

* Add debounce to scroll event

---------

Co-authored-by: David Walsh <davidwalsh83@gmail.com>
2023-05-03 13:32:29 -05:00
Dan J Miller
e8ede35dd1
Ensure we can successfully create prod builds with specific types (#18991) 2023-05-03 15:59:11 -02:30
OGPoyraz
e1295e489b fix: prevent cancel and speedup transactions to call accept approval (#18846) 2023-05-03 18:43:56 +01:00
David Walsh
ab4843f06b
UX: Multichain: Implement Account Details Popover (#18811)
* UX: Multichain: Implement Account Details Popover

* Styling account details popover

* using ButtonSecondary with variant, removing Text

* adding account-details jest test

* Close popover when outside area clicked

* Move all export functionality into the popover

* Improve jest tests

* Implement new design for export key screens

* Hide warning when popover is closed

* Vertically align the copy button

* Move AccountDetailsDisplay to its own file

* Move authentication to its own file

* Move private key to its own component

* Fix misalignment of avatar on display screen

* Move private key to its own component

* Update ui/components/multichain/account-details/account-details-authenticate.js

Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>

* Update ui/components/multichain/account-details/account-details.test.js

Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>

* Prevent account name overflow, update text size

* Use FormTextField

* Add analytics

* Move location of accountDetailsAddress

* Ensure passsword input is used

---------

Co-authored-by: Victor Thomas <10986371+vthomas13@users.noreply.github.com>
Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
2023-05-03 12:09:13 -05:00
Nidhi Kumari
c078807c72
UX Multichain: Account List Search Fix (#18963)
* fix for account-list-menu search bar

* updated title

* implemented event capturing
2023-05-03 22:23:42 +05:30
Nidhi Kumari
1eaba66631
removed top border from list item (#18959) 2023-05-03 22:22:57 +05:30
Nidhi Kumari
d9f67e403d
UX Multichain: Fixed NaN USD issue under Eth when using Fiat (#18981)
* updated fiat value

* updated primary value in storybook
2023-05-03 22:21:12 +05:30
Monte Lai
a3cf0036ad
Feat/srp metrics (#18015)
* add srp metrics

* add event names

* fix text

* add test

* add event test to hold to reveal modal

* fix lint

* add event test to reveal seed

* update coverage target

* revert willHide

* add more tests

* fix lint

* update coverage

* git commit -m "fix comments"

* fix merge conflict

* fixed the merge conflicts with #18353

* fix text

* update deprecated import

* alphabetize metametrics enums

* update coverage

* update coverage

---------

Co-authored-by: Brad Decker <bhdecker84@gmail.com>
Co-authored-by: Howard Braham <howrad@gmail.com>
2023-05-03 11:26:45 -05:00
Pedro Figueiredo
a356c40c86
add scuttle exceptions for JSON and Date (#18989)
* add scuttle exceptions for JSON and Date

* address feedback
2023-05-03 20:07:36 +04:00
witmicko
8d2803c179
limit connections (#18355)
limit background connections
2023-05-03 16:39:56 +01:00
António Regadas
c4e1edef19
[MMI] Don't group transactions by nonce if they are custodial Tx (#18982)
* adds mmi fence

* adds comment and casts variable to bool

* prettier
2023-05-03 17:00:38 +02:00
Jyoti Puri
02b537c0c1 Enable editing L2 gas on optimism (#18217) 2023-05-03 12:17:18 -02:30
António Regadas
bf0a70dbba
adds custody page route to account routes (#18985) 2023-05-03 15:04:49 +01:00
Dhruv
28b3490e7c
Fixes the cancel-speedup-popover.js (#18948)
Co-authored-by: Danica Shen <zhaodanica@gmail.com>
2023-05-03 19:32:03 +05:30
Dhruv
657b94cd47
Part of #17670: Replace Typography with Text component in beta-header/index.js (#18964)
* Changes to beta-header/index.js

* Updated-snapshot

* Suggested changes

* Changes to the text color enum
2023-05-03 19:20:06 +05:30
Mark Stacey
28241b0592
Delete two unused selectors (#18904)
The selectors `getNumberOfAccounts` and `getMetricsNetworkIdentifier`
were unused, so they have been deleted.
2023-05-03 11:06:06 -02:30
NanamiNakano
6f4969d701
Update messages.json (#18897)
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
Co-authored-by: Danica Shen <zhaodanica@gmail.com>
2023-05-03 08:28:32 -05:00
George Marshall
56e48a7e55
Fixing broken responsive box background color prop and color fix (#18978) 2023-05-03 08:18:56 -05:00
Harsh Shukla
98cb3381e6
Part of #17670: Replace Typography with Text component in: detected-token-values.js (#18977)
* Update detected-token-values.js

* Update ui/components/app/detected-token/detected-token-values/detected-token-values.js

Co-authored-by: George Marshall <georgewrmarshall@gmail.com>

---------

Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
2023-05-03 08:17:49 -05:00
Frederik Bolding
910b9e713f
Use separate versions for Flask and Stable snaps (#18875)
* Use separate versions for Flask and Stable snaps

* Update LM policy override

* Add deps to depcheck

* Improve import
2023-05-03 15:16:43 +02:00
Pedro Figueiredo
1d80029691
fix ff diff generation (#18824)
* fix ff diff generation

* wip

* Update .github/workflows/fitness-functions.yml

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

* Update .github/workflows/fitness-functions.yml

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

---------

Co-authored-by: Mark Stacey <markjstacey@gmail.com>
2023-05-03 16:04:53 +04:00
OGPoyraz
cbcb46f704
fix: prevent cancel and speedup transactions to call accept approval (#18846) 2023-05-03 13:07:03 +02:00
Dominik Rudzki
b5a11857c4
[FLASK] Fix overflowing notification content (#18881)
* Fix overflowing notification content

* Wrap overflow

* Fix lint & remove unnecessary width

---------

Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
2023-05-03 11:27:01 +02:00
Frederik Bolding
c716592fd1
Clean up some code fencing around snaps (#18802)
* Clean up some code fencing around snaps

* Fix code fencing

* Fix more fencing issues
2023-05-03 10:53:58 +02:00
David Walsh
120dfcdf32
UX: Multichain: Add maximum width for network picker in full screen mode (#18879) 2023-05-02 12:15:00 -05:00
David Walsh
57e90196cc
UX: Multichain: Provide localization for the network menu (#18880) 2023-05-02 12:14:48 -05:00
Mark Stacey
d1cea85f33
Rename provider to providerConfig (#18907)
* Rename `provider` to `providerConfig`

The network controller `provider` state has been renamed to
 `providerConfig`. This better reflects what this state is, and makes
this controller more closely aligned with the core network controller.

All references to the provider configuration have been updated to
prefer `providerConfig` over `provider`, to make the distinction clear
between a provider and provider config.

Closes #18902

* Add migration
2023-05-02 13:23:20 -02:30
Frederik Bolding
55d974d7b2
Bump Circle CI docker image (#18914)
* Bump Circle CI docker image

* Stop removing FF since it doesn't exist

* Use Circle CI browser tools

* Fix config name

* Fix browser tools args

* Fix Chrome version

* Use script for chrome

* Try update

* Try FF without browser-tools2

* Fix FF binary path

* Force enable e2e debug

* Add some logs

* More logs

* Disable XSET check for now

* Delete x-server logic

* remove another usage of the x-server logic
2023-05-02 17:10:53 +02:00
George Marshall
abd6df72c6
Improving code formatting in component-library readme (#18910) 2023-05-02 09:50:37 -05:00
Frederik Bolding
4d015de43e
Fence snaps endowments and permissions for stable/flask (#18847)
* Fence snaps endowments and permissions for stable/flask

* Fix lint

* Fix tests

* Actually fix tests

* Fix another test
2023-05-02 14:51:16 +02:00
Mark Stacey
88ae10418b
Expand usage of getProviderConfig selector (#18906)
The `getProviderConfig` selector is now used anywhere the `provider`
state was previously referenced directly. This was done to simplify
renaming this state from `provider` to `providerConfig` in a later PR.

Note that there are many opportunities left to use more-specific
selectors (e.g. `getChainId()` over `getProviderConfig().chainId`), but
that was intentionally omitted from this PR to reduce the size. I
started going down this path and it quickly exploded in scope.

Relates to #18902
2023-05-02 10:06:24 -02:30
Jyoti Puri
ece1e48200 Consistent message for third party requests across screens (#18873) 2023-05-02 10:03:30 -02:30
Victorien Gauch
b758165c1b fix(18709): fix error when switching to linea testnet using wallet_sw… (#18710)
* fix(18709): fix error when switching to linea testnet using wallet_switchEthereumChain

* fix: update condition to get network config
2023-05-02 10:03:30 -02:30
Bernardo Garces Chapero
ca0a4bec3b Return state when calling EncryptionPublicKeyController.cancelEncryptionPublicKey (#18845)
* returns state

* adds unit test
2023-05-02 10:03:30 -02:30
Mark Stacey
1626f22704 Update outdated browser versions (#18721)
The range of browsers considered to be outdated has been updated to
match our latest browser support policy, which is ~2 years on Chrome,
and the most recent end-of-life extended support release on Firefox.

Comments have been added to help explain how these versions were chosen
as well.
2023-05-02 10:03:30 -02:30
Jyoti Puri
0a9c6023dc Fixing issue with gasLimit in transaction being 0 (#18682) 2023-05-02 10:03:30 -02:30
micaelae
19257361e5 Show Bridge button in TokenOverview component (#18630)
* Show Bridge button in TokenOverview component

* Hide Swap button in token overview page when network is not supported
2023-05-02 10:03:30 -02:30
Dan J Miller
7fbc26eebd
Discontinue use of deleted getProductionConfig function (#18900) 2023-05-02 09:41:29 -02:30
Mark Stacey
483ffdb5c0
Simplify network controller unit test setup (#18901)
* Simplify network controller unit test setup

The network controller unit tests have been refactored to simplify the
setup steps related to the controller messenger. The messenger is now
constructed by the `withController` helper function, rather than being
manually setup in each test that references it.

Relates to https://github.com/MetaMask/core/issues/1197

* Bring tests closer in alignment to core

The function to build default controller constructor parameters has
been removed, bringing these tests closer in alignment to the core
tests.
2023-05-02 09:02:57 -02:30
George Marshall
2face84177
Adding deprecation notice to old Button component (#18908) 2023-05-02 03:05:08 -07:00
Harsh Shukla
1478e83b08
Part of #17670: Replace Typography with Text component for 'review-spending-cap' & 'tooltip.stories'. (#18839)
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
2023-05-02 15:17:00 +05:30
Ariella Vu
a5d7cf3319
Transaction cleanup and fix TransactionDetailItem key not unique bug (#18899)
* TransactionDetailItem: allow empty detailText

* TxDetailItem: fix keys; ensure unique keys
2023-05-02 00:42:59 -03:00
Harsh Shukla
36092571c6
Part of #17670 Replace Typography with Text component in: signature-request-siwe-tag\index.js (#18898) 2023-05-01 17:51:24 -07:00
Harsh Shukla
f5f2e2e35f
Part of #17670 , #18714 & #18651 for 3 files. (#18752)
* Adding strong tag support for Text component

* Update build-quote.js

* Update awaiting-signatures.js

* Used <strong> tag in a better way.

* Remove <strong> tag from file: awaiting-signatures.js

Co-authored-by: Danica Shen <zhaodanica@gmail.com>

* Update awaiting-signatures.js

* Update ui/components/component-library/text/text.scss

Co-authored-by: George Marshall <georgewrmarshall@gmail.com>

* Update ui/pages/swaps/build-quote/build-quote.js

Co-authored-by: George Marshall <georgewrmarshall@gmail.com>

* Removing unintended UI and strong css from Text component

---------

Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
Co-authored-by: Danica Shen <zhaodanica@gmail.com>
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
2023-05-01 17:48:58 -07:00
Harsh Shukla
32a7f0fe09
Update pin-extension.js (#18877) 2023-05-01 17:39:56 -07:00
Harsh Shukla
262a291185
Part of #17670 Replace Typography with Text component in: nft-default-image.js (#18894)
* Update nft-default-image.js

* Update nft-default-image.test.js.snap
2023-05-01 17:35:44 -07:00