1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-11-27 21:00:13 +01:00
Commit Graph

60 Commits

Author SHA1 Message Date
Dan Finlay
913a9e85bd Inject inpage script synchronously
Huge thanks to the Firefox team, for their help on the issue of our long-standing inpage script race condition.

http://stackoverflow.com/questions/38577656/how-can-i-make-a-firefox-add-on-contentscript-inject-and-run-a-script-before-oth

The problem is that we were injecting a `script` tag and assigning its `src` attribute, which triggers an asynchronous fetch request, and does not guarantee execution order! (That was news to me!)

Instead, I'm now assigning the `script` tag a `textContent` value of the script to inject, and it seems to fix the problem!

There is also a Firefox-only API that could solve this whole problem in an even more elegant way, so we might want to expose a code path for that solution later on:

https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Language_Bindings/Components.utils.exportFunction

Allows you to expose an object from one scope to another. There was even talk of creating a polyfill for it that does virtually what we do, message passing between contexts.
2016-07-25 16:38:07 -07:00
Dan Finlay
8fde8a8921 Manually linted 2016-06-21 13:56:04 -07:00
Dan Finlay
45506d6758 Got eslint running correctly 2016-06-21 12:40:09 -07:00
Dan Finlay
7b9a1197c8 Began adding auto linting 2016-06-21 12:07:13 -07:00
Dan Finlay
14916b022e Make gulp watch images folder 2016-06-14 12:43:55 -07:00
kumavis
c2c33ff6cd ui - redesign - app header + accounts selection 2016-05-10 16:52:07 -07:00
kumavis
04a61b7de9 build - post process with dereq 2016-04-20 13:22:41 -07:00
Dan Finlay
d814a45dff Moved UI into repo with its own dependency stack 2016-04-13 15:28:44 -07:00
kumavis
b3d46e02b8 build - use gulp, remove grunt 2016-03-11 15:21:43 -08:00
kumavis
f52f4d460e build - add gulp build process 2016-03-02 23:08:28 -08:00