Jyoti Puri
a28256ace4
Change api used for opensea validation ( #18383 )
...
* Change api used for opensea validation
* fix build
2023-03-30 17:33:35 -02:30
Jyoti Puri
701063542f
Adding terms of use link for opensea ( #18381 )
2023-03-30 19:45:14 +01:00
Elliot Winkler
50d8740a0d
Ensure that TS files in shared/modules are linted ( #18367 )
...
Some TypeScript files in shared/modules are not being linted. Add them
to the ESLint config and fix any lint violations that arise from doing
so.
2023-03-30 12:42:38 -06:00
Elliot Winkler
9b0a6ecc90
NetworkController: Use messenger for events ( #18041 )
...
Currently, the network controller notifies consumers about events by
emitting them directly from the controller. In order to migrate the
controller to the core repo, where controllers use the BaseControllerV2
interface, events should be emitted via a messenger object.
This commit updates the network controller to use a messenger, and then
updates all of the controllers that listen for network events to use the
messenger as well.
2023-03-30 12:39:36 -06:00
Jyoti Puri
b3e45ea4bc
Adding terms of use link for opensea ( #18381 )
2023-03-30 22:25:02 +04:00
David Walsh
6f7e382777
UX: Multichain: Improve accessibility of accounts menu ( #18309 )
...
* UX: Multichain: Improve accessibility of accounts menu
* Use button instead of a
* Pass color instead of using CSS
2023-03-30 13:12:45 -05:00
David Walsh
ba307d7258
UX: Multichain: Account Picker ( #18177 )
...
* UX: Multichain: Account Picker
* Update ui/components/multichain/account-picker/index.js
Co-authored-by: Garrett Bear <gwhisten@gmail.com>
* Update ui/components/multichain/account-picker/index.js
Co-authored-by: Garrett Bear <gwhisten@gmail.com>
* Update ui/components/multichain/account-picker/index.js
Co-authored-by: Garrett Bear <gwhisten@gmail.com>
* Update ui/components/multichain/account-picker/index.js
Co-authored-by: Garrett Bear <gwhisten@gmail.com>
* Cleanup
* Move file names to DS standard
* Add index for export
* Add MULTICHAIN flag
* Fix hover color
* Fix lint
* Use BackgroundColor instead of Color
* Add comments for propTypes
* Provide args properly
* Implement onClick arg
* Fix alignment
* Update ui/components/multichain/account-picker/account-picker.js
* Update ui/components/multichain/account-picker/account-picker.js
* Update ui/components/multichain/account-picker/account-picker.js
* Update ui/components/multichain/account-picker/account-picker.js
* Update ui/components/multichain/account-picker/account-picker.js
* Only use account name and address, account for blockies or jazzicons
* Add test
* Fix jest change
* Fix CSS locations
* Update ui/components/multichain/account-picker/account-picker.js
Co-authored-by: Garrett Bear <gwhisten@gmail.com>
* Update ui/components/multichain/account-picker/account-picker.js
Co-authored-by: Garrett Bear <gwhisten@gmail.com>
* Update ui/components/multichain/account-picker/account-picker.js
Co-authored-by: Garrett Bear <gwhisten@gmail.com>
* Update snapshot
* Update border radius
* Fix jest
* Switch to using Button
---------
Co-authored-by: Garrett Bear <gwhisten@gmail.com>
2023-03-30 13:11:13 -05:00
Pedro Figueiredo
05f0006684
Fix aria label error on the console ( #18370 )
...
* fix aria label bug
* improve solution
* improve solution
* improve solution
* update snapshot
2023-03-30 18:33:42 +01:00
Alex Donesky
9cd4e8c5a8
Fix #18199 : Add fallbacks for confirmation title on NFT transfers ( #18269 )
...
* add fallbacks for confirmation title on nft transfers
* Add token name and id
* fix
* fix test
---------
Co-authored-by: David Walsh <davidwalsh83@gmail.com>
2023-03-30 18:09:29 +01:00
Jyoti Puri
291469dece
Extracting out title component from confirm-transaction-base ( #17991 )
2023-03-30 18:09:17 +01:00
Alex Donesky
da06901f79
Fix #18199 : Add fallbacks for confirmation title on NFT transfers ( #18269 )
...
* add fallbacks for confirmation title on nft transfers
* Add token name and id
* fix
* fix test
---------
Co-authored-by: David Walsh <davidwalsh83@gmail.com>
2023-03-30 14:07:29 -02:30
Matthew Walsh
5f52aa0566
Fix missing transaction notifications ( #18323 )
2023-03-30 15:59:40 +01:00
Victorien Gauch
ff9d2b18ee
fix: update zkevm feature toggle date ( #18307 )
2023-03-30 15:54:55 +01:00
Ariella Vu
6252133c5b
Fix Signature Request scroll ( #18305 )
...
* signature-req: fix scroll
* signature-req: fix scroll allow items to shrink
2023-03-30 15:54:10 +01:00
micaelae
0f1c7cab02
Disable Bridge button on unsupported networks ( #18268 )
2023-03-30 15:53:05 +01:00
Filip Sekulic
d8889ac83a
OpenSea security provider metrics ( #17688 )
...
* Added metrics for the OpenSea security provider
* Fixed tests
* Fixed a test
* Fixed metrics
* Code refactor
* Lint fixed
* Removed unnecessary code
* Fix build
* Fix e2e
* Cleanup
* Fix e2e
* Code refactor
* Removed unnecessary code
* rpc middleware: catch securityProviderCheck errors
to not block dapp rpc requests
* Fixed an issue
* Added aditional test
* Applied some changes
* Fixed a test
* Fixed a test
* Code refactor
* Covered more code with tests
* Updated a test
* Fixed an issue
---------
Co-authored-by: Jyoti Puri <jyotipuri@gmail.com>
Co-authored-by: digiwand <20778143+digiwand@users.noreply.github.com>
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
2023-03-30 15:50:10 +01:00
Ariella Vu
6ad76745fe
Fix disabled 'eth_sign' event & add 'Request Disabled' event type ( #18007 )
...
* Fix #17974 / add REQUEST_DISABLED event
* RPCMiddleware: add eth_sign REQUEST_DISABLED test
* don't call Signature Request for disabled eth_sign
* clean: alphabetize
* clean: rn isDisabledRequest -> isDisabledRPCMethod
* fix test
* rpc middeware: add eth_sign comment
* fix eth_sign events and re-add Signature Request
* send 'Signature Failed' for disabled eth_sigh
2023-03-30 15:50:04 +01:00
Dan J Miller
73173e685d
Fixes to the Linea Goerli implementation ( #18290 )
...
* Ensure that NonInfuraDefaultNetworks are only selected in the dropdown if they are the currently selected network
* Ensure Linea Goerli network appears in network settings tab if added manually
2023-03-30 15:43:39 +01:00
vthomas13
8aead51f30
adding opensea security provider image ( #18292 )
2023-03-30 15:42:40 +01:00
Ariella Vu
cba9ba6198
Fix overflowing UI & buttons in Signature Request screens ( #18247 )
...
* signature-req: fix overflow ui
* signature-req: fix uneven btn height
2023-03-30 15:42:10 +01:00
Victorien Gauch
74f566f7f3
feat: add the ConsenSys zkEVM (Linea) as a default network ( #17875 )
...
* feat: add the consensys zkEVM as a default network
* fix: change infuraNetworkStatus in navigate-txs file
* fix: remove account tracker for zkEVM + remove zkEVM from infura list
* fix: change consensys zkevm name to linea + change rpc url for linea network
* fix: rebase conflicts
* feat: add new colors for linea goerli network
* feat: add new function inside network dropdown to render non infura networks
* feat: add feature toggle for linea network
* fix: add new unit test
---------
Co-authored-by: Dan J Miller <danjm.com@gmail.com>
2023-03-30 15:40:27 +01:00
vthomas13
d6b73d339d
Revert "What's new - OpenSea security provider ( #16831 )" ( #17968 )
...
This reverts commit 932282e638
.
2023-03-30 15:24:14 +01:00
Mark Stacey
917290e764
Revert "Moved subscribe and filter into network controller ( #16693 )" ( #18129 )
...
* Revert "Moved subscribe and filter into network controller (#16693 )"
This reverts commit 6f6984fa58
. That
commit was an RPC middleware refactor intended to move the subscribe
and filter middleware into the network controller, to simplify the
process of sharing this middleware between clients.
This refactor resulted in `eth_subscribe` notifications being sent on
the wrong connections, causing the UI to break in some cases (the UI
`provider` connection does not support notifications). This happened
because the `setupProviderEngine` function runs per-connection,
whereas the engine setup inside the network controller is global. The
global network client cannot support notifications because it has no
way to route them; they'll need to stay in the per-connection provider
engine.
Closes #17467
* Add e2e test
An e2e test has been added that confirms subscriptions are only
broadcast to the site that registered them. This test fails on
`develop`.
2023-03-30 15:18:50 +01:00
António Regadas
9f89d71c6f
[MMI] compliance settings component ( #18274 )
...
* MMI-2657 adds the compliance settings screen
* MMI-2657 adds stories file
* review fixes
* review fixes
* lint fix
* clean up
* Update ui/components/institutional/compliance-settings/compliance-settings.stories.js
Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
* lint fix
* snaps update
* Button update
---------
Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
2023-03-30 12:40:37 +02:00
Albert Olivé
b5184db620
[MMI] Added code fencing in keyring-label component ( #17993 )
...
* Added code fencing in keyring-label component
* Updated tests
2023-03-30 09:42:59 +02:00
Albert Olivé
f7aea9dc34
[MMI] Created institutional-entity-done-page component ( #18096 )
...
* Created institutional-entity-done-page component
* Added index file
* Added css file and Boxes
* Fixing prettier formatter
* Fixed prettier format
* Fixing prettier issues
* Fixed prettier
* Adding Text component
* Removed styles and added story
* Moving component to pages and improving styles
---------
Co-authored-by: António Regadas <apregadas@gmail.com>
2023-03-30 08:33:12 +02:00
Dan J Miller
06fba70888
Merge pull request #18366 from MetaMask/master-sync
...
Master sync for v10.27
2023-03-29 12:39:30 -07:00
Hassan Malik
c2b2f2685e
[FLASK] Redesign key management modal ( #18263 )
...
* added the rest of the sev1 warnings to getSnapInstallWarnings
* added and updated translations
* Updated getSnapInstallWarnings to include warnings for all weight-1 permissions
* Updated snap install warning and css according to designs
* fix snaps tests
* fixed alignment/spacing
* updated e2e tests to click through the newly displayed public key access warning
* lint fix
* fixed update snap test
* refactored getSnapInstallWarnings, moved logic to PERMISSION_DESCRIPTIONS
* fix logic to account for objects & arrays
* update function description
* add missing properties to ethereum provider description
* moved id and message to baseDescription to fix error
* add optional chaining to fix undefined error
* more optional chaining
* more optional chaining
2023-03-29 15:17:57 -04:00
Pedro Figueiredo
27f3af80bd
Revert "Fix(18190): add tabs to permission when initializing app ( #18218 )" ( #18336 )
...
This reverts commit 1eb102fd96
.
2023-03-29 20:11:08 +01:00
Ariella Vu
058c571fab
Fix Sign-in With Ethereum (SIWE) metametric, add tests, and clean RPC method middleware event logic ( #18008 )
...
* rpc middleware: update comment
* rpc middleware: use errorCodes const
* rpc middleware: only create event props once
* rpc middleware: rn properties -> eventProperties
* rpc middleware: use TransactionStatus const
* rpc middleware: use const for ui_customizations
* rpc middleware: no need to push null eventProp
- also removes === null check which makes this logic a bit more robust
* rpc middleware: rn METRIC..OPTIONS -> METRIC..OPT
* clean: add consistency
* rpc middleware: refactor let msgParams
* lint: rm unused METAMETRIC_KEY
* fix test: do not pass ui_customizations: null
* rpc middleware test: consolidate tests
* rpc middleware: fix siwe event
.push returns length of mutated array
* rpc middleware test: add siwe test
* rpc middleware test: rm redudant set
2023-03-29 15:25:01 -03:00
Peter
3c22a3b8a7
Merge branch 'develop' into master-sync
2023-03-29 18:46:02 +01:00
David Walsh
6052841381
Fix breaking jest test for MMI ( #18365 )
...
* Fix breaking jest test for MMI
* Bump coverage threshold
---------
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
Co-authored-by: PeterYinusa <peter.yinusa@consensys.net>
2023-03-29 13:44:04 -04:00
David Walsh
efc34b9420
UX: Multichain: Address Copy Button ( #18153 )
2023-03-29 11:14:38 -05:00
PeterYinusa
0fde32c1f5
Conflict cleanup 10.27.0 master-sync
2023-03-29 16:32:59 +01:00
PeterYinusa
04e5b76348
Merge remote-tracking branch 'origin/develop' into master-sync
2023-03-29 16:27:25 +01:00
Matthew Walsh
ff20873c65
Add documentation for creating new confirmations ( #18317 )
2023-03-29 16:01:05 +01:00
António Regadas
8fbd1e30e8
[MMI] compliance feature page ( #18320 )
...
* MMI-2657 adds the compliance settings screen
* MMI-2657 adds stories file
* wip compliance feature page
* adds stories and fixes imports
* adds storybook and tests
* lint fix
2023-03-29 14:49:45 +01:00
Matthew Walsh
12bd9b0b94
Fix missing transaction notifications ( #18323 )
2023-03-29 12:19:50 +01:00
OGPoyraz
f32d71ba1a
Merge pull request #18102 from MetaMask/fix/599-fix-theme-issues-of-desktop-pairing-page-in-the-extension-ui
...
fix: fix theme issues of desktop pairing page
2023-03-29 10:58:17 +02:00
Thomas Huang
8f65c268b4
Welcome onboarding unit test ( #18248 )
2023-03-29 14:00:34 +08:00
Youmna Jaza
6be18552ab
Updating Typography to Text ( #17681 )
...
Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
2023-03-28 15:04:22 -07:00
David Walsh
870415f111
UX: Multichain: Global Action Menu ( #18158 )
2023-03-28 14:59:18 -05:00
David Walsh
8cba64b993
Remove isEIP1559Account usage ( #18064 )
2023-03-28 09:50:02 -05:00
seaona
d4f04815c2
Remove timeouts without effect ( #18342 )
2023-03-28 14:59:41 +02:00
Goktug Poyraz
c640e769b2
Update snapshot
2023-03-28 10:36:53 +02:00
Goktug Poyraz
3a1bcf1446
Adds desktop pairing page story and fix suggestions
2023-03-28 10:35:30 +02:00
Goktug Poyraz
c1b607bdba
Fix: add tests
2023-03-28 10:35:30 +02:00
Goktug Poyraz
d2b44a338d
fix: download link
2023-03-28 10:35:30 +02:00
“Goktug
d2098e26ac
fix: fix theme issues of desktop pairing page
2023-03-28 10:35:30 +02:00
aleksandar-mihajlovic
0f1b86a037
Removed advanced gas controls from the settings ( #18138 )
2023-03-27 08:45:17 +02:00