1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-11-28 23:06:37 +01:00
Commit Graph

57 Commits

Author SHA1 Message Date
Monte Lai
af2c87d777
[FLASK] Add Snaps Keyring (#19710)
* flask - add restricted snap_manageAccounts

* snap keyring: use local snap keyring instead of package

* mvp snap-keyring

* fixed the easier lint errors

* fix missing permission text

* add removal function

* update snap keyring

* update dep

* update git link

* update messages and remove snap keyring from lib

* set snapprovider as soon as possible

* chore: update snap keyring dependency

* chore: pass SnapController to SnapKeyring constructor

* chore: update deps and comment line (wip)

* fix latest update for snaps and remove setController

* update yarn lock

* add routes

* add messages

* add message

* add snap account detail page

* add snap account card

* add snap account page

* update route

* add background

* use css grid

* update snap text styling

* fix lint

* remove unused import

* change manage link to go to snap

* add types for react-router-dom

* add link to settings

* add breadcrumb to header

* add popover

* add prop types

* add link to propTypes

* fix icon in header and tag

* update popover

* update yarn.lock

* add link to account list menu

* update from deprecated

* add add-snap-popup

* use popoverheader

* fix lint

* update to use modal instead of popup

* add install snap

* remove export of DeferredPromise

* change snap keyring to its own enum

* update imports and fences

* fix snapId and route

* fix header and button for snapCard

* hide app header on AddSnapAccountPage

* update icon

* match path to SnapAccountDetail

* set getting started button to close modal

* fix key prop warning

* add By Metamask message

* fix label

* add fence to snapkeyringtype

* update yarn.lock

* refactor removeAccount and static snap list

* update removeSnap

* feat: remove associated accounts when snap is removed

* add get snaps installed to snaps page

* fix updateAvailable

* add tests to ui components

* update test

* update scss

* udpate config snap popup style

* fixed https://www.notion.so/Show-pop-up-only-once-c6aa8494486a4ece8a5c5e35fea56ab5

* update accountListMenu click to open tab or push depending on environment

* update yark.lock

* remove unused uuid

* update lock

* update eth-snap-keyring

* udpate install from snap page

* update to install to use popup

* use release versino of eth-snap-keyring

* chore: bump snaps-utils version to `0.34.1-flask.1`

* update configure snap

* chore: update eth-snap-keyring

* chore: update policies

* fix: remove unused

* fix: fix snap-account-detail-page test

* fix: fix styles

* chore: remove swappable-obj-proxy

* fix: fix duplicate entry

* fix: disable export private key for snaps account

* feat: shuffle snap lists on every reload

* fix: configure not popping up

* refactor: snapsAddSnapAccountModalDismissal into action and selector

* fix: E2BIG when running prettier

* fix: lint default export or add-snap-account-modal

* fix: lint, remove vendor prefix

* fix: fix snapCreatedByMetamask to snapCreatedByMetaMask

* Add `manageAccounts` RPC method (#19724)

* Update dependencies

* Remove snap-keyring-permissions

* Update dependencies

* Update dependencies

* Update imports

* removed portfolio link from wallet view (#19716)

* removed portfolio link from wallet view

* removed unused code

* updated test

* updated spec file

* updated test

* Validate LavaMoat policies on each PR (#19703)

* Validate LavaMoat policies on each PR

The LavaMoat policies are now validated on every PR. This makes it
easier to validate policy changes, as they should always correspond
with the changes made in the PR (unlike today, when they could be due
to a change in platform or a previous PR).

Closes #19680

* Update LavaMoat policies

---------

Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>

* fix(action): add required permissions to remove labels (#19728)

* Fix dependencies

* signature approved metrics e2e test (#19628)

* Update dependencies

* Integrate Snow with LavaMoat scuttling protection (#17969)

* Update lavamoat policies

* Security Provider cleanup (#19694)

* security-prov: isFlaggedSecurityProviderResponse

* security-prov: create shared/modules/util

* security prov: rn isFlagged -> isSuspcious
- util fn returns true if response is not verified and flagged

* security prov: add util test
and support undefined param

* security prov: reorg util fn
- no logic changes

* Update LavaMoat policies (#19744)

Update LavaMoat policies to match what CI expects.

* Replacing deprecated constants & creating stories (#19686)

* Replacing deprecated constants & creating stories

* updating snapshot

* fix: fix imports

* chore: update policy.json

* fix: move SmartTransactionController out of snaps code fence

* fix: yarn.lock dedupe

* fix: lavamoat policy

* fix: update test

* fix: remove snapshot, the list of snaps are always randomized.

* fix: resole snaps-controller to use flask

---------

Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
Co-authored-by: Gauthier Petetin <gauthierpetetin@hotmail.com>
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
Co-authored-by: weizman <weizmangal@gmail.com>
Co-authored-by: Ariella Vu <20778143+digiwand@users.noreply.github.com>
Co-authored-by: Dhruv <79097544+dhruvv173@users.noreply.github.com>
Co-authored-by: Monte Lai <monte.lai@consensys.net>

* Update LavaMoat policies

* chore: fix webapp policy.json

* feat: add snap label test

* feat: test to disable export private key for snap accounts

* feat: add snap account link test in account-list-menu

* fix: add fence for setSnapsAddSnapAccountModalDismissed

* fix: remove comments

* fix: move routes into snaps fence

* feat: use snap registry

* fix: account snap identification

* chore: add `keyring-snaps` feature flag

* fix: remove unneeded spread

* Disable warn logs in content-script (#19754)

* Use Yarn caching in GitHub Actions (#19662)

GitHub actions that install dependencies will now also cache those
dependencies using the standard strategy for Yarn (which is to hash the
lockfile).

This matches the module template (see https://github.com/MetaMask/metamask-module-template/pull/145
for details).

This should have no functional impact except that this action will run
faster when dependencies are unchanged.

* Fixing misspelling in 10.28.0 changelog notes (#19756)

* Add `tokenId` type validation in `wallet_watchAsset` middleware (#19738)

* Remove unused GitHub Action workflow (#19660)

This GitHub action workflow was disabled, but was still running setup
steps. It has now been removed entirely. We can re-introduce it again
later once the problem that led to it being disabled has been fixed.

The associated npm script and JavaScript module have been removed as
well.

* Fix #847 - Don't show account address on token pages (#19740)

Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>

* Deprecating FormField and fixing console error (#19739)

* Deprecating FormField and fixing console error

* Updating snapshots

* updated linea image for token and badge (#19717)

* updated linea image for token and badge

* replaced hardcoded string with constant

* UI updates for contacts Page (#19646)

* updated contacts flow update

* json file updates

* updated contacts edit and view list

* keep contacts tab selected

* lint fix

* replaced hardcoded strings with constant

* updated padding in box

* Replacing deprecated components and fixing prop errors (#19745)

* Use `snaps@0.35.2-flask.1` and `snaps@1.0.0-prerelease.1` (#19734)

* snaps@0.35.0-flask.1

* Update LavaMoat policies

* Update stable snaps packages to 1.0.0-prerelease.1

* Update LavaMoat policies

* Fix lint

* snaps@0.35.2

* Exclude snap_manageAccounts

* Code fencing

* Revert removing endowment:keyring exclusion

* Bump iframe URLs

* UX: Ensure multichain native token name is always shown (#19705)

* UX: Ensure multichain native token name is always shown

* Fix lint

* UX Multichain: fixed padding for edit screen (#19707)

* fixed padding for edit screen

* Use network picker for header trigger

* Fix swaps display

* updated snapshot

---------

Co-authored-by: David Walsh <davidwalsh83@gmail.com>

* Bump @metamask/providers to v11.1.0 (#19762)

* Bump @metamask/providers to v11.1.0

---------

Co-authored-by: Alex <adonesky@gmail.com>

* Fix fallback gas estimation (#19746)

* Fix fallback gas estimation

Our fallback gas estimation was failing due to a bug in the
`@metamask/controller-utils` package. This was causing gas estimation
to fail completely on certain networks (those not supported by our gas
estimation APIs and non EIP-1559 compatibile), and it was causing the
fallback gas estimation operation (in case our API was down) to fail
across all networks.

Fixes https://github.com/MetaMask/metamask-extension/issues/19735

* Add e2e tests

E2E tests have been added to capture gas estimation. Cases are added
for our API, for the fallback estimate, and for non-EIP-1559 estimates.

As part of this work, the legacy gas API had to be disabled. This was
being used in e2e tests but was dead code in production. It needed to
be disabled to ensure the code under test was reachable.

* Fix gas API referenced in e2e test

* Update unit test snapshots

* Update Label component font weight from bold to medium (#19731)

* Update Label component font weight from bold to medium

* update snapshot

* fix snapshots

* fix snapshots 2

* Removeing deprecated constants for enums

---------

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>

* Part of #17670: Replace Typography with Text component in CancelSpeedupPopover (#18638)

* create story

* replace Typography with Text component

* review changes

* replace CSS with props styling
* use `Button` from `component-library`
* tooltip HTML refactor with `component-library` components
* remove whitespace in story

* strong tag support within Text component

* addresses #18651
* taken from #18752 as suggested in https://github.com/MetaMask/metamask-extension/pull/18638#discussion_r1176334805

* replace `strong` with new `Text as="strong"`

* remove unneccessary css from fa564e3f036f1439f9f220cca23595b508760614

* add text variant definition

* Updating text variant of button

* restrore proper spacing between elements

* Quick fix for test

* Adding key

---------

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
Co-authored-by: Garrett Bear <gwhisten@gmail.com>

* Issue 17670 replace typography with text (#19433)

* Replace Typograph with Text component in numeric-input-component.js

* Replace Typography with Text component in signature-request-message.js

* Replace Typography with Text component in signature-request.component.js

* Replacing deprecating constants and fixing some signature story warnings

* Updating snapshot

* Fixing import

---------

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
Co-authored-by: Garrett Bear <gwhisten@gmail.com>

* Part of #18714: Replacing deprecated constants in `confirm-subtitle` folder (#19699)

* repalcing deprecated constants

* resolve issue

* lint fixes

---------

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>

* Part of #17670: Replace Typography with Text component in: callout.js (#18912)

* Part of #17670: Replace Typography with Text component in: callout.js

* Update ui/components/ui/callout/callout.js

Co-authored-by: Danica Shen <zhaodanica@gmail.com>

* Update callout.js

* Updating snapshot and deprecating component

* Updating snapshot and deprecating component

---------

Co-authored-by: Danica Shen <zhaodanica@gmail.com>
Co-authored-by: George Marshall <george.marshall@consensys.net>
Co-authored-by: Garrett Bear <gwhisten@gmail.com>

* [MMI] Added code fences in whats new popup (#19581)

* added code fences in whats new popup

* Improved code

* Added missing prop

* Update LavaMoat policies

* updated functions by using an options object for the rendering functions in order to bypass possible typsecript issues

---------

Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>

* Updated action list in token, NFTs and activity view (#19702)

* updated ui for nft import button

* updated no nft image found in the center

* updated footer for all screens in tabs

* removed no nft state from nft tab

* updated snapshot

* lint fix

* fixed e2e tests

* fixed prep build error

* removed no nfts yet test

* updated tabs

* fixed prod error

* updated no nft screen

* changed button size to md

* fix: change 'M' to '?'

* fix: update fence to keyring-snaps

* chore: rename folder

* fix: typo

* chore: remove logs

* feat: add metamask developer constant

* fix: sass keyring-snap path

* chore: update yarn.lock

* fix: remove alias

* feat: add KEYRING_SNAPS_REGISTRY_URL env

* fix: nested fence

* feat: add snap manageAccount e2e (#19777)

* feat: add snap manageAccount e2e

* feat: update link

* fix: lint

* fix: get values of restrictedMethodPermissionBuilders

* fix: add fence to perferences

* fix: stop shuffle

* fix: remove KEYRING_SNAPS_REGISTRY_URL from metamaskRc

* fix: use permissions to determine account snaps

* fix: remove shuffle

* fix: add comments to fences in excluded snap permission.

* chore: fix policy.json

* fix: fix snap-account-detail test

* fix: lint

* fix: snap accoutn detail page test

* Update LavaMoat policies

* Update ui/pages/keyring-snaps/snap-account-detail-page/snap-account-detail-page.test.tsx

Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>

* Update ui/pages/keyring-snaps/snap-account-detail-page/snap-account-detail-page.test.tsx

Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>

* fix: remove fence from isAbleToExportAccount

* chore: remove comment line

* fix: dismiss snap modal

* fix: try catch for scroll

* fix: icon for manageAccount

* fix: update `handleSnapRequest` to make `params` optional and add `id`

* fix: lint for uuid

* fix: remove arg in saveSnapKeyring

* fix: add fence for uuidV4

* chore: bump dep

* fix: permission_manageAccounts message and icon

* chore: update registry link

* chore: convert address to lowercase

* fix: change icon

* chore: bump eth-snap-keyring

* chore: update webapp policy.json

* Update ui/pages/keyring-snaps/new-snap-account-page/new-snap-account-page.test.tsx

Co-authored-by: Gustavo Antunes <17601467+gantunesr@users.noreply.github.com>

* fix: update fences

* fix: nested fence

* Update app/_locales/en/messages.json

Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>

* Update app/_locales/en/messages.json

Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>

* Update app/_locales/en/messages.json

Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>

* Update app/_locales/en/messages.json

Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>

* Update ui/components/multichain/account-details/account-details-display.js

Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>

* Update ui/pages/keyring-snaps/snap-account-detail-page/header.tsx

Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>

* Update ui/pages/keyring-snaps/snap-account-detail-page/snap-account-detail-page.tsx

Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>

* fix: rename and added jsdoc

* fix: add fence to snap label

* fix: remove comment

* fix: change pixel to int and remove unused class

* fix: lint

* fix: create two tests for main and flask restricted methods

* fix: remove fence in test

* fix: lint header

* feat: allow `metamask.github.io` in manifest

* fix: remove comment

* fix: rename isAbleToExportAccount

* chore: use a more restrictive registry URL

* fix: change to && not ||

* fix: remove unused

* fix: move keyring snaps URL to Flask's base manifest

* fix: use fetch instead of fetchWithCache

* fix: lint

---------

Co-authored-by: kumavis <aaron@kumavis.me>
Co-authored-by: Howard Braham <howrad@gmail.com>
Co-authored-by: Daniel Rocha <68558152+danroc@users.noreply.github.com>
Co-authored-by: Gustavo Antunes <17601467+gantunesr@users.noreply.github.com>
Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
Co-authored-by: Gauthier Petetin <gauthierpetetin@hotmail.com>
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
Co-authored-by: weizman <weizmangal@gmail.com>
Co-authored-by: Ariella Vu <20778143+digiwand@users.noreply.github.com>
Co-authored-by: Dhruv <79097544+dhruvv173@users.noreply.github.com>
Co-authored-by: ryanml <ryanlanese@gmail.com>
Co-authored-by: Alex Donesky <adonesky@gmail.com>
Co-authored-by: David Walsh <davidwalsh83@gmail.com>
Co-authored-by: George Marshall <george.marshall@consensys.net>
Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
Co-authored-by: jiexi <jiexiluan@gmail.com>
Co-authored-by: jainex <jainexp017@gmail.com>
Co-authored-by: Matthias Kretschmann <m@kretschmann.io>
Co-authored-by: Garrett Bear <gwhisten@gmail.com>
Co-authored-by: Ujwal Kumar <ujwalkumar95@gmail.com>
Co-authored-by: rohit kerkar <129620973+rohiiittttt@users.noreply.github.com>
Co-authored-by: Harsh Shukla <125105825+PrgrmrHarshShukla@users.noreply.github.com>
Co-authored-by: Danica Shen <zhaodanica@gmail.com>
Co-authored-by: Albert Olivé <albertolivecorbella@gmail.com>
Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
2023-06-29 09:24:08 -04:00
Frederik Bolding
789779f4d5
[FLASK] Rework Snaps headers and footers (#19442)
* Add new snap header and footer to snap install

* Add new snap header and footer to snap result and snap update

* Fix loading state

* Fix lint

* Add required scrolling

* Adjust avatar component

* Apply new headers and footers to snaps confirmations

* Rename previous SnapAuthorship component to SnapAuthorshipExpanded

* Fix lint

* Fix font weight

* Fix fencing

* Fix a test

* Fix lint after rebase

* Fix E2E

* Fix locale lint

* Fix another E2E

* Fix test ID

* Address PR comments

* Better scroll button centering

* Address design comments

* Fix unit test

* Fix E2Es
2023-06-07 15:18:49 +02:00
David Drazic
354788510e
[FLASK] Update UI (for audit) (UI facelift) (#19388)
* Update UI (for audit)

Revert yarn.lock change

Update e2e tests with new copy for a button

Make UI changes to custom Snap UI

Update UI on snap installation success page

Fix icon on installation success

Fix snap name font weight in installation page

Add UI changes for Snap installation failed page

Add new copy for snap installation screen

Update e2e tests OK button name

Update OK button names in e2e tests

Return previous functionality of update flow

Add error message handling for update screens

* Fix after rebase

* Fix messages.json update message

* Revert SCSS changes

* Refactor failed and success screen rendering
2023-06-06 12:15:20 +02:00
Frederik Bolding
3b9e2eb5e5
[FLASK] Update snap tweaks (#19410)
* Sort revoked permissions before existing permissions

* Simplify update screen logic and update copy

* Remove approve and update copy

* Reduce nesting
2023-06-05 14:31:11 +02:00
David Walsh
b89630fdd2
Release MultiChain 0.5 (#18903)
* Show portfolio icon in ETH overview

* Show new copy button in QR code modal

* Show address copy button in wallet overview

* Update connected status component

* Remove legacy MenuBar

* Remove legacy ImportTokenLink

* Remove AssetListItem

* Remove DetectedTokensLink

* Remove legacy AppHeader

* Remove MULTICHAIN flag from builds.yml

* Remove legacy AccountMenu

* FIX: Token cell snapshot

* Add data-testid for Account Picker

* Remove multichain check in LoadingNetworkScreen

* Remove MULTICHAIN check for AccountDetailsModal

* Remove MULTICHAIN check for AssetList

* Update QR dimensions

* Remove MULTICHAIN declaration from metamaskrc.dist

* Implement PickerNetwork and NetworkListMenu in onboarding

* Remove legacy NetworkDropdown and Dropdown

* Remove documentation about legacy account menu

* FIX: Fixes route tests for missing data-testid=network-display

* Fix account-menu-icon data-testid

* Fix TokenCell test

* FIX Onboarding Flow tests

* Remove unused locales from AccountMenu removal

* E2E: Fix Import Secret Recovery Phrase: logs out of the vault

* E2E: Fix Show account details: should show the QR code for the account

* E2E: Fix add-account.spec.js

* E2E: Fix state-logs.spec.js

* E2E: Fix lock-account.spec.js

* E2E: Fix settings-general.spec.js

* E2E: Fix advanced-settings.spec.js

* E2E: Fix auto-lock.spec.js

* E2E: Fix backup-restore.spec.js

* E2E: Fix clear-activity.spec.js

* E2E: Fix settings-search.spec.js

* E2E: Fix encrypt-decrypt.spec.js

* E2E: Fix dapp-interactions.spec.js

* E2E: Fix test-snap-management.spec.js

* E2E: Fix add-custom-network.spec.js

* E2E: Fix from-import-ui.spec.js

* E2E: Fix provider-api.spec.js

* E2E: Fix chain-interactions.spec.js

* E2E: Fix custom-rpc-history.spec.js

* Remove network icon from overview components

* E2E: Fix user-actions-benchmark.js

* E2E: Fix benchmark.js

* E2E: Fix add-hide-token.spec.js

* E2E: Fix address-book.spec.js

* E2E: Fix custom-token-add-approve.spec.js

* E2E: Fix incremental-security.spec.js

* E2E: Fix metamask-responsive-ui.spec.js

* E2E: Onboarding.spec.js

* E2E: Fix permissions.spec.js

* E2E: Fix send-hex-address.spec.js

* E2E: Fix send-to-contract.spec.js

* Remove dead AccountOptionsMenu test

* E2E: Fix token-details.spec.js

* E2E: Fix switch-custom-network.spec.js

* E2E: Fix metamask-ui.spec.js

* Revert "UX Multichain: updated border top for activity list (#19176)"

This reverts commit 15598f2a23.

* E2Es: Fix test-snap-management.spec.js and test-snap-notification.spec.js

* E2Es: Fix add-account.spec.js after flaky test fixes

* e2e flaky test

* adds back the mmi options

* scss fix

* test fix

* removes unnecessary double quotes

* Prevent double logos on login screen

* Update ui/components/ui/list-item/index.scss

Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>

---------

Co-authored-by: seaona <mariona@gmx.es>
Co-authored-by: Antonio Regadas <antonio.regadas@consensys.net>
Co-authored-by: Nidhi Kumari <nidhi.kumari@consensys.net>
2023-06-01 16:14:38 -05:00
Bowen Sanders
290dbd77ce
[FLASK] Create E2E test for snaps network_access endowment (#19213)
* create networkaccess e2e

* final changes

* fixed enums

* requested changes

* fixed result test
2023-05-23 11:54:31 +02:00
Bowen Sanders
52109a1829
[FLASK] Create E2E test for ethereum_provider endowment (#19191) 2023-05-18 08:34:24 -07:00
Frederik Bolding
125021e425
[FLASK] snaps-monorepo@0.33.1-flask.1 (#18913)
* snaps-monorepo@0.33.0-flask.1

* Add browser-passworder

* Patch babel/core

* Fix PermissionController messenger allowlist

* Update test-snaps

* Use latest patch

* Update LavaMoat policies

* Re-enable RPC E2E

* Make snaps iframe URL be a env variable and bump it

* Add new env variable to test env

* Add iframe URL to desktop build
2023-05-15 19:36:24 +02:00
Bowen Sanders
be8d832426
[FLASK] Create E2E test for snap_GetEntropy (#18998) 2023-05-11 12:43:08 -07:00
Frederik Bolding
1646ab110e
[FLASK] Disable RPC test (#19011)
* Disable RPC test

* Fix lint
2023-05-04 19:09:37 +02:00
David Drazic
ff96836871
[FLASK] Add updated version of the Snaps settings UI (#18438)
* Add updated version of the Snaps list UI

Add more changes to match the designs of snaps list

Add next design iteration for snaps list

Update icons, sizes and pointer behaviour

Add redesign for snap settings page

Refactor and improve designs

Fix unit tests and refactor code

Fix e2e test

Fix lint

Update margin values

Add CSS override for connected sites list and update margins

Update paddings as requested

Fix vertical alignment of links

Fix tooltip position on the enable button

Add usage of getSnapName function for displaying snap names

Fix e2e tests and update date format for snap install date

Improve unit test for snap-settings-card

Change installation info logic

Update mocked state for snap

Add tests for ViewSnap component, refactor and update mocked state

Add check for version info

Change Snaps icon in Settings

Refactor Snaps list to use selector

Add handling in case of missing version history

* Fix icon ref

* Remove console logs

* Remove onClick from selector

* Add code fencing for imports in selectors.js
2023-04-24 12:21:37 +02:00
Bowen Sanders
dc69ff017b
added new snaps wasm test (#18696) 2023-04-21 05:27:48 -07:00
Bowen Sanders
90f4e47326
[FLASK] More Snaps E2E Optimization and Delay Reductions (#18245)
* bip32 delay reduction

* asserts changed to waitFors in 32/44

* scrollTo change

* replaced delay for firefox flake

* more reduced delays

* more delay reductions and changes

* raise paralellism to 4 for snaps tests

* additional delay changes

* fixed update code

* removed comment

* removed another comment
2023-04-06 10:57:11 -04:00
Frederik Bolding
a53b9fb489
[FLASK] snaps-monorepo@0.32.2 (#18371)
* snaps-monorepo@0.32.0

* Update LavaMoat policies

* Add JsonSnapRegistry

* Fix lint

* [FLASK] Handle side-effects changes in metamask-controller (#18373)

* Update PermissionController

* Fix lint

* Update iframe-execution-environment

* snaps-monorepo@0.32.1

* Bump test-snaps

* Update version assertion

* Update URLs

* Fix lint

* snaps-monorepo@0.32.2

---------

Co-authored-by: Guillaume Roux <guillaumeroux123@gmail.com>
2023-03-30 23:57:28 +02:00
Hassan Malik
c2b2f2685e
[FLASK] Redesign key management modal (#18263)
* added the rest of the sev1 warnings to getSnapInstallWarnings

* added and updated translations

* Updated getSnapInstallWarnings to include warnings for all weight-1 permissions

* Updated snap install warning and css according to designs

* fix snaps tests

* fixed alignment/spacing

* updated e2e tests to click through the newly displayed public key access warning

* lint fix

* fixed update snap test

* refactored getSnapInstallWarnings, moved logic to PERMISSION_DESCRIPTIONS

* fix logic to account for objects & arrays

* update function description

* add missing properties to ethereum provider description

* moved id and message to baseDescription to fix error

* add optional chaining to fix undefined error

* more optional chaining

* more optional chaining
2023-03-29 15:17:57 -04:00
David Drazic
0847917df4
[FLASK] Update UI related to MetaMask Snaps Platform trademark (#18172)
* Update UI related to MetaMask Snaps Platform trademark

* Remove redundant UI text according to new designs

* Fix lint errors

* Fix e2e test expectation

* Fix lint in test

* Fix e2e test expectation

* Fix some UI parts

* Update CSS for noSnaps message

* Add next design iteration

* Add minor fix

* Update locale message

* Fix learn more text size

* Refactor usage of design system components

---------

Co-authored-by: Erik Marks <rekmarks@protonmail.com>
2023-03-21 16:52:13 +01:00
Guillaume Roux
d6f58bceb0
[FLASK] snaps-monorepo@0.31.0 (#18142)
* allow SnapController to call `ApprovalController:updateRequestState` action

* combine popups

* show only autorship pill on result

* lint

* update `snaps-monorepo@0.31.0` and regen policies

* dedupe deps and fix fencing

* fix update button text

* fix fencing

* Update a bunch of e2es

* address requested changes

* update policy

* bump key-tree

* fix lint

* Update RPC E2E

* fix locales

* Remove wrong instance of window handle polling

* design changes and address pr comments

* remove unused imports

* fix lint

* fix fencing

* remove unused locales

* fence things

* re-add redirection

* bump test-snaps version

* Fix update e2e

* fix redirecting logic and address requested changes

* force update metamask state on approved

* move force update

---------

Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
2023-03-17 12:00:05 +01:00
Bowen Sanders
7a421e05c3
[FLASK] Snaps e2e test stability improvements (#18090)
* waitForSelector and pasteIntoField used now
2023-03-15 10:03:01 -07:00
Hassan Malik
7086494b72
[FLASK] BREAKING - snaps-monorepo@0.30.0 (#17718)
* updated snap permission to wallet_snap, updated tests and added migration

* updated snap packages

* yarn.lock fix

* fixed errors

* override policy

* update policy

* undo override

* updated localization message descriptions

* updated lavamoat policy

* more policy updates

* update permission controller version

* update policy

* update fixture builder

* updated code to include permission value to satisfy wallet_snap permission description call

* fix import issue

* update test-snaps version

* added missing actions, added snap permission dedupe function

* prettier fix

* fix fencing

* add more fencing

* prettier fix

* fix fencing (again)

* added new action and selector and updated view snap accordingly

* update test snaps website version

* unfence request variable

* add fencing

* add optional chaining to fix type error

* update migration #

* remove old migration

* prettier fix

* fix migration test

* fix fencing

* added missing fencing

* updated code to workaround fencing

* update test-snaps site version and remove snap confirm test

* update snap packages

* update policies

* fix merge marker issue

* update test

* more fixes

* fix permissions

* update test

* fixed test

* Bump test-snaps and iframe-execution-environment

* remove unused snap permission from fixture builder

* update policies

* undo comment removal, update selector implementation

* removed unnecessary function, updated migration, updated caveat action

* remove optional chaining

* fix type issue

* more type fixes

* fix migration test

* remove isFlask check, make migration logic more robust

* update coverage

* Update LavaMoat policies

* Update test/e2e/snaps/enums.js

* add extra bail condition

* Revert "add extra bail condition"

This reverts commit b45c53dcfc6e6e35a5e283d4955d6d6ea9ca5965.

* Revert "Revert "add extra bail condition""

This reverts commit cd2ded677935c9cdab0c02b6af55474c83727f60.

* fix test

* add SnapController entry to state object

* updated permission name and caveat type with hardcoded values

* add extra test for non-flask scenario

* update lavamoat policies

* fix locale messages

* change coverage target

* re-enable rpc snap test

* revert locale message change

* fix el message

* reverted changes

---------

Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
2023-03-08 13:29:23 -05:00
Peter
5c30fee59a
remove extraneous arg from clickElement (#18050) 2023-03-08 13:17:56 +00:00
Erik Marks
90ae4980b3
Update snaps locale messages for casing and content (#17915)
* Update snaps locale messages for casing and content

* Fix non-English locales

* udpate e2e test

---------

Co-authored-by: Guillaume Roux <guillaumeroux123@gmail.com>
2023-02-28 19:21:33 +01:00
Bowen Sanders
e015e027b6
[FLASK] Create E2E test for cronjobs (#17365)
* added long test

* Wait for a maximum of 65 seconds, not a hardcoded length

* Fix lint

---------

Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
2023-02-28 14:07:00 +01:00
Maarten Zuidhoorn
f20d5db1e4
[FLASK] Temporarily disable JSON-RPC snap e2e test (#17778)
* Temporarily disable JSON-RPC snap e2e test

* Update outdated snapshot
2023-02-16 10:35:11 +01:00
Bowen Sanders
0ffd548ff9
[FLASK] Create E2E test for RPC endowment (#17525)
* create e2e test
2023-02-06 09:54:07 -08:00
Frederik Bolding
f6f691190d
Fix Snaps E2E test flake (#17174) 2023-01-13 15:10:47 +01:00
Bowen Sanders
4c8faaba48
[FLASK] Create E2E test for snap_dialog (#17111)
* added dialog e2e test
2023-01-12 09:25:46 -08:00
Bowen Sanders
1b62a773b4
[E2E] Change to replace confirm snap to dialog snap (#17146) 2023-01-12 15:29:29 +01:00
Bowen Sanders
f2da79f563
[E2E] Fixes to try to deflake Snaps E2E tests (#17123)
* added delays in several places

* fix to update test
2023-01-10 11:11:15 -08:00
Frederik Bolding
7e7a0f1f72
[FLASK] Use custom UI for transaction insights (#16912)
* Allow custom UI for transaction insights

* Fix margin

* Small fixes to CSS and selectors

* Rename property

* Fix E2E locally

* Bump test-snaps

* Bump test-snaps
2022-12-20 11:44:49 +01:00
Bowen Sanders
720c7e7d16
initial deflakery (#16894) 2022-12-12 12:14:23 -08:00
Bowen Sanders
7e7be2769d
[FLASK] Create E2E test for tx-insights (#16785)
* Created an E2E test for tx-insights.

Co-authored-by: Guillaume Roux <guillaumeroux123@gmail.com>
2022-12-08 12:15:59 -08:00
Bowen Sanders
0e1c385cd0
[FLASK] Create E2E test for snap management (#16628)
* added management test

* added id and dismiss alert function

* changed xwindow handling

* fixed linting
2022-11-30 14:12:09 +01:00
Frederik Bolding
dfb6210910
[FLASK] snaps-monorepo@0.25.0 (#16673)
* snaps-monorepo@0.25.0

* Regen LavaMoat policies

* Bump test-snaps

* [FLASK] Add Snaps JSON-RPC handler permission (#16670)

* Add Snaps JSON-RPC handler permission

* Add copy and icon

* Fix test

Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
2022-11-30 13:19:33 +01:00
Frederik Bolding
de955f3faa
[FLASK] snaps-monorepo@0.24.1 (#16525)
* snaps-monorepo@0.24.0

* Fix imports and regen LavaMoat policies

* Bump iframe-execution-environment

* Fix tests

* Add permissions

* Bump patch

* Bump test-snaps

* [FLASK] Fix update e2e test to catch snaps with caveats (#16546)

* changed snap to update to bip32

* small changes to test

* Fix lint

* Fix E2E

* Update copy

* Update icon

Co-authored-by: Bowen Sanders <bowensanders@gmail.com>
2022-11-22 13:07:08 +01:00
Frederik Bolding
8a529bca47
[FLASK] Improve Snaps E2E stability (#16597)
* Improve Snaps E2E stability

* Simplify

* Fix lint
2022-11-21 14:38:05 +01:00
Bowen Sanders
327272f71e
[FLASK] Update e2e tests for new react test-snaps page (#16324)
* Creates updated e2e tests compatible with the new react based test-snaps page.
2022-11-16 13:47:51 -08:00
Frederik Bolding
de3068d932
[FLASK] snaps-monorepo@0.23.0 (#16394)
* snaps-monorepo@0.23.0

* Regen LavaMoat policies

* Update iframe-execution-environment

* Fix tests

* Bump luxon

* Fix lint

* Update test-snaps

* Bump post-message-stream

* Fix E2E
2022-11-08 10:31:22 +01:00
Peter Yinusa
0b4532ec1b
E2e test fixtures (#16061)
* remove state.json files

* move file

* Update Readme

* Create fixture builder

* load test fixture

* remove redundant method

* update snap tests

* update stats tests

* update extension tests

* update extension tests

* Update fixture data

* snap test dapp connection

* Update fixture data

* add onboarding fixture

* use onboarding fixture

* reuse import account vault

* remove unnecessary use of class

* use fixture builder in new tests

* switch to function

* update default fixture

* update default fixture

* update test

* update 1559 test fixttures

* update 1559 test fixtures

* update 1559 test fixtures

* dismiss 3box whats new

* remove redundant code

* move docs

* remove unused code

* token detection

* use default timeout

* remove redundant code

* Update fixture builder

hide `Protect your funds` dialog
remove browser environment
remove default network details
hide dismiss seed backup reminder
recursively merges fixture data

* add token to tokencontroller

* remove network details

* add missing identities to preference controller

* remove duplicate properties

* update bip-32 to use fixturebuilder

* alphabetise snap permissions

* update get snaps to use fixturebuilder

* Update test-snap-bip-32.spec.js

wait for window

* add popular network state

* update test

* lint
2022-10-28 09:42:12 +01:00
Frederik Bolding
359f782e7e
[FLASK] Fix flaky BIP-32 E2E test (#16255) 2022-10-24 13:49:41 +02:00
Frederik Bolding
6ba9f65b4c
[FLASK] Add E2E for wallet_getSnaps (#16169)
* Add E2E for wallet_getSnaps

* Fix lint
2022-10-14 15:34:27 +02:00
Bowen Sanders
1b4f1344b1
[FLASK] Create E2E Test for BIP-32 test-snap (#16037)
* new test and changed ui

* added bip32 test

* fixed linting and other errors

* changed description

* Bump test-snaps to latest and fix tests

* Fix error e2e

* Fix confirm e2e

* Remove balance

Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
2022-10-14 14:33:36 +02:00
Bowen Sanders
8622e61bd3
Create snaps E2E test for update function (#15979) 2022-09-27 16:37:17 -07:00
Frederik Bolding
4eb8e50800
[FLASK] snaps-skunkworks@0.21.0 (#15889)
* snaps-skunkworks@0.21.0

* Update policy files

* Regen policies again

* Fix tests

* Simplify selector

* Fix flaky test

* Update iframe execution env

* Move snap install warnings to util

* Add basic copy for snap_getBip32PublicKey

* Update permission icon

* Update E2Es

* Fix lint

* Fix locale strings
2022-09-23 12:39:54 +02:00
Frederik Bolding
d054175b2e
[FLASK] Fix an issue with installing and updating snaps with 0 permissions (#15796)
* Fix an issue with installing snaps with 0 permissions

* Fix some issues

* Fix lint

* Fix code fencing

* UI improvements for no permission use-case

* Fix redirect

* Delay BIP44 test slightly

* Add more delay

* Fix update UI
2022-09-20 14:46:25 +02:00
Frederik Bolding
7fc418a96d
[FLASK] snaps-skunkworks@0.20.0 (#15706)
* snaps-skunkworks@0.20.0

* Generate LavaMoat policy

* Fix some breaking changes

* Update iframe execution env

* Fix unit tests

* Implement snap_getBip44Entropy

* Regenerate LavaMoat policy

* Prefer ControllerMessenger over direct calls

* Fix not showing warning for BIP44 legacy permission and E2E test

Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
2022-08-26 13:48:53 +02:00
Maarten Zuidhoorn
a52c6a4908
[FLASK] snaps-skunkworks@0.19.0 (#15619)
* Bump snaps-skunkworks to 0.19.0

* Improve snap_getBip32Entropy UI

* Remove console.log

* Update LavaMoat policy

* Dedupe Yarn lock

* Update LavaMoat policy again

* Fix tests

* Update policies and e2e tests

* Update policy again

* Update iframe-execution-environment

* Dedupe yarn.lock

* Update snapshots

* Fix PR comments

* Add TODO

* Trigger CI
2022-08-18 17:07:34 +02:00
Hassan Malik
a7179a6b88
[FLASK] Add update snap UI (#15143)
* added snap-update folder

* addded update route, snap update component, updated permissions connect components

* added actions and selectors

* updated permissions selectors and updated permissions connect container to have update snap logic

* updated translations, added selector, updated request object

* updated translations, added update snap permission list component

* more fixes

* added CSS, redid some HTML

* lint fixes

* Add missing grantPermissions action

* updated button padding

* fixes

* removed prop type

* fix Update & Install wrapping

* made changes for forthcoming snap controller PR

* removed ununsed imports

* updated css

* re-added padding rule and removed unused translation messages

* addressed comments

* add subtext for new permissions

* lint fix

* removed unused translations

* some more changes

* fix e2e tests

* lint fix

* added in delay for e2e tests

* Revert "added in delay for e2e tests"

This reverts commit 095962a2c0c9de0b0b343d3134bb0787044dd8ce.

* fixed routing logic

Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
Co-authored-by: Guillaume Roux <guillaumeroux123@gmail.com>
2022-08-03 12:02:44 -04:00
Guillaume Roux
9ce4a8f987
[FLASK] Fix key management permission copy (#14849) 2022-08-02 11:29:40 +02:00
PeterYinusa
9ae909d6a7
[E2E] Install Firefox extension from dist folder (#15255)
* update webdriver

* install extension from dist folder

* remove redundant code
2022-07-18 09:22:23 +01:00
Bowen Sanders
b486524c07
Snaps E2E Test Upgrades for the new test-snaps UI (#14980)
* fixed e2e tests for new UI

* fixed scrolling in tests to be bi-compatible

* updated enums to point to new UI version
2022-07-06 15:22:21 -07:00